[GitHub] rymanluk commented on issue #957: nrf52 adc fixes

2018-04-25 Thread GitBox
rymanluk commented on issue #957: nrf52 adc fixes URL: https://github.com/apache/mynewt-core/pull/957#issuecomment-384226245 In order to make it merged I fixed commit message and merged it as #1052 Hope that this fine with you. Closing this PR now. -

[GitHub] rymanluk commented on issue #957: nrf52 adc fixes

2018-04-17 Thread GitBox
rymanluk commented on issue #957: nrf52 adc fixes URL: https://github.com/apache/mynewt-core/pull/957#issuecomment-381976799 @jacobrosenthal I wrote it two comments above ;) " I think it would be useful for others to have comment here why we need this patch and how resolution, overs

[GitHub] rymanluk commented on issue #957: nrf52 adc fixes

2018-04-12 Thread GitBox
rymanluk commented on issue #957: nrf52 adc fixes URL: https://github.com/apache/mynewt-core/pull/957#issuecomment-380809576 @jacobrosenthal could you please fix commit message so we can merge this PR? This is an automated mes

[GitHub] rymanluk commented on issue #957: nrf52 adc fixes

2018-03-27 Thread GitBox
rymanluk commented on issue #957: nrf52 adc fixes URL: https://github.com/apache/mynewt-core/pull/957#issuecomment-376456380 @jacobrosenthal if there is an issue with rebasing,could you please add "revert" patch into this PR. That should also work. Ping me on slack if you need support in t

[GitHub] rymanluk commented on issue #957: nrf52 adc fixes

2018-03-27 Thread GitBox
rymanluk commented on issue #957: nrf52 adc fixes URL: https://github.com/apache/mynewt-core/pull/957#issuecomment-376456380 @jacobrosenthal if there is an issue with rebasing, please add "revert" patch into this PR. That should also work. Ping me on slack if you need support in this.