[GitHub] rymanluk commented on issue #957: nrf52 adc fixes

2018-04-17 Thread GitBox
rymanluk commented on issue #957: nrf52 adc fixes
URL: https://github.com/apache/mynewt-core/pull/957#issuecomment-381976799
 
 
   @jacobrosenthal  I wrote it two comments above ;)
   
   " I think it would be useful for others to have comment here why we need 
this patch and how resolution, oversample etc are expected to be set."


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rymanluk commented on issue #957: nrf52 adc fixes

2018-04-12 Thread GitBox
rymanluk commented on issue #957: nrf52 adc fixes
URL: https://github.com/apache/mynewt-core/pull/957#issuecomment-380809576
 
 
   @jacobrosenthal could you please fix commit message so we can merge this PR?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rymanluk commented on issue #957: nrf52 adc fixes

2018-03-27 Thread GitBox
rymanluk commented on issue #957: nrf52 adc fixes
URL: https://github.com/apache/mynewt-core/pull/957#issuecomment-376456380
 
 
   @jacobrosenthal if there is an issue with rebasing, please add "revert" 
patch into this PR. That should also work. Ping me on slack if you need support 
in this.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services