[GitHub] sjanc commented on a change in pull request #4: [linux] initial port and osal additions.

2018-04-04 Thread GitBox
sjanc commented on a change in pull request #4: [linux] initial port and osal additions. URL: https://github.com/apache/mynewt-nimble/pull/4#discussion_r167164810 ## File path: porting/linux/os/os_mutex.c ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] sjanc commented on a change in pull request #4: [linux] initial port and osal additions.

2018-04-04 Thread GitBox
sjanc commented on a change in pull request #4: [linux] initial port and osal additions. URL: https://github.com/apache/mynewt-nimble/pull/4#discussion_r179080445 ## File path: porting/linux/config/sdk_config.h ## @@ -0,0 +1,698 @@ + Review comment: is this needed an

[GitHub] sjanc commented on a change in pull request #4: [linux] initial port and osal additions.

2018-04-04 Thread GitBox
sjanc commented on a change in pull request #4: [linux] initial port and osal additions. URL: https://github.com/apache/mynewt-nimble/pull/4#discussion_r167164892 ## File path: porting/linux/os/os_mutex.c ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] sjanc commented on a change in pull request #4: [linux] initial port and osal additions.

2018-04-04 Thread GitBox
sjanc commented on a change in pull request #4: [linux] initial port and osal additions. URL: https://github.com/apache/mynewt-nimble/pull/4#discussion_r167164786 ## File path: porting/linux/os/os_mutex.c ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] sjanc commented on a change in pull request #4: [linux] initial port and osal additions.

2018-04-04 Thread GitBox
sjanc commented on a change in pull request #4: [linux] initial port and osal additions. URL: https://github.com/apache/mynewt-nimble/pull/4#discussion_r167163624 ## File path: porting/linux/Makefile.common ## @@ -0,0 +1,177 @@ +# Copyright (c) 2016 Nordic Semiconductor. A

[GitHub] sjanc commented on a change in pull request #4: [linux] initial port and osal additions.

2018-04-04 Thread GitBox
sjanc commented on a change in pull request #4: [linux] initial port and osal additions. URL: https://github.com/apache/mynewt-nimble/pull/4#discussion_r167164236 ## File path: porting/linux/os/os_atomic.c ## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] sjanc commented on a change in pull request #4: [linux] initial port and osal additions.

2018-04-04 Thread GitBox
sjanc commented on a change in pull request #4: [linux] initial port and osal additions. URL: https://github.com/apache/mynewt-nimble/pull/4#discussion_r167165091 ## File path: porting/linux/os/os_sem.h ## @@ -0,0 +1,26 @@ +#ifndef _OS_SEM_H_ Review comment: license

[GitHub] sjanc commented on a change in pull request #4: [linux] initial port and osal additions.

2018-04-04 Thread GitBox
sjanc commented on a change in pull request #4: [linux] initial port and osal additions. URL: https://github.com/apache/mynewt-nimble/pull/4#discussion_r179079914 ## File path: porting/linux/os/os_atomic.c ## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] sjanc commented on a change in pull request #4: [linux] initial port and osal additions.

2018-04-04 Thread GitBox
sjanc commented on a change in pull request #4: [linux] initial port and osal additions. URL: https://github.com/apache/mynewt-nimble/pull/4#discussion_r167163692 ## File path: porting/linux/config/sdk_config.h ## @@ -0,0 +1,698 @@ + Review comment: miising license

[GitHub] sjanc commented on a change in pull request #4: [linux] initial port and osal additions.

2018-04-04 Thread GitBox
sjanc commented on a change in pull request #4: [linux] initial port and osal additions. URL: https://github.com/apache/mynewt-nimble/pull/4#discussion_r167165034 ## File path: porting/linux/os/os_sem.c ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation