[GitHub] utzig commented on issue #902: Feature: stm32 f3/f7 pll clk off HSI

2018-03-19 Thread GitBox
utzig commented on issue #902: Feature: stm32 f3/f7 pll clk off HSI
URL: https://github.com/apache/mynewt-core/pull/902#issuecomment-374278288
 
 
   Thanks a lot for this!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] utzig commented on issue #902: Feature: stm32 f3/f7 pll clk off HSI

2018-03-13 Thread GitBox
utzig commented on issue #902: Feature: stm32 f3/f7 pll clk off HSI
URL: https://github.com/apache/mynewt-core/pull/902#issuecomment-372608757
 
 
   Ok, this now has conflicts because I removed `hal_system.c` from all models 
to a common location shared between all. Yours added the clock config code so I 
would suggest you make a new file like `hal_system_clock.c` for example when 
rebasing on latest master. Btw, I can reapply the clock settings on the F3 
(already tested here yesterday!).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] utzig commented on issue #902: Feature: stm32 f3/f7 pll clk off HSI

2018-03-13 Thread GitBox
utzig commented on issue #902: Feature: stm32 f3/f7 pll clk off HSI
URL: https://github.com/apache/mynewt-core/pull/902#issuecomment-372608757
 
 
   Ok, this now has conflicts because I removed `hal_system.c` from all models 
to a common location shared between all. Yours added the clock config code so I 
would suggest you make a new file like `hal_system_clock.c` for example when 
rebasing on latest master.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] utzig commented on issue #902: Feature: stm32 f3/f7 pll clk off HSI

2018-03-12 Thread GitBox
utzig commented on issue #902: Feature: stm32 f3/f7 pll clk off HSI
URL: https://github.com/apache/mynewt-core/pull/902#issuecomment-372272265
 
 
   Looks good. Would you mind also applying the changes you did for the 
`nucleo-f303*` to `stm32f3discovery`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services