[GitHub] vrahane commented on issue #1088: [WIP] fix self test

2018-05-19 Thread GitBox
vrahane commented on issue #1088: [WIP] fix self test
URL: https://github.com/apache/mynewt-core/pull/1088#issuecomment-390437062
 
 
   @InternetofAwesome is this ready to review ? I see there is an extra commit 
in there `Optimizing space in mynewt-core repo.` You might want to remove that.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] vrahane commented on issue #1088: [WIP] fix self test

2018-05-19 Thread GitBox
vrahane commented on issue #1088: [WIP] fix self test
URL: https://github.com/apache/mynewt-core/pull/1088#issuecomment-390437062
 
 
   @InternetofAwesome is this ready to review ? I see there is an extra commit 
in there `Optimizing space in mynewt-core repo.` You might want to remove that. 
Also there is a conflict, so please rebase.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] vrahane commented on issue #1088: [WIP] fix self test

2018-05-19 Thread GitBox
vrahane commented on issue #1088: [WIP] fix self test
URL: https://github.com/apache/mynewt-core/pull/1088#issuecomment-390437062
 
 
   @InternetofAwesome is this ready to review ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] vrahane commented on issue #1088: [WIP] fix self test

2018-05-17 Thread GitBox
vrahane commented on issue #1088: [WIP] fix self test
URL: https://github.com/apache/mynewt-core/pull/1088#issuecomment-389954093
 
 
   Spoke to @InternetofAwesome. This needs some more work.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services