Re: [PR] controller/ble_ll_hci: fix ble_ll_hci_le_read_bufsize_v2 compilation [mynewt-nimble]

2023-11-15 Thread via GitHub 


KKopyscinski merged PR #1651:
URL: https://github.com/apache/mynewt-nimble/pull/1651


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] controller/ble_ll_hci: fix ble_ll_hci_le_read_bufsize_v2 compilation [mynewt-nimble]

2023-11-15 Thread via GitHub 


KKopyscinski commented on code in PR #1651:
URL: https://github.com/apache/mynewt-nimble/pull/1651#discussion_r1394208824


##
nimble/controller/src/ble_ll_hci.c:
##
@@ -355,8 +355,11 @@ ble_ll_hci_le_read_bufsize_v2(uint8_t *rspbuf, uint8_t 
*rsplen)
 {
 struct ble_hci_le_rd_buf_size_v2_rp *rp = (void *) rspbuf;
 
+
+#if MYNEWT_VAL(BLE_LL_ROLE_CENTRAL) || MYNEWT_VAL(BLE_LL_ROLE_PERIPHERAL)
 rp->data_len = htole16(g_ble_ll_data.ll_acl_pkt_size);
 rp->data_packets = g_ble_ll_data.ll_num_acl_pkts;
+#endif

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] controller/ble_ll_hci: fix ble_ll_hci_le_read_bufsize_v2 compilation [mynewt-nimble]

2023-11-15 Thread via GitHub 


andrzej-kaczmarek commented on code in PR #1651:
URL: https://github.com/apache/mynewt-nimble/pull/1651#discussion_r1394199497


##
nimble/controller/src/ble_ll_hci.c:
##
@@ -355,8 +355,11 @@ ble_ll_hci_le_read_bufsize_v2(uint8_t *rspbuf, uint8_t 
*rsplen)
 {
 struct ble_hci_le_rd_buf_size_v2_rp *rp = (void *) rspbuf;
 
+
+#if MYNEWT_VAL(BLE_LL_ROLE_CENTRAL) || MYNEWT_VAL(BLE_LL_ROLE_PERIPHERAL)
 rp->data_len = htole16(g_ble_ll_data.ll_acl_pkt_size);
 rp->data_packets = g_ble_ll_data.ll_num_acl_pkts;
+#endif

Review Comment:
   should be set to 0 if central/perihperal are disabled



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] controller/ble_ll_hci: fix ble_ll_hci_le_read_bufsize_v2 compilation [mynewt-nimble]

2023-11-15 Thread via GitHub 


KKopyscinski opened a new pull request, #1651:
URL: https://github.com/apache/mynewt-nimble/pull/1651

   ISO can be used without connection (for example for Auracast). Then, 
g_ble_ll_data has no ACL members and compilation will fail.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org