Re: [PR] Fix ble_gap_unpair_oldest_peer to prevent writing to invalid memory [mynewt-nimble]

2024-02-13 Thread via GitHub
andrzej-kaczmarek commented on PR #1650: URL: https://github.com/apache/mynewt-nimble/pull/1650#issuecomment-1942672005 `ble_gap_unpair_oldest_except` uses `BLE_STORE_MAX_BONDS` because it needs to retrieve all bonds in order to apply filter. I don't really see how

Re: [PR] Fix ble_gap_unpair_oldest_peer to prevent writing to invalid memory [mynewt-nimble]

2024-02-08 Thread via GitHub
darshan7patel commented on PR #1650: URL: https://github.com/apache/mynewt-nimble/pull/1650#issuecomment-1935383385 Okay, earlier when I attempted to bond 3 devices by setting MAX_BOND_COUNT to 2, it didn't work correctly. The correct behavior should be to delete the oldest peer when

Re: [PR] Fix ble_gap_unpair_oldest_peer to prevent writing to invalid memory [mynewt-nimble]

2024-02-08 Thread via GitHub
andrzej-kaczmarek commented on PR #1650: URL: https://github.com/apache/mynewt-nimble/pull/1650#issuecomment-1935077674 That behavior is on purpose because we only need single peer returned by `ble_store_util_bonded_peers` in `ble_store_util_delete_oldest_peer`. The `status` field set from

Re: [PR] Fix ble_gap_unpair_oldest_peer to prevent writing to invalid memory [mynewt-nimble]

2024-02-08 Thread via GitHub
darshan7patel commented on PR #1650: URL: https://github.com/apache/mynewt-nimble/pull/1650#issuecomment-1933928947 Hi @andrzej-kaczmarek, Upon review, I noticed that instead of passing **BLE_STORE_MAX_BONDS** as the argument for **ble_store_util_bonded_peers** in

Re: [PR] Fix ble_gap_unpair_oldest_peer to prevent writing to invalid memory [mynewt-nimble]

2023-11-30 Thread via GitHub
andrzej-kaczmarek commented on PR #1650: URL: https://github.com/apache/mynewt-nimble/pull/1650#issuecomment-1833484136 Again, please point me to exact location in code which returns this error code. I don't see how `ble_store_read` can return `rc=6` in any case for either config or ram

Re: [PR] Fix ble_gap_unpair_oldest_peer to prevent writing to invalid memory [mynewt-nimble]

2023-11-30 Thread via GitHub
darshan7patel commented on PR #1650: URL: https://github.com/apache/mynewt-nimble/pull/1650#issuecomment-1833375283 > `ble_store_util_bonded_peers` returns `rc=6` only if `ble_store_iterate` returns `rc=6` so assuming you're right, please point to the location in file which returns this

Re: [PR] Fix ble_gap_unpair_oldest_peer to prevent writing to invalid memory [mynewt-nimble]

2023-11-21 Thread via GitHub
andrzej-kaczmarek commented on PR #1650: URL: https://github.com/apache/mynewt-nimble/pull/1650#issuecomment-1820495034 `ble_store_util_bonded_peers` returns `rc=6` only if `ble_store_iterate` returns `rc=6` so assuming you're right, please point to the location in file which returns this

Re: [PR] Fix ble_gap_unpair_oldest_peer to prevent writing to invalid memory [mynewt-nimble]

2023-11-19 Thread via GitHub
darshan7patel commented on PR #1650: URL: https://github.com/apache/mynewt-nimble/pull/1650#issuecomment-1818307690 > `max_peers` parameter passed to `ble_store_util_bonded_peers` is set to `1` which means `ble_store_iterate` will stop iterating after 1st matched peer. There's no need for

Re: [PR] Fix ble_gap_unpair_oldest_peer to prevent writing to invalid memory [mynewt-nimble]

2023-11-16 Thread via GitHub
andrzej-kaczmarek commented on PR #1650: URL: https://github.com/apache/mynewt-nimble/pull/1650#issuecomment-1814248204 `max_peers` parameter passed to `ble_store_util_bonded_peers` is set to `1` which means `ble_store_iterate` will stop iterating after 1st matched peer. There's no need

Re: [PR] Fix ble_gap_unpair_oldest_peer to prevent writing to invalid memory [mynewt-nimble]

2023-11-16 Thread via GitHub
darshan7patel commented on PR #1650: URL: https://github.com/apache/mynewt-nimble/pull/1650#issuecomment-1814239868 > This function removes 1 bond which is 1st on the returned list and thus it only needs to retrieve that single bond. There's no need to retrieve all bonded devices only to

Re: [PR] Fix ble_gap_unpair_oldest_peer to prevent writing to invalid memory [mynewt-nimble]

2023-11-16 Thread via GitHub
andrzej-kaczmarek commented on PR #1650: URL: https://github.com/apache/mynewt-nimble/pull/1650#issuecomment-1814110559 This function removes 1 bond which is 1st on the returned list and thus it only needs to retrieve that single bond. There's no need to retrieve all bonded devices only to

Re: [PR] Fix ble_gap_unpair_oldest_peer to prevent writing to invalid memory [mynewt-nimble]

2023-11-16 Thread via GitHub
darshan7patel commented on PR #1650: URL: https://github.com/apache/mynewt-nimble/pull/1650#issuecomment-1813983309 > what exactly was the issue? original code retrieves only 1 address so it looks fine. - Changes were made to accommodate a maximum of BLE_STORE_MAX_BONDS bonds.

Re: [PR] Fix ble_gap_unpair_oldest_peer to prevent writing to invalid memory [mynewt-nimble]

2023-11-15 Thread via GitHub
andrzej-kaczmarek commented on PR #1650: URL: https://github.com/apache/mynewt-nimble/pull/1650#issuecomment-1812527168 what exactly was the issue? original code retrieves only 1 address so it looks fine. -- This is an automated message from the Apache Git Service. To respond to the