[jira] [Commented] (NETBEANS-5011) Match keyword marked as syntax error despite PHP version in Project settings
[ https://issues.apache.org/jira/browse/NETBEANS-5011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17230072#comment-17230072 ] Tomas Mysik commented on NETBEANS-5011: --- [~czukowski] No need to explain things, I fully understand that some bugs can be really annoying (not only for IDE users but also for IDE maintainers). And, as I wrote, if they could be fixed easily, we would do that (by "we" I mean [~junichi11] - sorry about that, Junichi! :) My suggestion to create a PR was really meant to see that things are not always as they could appear. And doing some bigger changes in the editor area _really_ are difficult. If you were really interested in doing some PR, I would suggest starting with something simpler. Trust me :) Anyway, thank you for reporting this issue and if you find any other problem or have an idea what could be improved or added, please, let us know in a new ticket. Ideally with a PR :) Thank you. > Match keyword marked as syntax error despite PHP version in Project settings > > > Key: NETBEANS-5011 > URL: https://issues.apache.org/jira/browse/NETBEANS-5011 > Project: NetBeans > Issue Type: Bug > Components: php - Editor >Affects Versions: 12.2 > Environment: Product Version: Apache NetBeans IDE 12.2-rc1 > Java: 14.0.2; Java HotSpot(TM) 64-Bit Server VM 14.0.2+12-46 >Reporter: Czukowski >Assignee: Junichi Yamamoto >Priority: Minor > Attachments: image-2020-11-11-10-36-51-198.png, > netbeans-5011-with-php8.0.png > > > NetBeans version: 12.2-rc1 > Project PHP version is set to 7.4 > !image-2020-11-11-10-36-51-198.png! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-5011) Match keyword marked as syntax error despite PHP version in Project settings
[ https://issues.apache.org/jira/browse/NETBEANS-5011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17230049#comment-17230049 ] Czukowski commented on NETBEANS-5011: - [~tmysik] well first of all, let me assure you there's no hard feelings from my side and I hope that it didn't appear as I was demanding any work to be done, as I realize very well that nobody here is being paid to work on NetBeans. In fact, this specific issue doesn't bother me too much (the code from my example isn't mine, but it'll be fixed eventually, although in my work I've had to work on some ancient code that i _knew_ will never be updated), I just assumed this is something you'd like to get fixed so I reported it. Being mostly just a user, I lack necessary perception to recognize all the terminology correctly. To me, the errors pointed out by the parser are 'hints' too and when I see that it works somewhere but not somewhere else, there come questions how come :) As for your question, I got that idea from your reply when I asked about how certain things worked and what would be necessary to improve that, and the response was the suggestion to do it myself if I so wanted. > Match keyword marked as syntax error despite PHP version in Project settings > > > Key: NETBEANS-5011 > URL: https://issues.apache.org/jira/browse/NETBEANS-5011 > Project: NetBeans > Issue Type: Bug > Components: php - Editor >Affects Versions: 12.2 > Environment: Product Version: Apache NetBeans IDE 12.2-rc1 > Java: 14.0.2; Java HotSpot(TM) 64-Bit Server VM 14.0.2+12-46 >Reporter: Czukowski >Assignee: Junichi Yamamoto >Priority: Minor > Attachments: image-2020-11-11-10-36-51-198.png, > netbeans-5011-with-php8.0.png > > > NetBeans version: 12.2-rc1 > Project PHP version is set to 7.4 > !image-2020-11-11-10-36-51-198.png! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-5011) Match keyword marked as syntax error despite PHP version in Project settings
[ https://issues.apache.org/jira/browse/NETBEANS-5011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17230028#comment-17230028 ] Tomas Mysik commented on NETBEANS-5011: --- [~czukowski] > Not interested in a discussion, I see. One more question from my side - why do you think so? > In that case I have no further questions. I don't see any question from your side without an answer - did I miss anything? Let me repeat - if it was easy to fix, we ([~junichi11] very likely) would do that, no doubts about that. But, unfortunately, the situation is not simple in this case and cannot be easily changed (also please note that [~junichi11] is not paid for his great work on NetBeans PHP support), moreover, your PHP code will need to be changed, sooner or later (if you would like to use a newer PHP version, of course). And your suggestion to remove the functionality does not make much sense to me - it does not work in this particular case but that does not mean that it cannot be useful for most of the users, no? > Match keyword marked as syntax error despite PHP version in Project settings > > > Key: NETBEANS-5011 > URL: https://issues.apache.org/jira/browse/NETBEANS-5011 > Project: NetBeans > Issue Type: Bug > Components: php - Editor >Affects Versions: 12.2 > Environment: Product Version: Apache NetBeans IDE 12.2-rc1 > Java: 14.0.2; Java HotSpot(TM) 64-Bit Server VM 14.0.2+12-46 >Reporter: Czukowski >Assignee: Junichi Yamamoto >Priority: Minor > Attachments: image-2020-11-11-10-36-51-198.png, > netbeans-5011-with-php8.0.png > > > NetBeans version: 12.2-rc1 > Project PHP version is set to 7.4 > !image-2020-11-11-10-36-51-198.png! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-5011) Match keyword marked as syntax error despite PHP version in Project settings
[ https://issues.apache.org/jira/browse/NETBEANS-5011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17230018#comment-17230018 ] Czukowski commented on NETBEANS-5011: - Not interested in a discussion, I see. In that case I have no further questions. As for the PRs, I've really considered it, but unfortunately I've had some serious issues with the build and nobody on the dev list was able or wanted to help, so I guess it's a no-go... > Match keyword marked as syntax error despite PHP version in Project settings > > > Key: NETBEANS-5011 > URL: https://issues.apache.org/jira/browse/NETBEANS-5011 > Project: NetBeans > Issue Type: Bug > Components: php - Editor >Affects Versions: 12.2 > Environment: Product Version: Apache NetBeans IDE 12.2-rc1 > Java: 14.0.2; Java HotSpot(TM) 64-Bit Server VM 14.0.2+12-46 >Reporter: Czukowski >Assignee: Junichi Yamamoto >Priority: Minor > Attachments: image-2020-11-11-10-36-51-198.png, > netbeans-5011-with-php8.0.png > > > NetBeans version: 12.2-rc1 > Project PHP version is set to 7.4 > !image-2020-11-11-10-36-51-198.png! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-5011) Match keyword marked as syntax error despite PHP version in Project settings
[ https://issues.apache.org/jira/browse/NETBEANS-5011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17230013#comment-17230013 ] Tomas Mysik commented on NETBEANS-5011: --- [~czukowski] > are you sure it will be much harder to maintain multiple grammar files? The >way I see it, whenever the PHP syntax changes, you can just make a copy, >including the tests and make the necessary adjustments. The previous version >would remain unchanged and it is unlikely there will ever be a need to change >it, if only to fix bugs, if there any found. The only down side is that in >case of bug fixing, there may be multiple copies of a bug, but since they're >just copies, that shouldn't be much of a problem. Yes, we are definitely sure. If you don't believe and you really think that it could work how you write, feel free to create a PR, NetBeans sources are on GitHub. > Match keyword marked as syntax error despite PHP version in Project settings > > > Key: NETBEANS-5011 > URL: https://issues.apache.org/jira/browse/NETBEANS-5011 > Project: NetBeans > Issue Type: Bug > Components: php - Editor >Affects Versions: 12.2 > Environment: Product Version: Apache NetBeans IDE 12.2-rc1 > Java: 14.0.2; Java HotSpot(TM) 64-Bit Server VM 14.0.2+12-46 >Reporter: Czukowski >Assignee: Junichi Yamamoto >Priority: Minor > Attachments: image-2020-11-11-10-36-51-198.png, > netbeans-5011-with-php8.0.png > > > NetBeans version: 12.2-rc1 > Project PHP version is set to 7.4 > !image-2020-11-11-10-36-51-198.png! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-5011) Match keyword marked as syntax error despite PHP version in Project settings
[ https://issues.apache.org/jira/browse/NETBEANS-5011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17230012#comment-17230012 ] Tomas Mysik commented on NETBEANS-5011: --- [~czukowski] > But if it's not really possible (not even to have a different grammar file >per 'supported' PHP version?), then you should probably remove that setting >and all associated code. If there's no ambiguity, there won't be any questions >:) Why do you think so? How would it help in this particular case? BTW I believe there is a note saying that PHP version is used only for hints, so I do not see any reason for removing it (it seems to be working fine for most of the users for 10+ years). > Match keyword marked as syntax error despite PHP version in Project settings > > > Key: NETBEANS-5011 > URL: https://issues.apache.org/jira/browse/NETBEANS-5011 > Project: NetBeans > Issue Type: Bug > Components: php - Editor >Affects Versions: 12.2 > Environment: Product Version: Apache NetBeans IDE 12.2-rc1 > Java: 14.0.2; Java HotSpot(TM) 64-Bit Server VM 14.0.2+12-46 >Reporter: Czukowski >Assignee: Junichi Yamamoto >Priority: Minor > Attachments: image-2020-11-11-10-36-51-198.png, > netbeans-5011-with-php8.0.png > > > NetBeans version: 12.2-rc1 > Project PHP version is set to 7.4 > !image-2020-11-11-10-36-51-198.png! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-5011) Match keyword marked as syntax error despite PHP version in Project settings
[ https://issues.apache.org/jira/browse/NETBEANS-5011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17230001#comment-17230001 ] Czukowski commented on NETBEANS-5011: - [~junichi11] are you sure it will be much harder to maintain multiple grammar files? The way I see it, whenever the PHP syntax changes, you can just make a copy, including the tests and make the necessary adjustments. The previous version would remain unchanged and it is unlikely there will ever be a need to change it, if only to fix bugs, if there any found. The only down side is that in case of bug fixing, there may be multiple copies of a bug, but since they're just copies, that shouldn't be much of a problem. Note: I'm not asking you to undertake such a task just in order to fix a 'match' keyword, I want to start a discussion to understand the situation better, including, for example, why is there a project setting that suggests there should be a support for multiple PHP versions, while in fact there might be some, but 'officially' there's none. And what would it take to bring such support into NetBeans and whether you (not you personally, but the team) hope to ever get around to do it. > Match keyword marked as syntax error despite PHP version in Project settings > > > Key: NETBEANS-5011 > URL: https://issues.apache.org/jira/browse/NETBEANS-5011 > Project: NetBeans > Issue Type: Bug > Components: php - Editor >Affects Versions: 12.2 > Environment: Product Version: Apache NetBeans IDE 12.2-rc1 > Java: 14.0.2; Java HotSpot(TM) 64-Bit Server VM 14.0.2+12-46 >Reporter: Czukowski >Assignee: Junichi Yamamoto >Priority: Minor > Attachments: image-2020-11-11-10-36-51-198.png, > netbeans-5011-with-php8.0.png > > > NetBeans version: 12.2-rc1 > Project PHP version is set to 7.4 > !image-2020-11-11-10-36-51-198.png! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-5011) Match keyword marked as syntax error despite PHP version in Project settings
[ https://issues.apache.org/jira/browse/NETBEANS-5011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17229990#comment-17229990 ] Junichi Yamamoto commented on NETBEANS-5011: [~tmysik] Thank you for your comment :) We may be able to allow "Match" as a namespace name and class name. But the grammar file will be complicated little by little... [~czukowski] Unfortunately, We have not supported such cases so far, I think. In this case, sooner or later, we should rename them for the future. We don't want to have grammar files per PHP version because it will be hard to maintain them (e.g. we have to add unit tests per parser). Thanks for your understanding. > Match keyword marked as syntax error despite PHP version in Project settings > > > Key: NETBEANS-5011 > URL: https://issues.apache.org/jira/browse/NETBEANS-5011 > Project: NetBeans > Issue Type: Bug > Components: php - Editor >Affects Versions: 12.2 > Environment: Product Version: Apache NetBeans IDE 12.2-rc1 > Java: 14.0.2; Java HotSpot(TM) 64-Bit Server VM 14.0.2+12-46 >Reporter: Czukowski >Assignee: Junichi Yamamoto >Priority: Minor > Attachments: image-2020-11-11-10-36-51-198.png, > netbeans-5011-with-php8.0.png > > > NetBeans version: 12.2-rc1 > Project PHP version is set to 7.4 > !image-2020-11-11-10-36-51-198.png! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-5011) Match keyword marked as syntax error despite PHP version in Project settings
[ https://issues.apache.org/jira/browse/NETBEANS-5011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17229975#comment-17229975 ] Czukowski commented on NETBEANS-5011: - Well, it is understandable, but not very user friendly and kind of defeats the purpose of having the PHP version setting in the project. If I remember correctly, there is _some_ level of support based on that setting. I've had to maintain some old projects in the past and just changing that setting to the correct version has always made it work without any issues and I liked NetBeans for that. But if it's not really possible (not even to have a different grammar file per 'supported' PHP version?), then you should probably remove that setting and all associated code. If there's no ambiguity, there won't be any questions :) p.s. Upgrading NetBeans to a newer version is not only for new features, but also in hope that some of the existing issues would be fixed. A situation like this will put the users into a lose-lose situation, where they'll have to give up one thing or another based on a choice they make. > Match keyword marked as syntax error despite PHP version in Project settings > > > Key: NETBEANS-5011 > URL: https://issues.apache.org/jira/browse/NETBEANS-5011 > Project: NetBeans > Issue Type: Bug > Components: php - Editor >Affects Versions: 12.2 > Environment: Product Version: Apache NetBeans IDE 12.2-rc1 > Java: 14.0.2; Java HotSpot(TM) 64-Bit Server VM 14.0.2+12-46 >Reporter: Czukowski >Assignee: Junichi Yamamoto >Priority: Minor > Attachments: image-2020-11-11-10-36-51-198.png, > netbeans-5011-with-php8.0.png > > > NetBeans version: 12.2-rc1 > Project PHP version is set to 7.4 > !image-2020-11-11-10-36-51-198.png! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-5011) Match keyword marked as syntax error despite PHP version in Project settings
[ https://issues.apache.org/jira/browse/NETBEANS-5011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17229955#comment-17229955 ] Tomas Mysik commented on NETBEANS-5011: --- Yes, unlike the Java editor, PHP supports only "the latest PHP version". The reasons are historical (PHP team was much smaller than the Java one, for example) and frankly, it works really well also because PHP is backward compatible most of the time. So, IMHO, the reported case here would be a NetBeans bug if the given code snippet runs fine with the latest PHP version. Of course, I understand that it can be very annoying and sorry for that but when we started NetBeans PHP support, there simply was not any other option how do it (and it would still be *a lot of* work even today). [~junichi11] The only thing here could be that the keyword is right after "\" but I really don't know whether we can fix it in NetBeans (I don't think so). Moreover, if this code won't work with future versions of PHP, then I see it as a really minor issue. > Match keyword marked as syntax error despite PHP version in Project settings > > > Key: NETBEANS-5011 > URL: https://issues.apache.org/jira/browse/NETBEANS-5011 > Project: NetBeans > Issue Type: Bug > Components: php - Editor >Affects Versions: 12.2 > Environment: Product Version: Apache NetBeans IDE 12.2-rc1 > Java: 14.0.2; Java HotSpot(TM) 64-Bit Server VM 14.0.2+12-46 >Reporter: Czukowski >Assignee: Junichi Yamamoto >Priority: Minor > Attachments: image-2020-11-11-10-36-51-198.png > > > NetBeans version: 12.2-rc1 > Project PHP version is set to 7.4 > !image-2020-11-11-10-36-51-198.png! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-5011) Match keyword marked as syntax error despite PHP version in Project settings
[ https://issues.apache.org/jira/browse/NETBEANS-5011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17229941#comment-17229941 ] Junichi Yamamoto commented on NETBEANS-5011: Well, you can't use "Match" in the future. i.e. You have to change it in the future. We support only the latest syntaxes to avoid the grammar file would be complicated. So, I'm not going to fix this... Fortunately, we can also use old versions of NetBeans if we would like to use "Match". [~tmysik] What do you think? > Match keyword marked as syntax error despite PHP version in Project settings > > > Key: NETBEANS-5011 > URL: https://issues.apache.org/jira/browse/NETBEANS-5011 > Project: NetBeans > Issue Type: Bug > Components: php - Code >Affects Versions: 12.2 > Environment: Product Version: Apache NetBeans IDE 12.2-rc1 > Java: 14.0.2; Java HotSpot(TM) 64-Bit Server VM 14.0.2+12-46 >Reporter: Czukowski >Assignee: Junichi Yamamoto >Priority: Minor > Attachments: image-2020-11-11-10-36-51-198.png > > > NetBeans version: 12.2-rc1 > Project PHP version is set to 7.4 > !image-2020-11-11-10-36-51-198.png! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
