[jira] [Commented] (MINIFI-82) Improve config.yml to handle component annotation data
[ https://issues.apache.org/jira/browse/MINIFI-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15514115#comment-15514115 ] ASF GitHub Bot commented on MINIFI-82: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi-minifi/pull/34 > Improve config.yml to handle component annotation data > -- > > Key: MINIFI-82 > URL: https://issues.apache.org/jira/browse/MINIFI-82 > Project: Apache NiFi MiNiFi > Issue Type: Improvement >Affects Versions: 0.0.1 >Reporter: Joseph Percivall >Assignee: Joseph Percivall > Fix For: 0.1.0 > > > Currently the config.yml does not allow for the configuration of component > annotation data. A specific example of which, is the annotation data created > by using the advanced UI of UpdateAttribute. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MINIFI-82) Improve config.yml to handle component annotation data
[ https://issues.apache.org/jira/browse/MINIFI-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15514039#comment-15514039 ] ASF GitHub Bot commented on MINIFI-82: -- Github user apiri commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/34#discussion_r80102080 --- Diff: minifi-toolkit/minifi-toolkit-configuration/src/test/java/org/apache/nifi/minifi/toolkit/configuration/dto/ProcessorSchemaTest.java --- @@ -45,6 +45,35 @@ private final String testKey = "testKey"; private final String testValue = "testValue"; private final String testPenalizationPeriod = "55 s"; +private final String testAnnotationData = ">\n" + --- End diff -- Most certainly, just wanted to make sure I wasn't overlooking. Will merge it in. > Improve config.yml to handle component annotation data > -- > > Key: MINIFI-82 > URL: https://issues.apache.org/jira/browse/MINIFI-82 > Project: Apache NiFi MiNiFi > Issue Type: Improvement >Affects Versions: 0.0.1 >Reporter: Joseph Percivall >Assignee: Joseph Percivall > Fix For: 0.1.0 > > > Currently the config.yml does not allow for the configuration of component > annotation data. A specific example of which, is the annotation data created > by using the advanced UI of UpdateAttribute. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MINIFI-82) Improve config.yml to handle component annotation data
[ https://issues.apache.org/jira/browse/MINIFI-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15514020#comment-15514020 ] ASF GitHub Bot commented on MINIFI-82: -- Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/34#discussion_r80100987 --- Diff: minifi-toolkit/minifi-toolkit-configuration/src/test/java/org/apache/nifi/minifi/toolkit/configuration/dto/ProcessorSchemaTest.java --- @@ -45,6 +45,35 @@ private final String testKey = "testKey"; private final String testValue = "testValue"; private final String testPenalizationPeriod = "55 s"; +private final String testAnnotationData = ">\n" + --- End diff -- Ah good catch, it should be removed. I mis-copied it from a the xml of a template. Could you just amend the commit to remove that? Sorry, I'm in the middle of debugging something else > Improve config.yml to handle component annotation data > -- > > Key: MINIFI-82 > URL: https://issues.apache.org/jira/browse/MINIFI-82 > Project: Apache NiFi MiNiFi > Issue Type: Improvement >Affects Versions: 0.0.1 >Reporter: Joseph Percivall >Assignee: Joseph Percivall > Fix For: 0.1.0 > > > Currently the config.yml does not allow for the configuration of component > annotation data. A specific example of which, is the annotation data created > by using the advanced UI of UpdateAttribute. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MINIFI-82) Improve config.yml to handle component annotation data
[ https://issues.apache.org/jira/browse/MINIFI-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15513780#comment-15513780 ] ASF GitHub Bot commented on MINIFI-82: -- Github user apiri commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/34#discussion_r80084132 --- Diff: minifi-toolkit/minifi-toolkit-configuration/src/test/java/org/apache/nifi/minifi/toolkit/configuration/dto/ProcessorSchemaTest.java --- @@ -45,6 +45,35 @@ private final String testKey = "testKey"; private final String testValue = "testValue"; private final String testPenalizationPeriod = "55 s"; +private final String testAnnotationData = ">\n" + --- End diff -- Very minor, but Is the beginning '>' a typo? I realize it's just test data, but seems like it would be invalid. > Improve config.yml to handle component annotation data > -- > > Key: MINIFI-82 > URL: https://issues.apache.org/jira/browse/MINIFI-82 > Project: Apache NiFi MiNiFi > Issue Type: Improvement >Affects Versions: 0.0.1 >Reporter: Joseph Percivall >Assignee: Joseph Percivall > Fix For: 0.1.0 > > > Currently the config.yml does not allow for the configuration of component > annotation data. A specific example of which, is the annotation data created > by using the advanced UI of UpdateAttribute. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MINIFI-82) Improve config.yml to handle component annotation data
[ https://issues.apache.org/jira/browse/MINIFI-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15511092#comment-15511092 ] ASF GitHub Bot commented on MINIFI-82: -- GitHub user JPercivall opened a pull request: https://github.com/apache/nifi-minifi/pull/34 MINIFI-82 Adding support for Processor 'Annotation Data' You can merge this pull request into a Git repository by running: $ git pull https://github.com/JPercivall/nifi-minifi MINIFI-82 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi/pull/34.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #34 commit 1bafa4fcbf5ef198880536f2563f45ca0e0b11d8 Author: Joseph Percivall Date: 2016-09-21T20:32:35Z MINIFI-82 Adding support for Processor 'Annotation Data' > Improve config.yml to handle component annotation data > -- > > Key: MINIFI-82 > URL: https://issues.apache.org/jira/browse/MINIFI-82 > Project: Apache NiFi MiNiFi > Issue Type: Improvement >Affects Versions: 0.0.1 >Reporter: Joseph Percivall >Assignee: Joseph Percivall > Fix For: 0.1.0 > > > Currently the config.yml does not allow for the configuration of component > annotation data. A specific example of which, is the annotation data created > by using the advanced UI of UpdateAttribute. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
