Repository: nifi Updated Branches: refs/heads/master 9b098f323 -> 29c2e1883
NIFI-4968: fix printing indefinite log errors After first failure in customValidate, stop printing logs until any property is changed Signed-off-by: Matthew Burgess <mattyb...@apache.org> This closes #2537 Project: http://git-wip-us.apache.org/repos/asf/nifi/repo Commit: http://git-wip-us.apache.org/repos/asf/nifi/commit/29c2e188 Tree: http://git-wip-us.apache.org/repos/asf/nifi/tree/29c2e188 Diff: http://git-wip-us.apache.org/repos/asf/nifi/diff/29c2e188 Branch: refs/heads/master Commit: 29c2e1883217377b22de2aaaef975015b92ba563 Parents: 9b098f3 Author: Ed <edward.berezit...@gmail.com> Authored: Tue Mar 13 01:49:04 2018 -0400 Committer: Matthew Burgess <mattyb...@apache.org> Committed: Tue Mar 13 16:40:49 2018 -0400 ---------------------------------------------------------------------- .../nifi/processors/script/InvokeScriptedProcessor.java | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/nifi/blob/29c2e188/nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java ---------------------------------------------------------------------- diff --git a/nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java b/nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java index 5d34a10..be498f5 100644 --- a/nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java +++ b/nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java @@ -234,6 +234,9 @@ public class InvokeScriptedProcessor extends AbstractSessionFactoryProcessor { */ @Override public void onPropertyModified(final PropertyDescriptor descriptor, final String oldValue, final String newValue) { + + validationResults.set(null); + final ComponentLog logger = getLogger(); final Processor instance = processor.get(); @@ -451,6 +454,12 @@ public class InvokeScriptedProcessor extends AbstractSessionFactoryProcessor { return commonValidationResults; } + // do not try to build processor/compile/etc until onPropertyModified clear the validation error/s + // and don't print anything into log. + if (validationResults.get() != null){ + return validationResults.get(); + } + scriptingComponentHelper.setScriptEngineName(context.getProperty(scriptingComponentHelper.SCRIPT_ENGINE).getValue()); scriptingComponentHelper.setScriptPath(context.getProperty(ScriptingComponentUtils.SCRIPT_FILE).evaluateAttributeExpressions().getValue()); scriptingComponentHelper.setScriptBody(context.getProperty(ScriptingComponentUtils.SCRIPT_BODY).getValue()); @@ -554,4 +563,4 @@ public class InvokeScriptedProcessor extends AbstractSessionFactoryProcessor { processor.set(null); scriptEngine = null; } -} +} \ No newline at end of file
