[GitHub] [incubator-nuttx] jerpelea commented on pull request #1332: make/export: copy incdir.c for export build

2020-06-30 Thread GitBox
jerpelea commented on pull request #1332: URL: https://github.com/apache/incubator-nuttx/pull/1332#issuecomment-651573734 @anchao please add commit message This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-nuttx-apps] jerpelea commented on pull request #312: make/import: add incdir into import build

2020-06-30 Thread GitBox
jerpelea commented on pull request #312: URL: https://github.com/apache/incubator-nuttx-apps/pull/312#issuecomment-651573119 @anchao please add commit message This is an automated message from the Apache Git Service. To

[GitHub] [incubator-nuttx] dakejahl commented on pull request #1268: STM32F412 board support

2020-06-30 Thread GitBox
dakejahl commented on pull request #1268: URL: https://github.com/apache/incubator-nuttx/pull/1268#issuecomment-651580166 Thanks everyone! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-nuttx] jerpelea commented on pull request #1327: [Backport-1322] tools: cxd56: mkspk: fix out of tree MAC build

2020-06-30 Thread GitBox
jerpelea commented on pull request #1327: URL: https://github.com/apache/incubator-nuttx/pull/1327#issuecomment-651568467 thanks This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-nuttx] jerpelea commented on pull request #1331: make/version: correct the version generation

2020-06-30 Thread GitBox
jerpelea commented on pull request #1331: URL: https://github.com/apache/incubator-nuttx/pull/1331#issuecomment-651575332 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-nuttx-apps] jerpelea commented on pull request #313: import: add hex/raw binary support

2020-06-30 Thread GitBox
jerpelea commented on pull request #313: URL: https://github.com/apache/incubator-nuttx-apps/pull/313#issuecomment-651572302 @anchao please add commit message This is an automated message from the Apache Git Service. To

[GitHub] [incubator-nuttx-testing] jerpelea commented on pull request #49: testlist/arm-07.dat: Add stm32/nucleo-f412zg boards to testlist

2020-06-30 Thread GitBox
jerpelea commented on pull request #49: URL: https://github.com/apache/incubator-nuttx-testing/pull/49#issuecomment-651572673 @liuguo09 please add commit message This is an automated message from the Apache Git Service. To

[GitHub] [incubator-nuttx] jerpelea merged pull request #1317: sched/task: unify task initialization

2020-06-30 Thread GitBox
jerpelea merged pull request #1317: URL: https://github.com/apache/incubator-nuttx/pull/1317 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-nuttx] 02/03: sched/task_init: change the stack pointer type to (void *)

2020-06-30 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 2fc02ec4a428c1d65dfd6d14dc936c00f1d1d7ec Author: chao.an AuthorDate: Mon Jun 29 11:23:01 2020 +0800

[incubator-nuttx] 03/03: binfmt/exec: allocate stack from internal

2020-06-30 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit b9ad4a000e254f5032914b520234cb23290c8aae Author: chao.an AuthorDate: Mon Jun 29 16:26:48 2020 +0800

[incubator-nuttx] 01/03: sched/task: unify task initialization

2020-06-30 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 62b777b1cd581f7dc4f8781a1fedd1254fca3f96 Author: chao.an AuthorDate: Mon Jun 29 10:44:33 2020 +0800

[incubator-nuttx] branch master updated (ac1641d -> b9ad4a0)

2020-06-30 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from ac1641d stm32/nucleo-f412zg: refresh nsh defconfig new 62b777b sched/task: unify task

[GitHub] [incubator-nuttx] jerpelea commented on pull request #1314: update risc-v rv32im

2020-06-30 Thread GitBox
jerpelea commented on pull request #1314: URL: https://github.com/apache/incubator-nuttx/pull/1314#issuecomment-651755571 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-nuttx] anchao commented on pull request #1332: make/export: copy incdir.c for export build

2020-06-30 Thread GitBox
anchao commented on pull request #1332: URL: https://github.com/apache/incubator-nuttx/pull/1332#issuecomment-651637955 > @anchao please add commit message This PR already contains the commit body, could you please review it again? just a simple correction.

[GitHub] [incubator-nuttx-apps] jerpelea opened a new pull request #314: Examples: camera: add a simple camera snapshot example

2020-06-30 Thread GitBox
jerpelea opened a new pull request #314: URL: https://github.com/apache/incubator-nuttx-apps/pull/314 ## Summary The camera example will take the specified number of pictures (default 10) then will exit To enable the example add the following line in your defconfig

[incubator-nuttx] branch master updated: make/export: copy incdir.c for export build

2020-06-30 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new b896da2 make/export: copy incdir.c

[GitHub] [incubator-nuttx] jerpelea merged pull request #1332: make/export: copy incdir.c for export build

2020-06-30 Thread GitBox
jerpelea merged pull request #1332: URL: https://github.com/apache/incubator-nuttx/pull/1332 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-nuttx-apps] anchao commented on pull request #313: import: add hex/raw binary support

2020-06-30 Thread GitBox
anchao commented on pull request #313: URL: https://github.com/apache/incubator-nuttx-apps/pull/313#issuecomment-651642047 > @anchao please add commit message Done This is an automated message from the Apache Git

[GitHub] [incubator-nuttx-apps] jerpelea commented on pull request #314: Examples: camera: add a simple camera snapshot example

2020-06-30 Thread GitBox
jerpelea commented on pull request #314: URL: https://github.com/apache/incubator-nuttx-apps/pull/314#issuecomment-651719785 @masayuki2009 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-nuttx] jerpelea commented on pull request #1335: boards: arm: cxd56xx: enable basic snapshot camera example

2020-06-30 Thread GitBox
jerpelea commented on pull request #1335: URL: https://github.com/apache/incubator-nuttx/pull/1335#issuecomment-651719885 @masayuki2009 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-nuttx] anchao opened a new pull request #1336: syscall/prctl: fix PR_SET_NAME failure if without arg

2020-06-30 Thread GitBox
anchao opened a new pull request #1336: URL: https://github.com/apache/incubator-nuttx/pull/1336 ## Summary syscall/prctl: fix PR_SET_NAME failure if without arg add PR_SET_NAME_EXT/PR_GET_NAME_EXT extension to avoid semantic conflicts, use extened version for

[GitHub] [incubator-nuttx] Ouss4 merged pull request #1323: vfs: Add chmod/fchmod/utimes function prototype

2020-06-30 Thread GitBox
Ouss4 merged pull request #1323: URL: https://github.com/apache/incubator-nuttx/pull/1323 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-nuttx] branch master updated (b9ad4a0 -> a81a260)

2020-06-30 Thread aguettouche
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from b9ad4a0 binfmt/exec: allocate stack from internal add a81a260 vfs: Add chmod/fchmod/utimes

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #1334: sched: Change tcb_s to task_tcb_s for nxtask_[un]init

2020-06-30 Thread GitBox
xiaoxiang781216 opened a new pull request #1334: URL: https://github.com/apache/incubator-nuttx/pull/1334 ## Summary since these functions can just work with task not thread. ## Impact No functionality change. ## Testing

[GitHub] [incubator-nuttx] jerpelea opened a new pull request #1335: boards: arm: cxd56xx: enable basic snapshot camera example

2020-06-30 Thread GitBox
jerpelea opened a new pull request #1335: URL: https://github.com/apache/incubator-nuttx/pull/1335 ## Summary This camera example grabs a specified number of pictures and saves them on the available storage ## Impact Spresense board ## Testing built for Spresense

[GitHub] [incubator-nuttx-apps] anchao commented on pull request #312: make/import: add incdir into import build

2020-06-30 Thread GitBox
anchao commented on pull request #312: URL: https://github.com/apache/incubator-nuttx-apps/pull/312#issuecomment-651645360 > @anchao please add commit message Done This is an automated message from the Apache Git

[GitHub] [incubator-nuttx] PetervdPerk-NXP opened a new pull request #1337: FlexCAN support NETDEV_LATEINIT

2020-06-30 Thread GitBox
PetervdPerk-NXP opened a new pull request #1337: URL: https://github.com/apache/incubator-nuttx/pull/1337 ## Summary FlexCAN uses arm_netinitialize() to intialize the CAN netdev however this conflicts on boards with both CAN and ENET (S32K148EVB). Thus NETDEV_LATEINIT support is

[GitHub] [incubator-nuttx] MasayukiIshikawa commented on pull request #1335: boards: arm: cxd56xx: enable basic snapshot camera example

2020-06-30 Thread GitBox
MasayukiIshikawa commented on pull request #1335: URL: https://github.com/apache/incubator-nuttx/pull/1335#issuecomment-651735386 @jerpelea Do you know why the build error happened? This is an automated message from

[GitHub] [incubator-nuttx] MasayukiIshikawa removed a comment on pull request #1335: boards: arm: cxd56xx: enable basic snapshot camera example

2020-06-30 Thread GitBox
MasayukiIshikawa removed a comment on pull request #1335: URL: https://github.com/apache/incubator-nuttx/pull/1335#issuecomment-651735386 @jerpelea Do you know why the build error happened? This is an automated

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #1335: boards: arm: cxd56xx: enable basic snapshot camera example

2020-06-30 Thread GitBox
masayuki2009 commented on pull request #1335: URL: https://github.com/apache/incubator-nuttx/pull/1335#issuecomment-651736009 @jerpelea Do you know why the build error happened? This is an automated message from the

[GitHub] [incubator-nuttx] acassis commented on pull request #1314: update risc-v rv32im

2020-06-30 Thread GitBox
acassis commented on pull request #1314: URL: https://github.com/apache/incubator-nuttx/pull/1314#issuecomment-651752048 I think everything was fixed, can we merge it? This is an automated message from the Apache Git

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1221: Add INTx_C macro defintion

2020-06-30 Thread GitBox
xiaoxiang781216 commented on pull request #1221: URL: https://github.com/apache/incubator-nuttx/pull/1221#issuecomment-651831082 https://github.com/apache/incubator-nuttx/issues/630 This is an automated message from the

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #1335: boards: arm: cxd56xx: enable basic snapshot camera example

2020-06-30 Thread GitBox
Ouss4 commented on pull request #1335: URL: https://github.com/apache/incubator-nuttx/pull/1335#issuecomment-651846745 > @jerpelea > Do you know why the build error happened? spresense/example_camera defconfig needs to be updated as well, with ./tools/refresh.sh

[GitHub] [incubator-nuttx] ghn-certi commented on a change in pull request #1328: [DRAFT] pthread_cleanup functions must be called from user space

2020-06-30 Thread GitBox
ghn-certi commented on a change in pull request #1328: URL: https://github.com/apache/incubator-nuttx/pull/1328#discussion_r447699093 ## File path: sched/pthread/pthread_create.c ## @@ -72,28 +72,29 @@ static const char g_pthreadname[] = "";

[GitHub] [incubator-nuttx] PetervdPerk-NXP commented on issue #630: NuttX UINT32_C portability issue

2020-06-30 Thread GitBox
PetervdPerk-NXP commented on issue #630: URL: https://github.com/apache/incubator-nuttx/issues/630#issuecomment-651807553 It seems that is issue has been fixed by this commit https://github.com/apache/incubator-nuttx/commit/7758eb865818d903dceeda4dd238985407673436, @xiaoxiang781216 that's

[GitHub] [incubator-nuttx] Ouss4 edited a comment on pull request #1335: boards: arm: cxd56xx: enable basic snapshot camera example

2020-06-30 Thread GitBox
Ouss4 edited a comment on pull request #1335: URL: https://github.com/apache/incubator-nuttx/pull/1335#issuecomment-651846745 > @jerpelea > Do you know why the build error happened? spresense/example_camera defconfig needs to be updated as well: `./tools/refresh.sh --silent

[GitHub] [incubator-nuttx] jarivanewijk opened a new pull request #1338: S32k small fixes

2020-06-30 Thread GitBox
jarivanewijk opened a new pull request #1338: URL: https://github.com/apache/incubator-nuttx/pull/1338 ## Summary This includes a few small fixes for the NXP S32K arch. - Typos / wrong names in s32k14x_irq.h, s32k1xx_memorymap.h and s32k1xx_pcc.h - Wrong base address for port input

[GitHub] [incubator-nuttx] jerpelea merged pull request #1331: make/version: correct the version generation

2020-06-30 Thread GitBox
jerpelea merged pull request #1331: URL: https://github.com/apache/incubator-nuttx/pull/1331 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-nuttx] branch master updated (0fe2884 -> b8e5755)

2020-06-30 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 0fe2884 libs/libc/machine/risc-v: add rv32 support add b8e5755 make/version: correct the version

[GitHub] [incubator-nuttx] PetervdPerk-NXP closed issue #630: NuttX UINT32_C portability issue

2020-06-30 Thread GitBox
PetervdPerk-NXP closed issue #630: URL: https://github.com/apache/incubator-nuttx/issues/630 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-nuttx] jarivanewijk opened a new pull request #1339: S32K: Expand FlexTimer and add PWM support

2020-06-30 Thread GitBox
jarivanewijk opened a new pull request #1339: URL: https://github.com/apache/incubator-nuttx/pull/1339 ## Summary This PR expands the hardware/s32k1xx_ftm.h file, adds PWM support to the S32K arch and also adds configuration options to enable the FlexTimers and configure PWM. I

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #630: NuttX UINT32_C portability issue

2020-06-30 Thread GitBox
xiaoxiang781216 commented on issue #630: URL: https://github.com/apache/incubator-nuttx/issues/630#issuecomment-651828828 Yes, thanks for closing the issue. This is an automated message from the Apache Git Service. To

[GitHub] [incubator-nuttx] Ouss4 merged pull request #1338: S32K small fixes (typos etc)

2020-06-30 Thread GitBox
Ouss4 merged pull request #1338: URL: https://github.com/apache/incubator-nuttx/pull/1338 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-nuttx] branch master updated (b8e5755 -> 1306cbc)

2020-06-30 Thread aguettouche
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from b8e5755 make/version: correct the version generation add 86c151e S32K Small Fixes: - Typos /

[GitHub] [incubator-nuttx] jerpelea commented on pull request #1335: boards: arm: cxd56xx: enable basic snapshot camera example

2020-06-30 Thread GitBox
jerpelea commented on pull request #1335: URL: https://github.com/apache/incubator-nuttx/pull/1335#issuecomment-651857422 @Ouss4 the config was updated with savedefconfig This is an automated message from the Apache Git

[incubator-nuttx] branch master updated (b896da2 -> 0fe2884)

2020-06-30 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from b896da2 make/export: copy incdir.c for export build add 36a0978 arch/risc-v/src/rv32im: update &

[GitHub] [incubator-nuttx] acassis merged pull request #1314: update risc-v rv32im

2020-06-30 Thread GitBox
acassis merged pull request #1314: URL: https://github.com/apache/incubator-nuttx/pull/1314 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-nuttx] patacongo merged pull request #1279: Implement lstat and realpath

2020-06-30 Thread GitBox
patacongo merged pull request #1279: URL: https://github.com/apache/incubator-nuttx/pull/1279 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-nuttx] branch master updated (b938348 -> a102922)

2020-06-30 Thread gnutt
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from b938348 S32K1XX EEEPROM indentation fix add b598ab4 fs: Implement lstat function add 0b891d6

[incubator-nuttx] 02/03: S32K148EVB netdev lateinit to support Enet & CAN at the same time

2020-06-30 Thread gnutt
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 4a40a7c3d7700cfd94fdaffb5898c4bb05a74dc3 Author: Peter van der Perk AuthorDate: Tue Jun 30 12:17:29 2020 +0200

[GitHub] [incubator-nuttx] patacongo merged pull request #1337: FlexCAN support NETDEV_LATEINIT

2020-06-30 Thread GitBox
patacongo merged pull request #1337: URL: https://github.com/apache/incubator-nuttx/pull/1337 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-nuttx] 03/03: S32K1XX EEEPROM indentation fix

2020-06-30 Thread gnutt
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit b938348cdb237f6b01a27c6650b73d770f7bd106 Author: Peter van der Perk AuthorDate: Tue Jun 30 18:58:00 2020 +0200

[incubator-nuttx] 01/03: Expose xxx_caninitialize() correctly so it's usable in latedev init when there are multiple net devices

2020-06-30 Thread gnutt
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit eca1011b1ef3aa770e1d92c4a9784e25b9f83084 Author: Peter van der Perk AuthorDate: Tue Jun 30 11:44:17 2020 +0200

[incubator-nuttx] branch master updated (14ecb87 -> b938348)

2020-06-30 Thread gnutt
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 14ecb87 sched: Change tcb_s to task_tcb_s for nxtask_[un]init new eca1011 Expose xxx_caninitialize()

[incubator-nuttx] branch master updated: sched: Change tcb_s to task_tcb_s for nxtask_[un]init

2020-06-30 Thread gnutt
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 14ecb87 sched: Change tcb_s to

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #1341: Call c++ global variables in nxtask_startup

2020-06-30 Thread GitBox
xiaoxiang781216 opened a new pull request #1341: URL: https://github.com/apache/incubator-nuttx/pull/1341 ## Summary To avoid the similar code spread around the apps code space ## Impact ## Testing

[GitHub] [incubator-nuttx] acassis commented on pull request #1320: net/sockopt: change the socket option style from Linux to BSD

2020-06-30 Thread GitBox
acassis commented on pull request #1320: URL: https://github.com/apache/incubator-nuttx/pull/1320#issuecomment-652064673 You are right! More info: https://gitlab.com/FFTEAM/oscam/commit/77fa61d900521bc01a6f19198da7796355635542

[incubator-nuttx] branch master updated (a102922 -> e7f2dc8)

2020-06-30 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from a102922 libc: Implement realpath add e7f2dc8 net/sockopt: change the socket option style from Linux

[GitHub] [incubator-nuttx] acassis merged pull request #1320: net/sockopt: change the socket option style from Linux to BSD

2020-06-30 Thread GitBox
acassis merged pull request #1320: URL: https://github.com/apache/incubator-nuttx/pull/1320 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #1331: make/version: correct the version generation

2020-06-30 Thread GitBox
davids5 commented on a change in pull request #1331: URL: https://github.com/apache/incubator-nuttx/pull/1331#discussion_r448026042 ## File path: tools/Makefile.unix ## @@ -31,7 +31,7 @@ endif # In case we cannot get version information from GIT -ifneq

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #1341: Call c++ global variables in nxtask_startup

2020-06-30 Thread GitBox
patacongo edited a comment on pull request #1341: URL: https://github.com/apache/incubator-nuttx/pull/1341#issuecomment-652127320 It is an incorrect design to call C++ destructors from the OS in kernel mode (PROTECTED and KERNEL builds) or with interrupts disabled. Calling the

[GitHub] [incubator-nuttx] patacongo commented on pull request #1341: Call c++ global variables in nxtask_startup

2020-06-30 Thread GitBox
patacongo commented on pull request #1341: URL: https://github.com/apache/incubator-nuttx/pull/1341#issuecomment-652133514 Look how I did the pthread startup function in PR #1328. This is EXACTLY the same issue. I created a user-space pthread_startup (NOT and OS startup function) in

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #1341: Call c++ global variables in nxtask_startup

2020-06-30 Thread GitBox
patacongo edited a comment on pull request #1341: URL: https://github.com/apache/incubator-nuttx/pull/1341#issuecomment-652127933 Think of how this is done in Linux: Each task has a wrapper function called __start in crt0.S and will handle both constructors and destructors. And the

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #1341: Call c++ global variables in nxtask_startup

2020-06-30 Thread GitBox
patacongo edited a comment on pull request #1341: URL: https://github.com/apache/incubator-nuttx/pull/1341#issuecomment-652127320 It is an incorrect design to call C++ constructors or destructors from the OS in kernel mode (PROTECTED and KERNEL builds) or with interrupts disabled.

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #1331: make/version: correct the version generation

2020-06-30 Thread GitBox
anchao commented on a change in pull request #1331: URL: https://github.com/apache/incubator-nuttx/pull/1331#discussion_r448074650 ## File path: tools/Makefile.unix ## @@ -31,7 +31,7 @@ endif # In case we cannot get version information from GIT -ifneq

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #1335: boards: arm: cxd56xx: enable basic snapshot camera example

2020-06-30 Thread GitBox
masayuki2009 commented on pull request #1335: URL: https://github.com/apache/incubator-nuttx/pull/1335#issuecomment-652107208 > I suspect that if fails because the example app is not merged in the app git > >

[GitHub] [incubator-nuttx] patacongo commented on pull request #1341: Call c++ global variables in nxtask_startup

2020-06-30 Thread GitBox
patacongo commented on pull request #1341: URL: https://github.com/apache/incubator-nuttx/pull/1341#issuecomment-652127933 Think of how this is done in Linux: Each task has a wraper function called __start in crt0.S and will handle both constructors and destructors. And the first layer

[GitHub] [incubator-nuttx-apps] masayuki2009 merged pull request #314: Examples: camera: add a simple camera snapshot example

2020-06-30 Thread GitBox
masayuki2009 merged pull request #314: URL: https://github.com/apache/incubator-nuttx-apps/pull/314 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[incubator-nuttx-apps] branch master updated (8750db6 -> f571af1)

2020-06-30 Thread masayuki
This is an automated email from the ASF dual-hosted git repository. masayuki pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git. from 8750db6 examples: fix nxstyle warning add f571af1 Examples: camera: add a simple camera

[GitHub] [incubator-nuttx] patacongo commented on pull request #1341: Call c++ global variables in nxtask_startup

2020-06-30 Thread GitBox
patacongo commented on pull request #1341: URL: https://github.com/apache/incubator-nuttx/pull/1341#issuecomment-652127320 It is an incorrect design to call C++ destructors from the OS in kernel mode (PROTECTED and KERNEL builds) or with interrupts disabled. Calling the destructors

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #316: apps: Remove all stuff related to CONFIG_xxx_CXXINITIALIZE

2020-06-30 Thread GitBox
xiaoxiang781216 opened a new pull request #316: URL: https://github.com/apache/incubator-nuttx-apps/pull/316 since it is moved to the central place in nuttx side instead Signed-off-by: Xiang Xiao Change-Id: I544d6110f1ca6460f7c82f970870aa9b1e7ab3dd ## Summary ##

[GitHub] [incubator-nuttx] yamt opened a new pull request #1342: sim: Sync Linux CMODULEFLAGS with macOS

2020-06-30 Thread GitBox
yamt opened a new pull request #1342: URL: https://github.com/apache/incubator-nuttx/pull/1342 ## Summary Namely, always use -mcmodel=large. NuttX modules are loaded into the NuttX heap, which can be out of range for 32-bit relocations generated with -mcmodel=small. A

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #1341: Call c++ global variables in nxtask_startup

2020-06-30 Thread GitBox
xiaoxiang781216 edited a comment on pull request #1341: URL: https://github.com/apache/incubator-nuttx/pull/1341#issuecomment-652168334 > It is an incorrect design to call C++ constructors or destructors from the OS in kernel mode (PROTECTED and KERNEL builds) or with interrupts disabled.

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1341: Call c++ global variables in nxtask_startup

2020-06-30 Thread GitBox
xiaoxiang781216 commented on pull request #1341: URL: https://github.com/apache/incubator-nuttx/pull/1341#issuecomment-652168334 > It is an incorrect design to call C++ constructors or destructors from the OS in kernel mode (PROTECTED and KERNEL builds) or with interrupts disabled.

[GitHub] [incubator-nuttx-testing] liuguo09 commented on pull request #49: testlist/arm-07.dat: Add stm32/nucleo-f412zg boards to testlist

2020-06-30 Thread GitBox
liuguo09 commented on pull request #49: URL: https://github.com/apache/incubator-nuttx-testing/pull/49#issuecomment-652167106 @jerpelea I have updated with more commit msg. This is an automated message from the Apache Git

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1341: Call c++ global variables in nxtask_startup

2020-06-30 Thread GitBox
xiaoxiang781216 commented on pull request #1341: URL: https://github.com/apache/incubator-nuttx/pull/1341#issuecomment-652173833 @patacongo to indicate nxtask_startup isn't used in KERNEL build, I add the guard like this: ``` #ifndef CONFIG_BUILD_KERNEL void nxtask_startup(main_t