[GitHub] [incubator-nuttx] davids5 commented on issue #459: stm32h7: support SDRAM via FMC peripherial
davids5 commented on issue #459: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-603827257 > > @anpaza could you refine your patchset a little bit? now the PR contain 10 patches, and most patch fix the style issue. It's better that: > > Never used rebase -i before, so it took a bit of time to read the internets :) > Now it looks a lot cleaner. > But davids5' branch nuttx-to-asf:stm32h7-fmc2_cs_fix should be broken now :) @anpaza Thank you! We do not need to be concerned with the stm32h7-fmc2_cs_fix branch. Please commit my suggestion and `rebase -i` one more time, the force push and we will merge this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #459: stm32h7: support SDRAM via FMC peripherial
davids5 commented on issue #459: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-601165084 @anpaza - did you see my PR to your fork? Shal we get this in? See https://github.com/apache/incubator-nuttx/pull/459#pullrequestreview-376872337 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #459: stm32h7: support SDRAM via FMC peripherial
davids5 commented on issue #459: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-599784780 @johannes-nivus Here is one thing that may make sense if @patacongo is onboard with it. There is the `excess ` control in Nxstyle. What in h files we could have a comment in the title block (like vim settings. ) `excess=N` Then we would not have to loose infomation in the right side comments. For for what you did above without loss of information it would be a ruler of 100 and have a tag of * excess=80 Thoughts? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #459: stm32h7: support SDRAM via FMC peripherial
davids5 commented on issue #459: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-597614597 @a > Do you mean: > a) The rulers in file stm32h7x3xx_rcc.h should be extended to cover the longest right-side comment > b) All the comments should be right-side of the respective #define > I can give one more try. Bravo! Yes. The way the file is on master, it only needed the blocks extended. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #459: stm32h7: support SDRAM via FMC peripherial
davids5 commented on issue #459: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-597608242 @anpaza - Again I must apologizes to you for our poor tooling, and my inability to communicate the steps to fix it. If it is OK with you , I will push a commit to this PR that will pass CI on the rcc file by changing the ruler. The issue I have is is that I have several deadlines I have to meet and will not be abel to get to it right away. The approach I will take is revert the rcc file and just add your code changes to it. Then lengthen the block comments. This why of fixing the file is 100% OK in a arch .h file. The way I will push it is documented here: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/committing-changes-to-a-pull-request-branch-created-from-a-fork This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #459: stm32h7: support SDRAM via FMC peripherial
davids5 commented on issue #459: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-597178908 >If you tell me how, I can fix it myself. @anpaza See this commit b27e7d7 @xiaoxiang781216 I left it up to the contributor @anpaza and he said he would like to fix it. That is what I am waiting on. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #459: stm32h7: support SDRAM via FMC peripherial
davids5 commented on issue #459: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-597132496 @johannes-nivus - not it was my mistake! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #459: stm32h7: support SDRAM via FMC peripherial
davids5 commented on issue #459: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-597119767 >If you tell me how, I can fix it myself. @anpaza See this commit https://github.com/apache/incubator-nuttx/pull/488/commits/b27e7d77491d64bb82fe598c90d83f50704961bd [line 1](https://github.com/apache/incubator-nuttx/pull/488/commits/b27e7d77491d64bb82fe598c90d83f50704961bd#diff-83151d0c6d55ed69fbb71462fe8ae91cR1) extended the "Ruler", then all the block comment were extended to match. The fixed the [real error](https://github.com/apache/incubator-nuttx/pull/488/commits/b27e7d77491d64bb82fe598c90d83f50704961bd#diff-83151d0c6d55ed69fbb71462fe8ae91cR4) If you run checkpathc.sh on the before and after of that file. it will be come clear. But I MUST warn you, I has an off by 1 error on one line length and the output of the tools was all wrong. I wasted 40 minutes on that mess. So I feel your pain and very much appreciate your desire to fix the formatting. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #459: stm32h7: support SDRAM via FMC peripherial
davids5 commented on issue #459: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-597105072 > Why not be merciful and stop anpanza's suffering some way. I agree. @anpaza It id is Ok with you, when I have time this week or on the weekend I will pull it in and fix it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #459: stm32h7: support SDRAM via FMC peripherial
davids5 commented on issue #459: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-597095946 @patacongo nxstyle misled lead @anpaza to make make changes in the RCC file. I need to know if you will accept them or suggest he reverts the style changes to that file. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #459: stm32h7: support SDRAM via FMC peripherial
davids5 commented on issue #459: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-597092291 @anpaza - I think the tools is wrong and flagged things it should not have. @patacongo would you please advise @anpaza on the rcc file and if we can take it in as is? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #459: stm32h7: support SDRAM via FMC peripherial
davids5 commented on issue #459: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-597073549 @anpaza > Should I fix someone else's warnings? I chose to. It makes the code better and in Eclipse with the error parers it is trivial. The set up is a bit tricky. I can share the screen shots here if you like/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #459: stm32h7: support SDRAM via FMC peripherial
davids5 commented on issue #459: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-596096058 @patacongo recognizing your are not failure with github. There is a `suggested change` that was requested. I have asked you to use that feature and not waste time on adding comments that are not actionable when they can be. The contributor can then merge the suggestion and all our efforts add value not just criticism. Once the review is done the contributor can squash and force push to remove all the bable commits. This PR is waiting on that action by @anpaza This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
