[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #108: tools/configure.c: Add missing k210 support.
xiaoxiang781216 commented on issue #108: tools/configure.c: Add missing k210 support. URL: https://github.com/apache/incubator-nuttx/pull/108#issuecomment-574943917 > That is a good enhancement request, but I think not relevant here. This change just corrects an error in configure.c. It needs to be merged now. That enhancement can be done later. > > Are you arguing that this should not be merged? I don't think that is a wise argument. We need to fix the error. You should open an issue in the NuttX repo for this. No, we need commit this first, then provide a better solution. I will provide one soon. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #108: tools/configure.c: Add missing k210 support.
xiaoxiang781216 commented on issue #108: tools/configure.c: Add missing k210 support. URL: https://github.com/apache/incubator-nuttx/pull/108#issuecomment-574934305 > Fix a minor but necessary addition to configure.c for the K210 port that was missed in commit [e33fc3d](https://github.com/apache/incubator-nuttx/commit/e33fc3dc895dacf55a0020852a8f3e303c1f52ca) It's better to get rid of the hardode arch/board list from tools directory at all, I don't think it's a good design that any addition in arch need to modify so many script in tools folder. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
