[GitHub] [incubator-nuttx] yamt commented on a change in pull request #279: tiva/lm3s6965-ek: Add CONFIG_BOARD_LATE_INITIALIZE
yamt commented on a change in pull request #279: tiva/lm3s6965-ek: Add
CONFIG_BOARD_LATE_INITIALIZE
URL: https://github.com/apache/incubator-nuttx/pull/279#discussion_r381319783
##
File path: boards/arm/tiva/lm3s6965-ek/src/lm_appinit.c
##
@@ -152,6 +153,9 @@ int board_app_initialize(uintptr_t arg)
mcinfo("Successfully bound SPI port %d to MMC/SD slot %d\n",
CONFIG_NSH_MMCSDSPIPORTNO, CONFIG_NSH_MMCSDSLOTNO);
+#endif
Review comment:
do you mean, the NSH_HAVEMMCSD block in board_app_initialize() should be
moved to bringup()?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #279: tiva/lm3s6965-ek: Add CONFIG_BOARD_LATE_INITIALIZE
yamt commented on a change in pull request #279: tiva/lm3s6965-ek: Add
CONFIG_BOARD_LATE_INITIALIZE
URL: https://github.com/apache/incubator-nuttx/pull/279#discussion_r379524043
##
File path: boards/arm/tiva/lm3s6965-ek/src/lm_appinit.c
##
@@ -152,6 +153,9 @@ int board_app_initialize(uintptr_t arg)
mcinfo("Successfully bound SPI port %d to MMC/SD slot %d\n",
CONFIG_NSH_MMCSDSPIPORTNO, CONFIG_NSH_MMCSDSLOTNO);
+#endif
Review comment:
how should it be?
i tried to follow what sim and others do.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #279: tiva/lm3s6965-ek: Add CONFIG_BOARD_LATE_INITIALIZE
yamt commented on a change in pull request #279: tiva/lm3s6965-ek: Add CONFIG_BOARD_LATE_INITIALIZE URL: https://github.com/apache/incubator-nuttx/pull/279#discussion_r379519773 ## File path: boards/arm/tiva/lm3s6965-ek/src/lm_bringup.c ## @@ -0,0 +1,96 @@ +/ + * boards/arm/tiva/lm3s6965-ek/src/lm_bringup.c + * + * Copyright (C) 2015, 2018 Gregory Nutt. All rights reserved. + * Author: Gregory Nutt + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in + *the documentation and/or other materials provided with the + *distribution. + * 3. Neither the name NuttX nor the names of its contributors may be + *used to endorse or promote products derived from this software + *without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS + * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE + * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, + * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS + * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED + * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN + * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY OF SUCH DAMAGE. + * + / Review comment: thank you. done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #279: tiva/lm3s6965-ek: Add CONFIG_BOARD_LATE_INITIALIZE
yamt commented on a change in pull request #279: tiva/lm3s6965-ek: Add CONFIG_BOARD_LATE_INITIALIZE URL: https://github.com/apache/incubator-nuttx/pull/279#discussion_r379506206 ## File path: boards/arm/tiva/lm3s6965-ek/src/lm_bringup.c ## @@ -0,0 +1,96 @@ +/ + * boards/arm/tiva/lm3s6965-ek/src/lm_bringup.c + * + * Copyright (C) 2015, 2018 Gregory Nutt. All rights reserved. + * Author: Gregory Nutt + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in + *the documentation and/or other materials provided with the + *distribution. + * 3. Neither the name NuttX nor the names of its contributors may be + *used to endorse or promote products derived from this software + *without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS + * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE + * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, + * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS + * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED + * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN + * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY OF SUCH DAMAGE. + * + / Review comment: @patacongo does your permission to change the license apply to this file as well? sorry for bothering, but i want to be strict about this kind of topic. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #279: tiva/lm3s6965-ek: Add CONFIG_BOARD_LATE_INITIALIZE
yamt commented on a change in pull request #279: tiva/lm3s6965-ek: Add CONFIG_BOARD_LATE_INITIALIZE URL: https://github.com/apache/incubator-nuttx/pull/279#discussion_r379499291 ## File path: boards/arm/tiva/lm3s6965-ek/src/Makefile ## @@ -46,4 +46,8 @@ ifeq ($(CONFIG_NX_LCDDRIVER),y) CSRCS += lm_oled.c endif +ifeq ($(CONFIG_BOARD_LATE_INITIALIZE),y) + CSRCS += lm_bringup.c +endif + Review comment: done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #279: tiva/lm3s6965-ek: Add CONFIG_BOARD_LATE_INITIALIZE
yamt commented on a change in pull request #279: tiva/lm3s6965-ek: Add CONFIG_BOARD_LATE_INITIALIZE URL: https://github.com/apache/incubator-nuttx/pull/279#discussion_r379480953 ## File path: boards/arm/tiva/lm3s6965-ek/src/lm_bringup.c ## @@ -0,0 +1,96 @@ +/ + * boards/arm/tiva/lm3s6965-ek/src/lm_bringup.c + * + * Copyright (C) 2015, 2018 Gregory Nutt. All rights reserved. + * Author: Gregory Nutt + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in + *the documentation and/or other materials provided with the + *distribution. + * 3. Neither the name NuttX nor the names of its contributors may be + *used to endorse or promote products derived from this software + *without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS + * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE + * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, + * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS + * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED + * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN + * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY OF SUCH DAMAGE. + * + / Review comment: as stated in the commit message, this file is a copy of an existing flie. i'm not the right person to change the license. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
