Re: [PR] arch/esp32_spi: Add check to see if the TX_FIFO is empty [nuttx]
xiaoxiang781216 merged PR #15904: URL: https://github.com/apache/nuttx/pull/15904 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] arch/esp32_spi: Add check to see if the TX_FIFO is empty [nuttx]
lupyuen commented on PR #15904: URL: https://github.com/apache/nuttx/pull/15904#issuecomment-2683779948 OK we'll allow this Exceptional Syntax for ESP32 SPI only. Thanks :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] arch/esp32_spi: Add check to see if the TX_FIFO is empty [nuttx]
nuttxs commented on PR #15904: URL: https://github.com/apache/nuttx/pull/15904#issuecomment-2683736759 > https://github.com/apache/nuttx/blob/03e8152cae1499f7540a4c10eb155ba6c3cd345e/arch/xtensa/src/esp32/esp32_spi.c#L948-L951 > > Just a minor comment: We seem to have a few variations of the Empty While Loop, wonder if we might wanna use the existing variations instead? Thanks :-) https://github.com/search?q=repo%3Aapache%2Fnuttx%20while%20((getreg32&type=code This is implemented in a similar way to the wait loop in the current ESP32 SPI driver code. For reference, see the following: https://github.com/apache/nuttx/blob/master/arch/xtensa/src/esp32/esp32_spi.c#L1008L1011 https://github.com/apache/nuttx/blob/master/arch/xtensa/src/esp32/esp32_spi.c#L1133L1137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] arch/esp32_spi: Add check to see if the TX_FIFO is empty [nuttx]
lupyuen commented on PR #15904: URL: https://github.com/apache/nuttx/pull/15904#issuecomment-2682600749 https://github.com/apache/nuttx/blob/03e8152cae1499f7540a4c10eb155ba6c3cd345e/arch/xtensa/src/esp32/esp32_spi.c#L948-L951 Just a minor comment: We seem to have a few variations of the Empty While Loop, wonder if we might wanna use the existing variations instead? Thanks :-) https://github.com/search?q=repo%3Aapache%2Fnuttx%20while%20((getreg32&type=code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] arch/esp32_spi: Add check to see if the TX_FIFO is empty [nuttx]
nuttxpr commented on PR #15904: URL: https://github.com/apache/nuttx/pull/15904#issuecomment-2680329314 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements, although the Testing section could be improved. While it specifies the target, it lacks specific build host information (OS, compiler, etc.) and, critically, it's missing the actual *content* of the testing logs before and after the change. Simply stating "ESP32 as SPI master device send data" isn't sufficient evidence of testing. The logs should demonstrate the erroneous behavior before the fix and the correct behavior afterward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
