Re: [PR] arch/sim: Translate Apple clock IDs for macOS sim [nuttx]
toku-mac closed pull request #18978: arch/sim: Translate Apple clock IDs for macOS sim URL: https://github.com/apache/nuttx/pull/18978 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] arch/sim: Translate Apple clock IDs for macOS sim [nuttx]
toku-mac commented on PR #18978: URL: https://github.com/apache/nuttx/pull/18978#issuecomment-4570300361 Please move to #18992. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] arch/sim: Translate Apple clock IDs for macOS sim [nuttx]
toku-mac commented on code in PR #18978:
URL: https://github.com/apache/nuttx/pull/18978#discussion_r3314345789
##
sched/clock/clock_gettime.c:
##
@@ -219,6 +219,10 @@ int clock_gettime(clockid_t clock_id, FAR struct timespec
*tp)
{
int ret;
+#ifdef CONFIG_ARCH_HAVE_CLOCKID_TRANSLATE
+ clock_id = up_translate_clockid(clock_id);
Review Comment:
I see. I'll look into the implementation flow of `tokio::time`, `std::time`,
and `clock_gettime()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] arch/sim: Translate Apple clock IDs for macOS sim [nuttx]
xiaoxiang781216 commented on code in PR #18978:
URL: https://github.com/apache/nuttx/pull/18978#discussion_r3311804524
##
sched/clock/clock_gettime.c:
##
@@ -219,6 +219,10 @@ int clock_gettime(clockid_t clock_id, FAR struct timespec
*tp)
{
int ret;
+#ifdef CONFIG_ARCH_HAVE_CLOCKID_TRANSLATE
+ clock_id = up_translate_clockid(clock_id);
Review Comment:
but, why rust tokio pass the macOS(not NuttX) clock id?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
