Re: [PR] boards/arm64/imx9/imx93-evk: add trdc header [nuttx]
github-actions[bot] commented on PR #14687: URL: https://github.com/apache/nuttx/pull/14687#issuecomment-2472555290 This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] boards/arm64/imx9/imx93-evk: add trdc header [nuttx]
xiaoxiang781216 merged PR #14687: URL: https://github.com/apache/nuttx/pull/14687 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] boards/arm64/imx9/imx93-evk: add trdc header [nuttx]
xiaoxiang781216 commented on PR #14687: URL: https://github.com/apache/nuttx/pull/14687#issuecomment-2470537700 @joukkone let's squash the patch into one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] boards/arm64/imx9/imx93-evk: add trdc header [nuttx]
xiaoxiang781216 commented on code in PR #14687:
URL: https://github.com/apache/nuttx/pull/14687#discussion_r1838101863
##
arch/arm64/src/imx9/imx9_trdc.c:
##
@@ -0,0 +1,938 @@
+/
+ * arch/arm64/src/imx9/imx9_trdc.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ /
+
+/
+ * Included Files
+ /
+
+#include
+
+#include
+#include
+#include
+#include
+#include
+#include
+
+#include
+
+#include "chip.h"
+#include "arm64_internal.h"
+#include "imx9_trdc.h"
+#include
+
+/
+ * Pre-processor Definitions
+ /
+
+#define mmio_read_32(c) getreg32(c)
+#define mmio_write_32(c, v) putreg32(v, c)
+#define mmio_clrbits_32(addr, clear) modifyreg32(addr, clear, 0)
+#define mmio_setbits_32(addr, set)modifyreg32(addr, 0, set)
+#define mmio_clrsetbits_32(addr, clear, set) modifyreg32(addr, clear, set)
+
+/* Bits 8:15 rdc id, bits 0:7 core id */
+
+#define TRDC_AON0x7402
+#define TRDC_WAKEUP 0x7802
+#define TRDC_MEDIA 0x8202
+#define TRDC_NIX0x8602
+
+#define VERBOSE _none
+
+/
+ * Private Types
+ /
+
+struct mbc_mem_dom
+{
+ uint32_t mem_glbcfg[4];
+ uint32_t nse_blk_index;
+ uint32_t nse_blk_set;
+ uint32_t nse_blk_clr;
+ uint32_t nsr_blk_clr_all;
+ uint32_t memn_glbac[8];
+
+ /* The upper only existed in the beginning of each MBC */
+
+ uint32_t mem0_blk_cfg_w[64];
+ uint32_t mem0_blk_nse_w[16];
+ uint32_t mem1_blk_cfg_w[8];
+ uint32_t mem1_blk_nse_w[2];
+ uint32_t mem2_blk_cfg_w[8];
+ uint32_t mem2_blk_nse_w[2];
+ uint32_t mem3_blk_cfg_w[8];
+ uint32_t mem3_blk_nse_w[2]; /* 0x1F0, 0x1F4 */
+ uint32_t reserved[2];
+};
+
+struct mrc_rgn_dom
+{
+ uint32_t mrc_glbcfg[4];
+ uint32_t nse_rgn_indirect;
+ uint32_t nse_rgn_set;
+ uint32_t nse_rgn_clr;
+ uint32_t nse_rgn_clr_all;
+ uint32_t memn_glbac[8];
+
+ /* The upper only existed in the beginning of each MRC */
+
+ uint32_t rgn_desc_words[16][2]; /* 16 regions at max, 2 words per region */
+ uint32_t rgn_nse;
+ uint32_t reserved2[15];
+};
+
+struct mda_inst
+{
+ uint32_t mda_w[8];
+};
+
+struct trdc_mgr
+{
+ uint32_t trdc_cr;
+ uint32_t res0[59];
+ uint32_t trdc_hwcfg0;
+ uint32_t trdc_hwcfg1;
+ uint32_t res1[450];
+ struct mda_inst mda[8];
+ uint32_t res2[15808];
+};
+
+struct trdc_mbc
+{
+ struct mbc_mem_dom mem_dom[DID_NUM];
+};
+
+struct trdc_mrc
+{
+ struct mrc_rgn_dom mrc_dom[DID_NUM];
+};
+
+struct trdc_mgr_info
+{
+ unsigned long trdc_base;
+ uint8_t mbc_id;
+ uint8_t mbc_mem_id;
+ uint8_t blk_mgr;
+ uint8_t blk_mc;
+};
+
+struct trdc_config_info
+{
+ unsigned long trdc_base;
+ struct trdc_glbac_config *mbc_glbac;
+ uint32_t num_mbc_glbac;
+ struct trdc_mbc_config *mbc_cfg;
+ uint32_t num_mbc_cfg;
+ struct trdc_glbac_config *mrc_glbac;
+ uint32_t num_mrc_glbac;
+ struct trdc_mrc_config *mrc_cfg;
+ uint32_t num_mrc_cfg;
+};
+
+struct trdc_fused_module_info
+{
+ unsigned long trdc_base;
+ uint8_t fsb_index;
+ uint8_t fuse_bit;
+ uint8_t mbc_id;
+ uint8_t mem_id;
+ uint8_t blk_id;
+ uint8_t blk_num;
+};
+
+struct trdc_fuse_data
+{
+ uint8_t fsb_index;
+ uint32_t value;
+};
+
+/
+ * Private Data
+ /
+
+static const struct trdc_mgr_info g_trdc_mgr_blks[] =
+{
+ { 0x4427, 0, 0, 39, 40 }, /* TRDC_A */
+ { 0x4246, 0, 0, 70, 71 }, /* TRDC_W */
+ { 0x4246, 1, 0, 1, 2 }, /* TRDC_M */
+ { 0x4901, 0, 1, 1, 2 }, /* TRDC_N */
+};
+
+static const struct trdc_config_info g
Re: [PR] boards/arm64/imx9/imx93-evk: add trdc header [nuttx]
joukkone commented on code in PR #14687: URL: https://github.com/apache/nuttx/pull/14687#discussion_r1838070111 ## arch/arm64/src/imx9/hardware/imx9_trdc.h: ## @@ -0,0 +1,97 @@ +/ + * arch/arm64/src/imx9/hardware/imx9_trdc.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + / + +#ifndef __ARCH_ARM64_SRC_IMX9_HARDWARE_IMX9_TRDC_H +#define __ARCH_ARM64_SRC_IMX9_HARDWARE_IMX9_TRDC_H + +/ + * Included Files + / + +#include + +/ + * Pre-processor Definitions + / + +#define IMX9_TRDC_HWCFG0(IMX9_TRDC_BASE + 0xf0) + +#define IMX9_MBC0_MEM_GLBAC(n) (0x20 + (n << 2)) +#define IMX9_MBC_MEM_BLK_CFG_0(m, n)(0x200 * m + 0x40 + (n << 2)) +#define IMX9_MBC_MEM_BLK_CFG_I(m, n, i) (0x200 * m + 0x40 + (80 << 2) + (i - 1) * 0x28 + (n << 2)) +#define IMX9_MRC0_DOM_RGD_W(m, n) (0x100 * m + 0x40 + (n << 3)) + +#define ELE_MAX_MSG 255U +#define AHAB_VERSION 0x6 +#define AHAB_CMD_TAG 0x17 +#define AHAB_RESP_TAG 0xe1 +#define ELE_RELEASE_RDC_REQ (0xC4) +#define ELE_READ_FUSE_REQ(0x97) +#define ELE_OK0xd6 + +#define FSB_BASE 0x4751UL Review Comment: done ## arch/arm64/src/imx9/imx9_trdc.c: ## @@ -0,0 +1,929 @@ +/ + * arch/arm64/src/imx9/imx9_trdc.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + / + +/ + * Included Files + / + +#include + +#include +#include +#include +#include +#include +#include + +#include + +#include "chip.h" +#include "arm64_internal.h" +#include "imx9_trdc.h" +#include + +/ + * Pre-processor Definitions + / + +#define ARRAY_SIZE(a) \ Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] boards/arm64/imx9/imx93-evk: add trdc header [nuttx]
github-actions[bot] commented on PR #14687: URL: https://github.com/apache/nuttx/pull/14687#issuecomment-2470287181 This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] boards/arm64/imx9/imx93-evk: add trdc header [nuttx]
xiaoxiang781216 commented on code in PR #14687:
URL: https://github.com/apache/nuttx/pull/14687#discussion_r1837771263
##
arch/arm64/src/imx9/imx9_trdc.c:
##
@@ -0,0 +1,929 @@
+/
+ * arch/arm64/src/imx9/imx9_trdc.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ /
+
+/
+ * Included Files
+ /
+
+#include
+
+#include
+#include
+#include
+#include
+#include
+#include
+
+#include
+
+#include "chip.h"
+#include "arm64_internal.h"
+#include "imx9_trdc.h"
+#include
+
+/
+ * Pre-processor Definitions
+ /
+
+#define ARRAY_SIZE(a) \
+ (sizeof(a) / sizeof((a)[0]))
+
+#define mmio_read_32(c)getreg32(c)
+#define mmio_write_32(c, v)putreg32(v, c)
+
+#define mmio_clrbits_32(addr, clear) modifyreg32(addr, clear, 0)
+#define mmio_setbits_32(addr, set) modifyreg32(addr, 0, set)
+#define mmio_clrsetbits_32(addr, clear, set) modifyreg32(addr, clear, set)
+
+/* Bits 8:15 rdc id, bits 0:7 core id */
+
+#define TRDC_AON0x7402
+#define TRDC_WAKEUP 0x7802
+#define TRDC_MEDIA 0x8202
+#define TRDC_NIX0x8602
+
+#define VERBOSE _none
+
+/
+ * Private Function Prototypes
+ /
+
+/
+ * Name: imx9_init_mu
+ *
+ * Description:
+ * This function disable interrupts from AHAB
+ *
+ * Input Parameters:
+ * None
+ *
+ * Returned Value:
+ * None
+ *
+ /
+
+static void imx9_init_mu(void)
+{
+ putreg32(0, ELE_MU_TCR);
+ putreg32(0, ELE_MU_RCR);
+}
+
+/
+ * Name: imx9_ele_sendmsg
+ *
+ * Description:
+ * This function communicates with the Advanced High Assurance Boot (AHAB)
+ * image that should reside in the particular address. This function
+ * sends a message to AHAB.
+ *
+ * Input Parameters:
+ * msg - Message to send
+ *
+ * Returned Value:
+ * None
+ *
+ /
+
+static void imx9_ele_sendmsg(struct ele_msg *msg)
+{
+ /* Check that ele is ready to receive */
+
+ while (!((1) & getreg32(ELE_MU_TSR)));
+
+ /* write header to slog 0 */
+
+ putreg32(msg->header.data, ELE_MU_TR(0));
+
+ /* write data */
+
+ for (int i = 1; i < msg->header.size; i++)
+{
+ int tx_channel;
+
+ tx_channel = i % ELE_TR_NUM ;
+ while (!((1 << tx_channel) & getreg32(ELE_MU_TSR)));
+
+ /* Write data */
+
+ putreg32(msg->data[i - 1], ELE_MU_TR(i));
+}
+}
+
+/
+ * Name: imx9_ele_receivemsg
+ *
+ * Description:
+ * This function communicates with the Advanced High Assurance Boot (AHAB)
+ * image that should reside in the particular address. This function
+ * receives message from AHAB.
+ *
+ * Input Parameters:
+ * msg - receive message buffer
+ *
+ * Returned Value:
+ * None
+ *
+ /
+
+static void imx9_ele_receivemsg(struct ele_msg *msg)
+{
+ /* Check if data ready */
+
+ while (!((1) & getreg32(ELE_MU_RSR)));
+
+ /* Read Header from slot 0 */
+
+ msg->header.data = getreg32(ELE_MU_RR(0));
+
+ for (int i = 1; i < msg->header.size; i++)
+{
+ /* Check if empty */
+
+ int rx_channel = (i) % ELE_RR_NUM;
+ while (!((1 << rx_channel) & getreg32(ELE_MU_RSR)));
+
+ /* Read data */
+
+ msg->data[i - 1] = getreg32(ELE_MU_RR(i));
+}
+}
+
+/***
Re: [PR] boards/arm64/imx9/imx93-evk: add trdc header [nuttx]
joukkone commented on code in PR #14687:
URL: https://github.com/apache/nuttx/pull/14687#discussion_r1837615343
##
boards/arm64/imx9/imx93-evk/include/imx9_trdc_config.h:
##
@@ -0,0 +1,286 @@
+/
+ * boards/arm64/imx9/imx93-evk/include/imx9_trdc_config.h
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ /
+#pragma once
+
+#define SP(X) ((X) << 12)
+#define SU(X) ((X) << 8)
+#define NP(X) ((X) << 4)
+#define NU(X) ((X) << 0)
+#define LK BIT(31)
+#define RWX 7
+#define RW 6
+#define RX 5
+#define R 4
+#define X 1
+#define TEE_SHM_SIZE0x0
+
+/* GLBAC7 is used for TRDC only, any setting to GLBAC7 will be ignored
+ * GLBAC6 is used for fused modules, any setting to GLBAC6 will be ignored
+ */
+
+/* aonmix */
+
+struct trdc_glbac_config trdc_a_mbc_glbac[] =
+{
+ { 0, 0, SP(RW) | SU(RW) | NP(RW) | NU(RW) }, /* MBC0 */
+ { 1, 0, SP(RW) | SU(RW) | NP(RW) | NU(RW) }, /* MBC1 */
+ { 1, 1, SP(RW) | SU(R)| NP(RW) | NU(R) },
+ { 1, 2, SP(RWX) | SU(RWX) | NP(RWX) | NU(RWX) },
+};
+
+struct trdc_mbc_config trdc_a_mbc[] =
Review Comment:
I changed those static, these are board specific and only used by imx9_trdc.c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] boards/arm64/imx9/imx93-evk: add trdc header [nuttx]
joukkone commented on PR #14687: URL: https://github.com/apache/nuttx/pull/14687#issuecomment-2467337021 Updated patch. There is now full trdc configuration, Those header files can be generated with that nxp chiptool, Trdc configuration must be done before DDR configuration. Final configuration should be executed just before jumping to EL1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] boards/arm64/imx9/imx93-evk: add trdc header [nuttx]
github-actions[bot] commented on PR #14687: URL: https://github.com/apache/nuttx/pull/14687#issuecomment-2467333215 This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] boards/arm64/imx9/imx93-evk: add trdc header [nuttx]
acassis commented on PR #14687: URL: https://github.com/apache/nuttx/pull/14687#issuecomment-2462311888 Hi @joukkone nice contribution! Please include later a board config and a Documentation/ explaining how to use the bootloader on this board -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] boards/arm64/imx9/imx93-evk: add trdc header [nuttx]
xiaoxiang781216 commented on code in PR #14687:
URL: https://github.com/apache/nuttx/pull/14687#discussion_r1832864569
##
boards/arm64/imx9/imx93-evk/include/imx9_trdc_config.h:
##
@@ -0,0 +1,286 @@
+/
+ * boards/arm64/imx9/imx93-evk/include/imx9_trdc_config.h
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ /
+#pragma once
+
+#define SP(X) ((X) << 12)
+#define SU(X) ((X) << 8)
+#define NP(X) ((X) << 4)
+#define NU(X) ((X) << 0)
+#define LK BIT(31)
+#define RWX 7
+#define RW 6
+#define RX 5
+#define R 4
+#define X 1
+#define TEE_SHM_SIZE0x0
+
+/* GLBAC7 is used for TRDC only, any setting to GLBAC7 will be ignored
+ * GLBAC6 is used for fused modules, any setting to GLBAC6 will be ignored
+ */
+
+/* aonmix */
+
+struct trdc_glbac_config trdc_a_mbc_glbac[] =
+{
+ { 0, 0, SP(RW) | SU(RW) | NP(RW) | NU(RW) }, /* MBC0 */
+ { 1, 0, SP(RW) | SU(RW) | NP(RW) | NU(RW) }, /* MBC1 */
+ { 1, 1, SP(RW) | SU(R)| NP(RW) | NU(R) },
+ { 1, 2, SP(RWX) | SU(RWX) | NP(RWX) | NU(RWX) },
+};
+
+struct trdc_mbc_config trdc_a_mbc[] =
Review Comment:
add g_ prefix, should we move all global variables to c file
##
boards/arm64/imx9/imx93-evk/include/imx9_trdc_config.h:
##
@@ -0,0 +1,286 @@
+/
+ * boards/arm64/imx9/imx93-evk/include/imx9_trdc_config.h
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ /
+#pragma once
+
+#define SP(X) ((X) << 12)
+#define SU(X) ((X) << 8)
+#define NP(X) ((X) << 4)
+#define NU(X) ((X) << 0)
+#define LK BIT(31)
+#define RWX 7
+#define RW 6
+#define RX 5
+#define R 4
+#define X 1
+#define TEE_SHM_SIZE0x0
+
+/* GLBAC7 is used for TRDC only, any setting to GLBAC7 will be ignored
+ * GLBAC6 is used for fused modules, any setting to GLBAC6 will be ignored
+ */
+
+/* aonmix */
+
+struct trdc_glbac_config trdc_a_mbc_glbac[] =
Review Comment:
where we use these new global variables?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] boards/arm64/imx9/imx93-evk: add trdc header [nuttx]
nuttxpr commented on PR #14687: URL: https://github.com/apache/nuttx/pull/14687#issuecomment-2461805182 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not meet the NuttX requirements. While it provides the template, it lacks the crucial information required by the template. Specifically, the sections marked with "*Update this section...*" are placeholders and haven't been filled with the actual details of the change. A PR with these placeholders is incomplete and unreviewable. Here's a breakdown of what's missing: * **Summary:** The summary needs to explain the *why*, *what*, and *how* of the change. It mentions a trdc header for the imx9-evk bootloader, but doesn't explain *why* this header is needed, *what* it contains, or *how* it solves the problem. There's no mention of related issues. * **Impact:** All the impact fields are left blank. The author needs to assess and document the impact of the change on users, build process, hardware, documentation, security, and compatibility. * **Testing:** The testing section is also incomplete. It requests details about the build host and target, as well as logs from before and after the change, but none of this information is provided. Simply stating "This is needed" isn't sufficient verification. To meet the NuttX requirements, the author needs to fill out all the required sections with specific information relevant to the changes made. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
