Re: [PR] graphics/libjpeg: Add JPEG compressor support to Makefile [nuttx-apps]
xiaoxiang781216 merged PR #3127: URL: https://github.com/apache/nuttx-apps/pull/3127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] graphics/libjpeg: Add JPEG compressor support to Makefile [nuttx-apps]
xiaoxiang781216 commented on PR #3127: URL: https://github.com/apache/nuttx-apps/pull/3127#issuecomment-3066335582 > > > I can clean up the JPEG resize tool and share it with NuttX as well if we think this is nice to have > > > > > > yes, I think it's useful tool and demo. > > While we are here, should this upcoming app be under the /example dir? It is an actual tool that could be used to resize images in production. Like in scripts. We are using this to create thumbnails. > > I dont see any /tools dir that contain actual tool applications. Maybe this is something worth adding? could put it into apps/graphics or apps/system folder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] graphics/libjpeg: Add JPEG compressor support to Makefile [nuttx-apps]
keever50 commented on PR #3127: URL: https://github.com/apache/nuttx-apps/pull/3127#issuecomment-3065999659 > > I can clean up the JPEG resize tool and share it with NuttX as well if we think this is nice to have > > yes, I think it's useful tool and demo. While we are here, should this upcoming app be under the /example dir? It is an actual tool that could be used to resize images in production. Like in scripts. We are using this to create thumbnails. I dont see any /tools dir that contain actual tool applications. Maybe this is something worth adding? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] graphics/libjpeg: Add JPEG compressor support to Makefile [nuttx-apps]
keever50 commented on PR #3127: URL: https://github.com/apache/nuttx-apps/pull/3127#issuecomment-3065314120 > Thanks @keever50 :-) Only sources needs to be added no application code? :-) > > CI failed for some reason, restarted :-) That's right yep. I think it is possible to add code to make JPEG run more efficient or to take advantage of JPEG hardware. But right now it is just stock. CI is still failing. Not sure why. About the resize tool, I can make a separate PR for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] graphics/libjpeg: Add JPEG compressor support to Makefile [nuttx-apps]
xiaoxiang781216 commented on PR #3127: URL: https://github.com/apache/nuttx-apps/pull/3127#issuecomment-3064672968 > I can clean up the JPEG resize tool and share it with NuttX as well if we think this is nice to have yes, I think it's useful tool and demo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] graphics/libjpeg: Add JPEG compressor support to Makefile [nuttx-apps]
cederom commented on PR #3127: URL: https://github.com/apache/nuttx-apps/pull/3127#issuecomment-3064077935 Thanks @keever50 :-) Only sources needs to be added no application code? :-) CI failed for some reason, restarted :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] graphics/libjpeg: Add JPEG compressor support to Makefile [nuttx-apps]
keever50 commented on PR #3127: URL: https://github.com/apache/nuttx-apps/pull/3127#issuecomment-3063335519 I can clean up the JPEG resize tool and share it with NuttX as well if we think this is nice to have -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
