[ofbiz-plugins] branch release22.01 updated: Fixed: Unable to add product to cart for specific product (OFBIZ-12105)
This is an automated email from the ASF dual-hosted git repository.
jleroux pushed a commit to branch release22.01
in repository https://gitbox.apache.org/repos/asf/ofbiz-plugins.git
The following commit(s) were added to refs/heads/release22.01 by this push:
new 40f923ff3 Fixed: Unable to add product to cart for specific product
(OFBIZ-12105)
40f923ff3 is described below
commit 40f923ff3ac450bd78cc2bd4ff96ae0833ac29a1
Author: Jacques Le Roux
AuthorDate: Sat Dec 31 10:52:03 2022 +0100
Fixed: Unable to add product to cart for specific product (OFBIZ-12105)
Completes previous commit
---
ecommerce/webapp/ecommerce/images/productAdditionalView.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ecommerce/webapp/ecommerce/images/productAdditionalView.js
b/ecommerce/webapp/ecommerce/images/productAdditionalView.js
index ad746d39b..f47d006da 100644
--- a/ecommerce/webapp/ecommerce/images/productAdditionalView.js
+++ b/ecommerce/webapp/ecommerce/images/productAdditionalView.js
@@ -38,7 +38,7 @@ imgView = {
},
showImage: function() {
var mainImage = document.getElementById('detailImage');
-mainImage.src = this.getAttributeNode('swapDetail').value;
+mainImage.src = this.getAttribute('swapDetail').value;
return false;
},
addEvent: function(element, eventType, doFunction, useCapture) {
[ofbiz-plugins] branch release22.01 updated: Fixed: Unable to add product to cart for specific product (OFBIZ-12105)
This is an automated email from the ASF dual-hosted git repository.
jleroux pushed a commit to branch release22.01
in repository https://gitbox.apache.org/repos/asf/ofbiz-plugins.git
The following commit(s) were added to refs/heads/release22.01 by this push:
new 736da3e5b Fixed: Unable to add product to cart for specific product
(OFBIZ-12105)
736da3e5b is described below
commit 736da3e5bb9aec581efcabf69d0b9efed79bad4f
Author: Jacques Le Roux
AuthorDate: Sat Dec 31 10:21:36 2022 +0100
Fixed: Unable to add product to cart for specific product (OFBIZ-12105)
Issue exist for Specfic product only as
giant-widget-with-variant-explosion-WG-9943-p
Step to reproduce
1. Open - https://demo-trunk.ofbiz.apache.org/ecomseo
2. Click on the giant-widget-with-variant-explosion product link.
3. Select colour and size.
4. Select unit of measure.
5. Click on add to cart link.
Actual Result: Unable to product to cart
Expected Result : Product should be added to cart.
jleroux: error in js console log:
The use of "getAttributeNode()" is deprecated. Use "getAttribute()" instead.
This was only a problem in Firefox since a very old version:
https://bugzilla.mozilla.org/show_bug.cgi?id=690120
Tested without fix on last Edge (ie Chromium) on Win7, works w/ fix too
Thanks: Ashish Sharma for report
---
ecommerce/webapp/ecommerce/images/productAdditionalView.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ecommerce/webapp/ecommerce/images/productAdditionalView.js
b/ecommerce/webapp/ecommerce/images/productAdditionalView.js
index a028a436c..ad746d39b 100644
--- a/ecommerce/webapp/ecommerce/images/productAdditionalView.js
+++ b/ecommerce/webapp/ecommerce/images/productAdditionalView.js
@@ -23,7 +23,7 @@ imgView = {
allAnchors = document.getElementsByTagName('a');
if (allAnchors.length) {
for (var i = 0; i < allAnchors.length; i++) {
-if (allAnchors[i].getAttributeNode('swapDetail') &&
allAnchors[i].getAttributeNode('swapDetail').value != '') {
+if (allAnchors[i].getAttribute('swapDetail') &&
allAnchors[i].getAttribute('swapDetail').value != '') {
allAnchors[i].onmouseover = imgView.showImage;
allAnchors[i].onmouseout = imgView.showDetailImage;
}
@@ -31,7 +31,7 @@ imgView = {
}
}
},
-showDetailImage: function() {
+showDetailImage: function() {
var mainImage = document.getElementById('detailImage');
mainImage.src = document.getElementById('originalImage').value;
return false;
