Author: mbrohl
Date: Fri Sep 16 22:26:05 2016
New Revision: 1761107

URL: http://svn.apache.org/viewvc?rev=1761107&view=rev
Log:
Improved: Ebaystore: Consistent form name.
(OFBIZ-8104)

Change all form names to upper camel case for consistency.

Thanks: Tanmay Muley for reporting and providing the patch.

Modified:
    ofbiz/trunk/specialpurpose/ebaystore/widget/EbaySellingManagerForms.xml
    ofbiz/trunk/specialpurpose/ebaystore/widget/EbaySellingManagerScreens.xml

Modified: 
ofbiz/trunk/specialpurpose/ebaystore/widget/EbaySellingManagerForms.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/ebaystore/widget/EbaySellingManagerForms.xml?rev=1761107&r1=1761106&r2=1761107&view=diff
==============================================================================
--- ofbiz/trunk/specialpurpose/ebaystore/widget/EbaySellingManagerForms.xml 
(original)
+++ ofbiz/trunk/specialpurpose/ebaystore/widget/EbaySellingManagerForms.xml Fri 
Sep 16 22:26:05 2016
@@ -160,7 +160,7 @@ under the License.
         </field>
         <field name="submitButton" ><submit button-type="button"/></field>
     </form>
-    <form name="reserveEbayProductInventory" type="single" list-name=""  
target="reserveProductInventory"
+    <form name="ReserveEbayProductInventory" type="single" list-name=""  
target="reserveProductInventory"
         odd-row-style="alternate-row" default-table-style="basic-table 
hover-bar">
         <field name="productStoreId"><display 
description="${parameters.productStoreId}"></display></field>
         <field name="facilityId"><display 
description="${parameters.facilityId}"></display></field>
@@ -195,7 +195,7 @@ under the License.
         <field name="reservedDate"><display></display></field>
         <field name="updateButton" 
title="${uiLabelMap.EbayUpdateInventory}"><submit button-type="button"/></field>
     </form>
-    <form name="updateQuantityReserved" type="single"  
target="updateProductQuantityReserved" 
default-entity-name="EbayProductStoreInventory" 
default-map-name="ebayProductStoreInventory"
+    <form name="UpdateQuantityReserved" type="single"  
target="updateProductQuantityReserved" 
default-entity-name="EbayProductStoreInventory" 
default-map-name="ebayProductStoreInventory"
         odd-row-style="alternate-row" default-table-style="basic-table 
hover-bar">
         <field name="productStoreId"><display></display></field>
         <field name="facilityId"><display></display></field>
@@ -213,7 +213,7 @@ under the License.
         <field name="submitButton"><submit button-type="button"/></field>
     </form>
     <!-- Automatically leave the following positive feedback  -->
-    <form name="autoPositiveFeedbackForBuyers" type="single"  
target="autoPrefLeaveFeedbackOptions"
+    <form name="AutoPositiveFeedbackForBuyers" type="single"  
target="autoPrefLeaveFeedbackOptions"
         odd-row-style="alternate-row" default-table-style="basic-table 
hover-bar">
         <actions>
             <entity-one entity-name="EbayProductStorePref"  
value-field="ebayProductStorePref">
@@ -286,7 +286,7 @@ under the License.
         <field name="submitButton" title="${uiLabelMap.CommonApply}"><submit 
button-type="button"/></field>
     </form>
     <!-- Automatically send a Feedback Reminder email if feedback has not been 
received. Please choose how many days after shipping you want this email sent? 
-->
-    <form name="autoSendFeedbackReminder" type="single"  
target="autoSendFeedbackReminder"
+    <form name="AutoSendFeedbackReminder" type="single"  
target="autoSendFeedbackReminder"
         header-row-style="header-row" default-table-style="basic-table">
         <actions>
             <entity-one entity-name="EbayProductStorePref"  
value-field="ebayProductStorePref">
@@ -310,7 +310,7 @@ under the License.
         <field name="submitButton" title="${uiLabelMap.CommonApply}"><submit 
button-type="button"/></field>
     </form>
     <!-- Automatically send Payment Received email when payment has been 
received -->
-    <form name="autoSendPaymentReceivedEmail" type="single"  
target="autoSendPaymentReceivedEmail"
+    <form name="AutoSendPaymentReceivedEmail" type="single"  
target="autoSendPaymentReceivedEmail"
         header-row-style="header-row" default-table-style="basic-table">
         <actions>
             <entity-one entity-name="EbayProductStorePref"  
value-field="ebayProductStorePref">
@@ -332,7 +332,7 @@ under the License.
         <field name="submitButton" title="${uiLabelMap.CommonApply}"><submit 
button-type="button"/></field>
     </form>
     <!-- Combine Orders Setting -->
-    <form name="combineOrdersSetting" type="single" 
target="settingCombineOrders" header-row-style="header-row" 
default-table-style="basic-table">
+    <form name="CombineOrdersSetting" type="single" 
target="settingCombineOrders" header-row-style="header-row" 
default-table-style="basic-table">
         <actions>
             <entity-one entity-name="EbayProductStorePref" 
value-field="ebayPrefCombine">
                 <field-map field-name="productStoreId" 
from-field="parameters.productStoreId"/>
@@ -346,7 +346,7 @@ under the License.
         <field name="condition2" title="Allow no more than" tooltip-style="h3" 
tooltip="items per order"><text size="3" 
default-value="${ebayPrefCombine.condition2}" maxlength="2"></text></field>
         <field name="submitButton" title="${uiLabelMap.CommonSave}"><submit 
button-type="button"/></field>
     </form>
-    <form name="winningBuyerNotification" type="single" 
target="settingWinningBuyerNotification" header-row-style="header-row" 
default-table-style="basic-table">
+    <form name="WinningBuyerNotification" type="single" 
target="settingWinningBuyerNotification" header-row-style="header-row" 
default-table-style="basic-table">
         <actions>
             <entity-one entity-name="EbayProductStorePref" 
value-field="ebayPrefCombine">
                 <field-map field-name="productStoreId" 
from-field="parameters.productStoreId"/>
@@ -358,7 +358,7 @@ under the License.
         <field name="isRunWinnerNotify" position="1" title="Enable send winner 
buyer notification automatically"><check></check></field>
         <field name="submitButton" title="${uiLabelMap.CommonSave}"><submit 
button-type="button"/></field>
     </form>
-    <form name="itemDispatchedNotification" type="single" 
target="settingSendItemDispatchedNotification" header-row-style="header-row" 
default-table-style="basic-table">
+    <form name="ItemDispatchedNotification" type="single" 
target="settingSendItemDispatchedNotification" header-row-style="header-row" 
default-table-style="basic-table">
         <actions>
             <entity-one entity-name="EbayProductStorePref" 
value-field="ebayPrefCombine">
                 <field-map field-name="productStoreId" 
from-field="parameters.productStoreId"/>
@@ -455,7 +455,7 @@ under the License.
         <field name="includeCrossPromotions" title=" " 
tooltip="${uiLabelMap.EbayIncludeMyDefaultCrossPromotionInThisEmail}" 
tooltip-style="h3"><check/></field-->
         <field name="submitButton"><submit/></field>
     </form>
-    <form name="blockItemsOutOfStock" type="single" 
target="runBlockItemOutOfStock" header-row-style="header-row" 
default-table-style="basic-table">
+    <form name="BlockItemsOutOfStock" type="single" 
target="runBlockItemOutOfStock" header-row-style="header-row" 
default-table-style="basic-table">
         <actions>
             <entity-one entity-name="EbayProductStorePref" 
value-field="ebayPrefCombine">
                 <field-map field-name="productStoreId" 
from-field="parameters.productStoreId"/>
@@ -520,7 +520,7 @@ under the License.
         <field name="buyerId"><text/></field>
         <field name="submitButton" 
title="${uiLabelMap.CommonSearch}"><submit/></field>
     </form>
-    <form name="findOrdersImported" type="single" 
target="searchOrdersImported">
+    <form name="FindOrdersImported" type="single" 
target="searchOrdersImported">
         <actions>
             <entity-and entity-name="ProductStoreRole" list="storeList">
                 <field-map field-name="productStoreId" 
from-field="parameters.productStoreId"/>
@@ -560,7 +560,7 @@ under the License.
         </field>
         <field name="submitButton" 
title="${uiLabelMap.CommonFind}"><submit/></field>
     </form>
-    <form name="bestOffer" type="single" target="ebayAutoPrefCond">
+    <form name="BestOffer" type="single" target="ebayAutoPrefCond">
         <field name="productStoreId"><hidden 
value="${parameters.productStoreId}"/></field>
         <field name="automateEnable" title="Enable" 
tooltip="${uiLabelMap.EbayEvaluateOn}" tooltip-style="h3"><check/></field>
         <field name="kindOfPrice" title="Based Price" 
tooltip="${uiLabelMap.EbayBasedOn}" tooltip-style="h3">
@@ -668,7 +668,7 @@ under the License.
             </hyperlink>
         </field>
     </grid>
-    <form name="viewCustomerOfferData" type="single" 
target="updateContactStatus">
+    <form name="ViewCustomerOfferData" type="single" 
target="updateContactStatus">
         <field name="customerUserId" title="Customer User ID"><display 
description="${userId}"/></field>
         <field name="productId" title="Item Id"><display 
description="${itemId}"/></field>
         <field name="productName" title="Item Name"><display 
description="${itemName}"/></field>

Modified: 
ofbiz/trunk/specialpurpose/ebaystore/widget/EbaySellingManagerScreens.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/ebaystore/widget/EbaySellingManagerScreens.xml?rev=1761107&r1=1761106&r2=1761107&view=diff
==============================================================================
--- ofbiz/trunk/specialpurpose/ebaystore/widget/EbaySellingManagerScreens.xml 
(original)
+++ ofbiz/trunk/specialpurpose/ebaystore/widget/EbaySellingManagerScreens.xml 
Fri Sep 16 22:26:05 2016
@@ -171,7 +171,7 @@
                 <decorator-screen name="SellingManagerDecorator" 
location="${parameters.mainDecoratorLocation}">
                     <decorator-section name="body">
                         <screenlet title="${uiLabelMap.EbayReserveProductFrom} 
: ${facility.facilityName}">
-                            <include-form name="reserveEbayProductInventory" 
location="component://ebaystore/widget/EbaySellingManagerForms.xml"/>
+                            <include-form name="ReserveEbayProductInventory" 
location="component://ebaystore/widget/EbaySellingManagerForms.xml"/>
                         </screenlet>
                     </decorator-section>
                 </decorator-screen>
@@ -224,7 +224,7 @@
                 <decorator-screen name="SellingManagerDecorator" 
location="${parameters.mainDecoratorLocation}">
                     <decorator-section name="body">
                         <screenlet title="Inventory Quantities">
-                            <include-form name="updateQuantityReserved" 
location="component://ebaystore/widget/EbaySellingManagerForms.xml"/>
+                            <include-form name="UpdateQuantityReserved" 
location="component://ebaystore/widget/EbaySellingManagerForms.xml"/>
                         </screenlet>
                     </decorator-section>
                 </decorator-screen>
@@ -249,28 +249,28 @@
                         <include-screen name="AutomationRelistSoldItems"/>
                         <include-screen name="AutomationDispute"/>
                         <screenlet 
title="${uiLabelMap.EbayTxtAutoPositiveFeedbackBuyer}" 
id="autoPositiveFeedback" collapsible="true" initially-collapsed="true">
-                            <include-form name="autoPositiveFeedbackForBuyers" 
location="component://ebaystore/widget/EbaySellingManagerForms.xml"/>
+                            <include-form name="AutoPositiveFeedbackForBuyers" 
location="component://ebaystore/widget/EbaySellingManagerForms.xml"/>
                         </screenlet>
                         <screenlet 
title="${uiLabelMap.EbayIsAutoFeedbackReminder}" id="autoSendFeedbackReminder" 
collapsible="true" initially-collapsed="true">
-                            <include-form name="autoSendFeedbackReminder" 
location="component://ebaystore/widget/EbaySellingManagerForms.xml"/>
+                            <include-form name="AutoSendFeedbackReminder" 
location="component://ebaystore/widget/EbaySellingManagerForms.xml"/>
                         </screenlet>
                         <screenlet 
title="${uiLabelMap.EbayAutoPaymentReceviedEmail}" 
id="autoSendPaymentReceivedEmail" collapsible="true" initially-collapsed="true">
-                            <include-form name="autoSendPaymentReceivedEmail" 
location="component://ebaystore/widget/EbaySellingManagerForms.xml"/>
+                            <include-form name="AutoSendPaymentReceivedEmail" 
location="component://ebaystore/widget/EbaySellingManagerForms.xml"/>
                         </screenlet>
                         <screenlet 
title="${uiLabelMap.EbayCombineOrderSetting}" id="combineOrdersSetting" 
collapsible="true" initially-collapsed="true">
-                            <include-form name="combineOrdersSetting" 
location="component://ebaystore/widget/EbaySellingManagerForms.xml"/>
+                            <include-form name="CombineOrdersSetting" 
location="component://ebaystore/widget/EbaySellingManagerForms.xml"/>
                         </screenlet>
                         <screenlet 
title="${uiLabelMap.EbayAutoSendWinBuyerEmail}" id="winningBuyerNotification" 
collapsible="true" initially-collapsed="true">
-                            <include-form name="winningBuyerNotification" 
location="component://ebaystore/widget/EbaySellingManagerForms.xml"/>
+                            <include-form name="WinningBuyerNotification" 
location="component://ebaystore/widget/EbaySellingManagerForms.xml"/>
                         </screenlet>
                         <screenlet 
title="${uiLabelMap.EbayAutoSendItemDispatchEmail}" 
id="itemDispatchedNotification" collapsible="true" initially-collapsed="true">
-                            <include-form name="itemDispatchedNotification" 
location="component://ebaystore/widget/EbaySellingManagerForms.xml"/>
+                            <include-form name="ItemDispatchedNotification" 
location="component://ebaystore/widget/EbaySellingManagerForms.xml"/>
                         </screenlet>
                         <screenlet 
title="${uiLabelMap.EbayBlockItemOutOfStock}" id="blockItemsOutOfStock" 
collapsible="true" initially-collapsed="true">
-                            <include-form name="blockItemsOutOfStock" 
location="component://ebaystore/widget/EbaySellingManagerForms.xml"/>
+                            <include-form name="BlockItemsOutOfStock" 
location="component://ebaystore/widget/EbaySellingManagerForms.xml"/>
                         </screenlet>
                         <screenlet title="${uiLabelMap.AutoBestOfferSetting}" 
id="bestOfferSetting" collapsible="true" initially-collapsed="true">
-                            <include-form name="bestOffer" 
location="component://ebaystore/widget/EbaySellingManagerForms.xml"/>
+                            <include-form name="BestOffer" 
location="component://ebaystore/widget/EbaySellingManagerForms.xml"/>
                         </screenlet>
                     </decorator-section>
                 </decorator-screen>
@@ -546,7 +546,7 @@
                 <decorator-screen name="SellingManagerDecorator" 
location="${parameters.mainDecoratorLocation}">
                     <decorator-section name="body">
                         <screenlet title="Find Orders Imported">
-                            <include-form name="findOrdersImported" 
location="component://ebaystore/widget/EbaySellingManagerForms.xml"/>
+                            <include-form name="FindOrdersImported" 
location="component://ebaystore/widget/EbaySellingManagerForms.xml"/>
                         </screenlet>
                         <platform-specific>
                             <html>
@@ -624,7 +624,7 @@
                <decorator-screen name="SellingManagerDecorator" 
location="${parameters.mainDecoratorLocation}">
                    <decorator-section name="body">
                        <screenlet name="customerData"  title="Customer Offer 
Data">
-                           <include-form 
location="component://ebaystore/widget/EbaySellingManagerForms.xml" 
name="viewCustomerOfferData"/>
+                           <include-form 
location="component://ebaystore/widget/EbaySellingManagerForms.xml" 
name="ViewCustomerOfferData"/>
                        </screenlet>
                    </decorator-section>
                </decorator-screen>


Reply via email to