Re: [PR] refactor(foyer): seperate mods from lib.rs [opendal]
flaneur2020 commented on PR #7154: URL: https://github.com/apache/opendal/pull/7154#issuecomment-3782338738 > I think foyer should be converted into a service first before we go further. just realized a potential issue: Foyer's `fetch` method has built-in concurrency control between checking for existence and writing to the cache. this prevents multiple requests from hitting the same cache key simultaneously and flooding the backend during a cache miss. it may has a risk that this capability might be lost after moving to the service interface, but imo it could be considered as an further optimization later. @xxchan do you have any suggestions regarding this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(foyer): seperate mods from lib.rs [opendal]
flaneur2020 commented on PR #7154: URL: https://github.com/apache/opendal/pull/7154#issuecomment-3782206071 > Thanks for your contribution @flaneur2020! LGTM. @tisonkun thank you for the fast response! > > I think foyer should be converted into a service first before we go further. @Xuanwo i like this direction. let me try this out. 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(foyer): seperate mods from lib.rs [opendal]
flaneur2020 commented on PR #7154: URL: https://github.com/apache/opendal/pull/7154#issuecomment-3782204508 > I think foyer should be converted into a service first before we go further. i like this direction. let me try this out. :+1: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(foyer): seperate mods from lib.rs [opendal]
Xuanwo commented on PR #7154: URL: https://github.com/apache/opendal/pull/7154#issuecomment-3780723907 I think foyer should be converted into a service first before we go further. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(foyer): seperate mods from lib.rs [opendal]
tisonkun merged PR #7154: URL: https://github.com/apache/opendal/pull/7154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[PR] refactor(foyer): seperate mods from lib.rs [opendal]
flaneur2020 opened a new pull request, #7154: URL: https://github.com/apache/opendal/pull/7154 # Which issue does this PR close? Closes #. # Rationale for this change A planned upcoming change is to provide chunked cache capabilities for the foyer layer, allowing large objects to be split into chunks for cached reads. Before implementing this, I think it might be good to perform a simple refactoring of the modules. This will help reduce the PR footprint when introducing chunked cache later, ideally limiting the new logic to a single additional file. This PR has zero logic changes, it's just moving code around. # What changes are included in this PR? This PR sperates the single lib.rs into the following structure: ``` core/layers/foyer/src/ ├── lib.rs ├── error.rs ├── full.rs ├── writer.rs └── deleter.rs ``` # Are there any user-facing changes? no # AI Usage Statement I used Opus4.5 to make this refactor, and reviewed by myself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
