svn commit: r1822932 - in /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation: PDAnnotationCaret.java PDAnnotationFreeText.java PDAnnotationSquareCircle.java

[msahyoun]

Author: msahyoun
Date: Fri Feb  2 09:08:02 2018
New Revision: 1822932

URL: http://svn.apache.org/viewvc?rev=1822932&view=rev
Log:
PDFBOX-4092: return empty array if the /RD entry hasn't been set to allow to 
check for that condition

Modified:
    
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/PDAnnotationCaret.java
    
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/PDAnnotationFreeText.java
    
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/PDAnnotationSquareCircle.java

Modified: 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/PDAnnotationCaret.java
URL: 
http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/PDAnnotationCaret.java?rev=1822932&r1=1822931&r2=1822932&view=diff
==============================================================================
--- 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/PDAnnotationCaret.java
 (original)
+++ 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/PDAnnotationCaret.java
 Fri Feb  2 09:08:02 2018
@@ -82,7 +82,7 @@ public class PDAnnotationCaret extends P
      * This will get the margin between the annotations "outer" rectangle 
defined by
      * /Rect and the boundaries of the underlying caret.
      * 
-     * @return the margins. If the entry hasn't been set defaults to 0 on all 
sides.
+     * @return the margins. If the entry hasn't been set am empty array is 
returned.
      */
     public float[] getMargins()
     {
@@ -91,7 +91,7 @@ public class PDAnnotationCaret extends P
         {
             return ((COSArray) margin).toFloatArray();
         }
-        return new float[]{0f, 0f, 0f, 0f};
+        return new float[]{};
     }
     
     /**

Modified: 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/PDAnnotationFreeText.java
URL: 
http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/PDAnnotationFreeText.java?rev=1822932&r1=1822931&r2=1822932&view=diff
==============================================================================
--- 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/PDAnnotationFreeText.java
 (original)
+++ 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/PDAnnotationFreeText.java
 Fri Feb  2 09:08:02 2018
@@ -153,7 +153,7 @@ public class PDAnnotationFreeText extend
      * This will get the margin between the annotations "outer" rectangle 
defined by
      * /Rect and the border.
      * 
-     * @return the margins. If the entry hasn't been set defaults to 0 on all 
sides.
+     * @return the margins. If the entry hasn't been set am empty array is 
returned.
      */
     public float[] getMargins()
     {
@@ -162,7 +162,7 @@ public class PDAnnotationFreeText extend
         {
             return ((COSArray) margin).toFloatArray();
         }
-        return new float[]{0f, 0f, 0f, 0f};
+        return new float[]{};
     }
     
     /**

Modified: 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/PDAnnotationSquareCircle.java
URL: 
http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/PDAnnotationSquareCircle.java?rev=1822932&r1=1822931&r2=1822932&view=diff
==============================================================================
--- 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/PDAnnotationSquareCircle.java
 (original)
+++ 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/PDAnnotationSquareCircle.java
 Fri Feb  2 09:08:02 2018
@@ -217,7 +217,7 @@ public abstract class PDAnnotationSquare
      * This will get the margin between the annotations "outer" rectangle 
defined by
      * /Rect and the border.
      * 
-     * @return the margins. If the entry hasn't been set defaults to 0 on all 
sides.
+     * @return the margins. If the entry hasn't been set am empty array is 
returned.
      */
     public float[] getMargins()
     {
@@ -226,7 +226,7 @@ public abstract class PDAnnotationSquare
         {
             return ((COSArray) margin).toFloatArray();
         }
-        return new float[]{0f, 0f, 0f, 0f};
+        return new float[]{};
     }
 
 }