[GitHub] [incubator-pinot] siddharthteotia edited a comment on issue #4527: Group by with order by

2019-08-15 Thread GitBox
siddharthteotia edited a comment on issue #4527: Group by with order by URL: https://github.com/apache/incubator-pinot/pull/4527#issuecomment-521686005 What do people think about implementing ORDER BY as a first class operator in Pinot -- that way different operators and query types will

[GitHub] [incubator-pinot] npawar commented on a change in pull request #4527: Group by with order by

2019-08-15 Thread GitBox
npawar commented on a change in pull request #4527: Group by with order by URL: https://github.com/apache/incubator-pinot/pull/4527#discussion_r314383656 ## File path: pinot-common/src/main/java/org/apache/pinot/common/response/broker/OrderedGroupByResults.java ## @@

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4527: Group by with order by

2019-08-15 Thread GitBox
kishoreg commented on a change in pull request #4527: Group by with order by URL: https://github.com/apache/incubator-pinot/pull/4527#discussion_r314147558 ## File path: pinot-common/src/main/java/org/apache/pinot/common/response/broker/OrderedGroupByResults.java ## @@

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4527: Group by with order by

2019-08-15 Thread GitBox
kishoreg commented on a change in pull request #4527: Group by with order by URL: https://github.com/apache/incubator-pinot/pull/4527#discussion_r314147427 ## File path: pinot-common/src/main/java/org/apache/pinot/common/response/broker/BrokerResponseNative.java ## @@

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4323: [Controller Separation] Add logic for lead controller resource

2019-08-15 Thread GitBox
codecov-io edited a comment on issue #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#issuecomment-502327426 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4323?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] siddharthteotia commented on issue #4527: Group by with order by

2019-08-15 Thread GitBox
siddharthteotia commented on issue #4527: Group by with order by URL: https://github.com/apache/incubator-pinot/pull/4527#issuecomment-521686005 What do people think about implementing ORDER BY as a first class operator in Pinot -- that way different operators and query types will not have

[GitHub] [incubator-pinot] sunithabeeram opened a new pull request #4532: Expose a method to determine if a QueryExceptionErrorCode represents a client-side error

2019-08-15 Thread GitBox
sunithabeeram opened a new pull request #4532: Expose a method to determine if a QueryExceptionErrorCode represents a client-side error URL: https://github.com/apache/incubator-pinot/pull/4532 Add a method in the QueryException class to determine if an error code represents a client-side

[GitHub] [incubator-pinot] npawar commented on a change in pull request #4527: Group by with order by

2019-08-15 Thread GitBox
npawar commented on a change in pull request #4527: Group by with order by URL: https://github.com/apache/incubator-pinot/pull/4527#discussion_r314382962 ## File path: pinot-common/src/main/java/org/apache/pinot/common/response/broker/BrokerResponseNative.java ## @@ -64,7

[GitHub] [incubator-pinot] snleee commented on a change in pull request #4516: [Instance Assignment] Plug in instance assignment

2019-08-15 Thread GitBox
snleee commented on a change in pull request #4516: [Instance Assignment] Plug in instance assignment URL: https://github.com/apache/incubator-pinot/pull/4516#discussion_r314441546 ## File path:

[incubator-pinot] branch add-logic-for-lead-controller-resource deleted (was 92ae1ab)

2019-08-15 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch add-logic-for-lead-controller-resource in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. was 92ae1ab Address PR comments The revisions that were on this branch are

[GitHub] [incubator-pinot] jackjlli merged pull request #4323: [Controller Separation] Add logic for lead controller resource

2019-08-15 Thread GitBox
jackjlli merged pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-pinot] sunithabeeram closed pull request #4356: Emit metrics to track performance against specific Service-Level-Objectives (SLO)

2019-08-15 Thread GitBox
sunithabeeram closed pull request #4356: Emit metrics to track performance against specific Service-Level-Objectives (SLO) URL: https://github.com/apache/incubator-pinot/pull/4356 This is an automated message from the

[GitHub] [incubator-pinot] sunithabeeram closed pull request #4380: Define SLO config for tables

2019-08-15 Thread GitBox
sunithabeeram closed pull request #4380: Define SLO config for tables URL: https://github.com/apache/incubator-pinot/pull/4380 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-pinot] sunithabeeram commented on issue #4356: Emit metrics to track performance against specific Service-Level-Objectives (SLO)

2019-08-15 Thread GitBox
sunithabeeram commented on issue #4356: Emit metrics to track performance against specific Service-Level-Objectives (SLO) URL: https://github.com/apache/incubator-pinot/pull/4356#issuecomment-521829273 Closing this as the logic has been moved to higher layers.

[GitHub] [incubator-pinot] sunithabeeram commented on issue #4380: Define SLO config for tables

2019-08-15 Thread GitBox
sunithabeeram commented on issue #4380: Define SLO config for tables URL: https://github.com/apache/incubator-pinot/pull/4380#issuecomment-521829184 Closing this as this has been moved to higher layers. This is an automated

[incubator-pinot] branch plug_in_instance_assignment deleted (was 18cba13)

2019-08-15 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch plug_in_instance_assignment in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. was 18cba13 [Instance Assignment] Plug in instance assignment The revisions that were on

[incubator-pinot] branch master updated: [Instance Assignment] Plug in instance assignment (#4516)

2019-08-15 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 4e41bc3 [Instance Assignment] Plug in

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #4516: [Instance Assignment] Plug in instance assignment

2019-08-15 Thread GitBox
Jackie-Jiang merged pull request #4516: [Instance Assignment] Plug in instance assignment URL: https://github.com/apache/incubator-pinot/pull/4516 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-pinot] haibow commented on issue #4225: Make Pinot schema evolution easier

2019-08-15 Thread GitBox
haibow commented on issue #4225: Make Pinot schema evolution easier URL: https://github.com/apache/incubator-pinot/issues/4225#issuecomment-521824275 Seems reload doesn't work well with REALTIME tables, and the table will end up having segments with inconsistent schemas. For

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4516: [Instance Assignment] Plug in instance assignment

2019-08-15 Thread GitBox
Jackie-Jiang commented on a change in pull request #4516: [Instance Assignment] Plug in instance assignment URL: https://github.com/apache/incubator-pinot/pull/4516#discussion_r314475279 ## File path:

[incubator-pinot] branch segment_assignment created (now 571e14a)

2019-08-15 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch segment_assignment in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 571e14a De-couple assignment strategy from SegmentAssignment This branch includes the

[incubator-pinot] 01/01: De-couple assignment strategy from SegmentAssignment

2019-08-15 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch segment_assignment in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 571e14a992947419c73b6088cfbc5a4095fa6c22 Author: Jackie (Xiaotian) Jiang AuthorDate: Thu Aug 15

[incubator-pinot] 01/01: [Instance Assignment] De-couple assignment strategy from SegmentAssignment

2019-08-15 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch segment_assignment in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit a9e32982ce460625e95100d241e5ddcad5cc2edf Author: Jackie (Xiaotian) Jiang AuthorDate: Thu Aug 15

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #4533: [Instance Assignment] De-couple assignment strategy from SegmentAssignment

2019-08-15 Thread GitBox
Jackie-Jiang opened a new pull request #4533: [Instance Assignment] De-couple assignment strategy from SegmentAssignment URL: https://github.com/apache/incubator-pinot/pull/4533 For REALTIME segments, we should be able to assign CONSUMING and COMPLETED segments with different

[incubator-pinot] branch segment_assignment updated (571e14a -> a9e3298)

2019-08-15 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch segment_assignment in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 571e14a De-couple assignment strategy from SegmentAssignment new a9e3298 [Instance

[incubator-pinot] branch segment_assignment updated (a9e3298 -> a20fa2a)

2019-08-15 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch segment_assignment in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard a9e3298 [Instance Assignment] De-couple assignment strategy from SegmentAssignment add

[GitHub] [incubator-pinot] codecov-io commented on issue #4533: [Instance Assignment] De-couple assignment strategy from SegmentAssignment

2019-08-15 Thread GitBox
codecov-io commented on issue #4533: [Instance Assignment] De-couple assignment strategy from SegmentAssignment URL: https://github.com/apache/incubator-pinot/pull/4533#issuecomment-521871617 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4533?src=pr=h1) Report >

[incubator-pinot] branch update_selection_query created (now 39c91cf)

2019-08-15 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch update_selection_query in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 39c91cf update column data type cast during inter merge This branch includes the

[incubator-pinot] 01/01: update column data type cast during inter merge

2019-08-15 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch update_selection_query in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 39c91cf7aa6f7bd3d305576474783779f8fc8363 Author: Xiang Fu AuthorDate: Thu Aug 15 22:19:08