[GitHub] [incubator-pinot] yupeng9 commented on issue #5843: Public API checker before release

2020-08-11 Thread GitBox
yupeng9 commented on issue #5843: URL: https://github.com/apache/incubator-pinot/issues/5843#issuecomment-672199407 > Related Issue #4854 +1 to adding it to the testing tool This is an automated message from the

[GitHub] [incubator-pinot] suvodeep-pyne commented on pull request #5808: [TE] Dashboard Resource Refactor

2020-08-11 Thread GitBox
suvodeep-pyne commented on pull request #5808: URL: https://github.com/apache/incubator-pinot/pull/5808#issuecomment-672266277 You are very welcome @akshayrai ! And thanks a lot for the approval. This is an automated message

[GitHub] [incubator-pinot] fx19880617 opened a new pull request #5846: Adding controller healthcheck endpoint: /health

2020-08-11 Thread GitBox
fx19880617 opened a new pull request #5846: URL: https://github.com/apache/incubator-pinot/pull/5846 ## Description Adding controller health check endpoint: /health to be on par with other pinot components. Existing check: `/pinot-controller/admin` is still available without any

[GitHub] [incubator-pinot] kishoreg merged pull request #5808: [TE] Dashboard Resource Refactor

2020-08-11 Thread GitBox
kishoreg merged pull request #5808: URL: https://github.com/apache/incubator-pinot/pull/5808 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-pinot] branch master updated (1c754f8 -> 47323de)

2020-08-11 Thread kishoreg
This is an automated email from the ASF dual-hosted git repository. kishoreg pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 1c754f8 Added set-diff operators and changed distinctCountThetaSketch syntax (#5832) add 47323de

[GitHub] [incubator-pinot] fx19880617 commented on issue #5802: Running Pinot with an invalid zookeeper service name seems to error during clean-up (in addition to connection error)

2020-08-11 Thread GitBox
fx19880617 commented on issue #5802: URL: https://github.com/apache/incubator-pinot/issues/5802#issuecomment-672277394 This will error out during start up as controller cannot connect to zookeeper for further processing. And you can safely ignore this helix cleanup as there is no

[incubator-pinot] 01/02: Adding /health endpoint in pinot controller

2020-08-11 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch adding-controller-healthcheck-endpoint in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 1820b5967764a4175290eed641c685460256c728 Author: Xiang Fu AuthorDate: Tue Aug

[incubator-pinot] 02/02: Adding controller health check endpoint

2020-08-11 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch adding-controller-healthcheck-endpoint in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit bd3e06f7fbd8ba56cd84bea8eacea89e7ea58c2b Author: Xiang Fu AuthorDate: Tue Aug

[incubator-pinot] branch adding-controller-healthcheck-endpoint created (now bd3e06f)

2020-08-11 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch adding-controller-healthcheck-endpoint in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at bd3e06f Adding controller health check endpoint This branch includes the

[GitHub] [incubator-pinot] kishoreg commented on pull request #5787: [Feature] - Spark Pinot Connector

2020-08-11 Thread GitBox
kishoreg commented on pull request #5787: URL: https://github.com/apache/incubator-pinot/pull/5787#issuecomment-672287954 @fx19880617 @mangrrua anything pending on this? This is an automated message from the Apache Git

[GitHub] [incubator-pinot] itzikiusa opened a new issue #5845: String date format - not working on data ingestion

2020-08-11 Thread GitBox
itzikiusa opened a new issue #5845: URL: https://github.com/apache/incubator-pinot/issues/5845 Hi, trying to ingest data with timestamp in a format of: '-MM-dd HH:mm:ss' scheme: ``` { "schemaName": "transcript", "dimensionFieldSpecs": [ { "name":

[GitHub] [incubator-pinot] jihaozh merged pull request #5769: [TE] add anomaly detection as a service - Phase 1

2020-08-11 Thread GitBox
jihaozh merged pull request #5769: URL: https://github.com/apache/incubator-pinot/pull/5769 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] KKcorps edited a comment on issue #5845: String date format - not working on data ingestion

2020-08-11 Thread GitBox
KKcorps edited a comment on issue #5845: URL: https://github.com/apache/incubator-pinot/issues/5845#issuecomment-672149764 For future reference, add the following to the job spec if your time column is in `String` format ```yaml segmentNameGeneratorSpec: type: normalizedDate

[GitHub] [incubator-pinot] KKcorps commented on issue #5845: String date format - not working on data ingestion

2020-08-11 Thread GitBox
KKcorps commented on issue #5845: URL: https://github.com/apache/incubator-pinot/issues/5845#issuecomment-672149764 For future reference, add the following to the job spec ```yaml segmentNameGeneratorSpec: type: normalizedDate ```

[GitHub] [incubator-pinot] jasonyanwenl commented on a change in pull request #5769: [TE] add anomaly detection as a service - Phase 1

2020-08-11 Thread GitBox
jasonyanwenl commented on a change in pull request #5769: URL: https://github.com/apache/incubator-pinot/pull/5769#discussion_r467200428 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/api/detection/AnomalyDetectionResource.java ## @@ -0,0 +1,756

[incubator-pinot] branch master updated (9551062 -> b268012)

2020-08-11 Thread jihao
This is an automated email from the ASF dual-hosted git repository. jihao pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 9551062 update Swagger (OpenAPI) configuration for HTTP+HTTPS (#5817) add b268012 [TE] add anomaly

[GitHub] [incubator-pinot] jasonyanwenl commented on pull request #5769: [TE] add anomaly detection as a service - Phase 1

2020-08-11 Thread GitBox
jasonyanwenl commented on pull request #5769: URL: https://github.com/apache/incubator-pinot/pull/5769#issuecomment-672181314 Thank you so much for the quick review. Really appreciate it! This is an automated message from

[GitHub] [incubator-pinot] kishoreg closed issue #5835: Problem when streaming data from S3 - 'Bucket' not found

2020-08-11 Thread GitBox
kishoreg closed issue #5835: URL: https://github.com/apache/incubator-pinot/issues/5835 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-pinot] itzikiusa commented on issue #5835: Problem when streaming data from S3 - 'Bucket' not found

2020-08-11 Thread GitBox
itzikiusa commented on issue #5835: URL: https://github.com/apache/incubator-pinot/issues/5835#issuecomment-672082911 fixed on merged version This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-pinot] mayankshriv merged pull request #5832: Added set-diff operators and changed distinctCountThetaSketch syntax

2020-08-11 Thread GitBox
mayankshriv merged pull request #5832: URL: https://github.com/apache/incubator-pinot/pull/5832 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-pinot] branch master updated (b268012 -> 1c754f8)

2020-08-11 Thread mayanks
This is an automated email from the ASF dual-hosted git repository. mayanks pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from b268012 [TE] add anomaly detection as a service - Phase 1 (#5769) add 1c754f8 Added set-diff

[GitHub] [incubator-pinot] fx19880617 commented on issue #5803: Controllers do not have a `/health` resource

2020-08-11 Thread GitBox
fx19880617 commented on issue #5803: URL: https://github.com/apache/incubator-pinot/issues/5803#issuecomment-672278520 Make sense, we will add `/health` to controller. Current health check for controller is using `/pinot-controller/admin`

[GitHub] [incubator-pinot] itzikiusa closed issue #5845: String date format - not working on data ingestion

2020-08-11 Thread GitBox
itzikiusa closed issue #5845: URL: https://github.com/apache/incubator-pinot/issues/5845 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-pinot] itzikiusa commented on issue #5845: String date format - not working on data ingestion

2020-08-11 Thread GitBox
itzikiusa commented on issue #5845: URL: https://github.com/apache/incubator-pinot/issues/5845#issuecomment-672147212 thanks @KKcorps can use the following config to solve the issue: ``` segmentNameGeneratorSpec: type: normalizedDate configs:

[GitHub] [incubator-pinot] suvodeep-pyne commented on pull request #5847: [TE] Added /application/reset API +refactor

2020-08-11 Thread GitBox
suvodeep-pyne commented on pull request #5847: URL: https://github.com/apache/incubator-pinot/pull/5847#issuecomment-672416913 Thanks a lot @akshayrai ! This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-pinot] npawar commented on pull request #5848: DataGenerator should tolerate DATE_TIME and COMPLEX fields

2020-08-11 Thread GitBox
npawar commented on pull request #5848: URL: https://github.com/apache/incubator-pinot/pull/5848#issuecomment-672446619 it should be fine to ignore the field for now. Eventually we want to handle it just like TIME case This

[GitHub] [incubator-pinot] apucher merged pull request #5848: DataGenerator should tolerate DATE_TIME and COMPLEX fields

2020-08-11 Thread GitBox
apucher merged pull request #5848: URL: https://github.com/apache/incubator-pinot/pull/5848 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-pinot] branch master updated: DataGenerator to tolerate DATE_TIME and COMPLEX fields (#5848)

2020-08-11 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new bb8b19e DataGenerator to tolerate

[GitHub] [incubator-pinot] apucher commented on pull request #5848: DataGenerator should tolerate DATE_TIME and COMPLEX fields

2020-08-11 Thread GitBox
apucher commented on pull request #5848: URL: https://github.com/apache/incubator-pinot/pull/5848#issuecomment-672447672 @Jackie-Jiang we already do when using the pattern data generator. the crappy old code is around for backwards compatibility only.

[GitHub] [incubator-pinot] apucher commented on pull request #5848: DataGenerator should tolerate DATE_TIME and COMPLEX fields

2020-08-11 Thread GitBox
apucher commented on pull request #5848: URL: https://github.com/apache/incubator-pinot/pull/5848#issuecomment-672448160 we may actually consider removing it. afaik there's no active use of it This is an automated message

[GitHub] [incubator-pinot] apucher opened a new pull request #5848: tolerate DATE_TIME and COMPLEX fields

2020-08-11 Thread GitBox
apucher opened a new pull request #5848: URL: https://github.com/apache/incubator-pinot/pull/5848 ## Description Fixes a forward compatibility issue with DATE_TIME fields in the data generator ## Upgrade Notes Does this PR prevent a zero down-time upgrade? **no**

[GitHub] [incubator-pinot] fx19880617 closed issue #5803: Controllers do not have a `/health` resource

2020-08-11 Thread GitBox
fx19880617 closed issue #5803: URL: https://github.com/apache/incubator-pinot/issues/5803 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-pinot] fx19880617 merged pull request #5846: Adding controller healthcheck endpoint: /health

2020-08-11 Thread GitBox
fx19880617 merged pull request #5846: URL: https://github.com/apache/incubator-pinot/pull/5846 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-pinot] branch master updated: Adding controller healthcheck endpoint: /health (#5846)

2020-08-11 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new db48107 Adding controller

[GitHub] [incubator-pinot] adriancole edited a comment on pull request #5818: Makes Pinot work on Alpine Linux or Distroless + BusyBox

2020-08-11 Thread GitBox
adriancole edited a comment on pull request #5818: URL: https://github.com/apache/incubator-pinot/pull/5818#issuecomment-670817753 fyi I'm currently inlining a script as when you consider docker knows the only image it will run on, the script doesn't need to do work like detect OS, JVM

[incubator-pinot] branch master updated (db48107 -> f4949e9)

2020-08-11 Thread akshayrai09
This is an automated email from the ASF dual-hosted git repository. akshayrai09 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from db48107 Adding controller healthcheck endpoint: /health (#5846) add f4949e9 [TE] Added reset

[GitHub] [incubator-pinot] akshayrai merged pull request #5847: [TE] Added /application/reset API +refactor

2020-08-11 Thread GitBox
akshayrai merged pull request #5847: URL: https://github.com/apache/incubator-pinot/pull/5847 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-pinot] branch data-generator-fix-20200811 created (now 502a9d3)

2020-08-11 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a change to branch data-generator-fix-20200811 in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 502a9d3 tolerate DATE_TIME and COMPLEX fields This branch includes the following

[incubator-pinot] 01/01: tolerate DATE_TIME and COMPLEX fields

2020-08-11 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a commit to branch data-generator-fix-20200811 in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 502a9d3a9d1fdbdf4dd39f19f54289d98f650499 Author: Alexander Pucher AuthorDate: Tue Aug 11

[GitHub] [incubator-pinot] fx19880617 commented on issue #5820: Query execution error when grouping by multi-value dimension and non-dictionary encoded dimension

2020-08-11 Thread GitBox
fx19880617 commented on issue #5820: URL: https://github.com/apache/incubator-pinot/issues/5820#issuecomment-672493742 Currently we are not supporting No-Dictionary multi-value column in groupby right now. The relative code path is in

[GitHub] [incubator-pinot] suvodeep-pyne opened a new pull request #5847: [TE] Added /application/reset API +refactor

2020-08-11 Thread GitBox
suvodeep-pyne opened a new pull request #5847: URL: https://github.com/apache/incubator-pinot/pull/5847 ## Description - Added /application/reset/{name}. Resets an application - Reset Usage: Primarily for demo purposes. It cleans up all old alerts and anomalies - Refactored

[GitHub] [incubator-pinot] adriancole commented on pull request #5818: Makes Pinot work on Alpine Linux or Distroless + BusyBox

2020-08-11 Thread GitBox
adriancole commented on pull request #5818: URL: https://github.com/apache/incubator-pinot/pull/5818#issuecomment-672397474 PS I had a bug in my comment https://github.com/apache/incubator-pinot/pull/5818#issuecomment-670817753 now is fixed. I didn't notice the fork about JRE 9+ needing

[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #5848: DataGenerator should tolerate DATE_TIME and COMPLEX fields

2020-08-11 Thread GitBox
Jackie-Jiang commented on pull request #5848: URL: https://github.com/apache/incubator-pinot/pull/5848#issuecomment-672440092 @npawar Please take a look and see whether we should support generating data for date time fields

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #5718: Feature/#5390 segment indexing reload status api

2020-08-11 Thread GitBox
kishoreg commented on a change in pull request #5718: URL: https://github.com/apache/incubator-pinot/pull/5718#discussion_r469006145 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java ## @@ -485,4 +503,80 @@

[GitHub] [incubator-pinot] adriancole opened a new issue #5850: Docker HEALTHCHECK guidance

2020-08-11 Thread GitBox
adriancole opened a new issue #5850: URL: https://github.com/apache/incubator-pinot/issues/5850 There is awesome flexibility we allow with anything from all-in-one until distributed deployment. I love it. This presents a healthcheck challenge as certain ordering constraints remain

[GitHub] [incubator-pinot] mangrrua commented on pull request #5787: [Feature] - Spark Pinot Connector

2020-08-11 Thread GitBox
mangrrua commented on pull request #5787: URL: https://github.com/apache/incubator-pinot/pull/5787#issuecomment-672613922 > @fx19880617 @mangrrua anything pending on this? Seems no This is an automated message from

[GitHub] [incubator-pinot] mangrrua edited a comment on pull request #5787: [Feature] - Spark Pinot Connector

2020-08-11 Thread GitBox
mangrrua edited a comment on pull request #5787: URL: https://github.com/apache/incubator-pinot/pull/5787#issuecomment-672613922 > @fx19880617 @mangrrua anything pending on this? Seems no @kishoreg This is an

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #5849: [Post-aggregation] Support type conversion for all scalar functions

2020-08-11 Thread GitBox
Jackie-Jiang opened a new pull request #5849: URL: https://github.com/apache/incubator-pinot/pull/5849 ## Description Support type conversion for all scalar functions. Parameter classes supported for type conversion using `PinotDataType`: - int/Integer - long/Long -

[GitHub] [incubator-pinot] mangrrua commented on a change in pull request #5787: [Feature] - Spark Pinot Connector

2020-08-11 Thread GitBox
mangrrua commented on a change in pull request #5787: URL: https://github.com/apache/incubator-pinot/pull/5787#discussion_r468554247 ## File path: pinot-connectors/pinot-spark-connector/src/main/scala/org/apache/pinot/connector/spark/connector/PinotServerDataFetcher.scala ##

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #5738: HAVING and Post-Aggregation Support

2020-08-11 Thread GitBox
Jackie-Jiang commented on issue #5738: URL: https://github.com/apache/incubator-pinot/issues/5738#issuecomment-672571284 Scalar function type conversion support: #5849 This is an automated message from the Apache Git

[GitHub] [incubator-pinot] fx19880617 merged pull request #5844: Move quickstart tests to use Java 14 release

2020-08-11 Thread GitBox
fx19880617 merged pull request #5844: URL: https://github.com/apache/incubator-pinot/pull/5844 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-pinot] branch master updated (3785aa7 -> c04b8b3)

2020-08-11 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 3785aa7 Improving retention manager to handle segment lineage clean-up (#5828) add c04b8b3 Move

svn commit: r40941 - /release/incubator/pinot/KEYS

2020-08-11 Thread tingchen
Author: tingchen Date: Tue Aug 11 07:08:15 2020 New Revision: 40941 Log: Update Pinot KEYS file for 1AAD3FDA Modified: release/incubator/pinot/KEYS Modified: release/incubator/pinot/KEYS == ---

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #5836: Fix data ingestion from Amazon S3 bucket

2020-08-11 Thread GitBox
KKcorps commented on a change in pull request #5836: URL: https://github.com/apache/incubator-pinot/pull/5836#discussion_r468406304 ## File path: pinot-plugins/pinot-file-system/pinot-s3/src/test/java/org/apache/pinot/plugin/filesystem/S3PinotFSTest.java ## @@ -28,12 +28,16

[GitHub] [incubator-pinot] fx19880617 commented on issue #5704: Support toWeek/toMonth/toYear in datetimeConvertUdf

2020-08-11 Thread GitBox
fx19880617 commented on issue #5704: URL: https://github.com/apache/incubator-pinot/issues/5704#issuecomment-671852467 We may also want to support this as granular in `datetimeConvertUdf`, so that we can take the pushdown from presto side for function:

[GitHub] [incubator-pinot] fx19880617 merged pull request #5836: Fix data ingestion from Amazon S3 bucket

2020-08-11 Thread GitBox
fx19880617 merged pull request #5836: URL: https://github.com/apache/incubator-pinot/pull/5836 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-pinot] branch master updated (c04b8b3 -> d8264c1)

2020-08-11 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from c04b8b3 Move quickstart tests to use Java 14 release (#5844) add d8264c1 Fix data ingestion from

[GitHub] [incubator-pinot] kishoreg merged pull request #5817: update Swagger (OpenAPI) configuration for HTTP+HTTPS

2020-08-11 Thread GitBox
kishoreg merged pull request #5817: URL: https://github.com/apache/incubator-pinot/pull/5817 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] kishoreg closed issue #5814: Pinot's swagger pages does not work on HTTPS-only environments

2020-08-11 Thread GitBox
kishoreg closed issue #5814: URL: https://github.com/apache/incubator-pinot/issues/5814 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-pinot] mcvsubbu commented on issue #4854: Compatibility regression testing tool

2020-08-11 Thread GitBox
mcvsubbu commented on issue #4854: URL: https://github.com/apache/incubator-pinot/issues/4854#issuecomment-672053230 Related issue #5843 This is an automated message from the Apache Git Service. To respond to the message,

[incubator-pinot] branch master updated (d8264c1 -> 9551062)

2020-08-11 Thread kishoreg
This is an automated email from the ASF dual-hosted git repository. kishoreg pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from d8264c1 Fix data ingestion from Amazon S3 bucket (#5836) add 9551062 update Swagger (OpenAPI)

[GitHub] [incubator-pinot] mcvsubbu commented on issue #5843: Public API checker before release

2020-08-11 Thread GitBox
mcvsubbu commented on issue #5843: URL: https://github.com/apache/incubator-pinot/issues/5843#issuecomment-672053619 Related Issue #4854 This is an automated message from the Apache Git Service. To respond to the message,