[GitHub] [incubator-pinot] icefury71 commented on a change in pull request #5966: Validate timeColumnName when adding/updating schema/tableConfig

2020-09-09 Thread GitBox
icefury71 commented on a change in pull request #5966: URL: https://github.com/apache/incubator-pinot/pull/5966#discussion_r485796322 ## File path: pinot-core/src/main/java/org/apache/pinot/core/util/TableConfigUtils.java ## @@ -74,19 +80,37 @@ public static void

[GitHub] [incubator-pinot] icefury71 commented on a change in pull request #5966: Validate timeColumnName when adding/updating schema/tableConfig

2020-09-09 Thread GitBox
icefury71 commented on a change in pull request #5966: URL: https://github.com/apache/incubator-pinot/pull/5966#discussion_r485792320 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSchemaRestletResource.java ## @@ -171,7 +173,8 @@

[incubator-pinot] branch master updated: Adding a null check inside getDataSource method for potentially invalid column name (#5923)

2020-09-09 Thread kishoreg
This is an automated email from the ASF dual-hosted git repository. kishoreg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new cd86f60 Adding a null check inside

[GitHub] [incubator-pinot] kishoreg merged pull request #5923: Null check for invalid column name

2020-09-09 Thread GitBox
kishoreg merged pull request #5923: URL: https://github.com/apache/incubator-pinot/pull/5923 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] snleee commented on pull request #5994: Add null check while fetching the schema

2020-09-09 Thread GitBox
snleee commented on pull request #5994: URL: https://github.com/apache/incubator-pinot/pull/5994#issuecomment-689799046 Exception example: ``` 2020/09/09 19:07:04.121 ERROR [ZKMetadataProvider] [grizzly-http-server-28] [pinot-controller] [] Caught exception while getting schema:

[GitHub] [incubator-pinot] jihaozh merged pull request #5962: [TE] Severity based alerter

2020-09-09 Thread GitBox
jihaozh merged pull request #5962: URL: https://github.com/apache/incubator-pinot/pull/5962 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] snleee commented on a change in pull request #5994: Add null check while fetching the schema

2020-09-09 Thread GitBox
snleee commented on a change in pull request #5994: URL: https://github.com/apache/incubator-pinot/pull/5994#discussion_r485901738 ## File path: pinot-common/src/main/java/org/apache/pinot/common/metadata/ZKMetadataProvider.java ## @@ -274,14 +274,20 @@ public static Schema

svn commit: r41392 - /dev/incubator/pinot/apache-pinot-incubating-0.5.0-rc2/ /release/incubator/pinot/apache-pinot-incubating-0.5.0/

2020-09-09 Thread tingchen
Author: tingchen Date: Wed Sep 9 19:05:58 2020 New Revision: 41392 Log: Move apache-pinot-incubating-0.5.0-rc2 to the official release. Added: release/incubator/pinot/apache-pinot-incubating-0.5.0/ - copied from r41391, dev/incubator/pinot/apache-pinot-incubating-0.5.0-rc2/ Removed:

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5987: upgrade to java 11

2020-09-09 Thread GitBox
fx19880617 commented on a change in pull request #5987: URL: https://github.com/apache/incubator-pinot/pull/5987#discussion_r485901003 ## File path: docker/images/pinot/Dockerfile ## @@ -17,7 +17,7 @@ # under the License. # -FROM openjdk:8 AS pinot_build_env Review

[GitHub] [incubator-pinot] jackjlli opened a new pull request #5995: Add ingestion descriptor in the header

2020-09-09 Thread GitBox
jackjlli opened a new pull request #5995: URL: https://github.com/apache/incubator-pinot/pull/5995 ## Description This PR adds ingestion descriptor in the header. This will be used to put the ingestion information from the flow, so that when there is something wrong with the data push,

[incubator-pinot] branch master updated (d062cfd -> 3a47121)

2020-09-09 Thread jihao
This is an automated email from the ASF dual-hosted git repository. jihao pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from d062cfd Add InIdSetTransformFunction (#5973) add 3a47121 [TE] Severity based alerter (#5962) No new

[GitHub] [incubator-pinot] snleee opened a new pull request #5994: Add null check while fetching the schema

2020-09-09 Thread GitBox
snleee opened a new pull request #5994: URL: https://github.com/apache/incubator-pinot/pull/5994 When call ZKMetadataProvider:getSchema(), input parameter schemaName is declared as `Nonnull`; however, it's possible that we pass null value. This pr adds the null check to avoid the such

[GitHub] [incubator-pinot] mcvsubbu opened a new pull request #5992: Fix CSV reader class path

2020-09-09 Thread GitBox
mcvsubbu opened a new pull request #5992: URL: https://github.com/apache/incubator-pinot/pull/5992 Fixed the classpath of CSV reader in the code. Introduced comment marker so that we can have comments in the csv file as well ## Description Add a description of your PR here.

[GitHub] [incubator-pinot] mr-agrwal opened a new issue #5993: API to Reload/Reset all ERROR segments

2020-09-09 Thread GitBox
mr-agrwal opened a new issue #5993: URL: https://github.com/apache/incubator-pinot/issues/5993 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #5984: Add row based schema validation code to detect schema mismatch

2020-09-09 Thread GitBox
Jackie-Jiang commented on pull request #5984: URL: https://github.com/apache/incubator-pinot/pull/5984#issuecomment-689836238 > Most of the cases can be covered by validating pinot schema and avro schema. One tricky thing is that when all the fields are required to be fetched, we convert

[GitHub] [incubator-pinot] snleee merged pull request #5994: Add null check while fetching the schema

2020-09-09 Thread GitBox
snleee merged pull request #5994: URL: https://github.com/apache/incubator-pinot/pull/5994 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] suvodeep-pyne opened a new pull request #5991: [TE] Moved interfaces and datalayer to a new thirdeye-spi module.

2020-09-09 Thread GitBox
suvodeep-pyne opened a new pull request #5991: URL: https://github.com/apache/incubator-pinot/pull/5991 [TE] Moved interfaces and datalayer to a new thirdeye-spi module. The spi module is intended to be the parent module for all downstream thirdeye consumers. Changes in Phase 1:

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5994: Add null check while fetching the schema

2020-09-09 Thread GitBox
fx19880617 commented on a change in pull request #5994: URL: https://github.com/apache/incubator-pinot/pull/5994#discussion_r485899781 ## File path: pinot-common/src/main/java/org/apache/pinot/common/metadata/ZKMetadataProvider.java ## @@ -274,14 +274,20 @@ public static

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5994: Add null check while fetching the schema

2020-09-09 Thread GitBox
fx19880617 commented on a change in pull request #5994: URL: https://github.com/apache/incubator-pinot/pull/5994#discussion_r485899681 ## File path: pinot-common/src/main/java/org/apache/pinot/common/metadata/ZKMetadataProvider.java ## @@ -274,14 +274,20 @@ public static

[incubator-pinot] branch master updated: Add null check while fetching the schema (#5994)

2020-09-09 Thread snlee
This is an automated email from the ASF dual-hosted git repository. snlee pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new bfced82 Add null check while fetching

[incubator-pinot] 01/01: Add ingestion descriptor in the header

2020-09-09 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch add-ingestion-descriptor in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 469e7b8e07f646cea5399f1c0c8012d9edebb8d6 Author: Jack Li(Analytics Engineering) AuthorDate:

[incubator-pinot] branch add-ingestion-descriptor created (now 469e7b8)

2020-09-09 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch add-ingestion-descriptor in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 469e7b8 Add ingestion descriptor in the header This branch includes the following new

[GitHub] [incubator-pinot] snleee commented on a change in pull request #5934: Segment processing framework

2020-09-09 Thread GitBox
snleee commented on a change in pull request #5934: URL: https://github.com/apache/incubator-pinot/pull/5934#discussion_r485969046 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/processing/collector/RollupCollector.java ## @@ -0,0 +1,159 @@ +/** + *

[incubator-pinot] annotated tag release-0.5.0 updated (d87bbc9 -> 6f032f7)

2020-09-09 Thread tingchen
This is an automated email from the ASF dual-hosted git repository. tingchen pushed a change to annotated tag release-0.5.0 in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. *** WARNING: tag release-0.5.0 was modified! *** from d87bbc9 (commit) to 6f032f7 (tag)

[GitHub] [incubator-pinot] chenboat opened a new pull request #5996: Update links for release 0.5.0 in the website

2020-09-09 Thread GitBox
chenboat opened a new pull request #5996: URL: https://github.com/apache/incubator-pinot/pull/5996 ## Description Add a description of your PR here. A good description should include pointers to an issue or design document, etc. ## Upgrade Notes Does this PR prevent a zero

[incubator-pinot] branch master updated: Fix CSV reader class path (#5992)

2020-09-09 Thread mcvsubbu
This is an automated email from the ASF dual-hosted git repository. mcvsubbu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new feeba9e Fix CSV reader class path

[GitHub] [incubator-pinot] mcvsubbu merged pull request #5992: Fix CSV reader class path

2020-09-09 Thread GitBox
mcvsubbu merged pull request #5992: URL: https://github.com/apache/incubator-pinot/pull/5992 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] snleee commented on a change in pull request #5934: Segment processing framework

2020-09-09 Thread GitBox
snleee commented on a change in pull request #5934: URL: https://github.com/apache/incubator-pinot/pull/5934#discussion_r485965064 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/processing/collector/Collector.java ## @@ -0,0 +1,55 @@ +/** + * Licensed to

[GitHub] [incubator-pinot] snleee commented on a change in pull request #5934: Segment processing framework

2020-09-09 Thread GitBox
snleee commented on a change in pull request #5934: URL: https://github.com/apache/incubator-pinot/pull/5934#discussion_r486009106 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/processing/framework/SegmentProcessorConfig.java ## @@ -0,0 +1,181 @@ +/** +