[GitHub] [incubator-pinot] fx19880617 commented on issue #6003: Review PinotFS ListFile Implementations

2020-09-11 Thread GitBox
fx19880617 commented on issue #6003: URL: https://github.com/apache/incubator-pinot/issues/6003#issuecomment-690927594 @elonazoulay could you help check if GcsPinotFs is good when the bucket has many objects? This is an

[GitHub] [incubator-pinot] fx19880617 opened a new pull request #6002: Fixing S3PinotFS List API returned partial results

2020-09-11 Thread GitBox
fx19880617 opened a new pull request #6002: URL: https://github.com/apache/incubator-pinot/pull/6002 ## Description S3 API has a bounded limit(1000) for the objects returned in ListObject API, which means each call may at most returned 1000 S3 objects. This PR will check

[incubator-pinot] branch master updated: Fix S3PinotFS List API may not return full results (#6002)

2020-09-11 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 11fd62b Fix S3PinotFS List API may

[GitHub] [incubator-pinot] fx19880617 merged pull request #6002: Fixing S3PinotFS List API returned partial results

2020-09-11 Thread GitBox
fx19880617 merged pull request #6002: URL: https://github.com/apache/incubator-pinot/pull/6002 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-pinot] branch fixing_s3_list_api created (now 8665918)

2020-09-11 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch fixing_s3_list_api in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 8665918 Fix S3PinotFS List API may not return full results This branch includes the

[incubator-pinot] 01/01: Fix S3PinotFS List API may not return full results

2020-09-11 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch fixing_s3_list_api in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 86659186e8e2196b199a5c2bb011dd560a5a524f Author: Xiang Fu AuthorDate: Thu Sep 10 23:38:37 2020

[incubator-pinot] branch fixing_s3_list_api updated (8665918 -> 0226925)

2020-09-11 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch fixing_s3_list_api in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 8665918 Fix S3PinotFS List API may not return full results add 0226925 Fix S3PinotFS

[GitHub] [incubator-pinot] fx19880617 commented on issue #6003: Review PinotFS ListFile Implementations

2020-09-11 Thread GitBox
fx19880617 commented on issue #6003: URL: https://github.com/apache/incubator-pinot/issues/6003#issuecomment-690920467 @snleee @elonazoulay This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-pinot] fx19880617 removed a comment on issue #6003: Review PinotFS ListFile Implementations

2020-09-11 Thread GitBox
fx19880617 removed a comment on issue #6003: URL: https://github.com/apache/incubator-pinot/issues/6003#issuecomment-690920467 @snleee @elonazoulay This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-pinot] fx19880617 commented on issue #6003: Review PinotFS ListFile Implementations

2020-09-11 Thread GitBox
fx19880617 commented on issue #6003: URL: https://github.com/apache/incubator-pinot/issues/6003#issuecomment-690926043 @snleee seems that ADLSGen2 also has the problem of truncation: https://docs.microsoft.com/en-us/rest/api/storageservices/datalakestoragegen2/filesystem/list

[GitHub] [incubator-pinot] fx19880617 commented on issue #6003: Review PinotFS ListFile Implementations

2020-09-11 Thread GitBox
fx19880617 commented on issue #6003: URL: https://github.com/apache/incubator-pinot/issues/6003#issuecomment-690914135 S3PinotFs is fixed in #6002 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-pinot] fx19880617 opened a new issue #6003: Review PinotFS ListFile Implementations

2020-09-11 Thread GitBox
fx19880617 opened a new issue #6003: URL: https://github.com/apache/incubator-pinot/issues/6003 Per https://github.com/apache/incubator-pinot/pull/6002, S3 has a limit on each ListObject call response. I think this policy may also be true for other blob store. This issue is created

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #6002: Fixing S3PinotFS List API returned partial results

2020-09-11 Thread GitBox
kishoreg commented on a change in pull request #6002: URL: https://github.com/apache/incubator-pinot/pull/6002#discussion_r486810483 ## File path: pinot-plugins/pinot-file-system/pinot-s3/src/main/java/org/apache/pinot/plugin/filesystem/S3PinotFS.java ## @@ -374,33 +375,39 @@

[GitHub] [incubator-pinot] fx19880617 commented on pull request #6002: Fixing S3PinotFS List API returned partial results

2020-09-11 Thread GitBox
fx19880617 commented on pull request #6002: URL: https://github.com/apache/incubator-pinot/pull/6002#issuecomment-690912063 We should also review other PinotFs implementations to ensure the similar issues are not presenting there.

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #6002: Fixing S3PinotFS List API returned partial results

2020-09-11 Thread GitBox
fx19880617 commented on a change in pull request #6002: URL: https://github.com/apache/incubator-pinot/pull/6002#discussion_r486817834 ## File path: pinot-plugins/pinot-file-system/pinot-s3/src/main/java/org/apache/pinot/plugin/filesystem/S3PinotFS.java ## @@ -374,33 +375,39

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #6004: Add ThetaSketchAggregationFunction

2020-09-11 Thread GitBox
Jackie-Jiang opened a new pull request #6004: URL: https://github.com/apache/incubator-pinot/pull/6004 ## Description Introduce `ThetaSketchAggregationFunction` as an enhanced version of `DistinctCountThetaSketchAggregationFunction`, and add the following supports: - Support

[incubator-pinot] branch fixing_s3_list_api updated (8665918 -> 0226925)

2020-09-11 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch fixing_s3_list_api in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 8665918 Fix S3PinotFS List API may not return full results add 0226925 Fix S3PinotFS

[incubator-pinot] branch fixing_s3_list_api updated (8665918 -> 0226925)

2020-09-11 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch fixing_s3_list_api in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 8665918 Fix S3PinotFS List API may not return full results add 0226925 Fix S3PinotFS

[GitHub] [incubator-pinot] ChethanUK opened a new pull request #6006: Fix/data view dev serve

2020-09-11 Thread GitBox
ChethanUK opened a new pull request #6006: URL: https://github.com/apache/incubator-pinot/pull/6006 Fixing a few data view and other errors which were failing the build Updating the packages and adding dev serve test mode ```bash yarn run serve --build --port 3001 --host

[GitHub] [incubator-pinot] vincentchenjl opened a new pull request #6007: [TE] add labeler into yaml

2020-09-11 Thread GitBox
vincentchenjl opened a new pull request #6007: URL: https://github.com/apache/incubator-pinot/pull/6007 This PR is second PR for severity-based alert feature, including the logic of parsing labeler configuration and constructing the detection pipelines based on the YAML.

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #6001: [TE] entity anomaly logging for ad-hoc debugging

2020-09-11 Thread GitBox
jihaozh commented on a change in pull request #6001: URL: https://github.com/apache/incubator-pinot/pull/6001#discussion_r487263049 ## File path: thirdeye/thirdeye-pinot/src/test/java/org/apache/pinot/thirdeye/tools/RunAdhocDatabaseQueriesTool.java ## @@ -723,9 +741,65 @@

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #6008: Add a length limit of 512 to the properties stored in the segment metadata

2020-09-11 Thread GitBox
Jackie-Jiang opened a new pull request #6008: URL: https://github.com/apache/incubator-pinot/pull/6008 ## Description Prevent storing very long values into the segment metadata. This could happen when Pinot is used as a blob store (not recommended but supported).

[GitHub] [incubator-pinot] fx19880617 merged pull request #6006: Fix/data view dev serve

2020-09-11 Thread GitBox
fx19880617 merged pull request #6006: URL: https://github.com/apache/incubator-pinot/pull/6006 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-pinot] branch master updated (11fd62b -> 13a281c)

2020-09-11 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 11fd62b Fix S3PinotFS List API may not return full results (#6002) add 13a281c Fix/data view dev

[GitHub] [incubator-pinot] ChethanUK commented on pull request #6006: Fix/data view dev serve

2020-09-11 Thread GitBox
ChethanUK commented on pull request #6006: URL: https://github.com/apache/incubator-pinot/pull/6006#issuecomment-691278842 ✅ Preview available at https://incubator-pinot-git-fix-web-data-error.chethanuk.vercel.app This is

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6008: Add a length limit of 512 to the properties stored in the segment metadata

2020-09-11 Thread GitBox
codecov-commenter commented on pull request #6008: URL: https://github.com/apache/incubator-pinot/pull/6008#issuecomment-691309424 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6008?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] yupeng9 commented on a change in pull request #6008: Add a length limit of 512 to the properties stored in the segment metadata

2020-09-11 Thread GitBox
yupeng9 commented on a change in pull request #6008: URL: https://github.com/apache/incubator-pinot/pull/6008#discussion_r487290286 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/SegmentColumnarIndexCreator.java ## @@ -78,6 +78,9 @@ public

[GitHub] [incubator-pinot] jackjlli commented on pull request #6005: Fix extract method in AvroRecordExtractor class

2020-09-11 Thread GitBox
jackjlli commented on pull request #6005: URL: https://github.com/apache/incubator-pinot/pull/6005#issuecomment-691313748 > Could you add a test such that it fails with the original code, and passes with the old code? Test added.

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6005: Fix extract method in AvroRecordExtractor class

2020-09-11 Thread GitBox
Jackie-Jiang commented on a change in pull request #6005: URL: https://github.com/apache/incubator-pinot/pull/6005#discussion_r487213705 ## File path: pinot-plugins/pinot-input-format/pinot-avro-base/src/main/java/org/apache/pinot/plugin/inputformat/avro/AvroRecordExtractor.java

[incubator-pinot] 01/01: Fix extract method in AvroRecordExtractor

2020-09-11 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch fix-AvroRecordExtractor in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit fd1cb00a4f8d0f475e114add27b81d11ef651372 Author: Jack Li(Analytics Engineering) AuthorDate: Fri

[incubator-pinot] branch fix-AvroRecordExtractor created (now fd1cb00)

2020-09-11 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch fix-AvroRecordExtractor in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at fd1cb00 Fix extract method in AvroRecordExtractor This branch includes the following new

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6005: Fix extract method in AvroRecordExtractor class

2020-09-11 Thread GitBox
jackjlli commented on a change in pull request #6005: URL: https://github.com/apache/incubator-pinot/pull/6005#discussion_r487224829 ## File path: pinot-plugins/pinot-input-format/pinot-avro-base/src/main/java/org/apache/pinot/plugin/inputformat/avro/AvroRecordExtractor.java

[incubator-pinot] 01/01: Fix extract method in AvroRecordExtractor

2020-09-11 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch fix-AvroRecordExtractor in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit bfb59545cdd13e94f34c882be579afd917fbdd80 Author: Jack Li(Analytics Engineering) AuthorDate: Fri

[incubator-pinot] branch fix-AvroRecordExtractor updated (f4add59 -> bfb5954)

2020-09-11 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch fix-AvroRecordExtractor in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard f4add59 Fix extract method in AvroRecordExtractor new bfb5954 Fix extract method in

[incubator-pinot] branch fix-AvroRecordExtractor updated (fd1cb00 -> f4add59)

2020-09-11 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch fix-AvroRecordExtractor in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard fd1cb00 Fix extract method in AvroRecordExtractor new f4add59 Fix extract method in

[incubator-pinot] 01/01: Fix extract method in AvroRecordExtractor

2020-09-11 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch fix-AvroRecordExtractor in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit f4add59f9518b37c638d90457a92e18f81108545 Author: Jack Li(Analytics Engineering) AuthorDate: Fri

[GitHub] [incubator-pinot] jackjlli opened a new pull request #6005: Fix extract method in AvroRecordExtractor class

2020-09-11 Thread GitBox
jackjlli opened a new pull request #6005: URL: https://github.com/apache/incubator-pinot/pull/6005 ## Description This PR fixes the extract method in AvroRecordExtractor class. When `_extractAll` is true, the generic record will be first converted to a json String and then parse

[incubator-pinot] branch fix-AvroRecordExtractor updated (bfb5954 -> c19fb22)

2020-09-11 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch fix-AvroRecordExtractor in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from bfb5954 Fix extract method in AvroRecordExtractor add c19fb22 Address PR comments No

[GitHub] [incubator-pinot] jackjlli commented on pull request #6009: Adjust schema validation logic in AvroIngestionSchemaValidator

2020-09-11 Thread GitBox
jackjlli commented on pull request #6009: URL: https://github.com/apache/incubator-pinot/pull/6009#issuecomment-691397062 > Can you reduce the size of the testing files (both `test_sample_data_multi_value.avro` and `test_sample_data.avro` previously checked in)? All we need from the file

[incubator-pinot] branch fix-schema-validator updated (6d22faa -> f09ca9a)

2020-09-11 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch fix-schema-validator in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 6d22faa Adjust schema validation logic in AvroIngestionSchemaValidator add f09ca9a

[incubator-pinot] 01/01: Update pinot helm to adding custom configs and update the jvm default configs

2020-09-11 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch update_pinot_helm_for_custom_config_file in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit c3d3d20b59f5af7e190afdbaa32a8ff121bd4c26 Author: Xiang Fu AuthorDate: Fri

[incubator-pinot] branch update_pinot_helm_for_custom_config_file created (now c3d3d20)

2020-09-11 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch update_pinot_helm_for_custom_config_file in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at c3d3d20 Update pinot helm to adding custom configs and update the jvm

[GitHub] [incubator-pinot] fx19880617 opened a new pull request #6011: Update pinot helm to adding custom configs

2020-09-11 Thread GitBox
fx19880617 opened a new pull request #6011: URL: https://github.com/apache/incubator-pinot/pull/6011 ## Description This change: 1. Allows users to add more configs into pinot config files just through `values.yaml` file. 2. Add GC related settings into default JVM configs for

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #6010: [Clean up] Separate TextIndex from InvertedIndex

2020-09-11 Thread GitBox
Jackie-Jiang opened a new pull request #6010: URL: https://github.com/apache/incubator-pinot/pull/6010 ## Description Introduce `TextIndexCreator` and `TextIndexReader` for text index This is an automated message from the

[GitHub] [incubator-pinot] yupeng9 commented on a change in pull request #6008: Add a length limit of 512 to the properties stored in the segment metadata

2020-09-11 Thread GitBox
yupeng9 commented on a change in pull request #6008: URL: https://github.com/apache/incubator-pinot/pull/6008#discussion_r487354466 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/SegmentColumnarIndexCreator.java ## @@ -78,6 +78,9 @@ public

[GitHub] [incubator-pinot] jackjlli opened a new pull request #6009: Adjust schema validation logic in AvroIngestionSchemaValidator

2020-09-11 Thread GitBox
jackjlli opened a new pull request #6009: URL: https://github.com/apache/incubator-pinot/pull/6009 ## Description This PR adjusts schema validation logic in AvroIngestionSchemaValidator. The current logic doesn't check the actual data type for multi-value column, which could have

[incubator-pinot] 01/01: Adjust schema validation logic in AvroIngestionSchemaValidator

2020-09-11 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch fix-schema-validator in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 6d22faa9fd916217b764ddebd8cacac54ea4a6db Author: Jack Li(Analytics Engineering) AuthorDate: Fri

[incubator-pinot] branch fix-schema-validator created (now 6d22faa)

2020-09-11 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch fix-schema-validator in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 6d22faa Adjust schema validation logic in AvroIngestionSchemaValidator This branch includes

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6008: Add a length limit of 512 to the properties stored in the segment metadata

2020-09-11 Thread GitBox
Jackie-Jiang commented on a change in pull request #6008: URL: https://github.com/apache/incubator-pinot/pull/6008#discussion_r487331483 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/SegmentColumnarIndexCreator.java ## @@ -78,6 +78,9 @@