codecov-io edited a comment on pull request #6120:
URL: https://github.com/apache/incubator-pinot/pull/6120#issuecomment-705891235
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6120?src=pr=h1)
Report
> Merging
codecov-io edited a comment on pull request #6120:
URL: https://github.com/apache/incubator-pinot/pull/6120#issuecomment-705891235
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6120?src=pr=h1)
Report
> Merging
yupeng9 commented on issue #5509:
URL:
https://github.com/apache/incubator-pinot/issues/5509#issuecomment-708860324
+1 to derived over derived. It's useful for defining common expressions.
Also, from impl it's just a topology sort
npawar commented on issue #5509:
URL:
https://github.com/apache/incubator-pinot/issues/5509#issuecomment-708710753
FYI @kishoreg @Jackie-Jiang
This is an automated message from the Apache Git Service.
To respond to the
codecov-io edited a comment on pull request #6136:
URL: https://github.com/apache/incubator-pinot/pull/6136#issuecomment-707985309
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6136?src=pr=h1)
Report
> Merging
yupeng9 commented on issue #5509:
URL:
https://github.com/apache/incubator-pinot/issues/5509#issuecomment-708861168
> Should the flag "derived" be part of the FieldSpec, or part of the
TableConfig -> IngestionConfig -> TransformConfig?
>
> It makes more sense in the fieldSpec. But
npawar commented on a change in pull request #6113:
URL: https://github.com/apache/incubator-pinot/pull/6113#discussion_r504983362
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
##
@@ -378,7 +463,12 @@ public
npawar commented on issue #5509:
URL:
https://github.com/apache/incubator-pinot/issues/5509#issuecomment-708715214
I think we should support derived on top of derived.
This is an automated message from the Apache Git
npawar commented on issue #5509:
URL:
https://github.com/apache/incubator-pinot/issues/5509#issuecomment-708719006
Should the flag "derived" be part of the FieldSpec, or part of the
TableConfig -> IngestionConfig -> TransformConfig?
It makes more sense in the fieldSpec. But we end up
Jackie-Jiang opened a new pull request #6147:
URL: https://github.com/apache/incubator-pinot/pull/6147
## Description
Add the on-heap version of the guava bloom filter reader
Add 2 new fields into the `BloomFilterConfig`:
- maxSizeInBytes: if configured, limit the max size of the
Jackie-Jiang commented on issue #5509:
URL:
https://github.com/apache/incubator-pinot/issues/5509#issuecomment-708713833
Do we want to support derived field on top of derived field?
E.g. we have x in the source data, and we want to add y = f(x) and z = f(y)
codecov-io edited a comment on pull request #6120:
URL: https://github.com/apache/incubator-pinot/pull/6120#issuecomment-705891235
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6120?src=pr=h1)
Report
> Merging
codecov-io edited a comment on pull request #6120:
URL: https://github.com/apache/incubator-pinot/pull/6120#issuecomment-705891235
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6120?src=pr=h1)
Report
> Merging
This is an automated email from the ASF dual-hosted git repository.
apucher pushed a change to branch query-runner-sampling-mode
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 338af06 track exception counts
discard 8093212 review fixes
discard b635bac add
bryantachen commented on a change in pull request #6101:
URL: https://github.com/apache/incubator-pinot/pull/6101#discussion_r505133609
##
File path:
thirdeye/thirdeye-spi/src/main/java/org/apache/pinot/thirdeye/detection/performance/PerformanceMetrics.java
##
@@ -0,0 +1,136
pradeepgv42 commented on pull request #6120:
URL: https://github.com/apache/incubator-pinot/pull/6120#issuecomment-708660577
@Jackie-Jiang
QQ about this comment if I seeing the history correctly you added it
npawar commented on issue #5509:
URL:
https://github.com/apache/incubator-pinot/issues/5509#issuecomment-708706434
**Challenges**
Although this seems exactly like transform functions, there's some
differences because of which we cannot handle this solely as regular transform
codecov-io edited a comment on pull request #6136:
URL: https://github.com/apache/incubator-pinot/pull/6136#issuecomment-707985309
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6136?src=pr=h1)
Report
> Merging
venkatvghub closed pull request #6131:
URL: https://github.com/apache/incubator-pinot/pull/6131
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
venkatvghub commented on pull request #6131:
URL: https://github.com/apache/incubator-pinot/pull/6131#issuecomment-708265518
This was filed in the wrong place. Closing this
This is an automated message from the Apache Git
timsants commented on a change in pull request #6046:
URL: https://github.com/apache/incubator-pinot/pull/6046#discussion_r504422005
##
File path:
pinot-plugins/pinot-input-format/pinot-orc/src/main/java/org/apache/pinot/plugin/inputformat/orc/ORCRecordReader.java
##
@@
timsants commented on a change in pull request #6046:
URL: https://github.com/apache/incubator-pinot/pull/6046#discussion_r504421904
##
File path:
pinot-plugins/pinot-input-format/pinot-orc/src/main/java/org/apache/pinot/plugin/inputformat/orc/ORCRecordReader.java
##
@@
timsants closed pull request #6046:
URL: https://github.com/apache/incubator-pinot/pull/6046
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
timsants commented on pull request #6046:
URL: https://github.com/apache/incubator-pinot/pull/6046#issuecomment-708178631
> shouldn't `CSVRecordExtractor` also extend `BaseRecordExtractor` abstract
class instead of implementing the `RecordExtractor` interface?
kvanjana opened a new issue #6142:
URL: https://github.com/apache/incubator-pinot/issues/6142
Dear Team,
I would like to ask three questions.
1. **Change the "fromAddress" of alert email:**I read in many documents
that “# Sender of the alert. Please avoid changing this
mcvsubbu commented on issue #5753:
URL:
https://github.com/apache/incubator-pinot/issues/5753#issuecomment-708496354
I just realized that if we have multiple data centers, this technique will
not produce the same results across the data centers. Something worth noting.
kishoreg edited a comment on issue #5753:
URL:
https://github.com/apache/incubator-pinot/issues/5753#issuecomment-708503218
Why do you say that? As long as you give enough buffer time for the events
from previous time period to flow in, it should be ok right?
kishoreg commented on issue #5753:
URL:
https://github.com/apache/incubator-pinot/issues/5753#issuecomment-708503218
Why do you say that? As long as you give enough buffer, it should be ok
right?
This is an automated
lgo opened a new issue #6145:
URL: https://github.com/apache/incubator-pinot/issues/6145
With a partition column, say `type`, if we uploaded segments containing
`type=foo` but had the following query over a non-existent value:
SELECT * FROM table WHERE type = 'bar'
lgo opened a new issue #6143:
URL: https://github.com/apache/incubator-pinot/issues/6143
While testing some results, I accidentally used the wrong name to refer to a
column. When querying, rather than raising an error the query actually returned
but with `0` results, such as the following
lgo opened a new issue #6144:
URL: https://github.com/apache/incubator-pinot/issues/6144
While building a query intended to pull out all values for a dimension, the
query was slow and timing out.
```sql
select type from adjustment group by type
```
Meanwhile, a query
lgo opened a new issue #6146:
URL: https://github.com/apache/incubator-pinot/issues/6146
On batch jobs processing lots of segments for a table, they often run into
Zookeeper conflicts when updating idealState. This causes contention on
updates, slowing down everything. To resolve that the
codecov-io edited a comment on pull request #6139:
URL: https://github.com/apache/incubator-pinot/pull/6139#issuecomment-708062404
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6139?src=pr=h1)
Report
> Merging
codecov-io edited a comment on pull request #6066:
URL: https://github.com/apache/incubator-pinot/pull/6066#issuecomment-707443440
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6066?src=pr=h1)
Report
> Merging
mcvsubbu commented on issue #5753:
URL:
https://github.com/apache/incubator-pinot/issues/5753#issuecomment-708520151
I mis-worded it. The results will be the same, but the segments in each data
center may not be the same, right? I am not sure if the m to n segment
reduction and time
mcvsubbu commented on a change in pull request #6094:
URL: https://github.com/apache/incubator-pinot/pull/6094#discussion_r504846446
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/generator/SegmentMergeRollupTaskGenerator.java
##
@@
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a change to branch throw-exception-when-column-mismatch
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 1c01c8b Address PR comments
discard 25eccab Add warn level message and emit
fx19880617 edited a comment on issue #6146:
URL:
https://github.com/apache/incubator-pinot/issues/6146#issuecomment-708558434
This is due to we upload segments to all the controller hosts and the
idealStats update requests coming from all controllers will cause the slowness
and update
fx19880617 commented on issue #6146:
URL:
https://github.com/apache/incubator-pinot/issues/6146#issuecomment-708558434
I feel is is due to we upload segments to all the controller hosts and the
idealStats update requests coming from all controllers will cause the slowness
and update
fx19880617 edited a comment on issue #6146:
URL:
https://github.com/apache/incubator-pinot/issues/6146#issuecomment-708558434
I feel this is due to we upload segments to all the controller hosts and the
idealStats update requests coming from all controllers will cause the slowness
and
mcvsubbu commented on issue #6143:
URL:
https://github.com/apache/incubator-pinot/issues/6143#issuecomment-708559618
I think there was a PR that @jackjlli had sometime before? It is best if we
enforce it as a part of SQL, and let PQL be. We are in the process of migrating
from PQL to
jackjlli commented on issue #6143:
URL:
https://github.com/apache/incubator-pinot/issues/6143#issuecomment-708562143
Yes, I have a PR to detect the column mismatch in the query:
https://github.com/apache/incubator-pinot/pull/6066
We'll first monitor how many existing use cases are
joey-stripe commented on issue #6146:
URL:
https://github.com/apache/incubator-pinot/issues/6146#issuecomment-708570008
Here was the stripped down jobSpec we are using
```yaml
executionFrameworkSpec:
name: spark
segmentMetadataPushJobRunnerClassName:
yupeng9 commented on pull request #6141:
URL: https://github.com/apache/incubator-pinot/pull/6141#issuecomment-708525828
> `disableUpsert` is a bit confusing. Initially it led me to believe that it
is actually going to disable upsert operation, which led me to question why the
read path
mayankshriv commented on a change in pull request #6134:
URL: https://github.com/apache/incubator-pinot/pull/6134#discussion_r504825339
##
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/StartServiceManagerCommand.java
##
@@ -69,6 +69,8 @@
private
mayankshriv commented on a change in pull request #6127:
URL: https://github.com/apache/incubator-pinot/pull/6127#discussion_r504830479
##
File path:
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java
##
@@ -343,6 +346,9 @@ private static void
mcvsubbu commented on a change in pull request #6113:
URL: https://github.com/apache/incubator-pinot/pull/6113#discussion_r504839631
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
##
@@ -378,7 +463,12 @@ public
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a change to branch fix-rsvp-meetup
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 0ec26b8 Remove tyrus dependencies
add b432f15 Remove tyrus dependencies
This update added
fx19880617 commented on issue #6143:
URL:
https://github.com/apache/incubator-pinot/issues/6143#issuecomment-708548825
I feel we should by default do column validation add an flag to loose this
behavior for legacy offline tables which doesn't enforce this behavior.
Thoughts? @mayankshriv
snleee commented on pull request #6094:
URL: https://github.com/apache/incubator-pinot/pull/6094#issuecomment-708555891
#2715
https://docs.google.com/document/d/1-AKCfXNXdoNjFIvJ87wjWwFM_38gS0NCwFrIYjYsqp8/edit#heading=h.3ajrnu1jdp9u
mcvsubbu commented on issue #6146:
URL:
https://github.com/apache/incubator-pinot/issues/6146#issuecomment-708561221
Not sure what you mean by rethink.
A metadata only or URI push is a cheaper operation, so there is less
likelyhood of contention.
We can also make the backoff be in
joey-stripe edited a comment on issue #6146:
URL:
https://github.com/apache/incubator-pinot/issues/6146#issuecomment-708570008
Here was the stripped down jobSpec we are using for reference
```yaml
executionFrameworkSpec:
name: spark
segmentMetadataPushJobRunnerClassName:
codecov-io edited a comment on pull request #6136:
URL: https://github.com/apache/incubator-pinot/pull/6136#issuecomment-707985309
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6136?src=pr=h1)
Report
> Merging
codecov-io edited a comment on pull request #6136:
URL: https://github.com/apache/incubator-pinot/pull/6136#issuecomment-707985309
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6136?src=pr=h1)
Report
> Merging
codecov-io edited a comment on pull request #6141:
URL: https://github.com/apache/incubator-pinot/pull/6141#issuecomment-708169596
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6141?src=pr=h1)
Report
> Merging
codecov-io edited a comment on pull request #6141:
URL: https://github.com/apache/incubator-pinot/pull/6141#issuecomment-708169596
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6141?src=pr=h1)
Report
> Merging
56 matches
Mail list logo
