[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5483: Add QueryContext to replace BrokerRequest in the query engine

2020-06-15 Thread GitBox 


codecov-commenter edited a comment on pull request #5483:
URL: https://github.com/apache/incubator-pinot/pull/5483#issuecomment-642283701


   # 
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=h1) 
Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@2c955ce`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `63.09%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-pinot/pull/5483/graphs/tree.svg?width=650=150=pr=4ibza2ugkz)](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master#5483   +/-   ##
   =
 Coverage  ?   66.50%   
   =
 Files ? 1122   
 Lines ?57564   
 Branches  ? 8618   
   =
 Hits  ?38281   
 Misses?16474   
 Partials  ? 2809   
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #integrationtests | `44.85% <0.51%> (?)` | |
   | #unittests | `57.00% <63.09%> (?)` | |
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[.../request/context/predicate/IsNotNullPredicate.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvcHJlZGljYXRlL0lzTm90TnVsbFByZWRpY2F0ZS5qYXZh)
 | `0.00% <0.00%> (ø)` | |
   | 
[...ery/request/context/predicate/IsNullPredicate.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvcHJlZGljYXRlL0lzTnVsbFByZWRpY2F0ZS5qYXZh)
 | `0.00% <0.00%> (ø)` | |
   | 
[...ore/query/request/context/predicate/Predicate.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvcHJlZGljYXRlL1ByZWRpY2F0ZS5qYXZh)
 | `0.00% <0.00%> (ø)` | |
   | 
[...uery/request/context/predicate/NotInPredicate.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvcHJlZGljYXRlL05vdEluUHJlZGljYXRlLmphdmE=)
 | `20.00% <20.00%> (ø)` | |
   | 
[...e/query/request/context/predicate/EqPredicate.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvcHJlZGljYXRlL0VxUHJlZGljYXRlLmphdmE=)
 | `26.66% <26.66%> (ø)` | |
   | 
[...uery/request/context/predicate/NotEqPredicate.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvcHJlZGljYXRlL05vdEVxUHJlZGljYXRlLmphdmE=)
 | `26.66% <26.66%> (ø)` | |
   | 
[...request/context/predicate/RegexpLikePredicate.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvcHJlZGljYXRlL1JlZ2V4cExpa2VQcmVkaWNhdGUuamF2YQ==)
 | `26.66% <26.66%> (ø)` | |
   | 
[.../request/context/predicate/TextMatchPredicate.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvcHJlZGljYXRlL1RleHRNYXRjaFByZWRpY2F0ZS5qYXZh)
 | `46.66% <46.66%> (ø)` | |
   | 
[...uery/request/context/OrderByExpressionContext.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvT3JkZXJCeUV4cHJlc3Npb25Db250ZXh0LmphdmE=)
 | `50.00% <50.00%> (ø)` | |
   | 
[...e/query/request/context/predicate/InPredicate.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvcHJlZGljYXRlL0luUHJlZGljYXRlLmphdmE=)
 | `60.00% <60.00%> (ø)` | |
   | ... and [1131 
more](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5483: Add QueryContext to replace BrokerRequest in the query engine

2020-06-15 Thread GitBox 


codecov-commenter edited a comment on pull request #5483:
URL: https://github.com/apache/incubator-pinot/pull/5483#issuecomment-642283701


   # 
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=h1) 
Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@2c955ce`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `0.51%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-pinot/pull/5483/graphs/tree.svg?width=650=150=pr=4ibza2ugkz)](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master#5483   +/-   ##
   =
 Coverage  ?   44.85%   
   =
 Files ? 1122   
 Lines ?57564   
 Branches  ? 8618   
   =
 Hits  ?25822   
 Misses?29500   
 Partials  ? 2242   
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #integrationtests | `44.85% <0.51%> (?)` | |
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...mon/request/transform/TransformExpressionTree.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC90cmFuc2Zvcm0vVHJhbnNmb3JtRXhwcmVzc2lvblRyZWUuamF2YQ==)
 | `77.77% <0.00%> (ø)` | |
   | 
[.../core/query/request/context/ExpressionContext.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvRXhwcmVzc2lvbkNvbnRleHQuamF2YQ==)
 | `0.00% <0.00%> (ø)` | |
   | 
[...inot/core/query/request/context/FilterContext.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvRmlsdGVyQ29udGV4dC5qYXZh)
 | `0.00% <0.00%> (ø)` | |
   | 
[...ot/core/query/request/context/FunctionContext.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvRnVuY3Rpb25Db250ZXh0LmphdmE=)
 | `0.00% <0.00%> (ø)` | |
   | 
[...uery/request/context/OrderByExpressionContext.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvT3JkZXJCeUV4cHJlc3Npb25Db250ZXh0LmphdmE=)
 | `0.00% <0.00%> (ø)` | |
   | 
[...pinot/core/query/request/context/QueryContext.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvUXVlcnlDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (ø)` | |
   | 
[...e/query/request/context/predicate/EqPredicate.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvcHJlZGljYXRlL0VxUHJlZGljYXRlLmphdmE=)
 | `0.00% <0.00%> (ø)` | |
   | 
[...e/query/request/context/predicate/InPredicate.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvcHJlZGljYXRlL0luUHJlZGljYXRlLmphdmE=)
 | `0.00% <0.00%> (ø)` | |
   | 
[.../request/context/predicate/IsNotNullPredicate.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvcHJlZGljYXRlL0lzTm90TnVsbFByZWRpY2F0ZS5qYXZh)
 | `0.00% <0.00%> (ø)` | |
   | 
[...ery/request/context/predicate/IsNullPredicate.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvcHJlZGljYXRlL0lzTnVsbFByZWRpY2F0ZS5qYXZh)
 | `0.00% <0.00%> (ø)` | |
   | ... and [1131 
more](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=footer).
 Last update

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5483: Add QueryContext to replace BrokerRequest in the query engine

2020-06-14 Thread GitBox 


codecov-commenter edited a comment on pull request #5483:
URL: https://github.com/apache/incubator-pinot/pull/5483#issuecomment-642283701


   # 
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=h1) 
Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@2c955ce`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `0.51%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-pinot/pull/5483/graphs/tree.svg?width=650=150=pr=4ibza2ugkz)](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master#5483   +/-   ##
   =
 Coverage  ?   44.72%   
   =
 Files ? 1122   
 Lines ?57564   
 Branches  ? 8618   
   =
 Hits  ?25745   
 Misses?29559   
 Partials  ? 2260   
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #integrationtests | `44.72% <0.51%> (?)` | |
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...mon/request/transform/TransformExpressionTree.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC90cmFuc2Zvcm0vVHJhbnNmb3JtRXhwcmVzc2lvblRyZWUuamF2YQ==)
 | `77.77% <0.00%> (ø)` | |
   | 
[.../core/query/request/context/ExpressionContext.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvRXhwcmVzc2lvbkNvbnRleHQuamF2YQ==)
 | `0.00% <0.00%> (ø)` | |
   | 
[...inot/core/query/request/context/FilterContext.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvRmlsdGVyQ29udGV4dC5qYXZh)
 | `0.00% <0.00%> (ø)` | |
   | 
[...ot/core/query/request/context/FunctionContext.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvRnVuY3Rpb25Db250ZXh0LmphdmE=)
 | `0.00% <0.00%> (ø)` | |
   | 
[...uery/request/context/OrderByExpressionContext.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvT3JkZXJCeUV4cHJlc3Npb25Db250ZXh0LmphdmE=)
 | `0.00% <0.00%> (ø)` | |
   | 
[...pinot/core/query/request/context/QueryContext.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvUXVlcnlDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (ø)` | |
   | 
[...e/query/request/context/predicate/EqPredicate.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvcHJlZGljYXRlL0VxUHJlZGljYXRlLmphdmE=)
 | `0.00% <0.00%> (ø)` | |
   | 
[...e/query/request/context/predicate/InPredicate.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvcHJlZGljYXRlL0luUHJlZGljYXRlLmphdmE=)
 | `0.00% <0.00%> (ø)` | |
   | 
[.../request/context/predicate/IsNotNullPredicate.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvcHJlZGljYXRlL0lzTm90TnVsbFByZWRpY2F0ZS5qYXZh)
 | `0.00% <0.00%> (ø)` | |
   | 
[...ery/request/context/predicate/IsNullPredicate.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvcHJlZGljYXRlL0lzTnVsbFByZWRpY2F0ZS5qYXZh)
 | `0.00% <0.00%> (ø)` | |
   | ... and [1131 
more](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=footer).
 Last update

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5483: Add QueryContext to replace BrokerRequest in the query engine

2020-06-12 Thread GitBox 


codecov-commenter edited a comment on pull request #5483:
URL: https://github.com/apache/incubator-pinot/pull/5483#issuecomment-642283701


   # 
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=h1) 
Report
   > Merging 
[#5483](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-pinot/commit/1beaab59b73f26c4e35f3b9bc856b03806cddf5a=desc)
 will **decrease** coverage by `0.16%`.
   > The diff coverage is `70.65%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-pinot/pull/5483/graphs/tree.svg?width=650=150=pr=4ibza2ugkz)](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#5483  +/-   ##
   ==
   - Coverage   66.44%   66.28%   -0.17% 
   ==
 Files1075 1122  +47 
 Lines   5477357565+2792 
 Branches 8168 8618 +450 
   ==
   + Hits3639638157+1761 
   - Misses  1570016592 +892 
   - Partials 2677 2816 +139 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #integrationtests | `44.39% <50.60%> (?)` | |
   | #unittests | `56.99% <63.40%> (?)` | |
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...quota/HelixExternalViewBasedQueryQuotaManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcXVlcnlxdW90YS9IZWxpeEV4dGVybmFsVmlld0Jhc2VkUXVlcnlRdW90YU1hbmFnZXIuamF2YQ==)
 | `67.87% <0.00%> (ø)` | |
   | 
[...org/apache/pinot/common/function/FunctionInfo.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vRnVuY3Rpb25JbmZvLmphdmE=)
 | `73.33% <ø> (ø)` | |
   | 
[...java/org/apache/pinot/common/segment/ReadMode.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vc2VnbWVudC9SZWFkTW9kZS5qYXZh)
 | `66.66% <ø> (ø)` | |
   | 
[...org/apache/pinot/common/utils/CommonConstants.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvQ29tbW9uQ29uc3RhbnRzLmphdmE=)
 | `39.02% <0.00%> (+0.92%)` | :arrow_up: |
   | 
[...troller/helix/core/retention/RetentionManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JldGVudGlvbi9SZXRlbnRpb25NYW5hZ2VyLmphdmE=)
 | `80.28% <0.00%> (+1.11%)` | :arrow_up: |
   | 
[...he/pinot/controller/util/AutoAddInvertedIndex.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci91dGlsL0F1dG9BZGRJbnZlcnRlZEluZGV4LmphdmE=)
 | `0.00% <0.00%> (ø)` | |
   | 
[.../org/apache/pinot/core/common/BaseBlockValSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vQmFzZUJsb2NrVmFsU2V0LmphdmE=)
 | `3.03% <0.00%> (-1.32%)` | :arrow_down: |
   | 
[.../java/org/apache/pinot/core/common/DataSource.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vRGF0YVNvdXJjZS5qYXZh)
 | `100.00% <ø> (ø)` | |
   | 
[...data/manager/realtime/DefaultSegmentCommitter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvRGVmYXVsdFNlZ21lbnRDb21taXR0ZXIuamF2YQ==)
 | `80.00% <ø> (ø)` | |
   | 
[...e/data/manager/realtime/SplitSegmentCommitter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvU3BsaXRTZWdtZW50Q29tbWl0dGVyLmphdmE=)
 | `0.00% <ø> (-63.64%)` | :arrow_down: |
   | ... and [463 
more](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=footer).
 Last update

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5483: Add QueryContext to replace BrokerRequest in the query engine

2020-06-12 Thread GitBox 


codecov-commenter edited a comment on pull request #5483:
URL: https://github.com/apache/incubator-pinot/pull/5483#issuecomment-642283701


   # 
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=h1) 
Report
   > Merging 
[#5483](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-pinot/commit/1beaab59b73f26c4e35f3b9bc856b03806cddf5a=desc)
 will **decrease** coverage by `0.16%`.
   > The diff coverage is `70.65%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-pinot/pull/5483/graphs/tree.svg?width=650=150=pr=4ibza2ugkz)](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#5483  +/-   ##
   ==
   - Coverage   66.44%   66.28%   -0.17% 
   ==
 Files1075 1122  +47 
 Lines   5477357565+2792 
 Branches 8168 8618 +450 
   ==
   + Hits3639638157+1761 
   - Misses  1570016592 +892 
   - Partials 2677 2816 +139 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #integrationtests | `44.39% <50.60%> (?)` | |
   | #unittests | `56.99% <63.40%> (?)` | |
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...quota/HelixExternalViewBasedQueryQuotaManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcXVlcnlxdW90YS9IZWxpeEV4dGVybmFsVmlld0Jhc2VkUXVlcnlRdW90YU1hbmFnZXIuamF2YQ==)
 | `67.87% <0.00%> (ø)` | |
   | 
[...org/apache/pinot/common/function/FunctionInfo.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vRnVuY3Rpb25JbmZvLmphdmE=)
 | `73.33% <ø> (ø)` | |
   | 
[...java/org/apache/pinot/common/segment/ReadMode.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vc2VnbWVudC9SZWFkTW9kZS5qYXZh)
 | `66.66% <ø> (ø)` | |
   | 
[...org/apache/pinot/common/utils/CommonConstants.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvQ29tbW9uQ29uc3RhbnRzLmphdmE=)
 | `39.02% <0.00%> (+0.92%)` | :arrow_up: |
   | 
[...troller/helix/core/retention/RetentionManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JldGVudGlvbi9SZXRlbnRpb25NYW5hZ2VyLmphdmE=)
 | `80.28% <0.00%> (+1.11%)` | :arrow_up: |
   | 
[...he/pinot/controller/util/AutoAddInvertedIndex.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci91dGlsL0F1dG9BZGRJbnZlcnRlZEluZGV4LmphdmE=)
 | `0.00% <0.00%> (ø)` | |
   | 
[.../org/apache/pinot/core/common/BaseBlockValSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vQmFzZUJsb2NrVmFsU2V0LmphdmE=)
 | `3.03% <0.00%> (-1.32%)` | :arrow_down: |
   | 
[.../java/org/apache/pinot/core/common/DataSource.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vRGF0YVNvdXJjZS5qYXZh)
 | `100.00% <ø> (ø)` | |
   | 
[...data/manager/realtime/DefaultSegmentCommitter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvRGVmYXVsdFNlZ21lbnRDb21taXR0ZXIuamF2YQ==)
 | `80.00% <ø> (ø)` | |
   | 
[...e/data/manager/realtime/SplitSegmentCommitter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvU3BsaXRTZWdtZW50Q29tbWl0dGVyLmphdmE=)
 | `0.00% <ø> (-63.64%)` | :arrow_down: |
   | ... and [463 
more](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=footer).
 Last update

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5483: Add QueryContext to replace BrokerRequest in the query engine

2020-06-11 Thread GitBox 


codecov-commenter edited a comment on pull request #5483:
URL: https://github.com/apache/incubator-pinot/pull/5483#issuecomment-642283701


   # 
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=h1) 
Report
   > Merging 
[#5483](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-pinot/commit/1beaab59b73f26c4e35f3b9bc856b03806cddf5a=desc)
 will **decrease** coverage by `0.12%`.
   > The diff coverage is `70.68%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-pinot/pull/5483/graphs/tree.svg?width=650=150=pr=4ibza2ugkz)](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#5483  +/-   ##
   ==
   - Coverage   66.44%   66.32%   -0.13% 
   ==
 Files1075 1121  +46 
 Lines   5477357445+2672 
 Branches 8168 8593 +425 
   ==
   + Hits3639638102+1706 
   - Misses  1570016526 +826 
   - Partials 2677 2817 +140 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #integrationtests | `44.50% <50.05%> (?)` | |
   | #unittests | `56.89% <65.63%> (?)` | |
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...quota/HelixExternalViewBasedQueryQuotaManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcXVlcnlxdW90YS9IZWxpeEV4dGVybmFsVmlld0Jhc2VkUXVlcnlRdW90YU1hbmFnZXIuamF2YQ==)
 | `67.87% <0.00%> (ø)` | |
   | 
[...org/apache/pinot/common/function/FunctionInfo.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vRnVuY3Rpb25JbmZvLmphdmE=)
 | `73.33% <ø> (ø)` | |
   | 
[...java/org/apache/pinot/common/segment/ReadMode.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vc2VnbWVudC9SZWFkTW9kZS5qYXZh)
 | `66.66% <ø> (ø)` | |
   | 
[...org/apache/pinot/common/utils/CommonConstants.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvQ29tbW9uQ29uc3RhbnRzLmphdmE=)
 | `39.02% <0.00%> (+0.92%)` | :arrow_up: |
   | 
[...troller/helix/core/retention/RetentionManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JldGVudGlvbi9SZXRlbnRpb25NYW5hZ2VyLmphdmE=)
 | `80.28% <0.00%> (+1.11%)` | :arrow_up: |
   | 
[...he/pinot/controller/util/AutoAddInvertedIndex.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci91dGlsL0F1dG9BZGRJbnZlcnRlZEluZGV4LmphdmE=)
 | `0.00% <0.00%> (ø)` | |
   | 
[.../org/apache/pinot/core/common/BaseBlockValSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vQmFzZUJsb2NrVmFsU2V0LmphdmE=)
 | `3.03% <0.00%> (-1.32%)` | :arrow_down: |
   | 
[.../java/org/apache/pinot/core/common/DataSource.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vRGF0YVNvdXJjZS5qYXZh)
 | `100.00% <ø> (ø)` | |
   | 
[...data/manager/realtime/DefaultSegmentCommitter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvRGVmYXVsdFNlZ21lbnRDb21taXR0ZXIuamF2YQ==)
 | `80.00% <ø> (ø)` | |
   | 
[...e/data/manager/realtime/SplitSegmentCommitter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvU3BsaXRTZWdtZW50Q29tbWl0dGVyLmphdmE=)
 | `0.00% <ø> (-63.64%)` | :arrow_down: |
   | ... and [466 
more](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=footer).
 Last update

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5483: Add QueryContext to replace BrokerRequest in the query engine

2020-06-11 Thread GitBox 


codecov-commenter edited a comment on pull request #5483:
URL: https://github.com/apache/incubator-pinot/pull/5483#issuecomment-642283701


   # 
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=h1) 
Report
   > Merging 
[#5483](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-pinot/commit/1beaab59b73f26c4e35f3b9bc856b03806cddf5a=desc)
 will **decrease** coverage by `0.12%`.
   > The diff coverage is `70.68%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-pinot/pull/5483/graphs/tree.svg?width=650=150=pr=4ibza2ugkz)](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#5483  +/-   ##
   ==
   - Coverage   66.44%   66.32%   -0.13% 
   ==
 Files1075 1121  +46 
 Lines   5477357445+2672 
 Branches 8168 8593 +425 
   ==
   + Hits3639638102+1706 
   - Misses  1570016526 +826 
   - Partials 2677 2817 +140 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #integrationtests | `44.50% <50.05%> (?)` | |
   | #unittests | `56.89% <65.63%> (?)` | |
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...quota/HelixExternalViewBasedQueryQuotaManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcXVlcnlxdW90YS9IZWxpeEV4dGVybmFsVmlld0Jhc2VkUXVlcnlRdW90YU1hbmFnZXIuamF2YQ==)
 | `67.87% <0.00%> (ø)` | |
   | 
[...org/apache/pinot/common/function/FunctionInfo.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vRnVuY3Rpb25JbmZvLmphdmE=)
 | `73.33% <ø> (ø)` | |
   | 
[...java/org/apache/pinot/common/segment/ReadMode.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vc2VnbWVudC9SZWFkTW9kZS5qYXZh)
 | `66.66% <ø> (ø)` | |
   | 
[...org/apache/pinot/common/utils/CommonConstants.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvQ29tbW9uQ29uc3RhbnRzLmphdmE=)
 | `39.02% <0.00%> (+0.92%)` | :arrow_up: |
   | 
[...troller/helix/core/retention/RetentionManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JldGVudGlvbi9SZXRlbnRpb25NYW5hZ2VyLmphdmE=)
 | `80.28% <0.00%> (+1.11%)` | :arrow_up: |
   | 
[...he/pinot/controller/util/AutoAddInvertedIndex.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci91dGlsL0F1dG9BZGRJbnZlcnRlZEluZGV4LmphdmE=)
 | `0.00% <0.00%> (ø)` | |
   | 
[.../org/apache/pinot/core/common/BaseBlockValSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vQmFzZUJsb2NrVmFsU2V0LmphdmE=)
 | `3.03% <0.00%> (-1.32%)` | :arrow_down: |
   | 
[.../java/org/apache/pinot/core/common/DataSource.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vRGF0YVNvdXJjZS5qYXZh)
 | `100.00% <ø> (ø)` | |
   | 
[...data/manager/realtime/DefaultSegmentCommitter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvRGVmYXVsdFNlZ21lbnRDb21taXR0ZXIuamF2YQ==)
 | `80.00% <ø> (ø)` | |
   | 
[...e/data/manager/realtime/SplitSegmentCommitter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvU3BsaXRTZWdtZW50Q29tbWl0dGVyLmphdmE=)
 | `0.00% <ø> (-63.64%)` | :arrow_down: |
   | ... and [466 
more](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=footer).
 Last update

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5483: Add QueryContext to replace BrokerRequest in the query engine

2020-06-10 Thread GitBox 


codecov-commenter edited a comment on pull request #5483:
URL: https://github.com/apache/incubator-pinot/pull/5483#issuecomment-642283701


   # 
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=h1) 
Report
   > Merging 
[#5483](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-pinot/commit/1beaab59b73f26c4e35f3b9bc856b03806cddf5a=desc)
 will **increase** coverage by `0.04%`.
   > The diff coverage is `72.42%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-pinot/pull/5483/graphs/tree.svg?width=650=150=pr=4ibza2ugkz)](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#5483  +/-   ##
   ==
   + Coverage   66.44%   66.49%   +0.04% 
   ==
 Files1075 1120  +45 
 Lines   5477357449+2676 
 Branches 8168 8592 +424 
   ==
   + Hits3639638199+1803 
   - Misses  1570016428 +728 
   - Partials 2677 2822 +145 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #integrationtests | `44.81% <51.75%> (?)` | |
   | #unittests | `56.79% <65.25%> (?)` | |
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...quota/HelixExternalViewBasedQueryQuotaManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcXVlcnlxdW90YS9IZWxpeEV4dGVybmFsVmlld0Jhc2VkUXVlcnlRdW90YU1hbmFnZXIuamF2YQ==)
 | `67.87% <0.00%> (ø)` | |
   | 
[...org/apache/pinot/common/function/FunctionInfo.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vRnVuY3Rpb25JbmZvLmphdmE=)
 | `73.33% <ø> (ø)` | |
   | 
[...org/apache/pinot/common/utils/CommonConstants.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvQ29tbW9uQ29uc3RhbnRzLmphdmE=)
 | `39.02% <0.00%> (+0.92%)` | :arrow_up: |
   | 
[...troller/helix/core/retention/RetentionManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JldGVudGlvbi9SZXRlbnRpb25NYW5hZ2VyLmphdmE=)
 | `76.05% <0.00%> (-3.12%)` | :arrow_down: |
   | 
[...he/pinot/controller/util/AutoAddInvertedIndex.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci91dGlsL0F1dG9BZGRJbnZlcnRlZEluZGV4LmphdmE=)
 | `0.00% <0.00%> (ø)` | |
   | 
[.../org/apache/pinot/core/common/BaseBlockValSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vQmFzZUJsb2NrVmFsU2V0LmphdmE=)
 | `3.03% <0.00%> (-1.32%)` | :arrow_down: |
   | 
[.../java/org/apache/pinot/core/common/DataSource.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vRGF0YVNvdXJjZS5qYXZh)
 | `100.00% <ø> (ø)` | |
   | 
[...data/manager/realtime/DefaultSegmentCommitter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvRGVmYXVsdFNlZ21lbnRDb21taXR0ZXIuamF2YQ==)
 | `80.00% <ø> (ø)` | |
   | 
[...e/data/manager/realtime/SplitSegmentCommitter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvU3BsaXRTZWdtZW50Q29tbWl0dGVyLmphdmE=)
 | `63.63% <ø> (ø)` | |
   | 
[...re/io/reader/impl/v1/FixedBitMultiValueReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pby9yZWFkZXIvaW1wbC92MS9GaXhlZEJpdE11bHRpVmFsdWVSZWFkZXIuamF2YQ==)
 | `100.00% <ø> (ø)` | |
   | ... and [458 
more](https://codecov.io/gh/apache/incubator-pinot/pull/5483/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=footer).
 Last update