[GitHub] [incubator-pinot] kishoreg commented on issue #4617: Adding CreateSegmentCommandV2 command

2019-09-17 Thread GitBox
kishoreg commented on issue #4617: Adding CreateSegmentCommandV2 command
URL: https://github.com/apache/incubator-pinot/pull/4617#issuecomment-532276771
 
 
   Yes. Which custom config are useful? Can we put them as part of tableConfig. 
   
   I am trying to see if we can move towards 3 main sections to setup a table 
   
   Schema
   TableConfig
   IngestionConfig Batch/stream
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org



[GitHub] [incubator-pinot] kishoreg commented on issue #4617: Adding CreateSegmentCommandV2 command

2019-09-17 Thread GitBox
kishoreg commented on issue #4617: Adding CreateSegmentCommandV2 command
URL: https://github.com/apache/incubator-pinot/pull/4617#issuecomment-532259749
 
 
   Existing command is too complicated and needs segment generation config. I 
would like to simplify this. Touching existing will break compatibility, so 
it’s better add a new one and deprecate the existing one. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org