[GitHub] [incubator-pinot] mcvsubbu commented on issue #5942: Better Table config validation

2020-09-29 Thread GitBox


mcvsubbu commented on issue #5942:
URL: 
https://github.com/apache/incubator-pinot/issues/5942#issuecomment-701001231


   yes, that works as long as the same validations are performed. thanks



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org



[GitHub] [incubator-pinot] mcvsubbu commented on issue #5942: Better Table config validation

2020-09-21 Thread GitBox


mcvsubbu commented on issue #5942:
URL: 
https://github.com/apache/incubator-pinot/issues/5942#issuecomment-696207582


   With all the changes proposed/added, it will be useful if a utility is also 
provided to validate an existing tableconfig. Many of them are tightening the 
(lax) rules from before, and are valid. It will be unfortunate if an existing 
installation suddenly stopped working because code elsewhere (not just in the 
table addition path) starts assuming things about the tableconfig.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org



[GitHub] [incubator-pinot] mcvsubbu commented on issue #5942: Better Table config validation

2020-09-21 Thread GitBox


mcvsubbu commented on issue #5942:
URL: 
https://github.com/apache/incubator-pinot/issues/5942#issuecomment-696207582


   With all the changes proposed/added, it will be useful if a utility is also 
provided to validate an existing tableconfig. Many of them are tightening the 
(lax) rules from before, and are valid. It will be unfortunate if an existing 
installation suddenly stopped working because code elsewhere (not just in the 
table addition path) starts assuming things about the tableconfig.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org