Re: [PR] Fix s3 pinot fs url [pinot]
noob-se7en commented on PR #17691: URL: https://github.com/apache/pinot/pull/17691#issuecomment-3905021834 > > wow i cant edit PR title > > Some behavior change in Github lol. What title do you want to change it to? Thank you, I wanted to change to: Fix S3PinotFs URL Encoding for S3 Compatible storage -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Fix s3 pinot fs url [pinot]
Jackie-Jiang commented on PR #17691: URL: https://github.com/apache/pinot/pull/17691#issuecomment-3894195043 > wow i cant edit PR title Some behavior change in Github lol. What title do you want to change it to? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Fix s3 pinot fs url [pinot]
codecov-commenter commented on PR #17691: URL: https://github.com/apache/pinot/pull/17691#issuecomment-3893405823 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/17691?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 55.60%. Comparing base ([`4ef8e3e`](https://app.codecov.io/gh/apache/pinot/commit/4ef8e3eafd14a3c656689afe910bc3a3c615773d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0245e3b`](https://app.codecov.io/gh/apache/pinot/commit/0245e3badb5799f588e6e51fe98f02e54c0013e4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 22 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (4ef8e3e) and HEAD (0245e3b). Click for more details. > > HEAD has 36 uploads less than BASE > >| Flag | BASE (4ef8e3e) | HEAD (0245e3b) | >|--|--|--| >|java-21|5|1| >|unittests1|2|1| >|unittests|4|1| >|temurin|10|1| >|java-11|5|0| >|unittests2|2|0| >|integration|6|0| >|integration2|2|0| >|integration1|2|0| >|custom-integration1|2|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17691 +/- ## - Coverage 63.25% 55.60% -7.65% + Complexity 1499 720 -779 Files 3174 2476 -698 Lines190323 140428 -49895 Branches 2908022375-6705 - Hits 12038178081 -42300 + Misses6060655744-4862 + Partials 9336 6603-2733 ``` | [Flag](https://app.codecov.io/gh/apache/pinot/pull/17691/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/17691/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [integration](https://app.codecov.io/gh/apache/pinot/pull/17691/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [integration1](https://app.codecov.io/gh/apache/pinot/pull/17691/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [integration2](https://app.codecov.io/gh/apache/pinot/pull/17691/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [java-11](https://app.codecov.io/gh/apache/pinot/pull/17691/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [java-21](https://app.codecov.io/gh/apache/pinot/pull/17691/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.60% <ø> (-7.62%)` | :arrow_down: | | [temurin](https://app.codecov.io/gh/apache/pinot/pull/17691/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.60% <ø> (-7.65%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/apache/pinot/pull/17691/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.60% <ø> (-7.65%)` | :arrow_down: | | [unittests1](https://app.codecov.io/gh/apache/pinot/pull/17691/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.60% <ø> (-0.03%)` | :arrow_down: | | [unittests2](https://app.codecov.io/gh/apache/pinot/pull/17691/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/17691?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=g
Re: [PR] Fix s3 pinot fs url [pinot]
noob-se7en commented on PR #17691: URL: https://github.com/apache/pinot/pull/17691#issuecomment-3893205886 wow i cant edit PR title -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[PR] Fix s3 pinot fs url [pinot]
noob-se7en opened a new pull request, #17691: URL: https://github.com/apache/pinot/pull/17691 Fixes [#11182](https://github.com/apache/pinot/issues/11182) - Fix `S3PinotFS.copyFile()` and `touch()` URL encoding that converts `/` to `%2F`, breaking S3-compatible backends (Ceph, NetApp ONTAP) that interpret `%2F` literally - Replace deprecated `copySource` with `sourceBucket`/`sourceKey` in `CopyObjectRequest`, the modern AWS SDK v2 pattern - Remove unnecessary `URLEncoder.encode()` — the AWS SDK handles encoding internally -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
