svn commit: r1783426 - /poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/TestXSSFCloneSheet.java

2017-02-17 Thread onealj
Author: onealj Date: Fri Feb 17 16:57:43 2017 New Revision: 1783426 URL: http://svn.apache.org/viewvc?rev=1783426&view=rev Log: bug 60742: write out to unit test TempFile rather than Unix-only /tmp/60512.xlsx; patch from Chiara Marcheschi Modified: poi/trunk/src/ooxml/testcases/org/ap

svn commit: r1783470 - /poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/TestXSSFCloneSheet.java

2017-02-17 Thread onealj
Author: onealj Date: Fri Feb 17 20:53:44 2017 New Revision: 1783470 URL: http://svn.apache.org/viewvc?rev=1783470&view=rev Log: bug 60742: remove commented out debugging code Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/TestXSSFCloneSheet.java Modified: poi/trunk/src/o

svn commit: r1783703 - /poi/site/src/documentation/release-guide.txt

2017-02-19 Thread onealj
Author: onealj Date: Mon Feb 20 00:59:09 2017 New Revision: 1783703 URL: http://svn.apache.org/viewvc?rev=1783703&view=rev Log: emails sent to annou...@apache.org should have a subject in the format of "[ANNOUNCE] Apache ProjectName X.Y.Z" Modified: poi/site/src/documen

svn commit: r1784230 - /poi/trunk/src/java/org/apache/poi/util/Removal.java

2017-02-23 Thread onealj
Author: onealj Date: Fri Feb 24 04:59:29 2017 New Revision: 1784230 URL: http://svn.apache.org/viewvc?rev=1784230&view=rev Log: bug 59804: @Removal(version="3.15") version should be parsed to make sure the version number is recognizable Modified: poi/trunk/src/java/org/a

svn commit: r1784231 - /poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestWeekdayFunc.java

2017-02-23 Thread onealj
Author: onealj Date: Fri Feb 24 05:07:10 2017 New Revision: 1784231 URL: http://svn.apache.org/viewvc?rev=1784231&view=rev Log: add helper functions to make it easier to see which scenarios are being tested Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/funct

svn commit: r1784493 - /poi/trunk/.gitignore

2017-02-26 Thread onealj
Author: onealj Date: Mon Feb 27 04:18:46 2017 New Revision: 1784493 URL: http://svn.apache.org/viewvc?rev=1784493&view=rev Log: copy .gitignore from svn-props svn propget svn:ignore . > .gitignore Added: poi/trunk/.gitignore Added: poi/trunk/.gitignore URL: http://svn.apache.org/vie

svn commit: r1784495 - /poi/site/src/documentation/content/xdocs/hpsf/index.xml

2017-02-26 Thread onealj
Author: onealj Date: Mon Feb 27 04:41:07 2017 New Revision: 1784495 URL: http://svn.apache.org/viewvc?rev=1784495&view=rev Log: remove informal verbiage Modified: poi/site/src/documentation/content/xdocs/hpsf/index.xml Modified: poi/site/src/documentation/content/xdocs/hpsf/index.xml

svn commit: r1784496 - in /poi/site: publish/ publish/hpbf/ publish/hpsf/ publish/poifs/ src/documentation/content/xdocs/

2017-02-26 Thread onealj
Author: onealj Date: Mon Feb 27 04:50:49 2017 New Revision: 1784496 URL: http://svn.apache.org/viewvc?rev=1784496&view=rev Log: rearrange Component APIs section of menu Modified: poi/site/publish/casestudies.html poi/site/publish/changes.html poi/site/publish/download.html

svn commit: r1784497 - in /poi/site: publish/ src/documentation/content/xdocs/

2017-02-26 Thread onealj
Author: onealj Date: Mon Feb 27 04:54:22 2017 New Revision: 1784497 URL: http://svn.apache.org/viewvc?rev=1784497&view=rev Log: rearrange Component APIs section of menu Modified: poi/site/publish/casestudies.html poi/site/publish/changes.html poi/site/publish/download.html

svn commit: r1784501 - /poi/trunk/README.rst

2017-02-26 Thread onealj
Author: onealj Date: Mon Feb 27 05:35:19 2017 New Revision: 1784501 URL: http://svn.apache.org/viewvc?rev=1784501&view=rev Log: add README.rst to make project more accessible to GitHub users Added: poi/trunk/README.rst Added: poi/trunk/README.rst URL: http://svn.apache.org/viewvc/poi/t

svn commit: r1784502 - /poi/trunk/README.rst

2017-02-26 Thread onealj
Author: onealj Date: Mon Feb 27 05:36:19 2017 New Revision: 1784502 URL: http://svn.apache.org/viewvc?rev=1784502&view=rev Log: fix formatting Modified: poi/trunk/README.rst Modified: poi/trunk/README.rst URL: http://svn.apache.org/viewvc/poi/trunk/README.rst?rev=1784502&r1=17

svn commit: r1784503 - /poi/trunk/README.rst

2017-02-26 Thread onealj
Author: onealj Date: Mon Feb 27 05:37:43 2017 New Revision: 1784503 URL: http://svn.apache.org/viewvc?rev=1784503&view=rev Log: fix formatting Modified: poi/trunk/README.rst Modified: poi/trunk/README.rst URL: http://svn.apache.org/viewvc/poi/trunk/README.rst?rev=1784503&r1=17

svn commit: r1784504 - /poi/trunk/README.rst

2017-02-26 Thread onealj
Author: onealj Date: Mon Feb 27 05:52:50 2017 New Revision: 1784504 URL: http://svn.apache.org/viewvc?rev=1784504&view=rev Log: add repo location of unit test code Modified: poi/trunk/README.rst (contents, props changed) Modified: poi/trunk/README.rst URL: http://svn.apache.org/vi

svn commit: r1784505 - /poi/trunk/README.rst

2017-02-26 Thread onealj
Author: onealj Date: Mon Feb 27 05:56:41 2017 New Revision: 1784505 URL: http://svn.apache.org/viewvc?rev=1784505&view=rev Log: fix formatting: 2nd level indentation Modified: poi/trunk/README.rst Modified: poi/trunk/README.rst URL: http://svn.apache.org/viewvc/poi/trunk/README.rst

svn commit: r1785185 - /poi/trunk/src/java/org/apache/poi/ss/util/CellUtil.java

2017-03-02 Thread onealj
Author: onealj Date: Thu Mar 2 18:47:28 2017 New Revision: 1785185 URL: http://svn.apache.org/viewvc?rev=1785185&view=rev Log: bug 60787: remove calls to System.out.println. Thanks to Kamile Demirel. Modified: poi/trunk/src/java/org/apache/poi/ss/util/CellUtil.java Modified: poi/trunk

svn commit: r1785793 - /poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestZipPackage.java

2017-03-06 Thread onealj
Author: onealj Date: Tue Mar 7 03:16:50 2017 New Revision: 1785793 URL: http://svn.apache.org/viewvc?rev=1785793&view=rev Log: store repeated expressions as temporary variables to make code shorter Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestZipPackage.

svn commit: r1787224 - /poi/site/src/documentation/content/xdocs/index.xml

2017-03-16 Thread onealj
Author: onealj Date: Thu Mar 16 18:28:41 2017 New Revision: 1787224 URL: http://svn.apache.org/viewvc?rev=1787224&view=rev Log: add GSoC announcement to POI homepage Modified: poi/site/src/documentation/content/xdocs/index.xml Modified: poi/site/src/documentation/content/xdocs/index.xml

svn commit: r1791440 - in /poi/trunk/src: ooxml/testcases/org/apache/poi/xssf/extractor/TestXSSFExcelExtractor.java testcases/org/apache/poi/POITestCase.java testcases/org/apache/poi/TestPOITestCase.j

2017-04-14 Thread onealj
Author: onealj Date: Sat Apr 15 02:19:24 2017 New Revision: 1791440 URL: http://svn.apache.org/viewvc?rev=1791440&view=rev Log: use assertStartsWith and assertEndsWith for better unit test error messages Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/extra

svn commit: r1791443 - in /poi/trunk/src: ooxml/testcases/org/apache/poi/xssf/extractor/TestXSSFExcelExtractor.java testcases/org/apache/poi/POITestCase.java

2017-04-14 Thread onealj
Author: onealj Date: Sat Apr 15 02:50:46 2017 New Revision: 1791443 URL: http://svn.apache.org/viewvc?rev=1791443&view=rev Log: use hamcrest matchers to reduce custom code Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/extractor/TestXSSFExcelExtractor.java poi/trunk

svn commit: r1791444 - in /poi/trunk: build.xml src/testcases/org/apache/poi/POITestCase.java

2017-04-14 Thread onealj
Author: onealj Date: Sat Apr 15 03:19:27 2017 New Revision: 1791444 URL: http://svn.apache.org/viewvc?rev=1791444&view=rev Log: change from hamcrest-core-1.3 to hamcrest-all-1.3 Modified: poi/trunk/build.xml poi/trunk/src/testcases/org/apache/poi/POITestCase.java Modified: poi/t

svn commit: r1791445 - /poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/extractor/TestXSSFExcelExtractor.java

2017-04-14 Thread onealj
Author: onealj Date: Sat Apr 15 03:21:34 2017 New Revision: 1791445 URL: http://svn.apache.org/viewvc?rev=1791445&view=rev Log: improve unit test error messages Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/extractor/TestXSSFExcelExtractor.java Modified: poi/trunk/src/o

svn commit: r1791567 - /poi/trunk/maven/poi.pom

2017-04-15 Thread onealj
Author: onealj Date: Sun Apr 16 05:02:07 2017 New Revision: 1791567 URL: http://svn.apache.org/viewvc?rev=1791567&view=rev Log: change from hamcrest-core-1.3 to hamcrest-all-1.3 Modified: poi/trunk/maven/poi.pom Modified: poi/trunk/maven/poi.pom URL: http://svn.apache.org/viewvc/poi/t

svn commit: r1791570 - in /poi/trunk: build.xml maven/poi.pom src/testcases/org/apache/poi/POITestCase.java

2017-04-15 Thread onealj
Author: onealj Date: Sun Apr 16 06:10:23 2017 New Revision: 1791570 URL: http://svn.apache.org/viewvc?rev=1791570&view=rev Log: roll back to hamcrest-core Modified: poi/trunk/build.xml poi/trunk/maven/poi.pom poi/trunk/src/testcases/org/apache/poi/POITestCase.java Modified:

svn commit: r1791572 - /poi/trunk/build.xml

2017-04-15 Thread onealj
Author: onealj Date: Sun Apr 16 06:19:30 2017 New Revision: 1791572 URL: http://svn.apache.org/viewvc?rev=1791572&view=rev Log: roll back to hamcrest-core Modified: poi/trunk/build.xml Modified: poi/trunk/build.xml URL: http://svn.apache.org/viewvc/poi/trunk/build.xml?rev=179157

svn commit: r1792007 - in /poi/trunk/src: ooxml/testcases/org/apache/poi/xssf/eventusermodel/ scratchpad/testcases/org/apache/poi/hslf/extractor/ scratchpad/testcases/org/apache/poi/hwpf/extractor/ sc

2017-04-19 Thread onealj
Author: onealj Date: Wed Apr 19 23:51:03 2017 New Revision: 1792007 URL: http://svn.apache.org/viewvc?rev=1792007&view=rev Log: Use assertContains instead of assertTrue(text.contains) for better error messages on failure Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/

svn commit: r1792009 - in /poi/trunk/src: ooxml/testcases/org/apache/poi/xslf/extractor/ ooxml/testcases/org/apache/poi/xssf/extractor/ ooxml/testcases/org/apache/poi/xssf/streaming/ ooxml/testcases/o

2017-04-19 Thread onealj
Author: onealj Date: Thu Apr 20 01:28:40 2017 New Revision: 1792009 URL: http://svn.apache.org/viewvc?rev=1792009&view=rev Log: Use assertContains instead of assertTrue(text.contains) for better error messages on failure Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/extra

svn commit: r1793223 - in /poi/trunk: src/ooxml/java/org/apache/poi/xssf/eventusermodel/ src/ooxml/testcases/org/apache/poi/xssf/eventusermodel/ src/testcases/org/apache/poi/ test-data/spreadsheet/

2017-04-29 Thread onealj
Author: onealj Date: Sat Apr 29 17:27:17 2017 New Revision: 1793223 URL: http://svn.apache.org/viewvc?rev=1793223&view=rev Log: bug 61034: Call to XSSFReader.getSheetsData() returns duplicate sheets. Thanks to Mauricio Eastmond for the Excel test file and unit test. Thanks to Sebastian Wikali

svn commit: r1793228 - in /poi/site: publish/changes.html publish/changes.rss src/documentation/content/xdocs/status.xml

2017-04-29 Thread onealj
Author: onealj Date: Sat Apr 29 18:30:23 2017 New Revision: 1793228 URL: http://svn.apache.org/viewvc?rev=1793228&view=rev Log: update changelog for bug 61034 Modified: poi/site/publish/changes.html poi/site/publish/changes.rss poi/site/src/documentation/content/xdocs/status

svn commit: r1793230 - /poi/trunk/src/ooxml/java/org/apache/poi/xssf/eventusermodel/XSSFReader.java

2017-04-29 Thread onealj
Author: onealj Date: Sat Apr 29 18:56:09 2017 New Revision: 1793230 URL: http://svn.apache.org/viewvc?rev=1793230&view=rev Log: bug 61034: break out of for-loop when both are found Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/eventusermodel/XSSFReader.java Modified: poi/t

svn commit: r1793418 - /poi/trunk/src/java/org/apache/poi/ss/formula/ptg/NamePtg.java

2017-05-01 Thread onealj
Author: onealj Date: Mon May 1 21:51:34 2017 New Revision: 1793418 URL: http://svn.apache.org/viewvc?rev=1793418&view=rev Log: bug 61059: add @Override annotations Modified: poi/trunk/src/java/org/apache/poi/ss/formula/ptg/NamePtg.java Modified: poi/trunk/src/java/org/apache/poi/ss/for

svn commit: r1795252 - in /poi/trunk: ./ src/ooxml/java/org/apache/poi/ src/ooxml/java/org/apache/poi/openxml4j/opc/ src/ooxml/testcases/org/apache/poi/benchmark/ src/ooxml/testcases/org/apache/poi/xs

2017-05-15 Thread onealj
Author: onealj Date: Mon May 15 23:27:21 2017 New Revision: 1795252 URL: http://svn.apache.org/viewvc?rev=1795252&view=rev Log: github-54: when adding a picture to an XSSFWorkbook, reduce memory consumption by 100x and increase speed by 10x based on OpenJDK JMH benchmarking. Thanks to

svn commit: r1795253 - in /poi/site: publish/changes.html publish/changes.rss src/documentation/content/xdocs/status.xml

2017-05-15 Thread onealj
Author: onealj Date: Mon May 15 23:57:51 2017 New Revision: 1795253 URL: http://svn.apache.org/viewvc?rev=1795253&view=rev Log: update changelog for github-54 from Tim Helmstedt Modified: poi/site/publish/changes.html poi/site/publish/changes.rss poi/site/src/documentation/con

svn commit: r1795254 - /poi/trunk/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFParagraph.java

2017-05-15 Thread onealj
Author: onealj Date: Tue May 16 00:41:25 2017 New Revision: 1795254 URL: http://svn.apache.org/viewvc?rev=1795254&view=rev Log: github-53: fix NPE when iterating over paragraphs in certain *.docx files. Thanks to Praful Kumar Vaishnav! This closes #53. https://github.com/apache/poi/pul

svn commit: r1795256 - /poi/trunk/src/scratchpad/src/org/apache/poi/hssf/converter/ExcelToHtmlConverter.java

2017-05-15 Thread onealj
Author: onealj Date: Tue May 16 00:58:01 2017 New Revision: 1795256 URL: http://svn.apache.org/viewvc?rev=1795256&view=rev Log: github-52: add ExcelToHtmlConverter method that works on InputStreams. Thanks to Tony Zeng! This closes #52. https://github.com/apache/poi/pull/52 Modified:

svn commit: r1795257 - in /poi/site: publish/changes.html publish/changes.rss src/documentation/content/xdocs/status.xml

2017-05-15 Thread onealj
Author: onealj Date: Tue May 16 01:03:13 2017 New Revision: 1795257 URL: http://svn.apache.org/viewvc?rev=1795257&view=rev Log: update changelog for github-52 and github-53 Modified: poi/site/publish/changes.html poi/site/publish/changes.rss poi/site/src/documentation/content/x

svn commit: r1795265 - in /poi/trunk/src/testcases/org/apache/poi/ss/formula/functions: TestMathX.java TestRoundFuncs.java

2017-05-15 Thread onealj
Author: onealj Date: Tue May 16 03:04:12 2017 New Revision: 1795265 URL: http://svn.apache.org/viewvc?rev=1795265&view=rev Log: github-43: add disabled unit test showing a problem with ROUNDUP(3987*0.2, 2). Thanks to @FishMeat. https://github.com/apache/poi/pull/43 Modified: poi/trunk

svn commit: r1795266 - /poi/trunk/src/java/org/apache/poi/ss/formula/functions/Irr.java

2017-05-15 Thread onealj
Author: onealj Date: Tue May 16 03:18:17 2017 New Revision: 1795266 URL: http://svn.apache.org/viewvc?rev=1795266&view=rev Log: github-32: speed up Irr() Excel formula computation by replacing Math.pow() with multiplication. Thanks to Daniel Kuan! This closes #32. https://github.com/apache

svn commit: r1795267 - in /poi/site: publish/changes.html publish/changes.rss src/documentation/content/xdocs/status.xml

2017-05-15 Thread onealj
Author: onealj Date: Tue May 16 03:21:47 2017 New Revision: 1795267 URL: http://svn.apache.org/viewvc?rev=1795267&view=rev Log: update changelog for github-32 Modified: poi/site/publish/changes.html poi/site/publish/changes.rss poi/site/src/documentation/content/xdocs/status

svn commit: r1795277 - /poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFSheet.java

2017-05-16 Thread onealj
Author: onealj Date: Tue May 16 08:38:58 2017 New Revision: 1795277 URL: http://svn.apache.org/viewvc?rev=1795277&view=rev Log: github-25: add enable locking and tab color in SXSSFSheet. Thanks to Danilo Rangel. This closes #25. https://github.com/apache/poi/pull/25 Modified: poi/trunk

svn commit: r1795279 - in /poi/site: publish/changes.html publish/changes.rss src/documentation/content/xdocs/status.xml

2017-05-16 Thread onealj
Author: onealj Date: Tue May 16 08:45:46 2017 New Revision: 1795279 URL: http://svn.apache.org/viewvc?rev=1795279&view=rev Log: update changelog for github-25 Modified: poi/site/publish/changes.html poi/site/publish/changes.rss poi/site/src/documentation/content/xdocs/status

svn commit: r1795296 - in /poi/trunk/src: excelant/testcases/org/apache/poi/ss/excelant/ java/org/apache/poi/hssf/usermodel/ java/org/apache/poi/ss/util/ ooxml/java/org/apache/poi/ ooxml/java/org/apac

2017-05-16 Thread onealj
Author: onealj Date: Tue May 16 10:53:15 2017 New Revision: 1795296 URL: http://svn.apache.org/viewvc?rev=1795296&view=rev Log: replace "String.indexOf(String) >= 1" with "String.contains(String)" Modified: poi/trunk/src/excelant/testcases/org/apache/poi/ss/

svn commit: r1795595 - in /poi/trunk/src/ooxml: java/org/apache/poi/xssf/usermodel/XSSFName.java testcases/org/apache/poi/xssf/usermodel/TestXSSFName.java

2017-05-19 Thread onealj
Author: onealj Date: Fri May 19 08:26:41 2017 New Revision: 1795595 URL: http://svn.apache.org/viewvc?rev=1795595&view=rev Log: github-55: NumberFormatException if XSSFName.setNameName is set with a long name that looks similar to a cell address. Thanks to Thomas S @Millie4Ever This closes

svn commit: r1795598 - in /poi/site: publish/changes.html publish/changes.rss src/documentation/content/xdocs/status.xml

2017-05-19 Thread onealj
Author: onealj Date: Fri May 19 08:43:35 2017 New Revision: 1795598 URL: http://svn.apache.org/viewvc?rev=1795598&view=rev Log: update changelog for github-55 Modified: poi/site/publish/changes.html poi/site/publish/changes.rss poi/site/src/documentation/content/xdocs/status

svn commit: r1795680 - /poi/trunk/src/java/org/apache/poi/ss/util/CellReference.java

2017-05-20 Thread onealj
Author: onealj Date: Sat May 20 20:22:24 2017 New Revision: 1795680 URL: http://svn.apache.org/viewvc?rev=1795680&view=rev Log: bug 61110: remove deprecated, misspelled CellReference#isRowWithnRange and #isColumnWithnRange methods Modified: poi/trunk/src/java/org/apache/poi/ss/

svn commit: r1795681 - in /poi/trunk/src: java/org/apache/poi/ss/util/CellReference.java testcases/org/apache/poi/ss/util/TestCellReference.java

2017-05-20 Thread onealj
Author: onealj Date: Sat May 20 21:04:14 2017 New Revision: 1795681 URL: http://svn.apache.org/viewvc?rev=1795681&view=rev Log: github-55: document that CellReference#isRowWithinRange(String rowNum, SpreadsheetVersion ss) expects rowNum to be parseable as an integer Modified: poi/trunk

svn commit: r1796466 - /poi/trunk/src/java/org/apache/poi/ss/formula/ptg/NamePtg.java

2017-05-27 Thread onealj
Author: onealj Date: Sun May 28 01:17:16 2017 New Revision: 1796466 URL: http://svn.apache.org/viewvc?rev=1796466&view=rev Log: bug 61059: fix NamePtg to read unsigned shorts instead of signed shorts, avoiding a AIOOBE when a workbook contains more than 32k Names. Thanks to Travis Burtrum

svn commit: r1796467 - in /poi/site: publish/changes.html publish/changes.rss src/documentation/content/xdocs/status.xml

2017-05-27 Thread onealj
Author: onealj Date: Sun May 28 01:24:28 2017 New Revision: 1796467 URL: http://svn.apache.org/viewvc?rev=1796467&view=rev Log: update changelog for bug 61085 Modified: poi/site/publish/changes.html poi/site/publish/changes.rss poi/site/src/documentation/content/xdocs/status

svn commit: r1796966 - /poi/trunk/src/java/org/apache/poi/ss/formula/Formula.java

2017-05-30 Thread onealj
Author: onealj Date: Wed May 31 02:46:24 2017 New Revision: 1796966 URL: http://svn.apache.org/viewvc?rev=1796966&view=rev Log: javadocs Modified: poi/trunk/src/java/org/apache/poi/ss/formula/Formula.java Modified: poi/trunk/src/java/org/apache/poi/ss/formula/Formula.java URL:

svn commit: r1797600 - in /poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel: TestUnfixedBugs.java TestXSSFShape.java

2017-06-04 Thread onealj
Author: onealj Date: Sun Jun 4 18:59:18 2017 New Revision: 1797600 URL: http://svn.apache.org/viewvc?rev=1797600&view=rev Log: bug 58325: enable TestXSSFShape unit tests. Thanks to Dominik Stadler for the initial unit test. Thanks to PJ Fanning for discovering that the bug was fixed at

svn commit: r1797602 - /poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFShape.java

2017-06-04 Thread onealj
Author: onealj Date: Sun Jun 4 19:01:51 2017 New Revision: 1797602 URL: http://svn.apache.org/viewvc?rev=1797602&view=rev Log: bug 58325, github-57: Set svn props. This closes #57 on github. Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFShape.java (p

svn commit: r1797603 - in /poi/site: publish/changes.html publish/changes.rss src/documentation/content/xdocs/status.xml

2017-06-04 Thread onealj
Author: onealj Date: Sun Jun 4 19:07:59 2017 New Revision: 1797603 URL: http://svn.apache.org/viewvc?rev=1797603&view=rev Log: update changelog for bug 58325 Modified: poi/site/publish/changes.html poi/site/publish/changes.rss poi/site/src/documentation/content/xdocs/status

svn commit: r1797606 - in /poi/site: publish/changes.html publish/changes.rss src/documentation/content/xdocs/status.xml

2017-06-04 Thread onealj
Author: onealj Date: Sun Jun 4 19:48:54 2017 New Revision: 1797606 URL: http://svn.apache.org/viewvc?rev=1797606&view=rev Log: update changelog for bug 60230 Modified: poi/site/publish/changes.html poi/site/publish/changes.rss poi/site/src/documentation/content/xdocs/status

svn commit: r1798792 - /poi/trunk/src/ooxml/java/org/apache/poi/util/SAXHelper.java

2017-06-14 Thread onealj
Author: onealj Date: Thu Jun 15 05:00:25 2017 New Revision: 1798792 URL: http://svn.apache.org/viewvc?rev=1798792&view=rev Log: bug 61170: add extra logging to SaxHelper. Thanks to PJ Fanning for the patch! This closes #58 on github. Modified: poi/trunk/src/ooxml/java/org/apache/poi/

svn commit: r1798793 - /poi/trunk/src/ooxml/java/org/apache/poi/util/SAXHelper.java

2017-06-14 Thread onealj
Author: onealj Date: Thu Jun 15 05:08:24 2017 New Revision: 1798793 URL: http://svn.apache.org/viewvc?rev=1798793&view=rev Log: bug 61170: add comment why we should catch exceptions in SAXHelper Modified: poi/trunk/src/ooxml/java/org/apache/poi/util/SAXHelper.java Modified: poi/trunk

svn commit: r1799302 - in /poi/trunk/src: java/org/apache/poi/ss/formula/functions/Lookup.java testcases/org/apache/poi/ss/formula/eval/TestFormulaBugs.java

2017-06-19 Thread onealj
Author: onealj Date: Tue Jun 20 05:47:56 2017 New Revision: 1799302 URL: http://svn.apache.org/viewvc?rev=1799302&view=rev Log: bug 52063: support 2-argument LOOKUP(lookup_value, array) function in Excel Modified: poi/trunk/src/java/org/apache/poi/ss/formula/functions/Lookup.java

svn commit: r1799303 - in /poi/trunk/src: java/org/apache/poi/ss/formula/functions/Lookup.java testcases/org/apache/poi/ss/formula/eval/TestFormulaBugs.java

2017-06-19 Thread onealj
Author: onealj Date: Tue Jun 20 05:51:48 2017 New Revision: 1799303 URL: http://svn.apache.org/viewvc?rev=1799303&view=rev Log: whitespace Modified: poi/trunk/src/java/org/apache/poi/ss/formula/functions/Lookup.java poi/trunk/src/testcases/org/apache/poi/ss/formula/

svn commit: r1799304 - /poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/streaming/TestSXSSFWorkbook.java

2017-06-19 Thread onealj
Author: onealj Date: Tue Jun 20 06:08:38 2017 New Revision: 1799304 URL: http://svn.apache.org/viewvc?rev=1799304&view=rev Log: bug 56557: open test-data/spreadsheet/56557.xlsx such that the unit test test56557() does not leave a modified file on disk after running. I verified that > W

svn commit: r1799305 - /poi/site/src/documentation/content/xdocs/status.xml

2017-06-19 Thread onealj
Author: onealj Date: Tue Jun 20 06:12:23 2017 New Revision: 1799305 URL: http://svn.apache.org/viewvc?rev=1799305&view=rev Log: update changelog for bug 52063 Modified: poi/site/src/documentation/content/xdocs/status.xml Modified: poi/site/src/documentation/content/xdocs/status.xml

svn commit: r1799306 - /poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestSXSSFBugs.java

2017-06-20 Thread onealj
Author: onealj Date: Tue Jun 20 07:03:13 2017 New Revision: 1799306 URL: http://svn.apache.org/viewvc?rev=1799306&view=rev Log: bug 58113: this passes with SXSSF now Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestSXSSFBugs.java Modified: poi/trunk/src/o

svn commit: r1799307 - /poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFBugs.java

2017-06-20 Thread onealj
Author: onealj Date: Tue Jun 20 07:05:08 2017 New Revision: 1799307 URL: http://svn.apache.org/viewvc?rev=1799307&view=rev Log: rename createXls and createXlsx helper functions: these are specifically for testing text rotation. Made the file creation compatible on Windows and Mac/Linux using

svn commit: r1799308 - /poi/trunk/src/java/org/apache/poi/util/IOUtils.java

2017-06-20 Thread onealj
Author: onealj Date: Tue Jun 20 07:28:14 2017 New Revision: 1799308 URL: http://svn.apache.org/viewvc?rev=1799308&view=rev Log: bug 57919: add functions to write and close a POIDocument, guaranteeing closure of the output stream and document. Modified: poi/trunk/src/java/org/apache/poi/

svn commit: r1799316 - in /poi/trunk/src: java/org/apache/poi/util/IOUtils.java ooxml/testcases/org/apache/poi/xssf/XSSFTestDataSamples.java

2017-06-20 Thread onealj
Author: onealj Date: Tue Jun 20 08:13:58 2017 New Revision: 1799316 URL: http://svn.apache.org/viewvc?rev=1799316&view=rev Log: bug 57919: close opened resources Modified: poi/trunk/src/java/org/apache/poi/util/IOUtils.java poi/trunk/src/ooxml/testcases/org/apache/poi/

svn commit: r1799324 - /poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFFormulaEvaluation.java

2017-06-20 Thread onealj
Author: onealj Date: Tue Jun 20 09:13:18 2017 New Revision: 1799324 URL: http://svn.apache.org/viewvc?rev=1799324&view=rev Log: unit test that is not written yet should fail Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFFormulaEvaluation.java Modified:

svn commit: r1799323 - /poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFBugs.java

2017-06-20 Thread onealj
Author: onealj Date: Tue Jun 20 09:12:42 2017 New Revision: 1799323 URL: http://svn.apache.org/viewvc?rev=1799323&view=rev Log: simplify unit test code with IOUtils.write to a NullOutputStream Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFBugs.java Modi

svn commit: r1799326 - /poi/trunk/src/scratchpad/testcases/org/apache/poi/hslf/usermodel/TestPictures.java

2017-06-20 Thread onealj
Author: onealj Date: Tue Jun 20 09:16:05 2017 New Revision: 1799326 URL: http://svn.apache.org/viewvc?rev=1799326&view=rev Log: @Ignore("requires an internet connection to a 3rd party site" Modified: poi/trunk/src/scratchpad/testcases/org/apache/poi/hslf/usermodel/Tes

svn commit: r1799332 - /poi/trunk/src/java/org/apache/poi/ss/util/CellReference.java

2017-06-20 Thread onealj
Author: onealj Date: Tue Jun 20 09:52:43 2017 New Revision: 1799332 URL: http://svn.apache.org/viewvc?rev=1799332&view=rev Log: javadoc Modified: poi/trunk/src/java/org/apache/poi/ss/util/CellReference.java Modified: poi/trunk/src/java/org/apache/poi/ss/util/CellReference.java URL:

svn commit: r1800360 - in /poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/charts: XSSFCategoryAxis.java XSSFChartAxis.java XSSFDateAxis.java XSSFValueAxis.java

2017-06-30 Thread onealj
Author: onealj Date: Fri Jun 30 07:45:46 2017 New Revision: 1800360 URL: http://svn.apache.org/viewvc?rev=1800360&view=rev Log: add @Internal annotation to methods that return a CT* class add @Override annotation where missing Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/userm

svn commit: r1800361 - /poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/charts/XSSFDateAxis.java

2017-06-30 Thread onealj
Author: onealj Date: Fri Jun 30 07:48:40 2017 New Revision: 1800361 URL: http://svn.apache.org/viewvc?rev=1800361&view=rev Log: remove incomplete javadocs Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/charts/XSSFDateAxis.java Modified: poi/trunk/src/ooxml/java

svn commit: r1801403 - in /poi/site: publish/hpbf/file-format.html publish/hpbf/file-format.xml publish/hpbf/index.html src/documentation/content/xdocs/hpbf/file-format.xml src/documentation/content/x

2017-07-09 Thread onealj
Author: onealj Date: Mon Jul 10 01:19:50 2017 New Revision: 1801403 URL: http://svn.apache.org/viewvc?rev=1801403&view=rev Log: Microsoft Publisher binary format is undocumented Modified: poi/site/publish/hpbf/file-format.html poi/site/publish/hpbf/file-format.xml poi/site/pub

svn commit: r1801404 - /poi/trunk/src/scratchpad/src/org/apache/poi/hpbf/model/QuillContents.java

2017-07-09 Thread onealj
Author: onealj Date: Mon Jul 10 01:31:31 2017 New Revision: 1801404 URL: http://svn.apache.org/viewvc?rev=1801404&view=rev Log: whitespace Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hpbf/model/QuillContents.java Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hpbf/m

svn commit: r1801405 - in /poi/trunk: src/scratchpad/src/org/apache/poi/hpbf/model/QuillContents.java test-data/publisher/60685.pub

2017-07-09 Thread onealj
Author: onealj Date: Mon Jul 10 01:34:30 2017 New Revision: 1801405 URL: http://svn.apache.org/viewvc?rev=1801405&view=rev Log: bug 60685: ignore problems with HPBF Publisher Quill Contents PLC hyperlink records so that text extraction can continue Added: poi/trunk/test-data/publisher/6

svn commit: r1801798 - in /poi/trunk/src: java/org/apache/poi/ss/formula/functions/MathX.java testcases/org/apache/poi/ss/formula/functions/TestMathX.java

2017-07-12 Thread onealj
Author: onealj Date: Thu Jul 13 03:35:06 2017 New Revision: 1801798 URL: http://svn.apache.org/viewvc?rev=1801798&view=rev Log: github #43: fix roundUp and roundDown. Thanks to @FishMeat on github for the patch. This closes #43 on github. Modified: poi/trunk/src/java/org/apache/po

svn commit: r1801799 - /poi/trunk/src/java/org/apache/poi/ss/formula/functions/MathX.java

2017-07-12 Thread onealj
Author: onealj Date: Thu Jul 13 03:42:12 2017 New Revision: 1801799 URL: http://svn.apache.org/viewvc?rev=1801799&view=rev Log: replace return variable assignments with return statements Modified: poi/trunk/src/java/org/apache/poi/ss/formula/functions/MathX.java Modified: poi/trunk/src/

svn commit: r1801801 - in /poi/trunk/src: java/org/apache/poi/util/IOUtils.java ooxml/testcases/org/apache/poi/xssf/XSSFTestDataSamples.java ooxml/testcases/org/apache/poi/xssf/usermodel/TestUnfixedBu

2017-07-12 Thread onealj
Author: onealj Date: Thu Jul 13 04:19:20 2017 New Revision: 1801801 URL: http://svn.apache.org/viewvc?rev=1801801&view=rev Log: replace commented-out throw-away code that writes workbook to C:\temp\x.xlsx for manual review with XSSFTestDataSamples.writeOut(wb, "bug x for manu

svn commit: r1801803 - /poi/trunk/src/ooxml/testcases/org/apache/poi/sl/TestFonts.java

2017-07-12 Thread onealj
Author: onealj Date: Thu Jul 13 04:30:41 2017 New Revision: 1801803 URL: http://svn.apache.org/viewvc?rev=1801803&view=rev Log: add 362px font height for my computer's configuration (high-dpi monitor) Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/sl/TestFonts.java Modi

svn commit: r1801901 - in /poi/trunk/src/ooxml: java/org/apache/poi/POIXMLTypeLoader.java java/org/apache/poi/openxml4j/opc/internal/PackagePropertiesPart.java testcases/org/apache/poi/openxml4j/opc/T

2017-07-13 Thread onealj
Author: onealj Date: Fri Jul 14 03:14:30 2017 New Revision: 1801901 URL: http://svn.apache.org/viewvc?rev=1801901&view=rev Log: bug 61296: consolidate some of the ooxml namespace uri copy-paste in POI, prepare to make these usable by downstream libraries like Tika Modified: poi/trunk

svn commit: r1801902 - in /poi/site: publish/changes.html publish/changes.rss src/documentation/content/xdocs/status.xml

2017-07-13 Thread onealj
Author: onealj Date: Fri Jul 14 03:20:25 2017 New Revision: 1801902 URL: http://svn.apache.org/viewvc?rev=1801902&view=rev Log: update changelog for github-43 Modified: poi/site/publish/changes.html poi/site/publish/changes.rss poi/site/src/documentation/content/xdocs/status

svn commit: r1801903 - /poi/trunk/src/ooxml/java/org/apache/poi/openxml4j/opc/internal/PackagePropertiesPart.java

2017-07-13 Thread onealj
Author: onealj Date: Fri Jul 14 03:39:25 2017 New Revision: 1801903 URL: http://svn.apache.org/viewvc?rev=1801903&view=rev Log: bug 61296: consolidate some of the ooxml namespace uri copy-paste in POI, prepare to make these usable by downstream libraries like Tika Modified: poi/trunk

svn commit: r1801904 - /poi/trunk/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFRelation.java

2017-07-13 Thread onealj
Author: onealj Date: Fri Jul 14 03:47:38 2017 New Revision: 1801904 URL: http://svn.apache.org/viewvc?rev=1801904&view=rev Log: bug 61296: deduplicate ooxml schema constants Modified: poi/trunk/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFRelation.java Modified: poi/trunk/src/o

svn commit: r1801905 - /poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/converter/FoDocumentFacade.java

2017-07-13 Thread onealj
Author: onealj Date: Fri Jul 14 03:54:12 2017 New Revision: 1801905 URL: http://svn.apache.org/viewvc?rev=1801905&view=rev Log: bug 61296: suggest de-duplication of purl dublin core namespace url Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/converter/FoDocumentFacade.

svn commit: r1804255 - /poi/site/src/documentation/content/xdocs/status.xml

2017-08-06 Thread onealj
Author: onealj Date: Sun Aug 6 18:44:53 2017 New Revision: 1804255 URL: http://svn.apache.org/viewvc?rev=1804255&view=rev Log: update changelog for bug 58975 Modified: poi/site/src/documentation/content/xdocs/status.xml Modified: poi/site/src/documentation/content/xdocs/status.xml

svn commit: r1804268 - /poi/site/src/documentation/content/xdocs/status.xml

2017-08-06 Thread onealj
Author: onealj Date: Sun Aug 6 19:45:37 2017 New Revision: 1804268 URL: http://svn.apache.org/viewvc?rev=1804268&view=rev Log: add module metadata for 3.11-beta1 changelog Modified: poi/site/src/documentation/content/xdocs/status.xml Modified: poi/site/src/documentation/content/x

svn commit: r1804271 - /poi/site/src/documentation/content/xdocs/status.xml

2017-08-06 Thread onealj
Author: onealj Date: Sun Aug 6 19:53:01 2017 New Revision: 1804271 URL: http://svn.apache.org/viewvc?rev=1804271&view=rev Log: add module metadata for 3.11-beta1 changelog Modified: poi/site/src/documentation/content/xdocs/status.xml Modified: poi/site/src/documentation/content/x

svn commit: r1804274 - /poi/site/src/documentation/content/xdocs/status.xml

2017-08-06 Thread onealj
Author: onealj Date: Sun Aug 6 20:42:23 2017 New Revision: 1804274 URL: http://svn.apache.org/viewvc?rev=1804274&view=rev Log:   entities not allowed in xml Modified: poi/site/src/documentation/content/xdocs/status.xml Modified: poi/site/src/documentation/content/xdocs/status.xml

svn commit: r1804279 [1/2] - in /poi/site/src/documentation/content/xdocs: status.copy_module_from_bugzilla.py status.xml

2017-08-06 Thread onealj
Author: onealj Date: Sun Aug 6 23:32:31 2017 New Revision: 1804279 URL: http://svn.apache.org/viewvc?rev=1804279&view=rev Log: add module (copied from Bugzilla component) to changelog of all older releases Added: poi/site/src/documentation/content/xdocs/status.copy_module_from_bugzill

svn commit: r1804279 [2/2] - in /poi/site/src/documentation/content/xdocs: status.copy_module_from_bugzilla.py status.xml

2017-08-06 Thread onealj
Modified: poi/site/src/documentation/content/xdocs/status.xml URL: http://svn.apache.org/viewvc/poi/site/src/documentation/content/xdocs/status.xml?rev=1804279&r1=1804278&r2=1804279&view=diff == --- poi/site/src/documentat

svn commit: r1804280 - /poi/site/src/documentation/content/xdocs/status.copy_module_from_bugzilla.py

2017-08-06 Thread onealj
Author: onealj Date: Mon Aug 7 00:58:14 2017 New Revision: 1804280 URL: http://svn.apache.org/viewvc?rev=1804280&view=rev Log: don't add duplicate modules to status.xml Modified: poi/site/src/documentation/content/xdocs/status.copy_module_from_bugzilla.py Modified: poi

svn commit: r1804281 [2/3] - in /poi/site/publish: changes.html changes.rss

2017-08-06 Thread onealj
Modified: poi/site/publish/changes.html URL: http://svn.apache.org/viewvc/poi/site/publish/changes.html?rev=1804281&r1=1804280&r2=1804281&view=diff == --- poi/site/publish/changes.html (original) +++ poi/site/publish/chan

svn commit: r1804281 [1/3] - in /poi/site/publish: changes.html changes.rss

2017-08-06 Thread onealj
Author: onealj Date: Mon Aug 7 01:23:18 2017 New Revision: 1804281 URL: http://svn.apache.org/viewvc?rev=1804281&view=rev Log: update changelog with module information for every change in the changelog using Bugzilla component field" Modified: poi/site/publish/changes.html

svn commit: r1804281 [3/3] - in /poi/site/publish: changes.html changes.rss

2017-08-06 Thread onealj
Modified: poi/site/publish/changes.rss URL: http://svn.apache.org/viewvc/poi/site/publish/changes.rss?rev=1804281&r1=1804280&r2=1804281&view=diff == --- poi/site/publish/changes.rss (original) +++ poi/site/publish/changes.

svn commit: r1804282 - in /poi/site/src/documentation/content/xdocs: status.copy_module_from_bugzilla.py status.xml

2017-08-06 Thread onealj
Author: onealj Date: Mon Aug 7 01:35:07 2017 New Revision: 1804282 URL: http://svn.apache.org/viewvc?rev=1804282&view=rev Log: remove duplicate modules Modified: poi/site/src/documentation/content/xdocs/status.copy_module_from_bugzilla.py poi/site/src/documentation/content/x

svn commit: r1804283 - /poi/site/publish/changes.html

2017-08-06 Thread onealj
Author: onealj Date: Mon Aug 7 01:39:52 2017 New Revision: 1804283 URL: http://svn.apache.org/viewvc?rev=1804283&view=rev Log: republish changelog Modified: poi/site/publish/changes.html Modified: poi/site/publish/changes.html URL: http://svn.apache.org/viewvc/poi/site/pub

svn commit: r1804284 - in /poi/site: publish/changes.html src/documentation/content/xdocs/status.xml

2017-08-06 Thread onealj
Author: onealj Date: Mon Aug 7 01:51:17 2017 New Revision: 1804284 URL: http://svn.apache.org/viewvc?rev=1804284&view=rev Log: fix spelling Modified: poi/site/publish/changes.html poi/site/src/documentation/content/xdocs/status.xml Modified: poi/site/publish/changes.html URL:

svn commit: r1804285 - in /poi/site: publish/hpbf/file-format.html publish/hpsf/how-to.html publish/poifs/how-to.html publish/poifs/usecases.html src/documentation/content/xdocs/status.xml

2017-08-06 Thread onealj
Author: onealj Date: Mon Aug 7 01:52:39 2017 New Revision: 1804285 URL: http://svn.apache.org/viewvc?rev=1804285&view=rev Log: unofficial 3.11-beta1 release notes Modified: poi/site/publish/hpbf/file-format.html poi/site/publish/hpsf/how-to.html poi/site/publish/poifs/how-to.

svn commit: r1805345 - in /poi/site: publish/poi-jvm-languages.html src/documentation/content/xdocs/poi-jvm-languages.xml

2017-08-17 Thread onealj
Author: onealj Date: Thu Aug 17 23:05:31 2017 New Revision: 1805345 URL: http://svn.apache.org/viewvc?rev=1805345&view=rev Log: add Clojure example, provided by Blake Watson from the POI mailing list Modified: poi/site/publish/poi-jvm-languages.html poi/site/src/documentation/con

svn commit: r1805346 - /poi/site/publish/poi-jvm-languages.html

2017-08-17 Thread onealj
Author: onealj Date: Thu Aug 17 23:09:51 2017 New Revision: 1805346 URL: http://svn.apache.org/viewvc?rev=1805346&view=rev Log: add Clojure example, provided by Blake Watson from the POI mailing list Modified: poi/site/publish/poi-jvm-languages.html Modified: poi/site/publish/poi

svn commit: r1805350 - in /poi/site: publish/poi-jvm-languages.html src/documentation/content/xdocs/poi-jvm-languages.xml

2017-08-17 Thread onealj
Author: onealj Date: Thu Aug 17 23:29:29 2017 New Revision: 1805350 URL: http://svn.apache.org/viewvc?rev=1805350&view=rev Log: add link to Help Wanted for JVM languages Modified: poi/site/publish/poi-jvm-languages.html poi/site/src/documentation/content/xdocs/poi-jvm-languages

svn commit: r1805351 - in /poi/site: publish/poi-jvm-languages.html src/documentation/content/xdocs/poi-jvm-languages.xml

2017-08-17 Thread onealj
Author: onealj Date: Thu Aug 17 23:41:37 2017 New Revision: 1805351 URL: http://svn.apache.org/viewvc?rev=1805351&view=rev Log: add note about hiding each language section Modified: poi/site/publish/poi-jvm-languages.html poi/site/src/documentation/content/xdocs/poi-jvm-languages

svn commit: r1805352 - in /poi/site: publish/poi-jvm-languages.html src/documentation/content/xdocs/poi-jvm-languages.xml

2017-08-17 Thread onealj
Author: onealj Date: Thu Aug 17 23:43:55 2017 New Revision: 1805352 URL: http://svn.apache.org/viewvc?rev=1805352&view=rev Log: add Clojure minimum version; Clojure 1.6, 1.7, and 1.8 are tested as well Modified: poi/site/publish/poi-jvm-languages.html poi/site/src/documentation/con

svn commit: r1805353 - /poi/site/src/documentation/content/xdocs/poi-jvm-languages.xml

2017-08-17 Thread onealj
Author: onealj Date: Thu Aug 17 23:44:57 2017 New Revision: 1805353 URL: http://svn.apache.org/viewvc?rev=1805353&view=rev Log: add Clojure minimum version; Clojure 1.6, 1.7, and 1.8 are tested as well Modified: poi/site/src/documentation/content/xdocs/poi-jvm-languages.xml Modified:

  1   2   3   4   5   6   7   8   9   10   >