Author: onealj
Date: Wed Sep 21 01:03:12 2016
New Revision: 1761652
URL: http://svn.apache.org/viewvc?rev=1761652&view=rev
Log:
bug 60158: add failing test cases for AIOOBE on VBAMacroReader
Added:
poi/trunk/test-data/document/60158.docm (with props)
Modified:
poi/trunk/src/testcases/org/apache/poi/poifs/macros/TestVBAMacroReader.java
Modified:
poi/trunk/src/testcases/org/apache/poi/poifs/macros/TestVBAMacroReader.java
URL:
http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/poifs/macros/TestVBAMacroReader.java?rev=1761652&r1=1761651&r2=1761652&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/poifs/macros/TestVBAMacroReader.java
(original)
+++ poi/trunk/src/testcases/org/apache/poi/poifs/macros/TestVBAMacroReader.java
Wed Sep 21 01:03:12 2016
@@ -262,6 +262,10 @@ public class TestVBAMacroReader {
reader.close();
}
+ private void skipTest(Throwable e) {
+ assumeTrue("This test currently fails." + e.getLocalizedMessage(),
false);
+ }
+
// This test is written as expected-to-fail and should be rewritten
// as expected-to-pass when the bug is fixed.
@Test
@@ -273,11 +277,23 @@ public class TestVBAMacroReader {
if (e.getMessage().matches("Module offset for '.+' was never
read.")) {
//e.printStackTrace();
// NPE when reading module.offset in VBAMacroReader.readMacros
(approx line 258)
- assumeTrue("This test currently fails. See stdout.", false);
+ skipTest(e);
} else {
// something unexpected failed
throw e;
}
}
}
+
+ // This test is written as expected-to-fail and should be rewritten
+ // as expected-to-pass when the bug is fixed.
+ @Test
+ public void bug60158() throws IOException {
+ try {
+ fromFile(POIDataSamples.getDocumentInstance(), "60158.docm");
+ fail("This test passes now. Please update the unit test and bug
59858.");
+ } catch (ArrayIndexOutOfBoundsException e) {
+ skipTest(e);
+ }
+ }
}
Added: poi/trunk/test-data/document/60158.docm
URL:
http://svn.apache.org/viewvc/poi/trunk/test-data/document/60158.docm?rev=1761652&view=auto
==============================================================================
Binary file - no diff available.
Propchange: poi/trunk/test-data/document/60158.docm
------------------------------------------------------------------------------
svn:mime-type = application/vnd.ms-word.document.macroEnabled.12
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@poi.apache.org
For additional commands, e-mail: commits-h...@poi.apache.org
