[GitHub] merlimat opened a new pull request #2753: Fixed apache-rat validations

2018-10-09 Thread GitBox
merlimat opened a new pull request #2753: Fixed apache-rat validations URL: https://github.com/apache/pulsar/pull/2753 ### Motivation Fixed the exclusion and a couple of license headers in newly added files. This

[GitHub] sijie opened a new pull request #2761: Issue #2757: Kafka source connector should just transfer bytes

2018-10-09 Thread GitBox
sijie opened a new pull request #2761: Issue #2757: Kafka source connector should just transfer bytes URL: https://github.com/apache/pulsar/pull/2761 *Motivation* connector is mostly used for transferring bytes from kafka to pulsar. since we haven't mapped schema between kafka

[GitHub] srkukarni commented on issue #2760: Fix Topic Pattern functionality for Python functions

2018-10-09 Thread GitBox
srkukarni commented on issue #2760: Fix Topic Pattern functionality for Python functions URL: https://github.com/apache/pulsar/pull/2760#issuecomment-428443579 run cpp tests This is an automated message from the Apache Git

[GitHub] srkukarni opened a new pull request #2762: Fix IdentitySerde

2018-10-09 Thread GitBox
srkukarni opened a new pull request #2762: Fix IdentitySerde URL: https://github.com/apache/pulsar/pull/2762 ### Motivation We need to make sure that IdentitySerde(which is the default serde for python) outputs bytes on serialization. ### Modifications Describe the

[GitHub] srkukarni commented on issue #2756: Do not create any producer if the output type of a function is void

2018-10-09 Thread GitBox
srkukarni commented on issue #2756: Do not create any producer if the output type of a function is void URL: https://github.com/apache/pulsar/pull/2756#issuecomment-428415061 @jerrypeng reverted the check in write This is an

[GitHub] sijie commented on issue #2760: Fix Topic Pattern functionality for Python functions

2018-10-09 Thread GitBox
sijie commented on issue #2760: Fix Topic Pattern functionality for Python functions URL: https://github.com/apache/pulsar/pull/2760#issuecomment-428433196 as I commented before, we should have python regex related function testing in integration tests. then we can prevent this kind of

[pulsar] branch master updated: change constructor access for ConsumerBuilderImpl (#2759)

2018-10-09 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 362f795 change constructor access for

[GitHub] sijie closed pull request #2759: Change access to public for constructor in ConsumerBuilderImpl

2018-10-09 Thread GitBox
sijie closed pull request #2759: Change access to public for constructor in ConsumerBuilderImpl URL: https://github.com/apache/pulsar/pull/2759 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] srkukarni commented on issue #2760: Fix Topic Pattern functionality for Python functions

2018-10-09 Thread GitBox
srkukarni commented on issue #2760: Fix Topic Pattern functionality for Python functions URL: https://github.com/apache/pulsar/pull/2760#issuecomment-428438761 @sijie added integration tests This is an automated message from

[GitHub] srkukarni commented on issue #2760: Fix Topic Pattern functionality for Python functions

2018-10-09 Thread GitBox
srkukarni commented on issue #2760: Fix Topic Pattern functionality for Python functions URL: https://github.com/apache/pulsar/pull/2760#issuecomment-428440334 run cpp tests This is an automated message from the Apache Git

[GitHub] srkukarni opened a new pull request #2760: Fix Topic Pattern functionality for Python functions

2018-10-09 Thread GitBox
srkukarni opened a new pull request #2760: Fix Topic Pattern functionality for Python functions URL: https://github.com/apache/pulsar/pull/2760 ### Motivation pulsar client no longer has subscribe_pattern interface. ### Modifications Describe the modifications you've

[GitHub] srkukarni closed pull request #2755: fix: function update and related tests are broken

2018-10-09 Thread GitBox
srkukarni closed pull request #2755: fix: function update and related tests are broken URL: https://github.com/apache/pulsar/pull/2755 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[pulsar] branch master updated: fix: function update and related tests are broken (#2755)

2018-10-09 Thread sanjeevrk
This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 6d6155e fix: function update and related

[GitHub] merlimat opened a new pull request #2754: [c++] Fixed virtual destructors

2018-10-09 Thread GitBox
merlimat opened a new pull request #2754: [c++] Fixed virtual destructors URL: https://github.com/apache/pulsar/pull/2754 ### Motivation Few virtual destructors were missing and generating compile warnings. This is an

[GitHub] jerrypeng opened a new pull request #2755: fix: function update and related tests are broken

2018-10-09 Thread GitBox
jerrypeng opened a new pull request #2755: fix: function update and related tests are broken URL: https://github.com/apache/pulsar/pull/2755 ### Motivation Updating a function is currently broken since updates are not propagated through in the schedulerManager due to recent

[pulsar] branch master updated: [python] MessageId.serialize() should return bytes instead of str (#2750)

2018-10-09 Thread sanjeevrk
This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 95f67d0 [python] MessageId.serialize()

[GitHub] srkukarni closed pull request #2750: [python] MessageId.serialize() should return bytes instead of str

2018-10-09 Thread GitBox
srkukarni closed pull request #2750: [python] MessageId.serialize() should return bytes instead of str URL: https://github.com/apache/pulsar/pull/2750 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] srkukarni closed issue #2708: Python messageId serialize is broken

2018-10-09 Thread GitBox
srkukarni closed issue #2708: Python messageId serialize is broken URL: https://github.com/apache/pulsar/issues/2708 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[pulsar] branch master updated: [c++] Fixed virtual destructors (#2754)

2018-10-09 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 8d396c3 [c++] Fixed virtual destructors

[GitHub] sijie opened a new issue #2757: Kafka source connector should just transfer bytes like what we do in sink connector

2018-10-09 Thread GitBox
sijie opened a new issue #2757: Kafka source connector should just transfer bytes like what we do in sink connector URL: https://github.com/apache/pulsar/issues/2757 connector is mostly used for transferring bytes from kafka to pulsar, we should act on bytes rather than string. Kafka sink

[GitHub] sijie opened a new issue #2758: Provide example yaml files for pulsar builtin connectors

2018-10-09 Thread GitBox
sijie opened a new issue #2758: Provide example yaml files for pulsar builtin connectors URL: https://github.com/apache/pulsar/issues/2758 We should provide example yaml files for pulsar builtin connectors. This is an

[pulsar] branch asf-site updated: Updated site at revision 90aa408

2018-10-09 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/asf-site by this push: new 8ac8a71 Updated site at revision 90aa408

[GitHub] nkurihar opened a new issue #2749: Admin API via PulsarProxy with authentication fails

2018-10-09 Thread GitBox
nkurihar opened a new issue #2749: Admin API via PulsarProxy with authentication fails URL: https://github.com/apache/pulsar/issues/2749 I tried Admin API via PulsarProxy with Athenz authentication, and found a few unexpected behaviors. Please correct me if my expectation/understanding is

[GitHub] sijie commented on issue #2691: Automatic schema update can be disabled through admin interface

2018-10-09 Thread GitBox
sijie commented on issue #2691: Automatic schema update can be disabled through admin interface URL: https://github.com/apache/pulsar/pull/2691#issuecomment-428276481 @merlimat can you review this PR? This is an automated

[pulsar] branch master updated: Fixed apache-rat validations (#2753)

2018-10-09 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new b22f59c Fixed apache-rat validations (#2753)

[GitHub] merlimat closed pull request #2753: Fixed apache-rat validations

2018-10-09 Thread GitBox
merlimat closed pull request #2753: Fixed apache-rat validations URL: https://github.com/apache/pulsar/pull/2753 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] srkukarni opened a new pull request #2756: Do not create any producer if the output type of a function is void

2018-10-09 Thread GitBox
srkukarni opened a new pull request #2756: Do not create any producer if the output type of a function is void URL: https://github.com/apache/pulsar/pull/2756 ### Motivation If the function output type is void and an output topic is specified, currently we create a producer thats

[GitHub] merlimat closed pull request #2754: [c++] Fixed virtual destructors

2018-10-09 Thread GitBox
merlimat closed pull request #2754: [c++] Fixed virtual destructors URL: https://github.com/apache/pulsar/pull/2754 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[pulsar] branch srkukarni/serverside_validation_endpoints deleted (was 888867c)

2018-10-09 Thread sanjeevrk
This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a change to branch srkukarni/serverside_validation_endpoints in repository https://gitbox.apache.org/repos/asf/pulsar.git. was 67c Fixed path for sink The revisions that were on this branch are still

[pulsar] branch branch-2.2 updated: Fixed apache-rat validations

2018-10-09 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch branch-2.2 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.2 by this push: new dd50929 Fixed apache-rat validations

[GitHub] srkukarni commented on issue #2756: Do not create any producer if the output type of a function is void

2018-10-09 Thread GitBox
srkukarni commented on issue #2756: Do not create any producer if the output type of a function is void URL: https://github.com/apache/pulsar/pull/2756#issuecomment-428401050 @jerrypeng added the check during write. This is

[GitHub] codelipenghui opened a new pull request #2759: Change access to public for constructor in ConsumerBuilderImpl

2018-10-09 Thread GitBox
codelipenghui opened a new pull request #2759: Change access to public for constructor in ConsumerBuilderImpl URL: https://github.com/apache/pulsar/pull/2759 This is an automated message from the Apache

[GitHub] merlimat commented on a change in pull request #2691: Automatic schema update can be disabled through admin interface

2018-10-09 Thread GitBox
merlimat commented on a change in pull request #2691: Automatic schema update can be disabled through admin interface URL: https://github.com/apache/pulsar/pull/2691#discussion_r223800931 ## File path:

[GitHub] sfescape opened a new issue #2751: null payload or property values generated NullPointerException in server

2018-10-09 Thread GitBox
sfescape opened a new issue #2751: null payload or property values generated NullPointerException in server URL: https://github.com/apache/pulsar/issues/2751 Expected behavior I expected the server to accept null valued properties and payloads Actual behavior

[GitHub] merlimat commented on issue #2751: null payload or property values generated NullPointerException in server

2018-10-09 Thread GitBox
merlimat commented on issue #2751: null payload or property values generated NullPointerException in server URL: https://github.com/apache/pulsar/issues/2751#issuecomment-428338518 @sfescape by null payload you mean empty? Is the exception happening in the WebSocket proxy?

[GitHub] srkukarni opened a new pull request #2752: Function Serverside validation Part 2

2018-10-09 Thread GitBox
srkukarni opened a new pull request #2752: Function Serverside validation Part 2 URL: https://github.com/apache/pulsar/pull/2752 ### Motivation In the first part of adding serverside function validation(#2701), we added ability to pass in functionConfig to the function api endpoints

[GitHub] sfescape commented on issue #2751: null payload or property values generated NullPointerException in server

2018-10-09 Thread GitBox
sfescape commented on issue #2751: null payload or property values generated NullPointerException in server URL: https://github.com/apache/pulsar/issues/2751#issuecomment-428345279 Not an empty string, a null value. I'm not sure if a base64 encoded empty string works. I can test that

[GitHub] merlimat closed pull request #2741: Avoid shading netty in managed-ledger-shaded

2018-10-09 Thread GitBox
merlimat closed pull request #2741: Avoid shading netty in managed-ledger-shaded URL: https://github.com/apache/pulsar/pull/2741 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[pulsar] 03/04: More compile fixes

2018-10-09 Thread sanjeevrk
This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a commit to branch srkukarni/serverside_validation_endpoints in repository https://gitbox.apache.org/repos/asf/pulsar.git commit a19d6365415b4a112c30b82e711fbf2877716515 Author: Sanjeev Kulkarni AuthorDate: Tue

[pulsar] 02/04: Fix bugs after mergin

2018-10-09 Thread sanjeevrk
This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a commit to branch srkukarni/serverside_validation_endpoints in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 6915ff80c1cde193a6f4b1804e6351b920bd2e00 Author: Sanjeev Kulkarni AuthorDate: Tue

[pulsar] 04/04: Fixed path for sink

2018-10-09 Thread sanjeevrk
This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a commit to branch srkukarni/serverside_validation_endpoints in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 67c6655702e95433a79c424fd3efbddd26f4 Author: Sanjeev Kulkarni AuthorDate: Tue

[pulsar] branch srkukarni/serverside_validation_endpoints updated (8fd2209 -> 888867c)

2018-10-09 Thread sanjeevrk
This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a change to branch srkukarni/serverside_validation_endpoints in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 8fd2209 Logic correction add dd4f71d [clients][kafka] Fix topic name &

[pulsar] 01/04: Merge branch 'master' into serverside_validation_endpoints

2018-10-09 Thread sanjeevrk
This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a commit to branch srkukarni/serverside_validation_endpoints in repository https://gitbox.apache.org/repos/asf/pulsar.git commit d7d178cd468d6317467928644907a7874a5d5b30 Merge: 8fd2209 90aa408 Author: Sanjeev

[GitHub] srkukarni commented on issue #2750: [python] MessageId.serialize() should return bytes instead of str

2018-10-09 Thread GitBox
srkukarni commented on issue #2750: [python] MessageId.serialize() should return bytes instead of str URL: https://github.com/apache/pulsar/pull/2750#issuecomment-428332729 run cpp tests This is an automated message from

[GitHub] merlimat opened a new pull request #2750: [python] MessageId.serialize() should return bytes instead of str

2018-10-09 Thread GitBox
merlimat opened a new pull request #2750: [python] MessageId.serialize() should return bytes instead of str URL: https://github.com/apache/pulsar/pull/2750 ### Motivation Fixes #2708 `MessageId.serialize()` is returning a `str` object but it Python 3 that should be a

[pulsar] branch master updated: Avoid shading netty in managed-ledger-shaded (#2741)

2018-10-09 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 83da460 Avoid shading netty in

[pulsar.wiki] branch master updated: Updated PIP 19: Pulsar SQL (markdown)

2018-10-09 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.wiki.git The following commit(s) were added to refs/heads/master by this push: new d9cb76e Updated PIP 19: Pulsar SQL