[GitHub] [pulsar] merlimat commented on issue #5587: [Issue 5585][pulsar-client] Fix producer Semaphore release error

2019-11-08 Thread GitBox
merlimat commented on issue #5587: [Issue 5585][pulsar-client] Fix producer Semaphore release error URL: https://github.com/apache/pulsar/pull/5587#issuecomment-551963297 @rdhabalia PTAL as well This is an automated message

[GitHub] [pulsar] vicaya edited a comment on issue #5598: Proxy Websocket authentication using websocket in browser

2019-11-08 Thread GitBox
vicaya edited a comment on issue #5598: Proxy Websocket authentication using websocket in browser URL: https://github.com/apache/pulsar/issues/5598#issuecomment-551943081 Ideally, the browser websocket api needs to be enhanced to support additional headers per websocket RFC 6455 (section

[GitHub] [pulsar] vicaya commented on issue #5598: Proxy Websocket authentication using websocket in browser

2019-11-08 Thread GitBox
vicaya commented on issue #5598: Proxy Websocket authentication using websocket in browser URL: https://github.com/apache/pulsar/issues/5598#issuecomment-551943081 Ideally, the browser websocket api needs to be enhanced to support additional headers per websocket RFC 6455 (section 4.1).

[GitHub] [pulsar] addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options

2019-11-08 Thread GitBox
addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#issuecomment-551971510 rerun java8 tests This is an automated message from the

[GitHub] [pulsar] vicaya edited a comment on issue #5598: Proxy Websocket authentication using websocket in browser

2019-11-08 Thread GitBox
vicaya edited a comment on issue #5598: Proxy Websocket authentication using websocket in browser URL: https://github.com/apache/pulsar/issues/5598#issuecomment-551943081 Ideally, the browser websocket api needs to be enhanced to support additional headers per websocket RFC 6455 (section

[GitHub] [pulsar] merlimat merged pull request #5591: KafkaSourceRecord - Initialize key property with Optional.empty()

2019-11-08 Thread GitBox
merlimat merged pull request #5591: KafkaSourceRecord - Initialize key property with Optional.empty() URL: https://github.com/apache/pulsar/pull/5591 This is an automated message from the Apache Git Service. To respond to

[pulsar] branch master updated: [pulsar-io] [kafka-connect-adapter] KafkaSourceRecord - Initialize key property with Optional.empty() if keyBytes from SourceRecord is null (Optional property should ne

2019-11-08 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new f2ee3fa [pulsar-io] [kafka-connect-adapter]

[GitHub] [pulsar] merlimat commented on a change in pull request #5557: [Schema]Add SchemaDisabled for schema

2019-11-08 Thread GitBox
merlimat commented on a change in pull request #5557: [Schema]Add SchemaDisabled for schema URL: https://github.com/apache/pulsar/pull/5557#discussion_r344342273 ## File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Schema.java ## @@ -213,6 +213,16

[GitHub] [pulsar] addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options

2019-11-08 Thread GitBox
addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#issuecomment-552028052 @sijie @jerrypeng this is ready for another look, let me know if you have any questions!

[GitHub] [pulsar] addisonj commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options

2019-11-08 Thread GitBox
addisonj commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#discussion_r344412884 ## File path:

[GitHub] [pulsar] addisonj commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options

2019-11-08 Thread GitBox
addisonj commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#discussion_r344416860 ## File path:

[GitHub] [pulsar] addisonj commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options

2019-11-08 Thread GitBox
addisonj commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#discussion_r344416849 ## File path:

[GitHub] [pulsar] wolfstudy commented on issue #5595: [Docs] Fix the go client docs missing in website

2019-11-08 Thread GitBox
wolfstudy commented on issue #5595: [Docs] Fix the go client docs missing in website URL: https://github.com/apache/pulsar/pull/5595#issuecomment-552069133 run java8 tests This is an automated message from the Apache Git

[GitHub] [pulsar] sky-big opened a new issue #5600: [Kubernetes] Fix zookeeper yaml prometheus pull metrics port

2019-11-08 Thread GitBox
sky-big opened a new issue #5600: [Kubernetes] Fix zookeeper yaml prometheus pull metrics port URL: https://github.com/apache/pulsar/issues/5600 Zookeeper expose 8000 for prometheus pull metrics, however kubernetes yaml file is 8080.

[GitHub] [pulsar] addisonj commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options

2019-11-08 Thread GitBox
addisonj commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#discussion_r344417791 ## File path:

[GitHub] [pulsar] codelipenghui commented on issue #5571: Add epoch for connection handler to handle create producer timeout.

2019-11-08 Thread GitBox
codelipenghui commented on issue #5571: Add epoch for connection handler to handle create producer timeout. URL: https://github.com/apache/pulsar/pull/5571#issuecomment-552050075 run cpp tests run java8 tests This is an

[GitHub] [pulsar] tuteng commented on issue #5582: pulsar dashboard collector encountered error message

2019-11-08 Thread GitBox
tuteng commented on issue #5582: pulsar dashboard collector encountered error message URL: https://github.com/apache/pulsar/issues/5582#issuecomment-552055106 It seems that there are more namespaces. You can check whether there are many identical namespaces in your cluster. In theory, in

[GitHub] [pulsar] wolfstudy commented on issue #5491: [Issue 5476]Fix message deduplicate issue while using external sequence id with batch produce

2019-11-08 Thread GitBox
wolfstudy commented on issue #5491: [Issue 5476]Fix message deduplicate issue while using external sequence id with batch produce URL: https://github.com/apache/pulsar/pull/5491#issuecomment-552069364 run java8 tests

[GitHub] [pulsar] sky-big opened a new pull request #5601: Fix zookeeper expose metrics port on kubernetes yaml

2019-11-08 Thread GitBox
sky-big opened a new pull request #5601: Fix zookeeper expose metrics port on kubernetes yaml URL: https://github.com/apache/pulsar/pull/5601 #5600 Fix zookeeper kubernetes annotations for prometheus pull metrics from port 8000

[GitHub] [pulsar] jerrypeng commented on issue #5400: [functions] Allow functions to pass runtime specific options

2019-11-08 Thread GitBox
jerrypeng commented on issue #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#issuecomment-552047388 @addisonj also see if modiying "KubernetesFunctionAuthProvider/FunctionAuthProvider" interface to take in custom options

[GitHub] [pulsar] addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options

2019-11-08 Thread GitBox
addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#issuecomment-552048442 Perhaps I am missing something, but I think there is a mismatch here. The `FunctionRuntimeManager` can manage the

[GitHub] [pulsar] rdhabalia opened a new pull request #5599: [pulsar-broker] close managed-ledgers before giving up bundle ownership to avoid bad zk-version

2019-11-08 Thread GitBox
rdhabalia opened a new pull request #5599: [pulsar-broker] close managed-ledgers before giving up bundle ownership to avoid bad zk-version URL: https://github.com/apache/pulsar/pull/5599 ### Motivation right now, while unloading bundle: broker removes ownership of bundle after

[GitHub] [pulsar] sky-big commented on issue #5601: Fix zookeeper expose metrics port on kubernetes yaml

2019-11-08 Thread GitBox
sky-big commented on issue #5601: Fix zookeeper expose metrics port on kubernetes yaml URL: https://github.com/apache/pulsar/pull/5601#issuecomment-552070020 Hi @sijie, can you please take a look? This is an automated

[GitHub] [pulsar] jerrypeng commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options

2019-11-08 Thread GitBox
jerrypeng commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#discussion_r344413435 ## File path:

[GitHub] [pulsar] jerrypeng commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options

2019-11-08 Thread GitBox
jerrypeng commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#discussion_r344414390 ## File path:

[GitHub] [pulsar] jerrypeng commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options

2019-11-08 Thread GitBox
jerrypeng commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#discussion_r344414425 ## File path:

[GitHub] [pulsar] nathan-zhu commented on issue #5514: use pulsar get error in mac os

2019-11-08 Thread GitBox
nathan-zhu commented on issue #5514: use pulsar get error in mac os URL: https://github.com/apache/pulsar/issues/5514#issuecomment-552062028 > @nathan-zhu try this > `pip3 install pulsar-client==2.4.1.post1` thanks, aahmed-se. now it works on my mac. thanks all people to help me

[GitHub] [pulsar] jerrypeng commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options

2019-11-08 Thread GitBox
jerrypeng commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#discussion_r344412355 ## File path:

[GitHub] [pulsar] addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options

2019-11-08 Thread GitBox
addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#issuecomment-552046680 I considered such an approach, but wasn't sure if that was something that made sense for other providers. Will take a look

[GitHub] [pulsar] wolfstudy commented on issue #5491: [Issue 5476]Fix message deduplicate issue while using external sequence id with batch produce

2019-11-08 Thread GitBox
wolfstudy commented on issue #5491: [Issue 5476]Fix message deduplicate issue while using external sequence id with batch produce URL: https://github.com/apache/pulsar/pull/5491#issuecomment-552069382 ping @merlimat PTAL again.

[GitHub] [pulsar] raghavi92 commented on issue #4672: [Kafka connect] Transformations are not working

2019-11-08 Thread GitBox
raghavi92 commented on issue #4672: [Kafka connect] Transformations are not working URL: https://github.com/apache/pulsar/issues/4672#issuecomment-552072529 Coming from Slack here. Would like to know if there's any scope and when we can expect custom kafka-like transforms in pulsar? For

[GitHub] [pulsar] jerrypeng commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options

2019-11-08 Thread GitBox
jerrypeng commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#discussion_r344415812 ## File path:

[GitHub] [pulsar] addisonj commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options

2019-11-08 Thread GitBox
addisonj commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#discussion_r344416501 ## File path:

[GitHub] [pulsar] codelipenghui commented on issue #5491: [Issue 5476]Fix message deduplicate issue while using external sequence id with batch produce

2019-11-08 Thread GitBox
codelipenghui commented on issue #5491: [Issue 5476]Fix message deduplicate issue while using external sequence id with batch produce URL: https://github.com/apache/pulsar/pull/5491#issuecomment-552050177 run java8 tests

[GitHub] [pulsar] codelipenghui commented on issue #5491: [Issue 5476]Fix message deduplicate issue while using external sequence id with batch produce

2019-11-08 Thread GitBox
codelipenghui commented on issue #5491: [Issue 5476]Fix message deduplicate issue while using external sequence id with batch produce URL: https://github.com/apache/pulsar/pull/5491#issuecomment-552050267 run cpp tests This

[GitHub] [pulsar] jerrypeng commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options

2019-11-08 Thread GitBox
jerrypeng commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#discussion_r344413435 ## File path:

[GitHub] [pulsar] jerrypeng commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options

2019-11-08 Thread GitBox
jerrypeng commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#discussion_r344413224 ## File path:

[GitHub] [pulsar] aahmed-se closed issue #5514: use pulsar get error in mac os

2019-11-08 Thread GitBox
aahmed-se closed issue #5514: use pulsar get error in mac os URL: https://github.com/apache/pulsar/issues/5514 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar] ltamber opened a new issue #5597: [pulsar-client-java] retry when getPartitionedTopicMetadata failed

2019-11-08 Thread GitBox
ltamber opened a new issue #5597: [pulsar-client-java] retry when getPartitionedTopicMetadata failed URL: https://github.com/apache/pulsar/issues/5597 **Is your feature request related to a problem? Please describe.** when pulsar client create producer async, we can provide a serviceUrl

[GitHub] [pulsar] sijie commented on issue #5591: KafkaSourceRecord - Initialize key property with Optional.empty()

2019-11-08 Thread GitBox
sijie commented on issue #5591: KafkaSourceRecord - Initialize key property with Optional.empty() URL: https://github.com/apache/pulsar/pull/5591#issuecomment-551883858 run java8 tests This is an automated message from the

[GitHub] [pulsar] sijie commented on issue #5594: [Issue 5553] [website] Add coding-guide page

2019-11-08 Thread GitBox
sijie commented on issue #5594: [Issue 5553] [website] Add coding-guide page URL: https://github.com/apache/pulsar/pull/5594#issuecomment-551884564 run java8 tests This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] sijie commented on issue #5596: [Issue 5575] fix typo in BrokersBase file

2019-11-08 Thread GitBox
sijie commented on issue #5596: [Issue 5575] fix typo in BrokersBase file URL: https://github.com/apache/pulsar/pull/5596#issuecomment-551885462 run java8 tests This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] waxzce opened a new issue #5598: Proxy Websocket authentication using websocket in browser

2019-11-08 Thread GitBox
waxzce opened a new issue #5598: Proxy Websocket authentication using websocket in browser URL: https://github.com/apache/pulsar/issues/5598 Websocket API in a browser does not allow to manage header https://developer.mozilla.org/en-US/docs/Web/API/WebSocket/WebSocket The

[GitHub] [pulsar] nathan-zhu commented on issue #5514: use pulsar get error in mac os

2019-11-08 Thread GitBox
nathan-zhu commented on issue #5514: use pulsar get error in mac os URL: https://github.com/apache/pulsar/issues/5514#issuecomment-551430495 > There seems to be a lack of package boost-python3, if you try to install with source code, don't install with pip anymore. Python3 is no problem,

[GitHub] [pulsar] Anonymitaet edited a comment on issue #5593: [Docs] Add admin api docs of Pulsar Functions

2019-11-08 Thread GitBox
Anonymitaet edited a comment on issue #5593: [Docs] Add admin api docs of Pulsar Functions URL: https://github.com/apache/pulsar/pull/5593#issuecomment-551451378 @sijie it seems that the contents of this PR are similar to the ["Use" chapter in Connector

[GitHub] [pulsar] Anonymitaet edited a comment on issue #5593: [Docs] Add admin api docs of Pulsar Functions

2019-11-08 Thread GitBox
Anonymitaet edited a comment on issue #5593: [Docs] Add admin api docs of Pulsar Functions URL: https://github.com/apache/pulsar/pull/5593#issuecomment-551451378 @sijie it seems that the contents of this PR are similar to the ["Use" chapter in Connector

[GitHub] [pulsar] Anonymitaet removed a comment on issue #5593: [Docs] Add admin api docs of Pulsar Functions

2019-11-08 Thread GitBox
Anonymitaet removed a comment on issue #5593: [Docs] Add admin api docs of Pulsar Functions URL: https://github.com/apache/pulsar/pull/5593#issuecomment-551451378 @sijie it seems that the contents of this PR are similar to the ["Use" chapter in Connector

[GitHub] [pulsar] codelipenghui commented on issue #4621: [PIP-38] Support batch receive in java client.

2019-11-08 Thread GitBox
codelipenghui commented on issue #4621: [PIP-38] Support batch receive in java client. URL: https://github.com/apache/pulsar/pull/4621#issuecomment-551519583 run java8 tests This is an automated message from the Apache Git

[GitHub] [pulsar] tuteng commented on issue #5590: [Issue 5474][pulsar-io-debezium] Support CDC Connector for MongoDB

2019-11-08 Thread GitBox
tuteng commented on issue #5590: [Issue 5474][pulsar-io-debezium] Support CDC Connector for MongoDB URL: https://github.com/apache/pulsar/pull/5590#issuecomment-551605145 Great job!!! Are you interested in adding an integration test using the

[GitHub] [pulsar] wolfstudy commented on issue #5312: Function REST API documentation is insufficient for Create POST action

2019-11-08 Thread GitBox
wolfstudy commented on issue #5312: Function REST API documentation is insufficient for Create POST action URL: https://github.com/apache/pulsar/issues/5312#issuecomment-551653091 @devinbost Sorry, I missed this message. The REST API for create function should be correct. In

[pulsar-manager] branch master updated: Move package name from io.streamnative.pulsar to org.apache.pulsar (#208)

2019-11-08 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-manager.git The following commit(s) were added to refs/heads/master by this push: new 7ec5ef6 Move package name from

[GitHub] [pulsar] codelipenghui commented on issue #5587: [Issue 5585][pulsar-client] Fix producer Semaphore release error

2019-11-08 Thread GitBox
codelipenghui commented on issue #5587: [Issue 5585][pulsar-client] Fix producer Semaphore release error URL: https://github.com/apache/pulsar/pull/5587#issuecomment-551693802 run java8 tests This is an automated message

[GitHub] [pulsar] wolfstudy commented on issue #2719: Fix various bugs in the Go client doc examples

2019-11-08 Thread GitBox
wolfstudy commented on issue #2719: Fix various bugs in the Go client doc examples URL: https://github.com/apache/pulsar/issues/2719#issuecomment-551707356 @grantwwu @sijie According to the go community's processing specification, we should add a `README.md` file to pulsar-client-go and

[GitHub] [pulsar] sijie commented on issue #2719: Fix various bugs in the Go client doc examples

2019-11-08 Thread GitBox
sijie commented on issue #2719: Fix various bugs in the Go client doc examples URL: https://github.com/apache/pulsar/issues/2719#issuecomment-551747371 @wolfstudy can you drive the work to solve the problem? This is an

[GitHub] [pulsar] wolfstudy opened a new pull request #5595: [Docs] Fix the go client docs missing in website

2019-11-08 Thread GitBox
wolfstudy opened a new pull request #5595: [Docs] Fix the go client docs missing in website URL: https://github.com/apache/pulsar/pull/5595 Signed-off-by: xiaolong.ran ### Motivation In website, the go client docs missing. ### Modifications Add missing docs for

[GitHub] [pulsar] sijie commented on issue #5022: Fixed the cleanup of non-durable cursors when a reader is closed

2019-11-08 Thread GitBox
sijie commented on issue #5022: Fixed the cleanup of non-durable cursors when a reader is closed URL: https://github.com/apache/pulsar/pull/5022#issuecomment-551441869 @merlimat can you rebase this pull request? so it can unblock 2.4.2 release. or we can move it to 2.4.3.

[GitHub] [pulsar] sijie commented on issue #5278: Fixed reader cursor seek with disconnection

2019-11-08 Thread GitBox
sijie commented on issue #5278: Fixed reader cursor seek with disconnection URL: https://github.com/apache/pulsar/pull/5278#issuecomment-551442260 actually moved to 2.4.3 This is an automated message from the Apache Git

[GitHub] [pulsar] Anonymitaet edited a comment on issue #5593: [Docs] Add admin api docs of Pulsar Functions

2019-11-08 Thread GitBox
Anonymitaet edited a comment on issue #5593: [Docs] Add admin api docs of Pulsar Functions URL: https://github.com/apache/pulsar/pull/5593#issuecomment-551520270 As discussed just now, you and @tuteng will generate docs of admin CLI, Java Admin API, and REST API from code. The formats and

[GitHub] [pulsar] Anonymitaet commented on issue #5593: [Docs] Add admin api docs of Pulsar Functions

2019-11-08 Thread GitBox
Anonymitaet commented on issue #5593: [Docs] Add admin api docs of Pulsar Functions URL: https://github.com/apache/pulsar/pull/5593#issuecomment-551520270 As discussed just now, you and @tuteng will generate docs of admin CLI, Java Admin API, and REST API from code. The contents and

[GitHub] [pulsar] Jennifer88huang opened a new pull request #5594: [WIP][Issue 5553] [website] Add coding-guide page

2019-11-08 Thread GitBox
Jennifer88huang opened a new pull request #5594: [WIP][Issue 5553] [website] Add coding-guide page URL: https://github.com/apache/pulsar/pull/5594 Fixes #5553 ### Motivation Lack of coding guide page on Pulsar website. ### Modifications 1. Add coding guide. 2. Add

[GitHub] [pulsar] Anonymitaet commented on issue #5593: [Docs] Add admin api docs of Pulsar Functions

2019-11-08 Thread GitBox
Anonymitaet commented on issue #5593: [Docs] Add admin api docs of Pulsar Functions URL: https://github.com/apache/pulsar/pull/5593#issuecomment-551451378 @sijie it seems that the contents of this PR are similar to the ["Use" chapter in Connector

[GitHub] [pulsar] Anonymitaet edited a comment on issue #5593: [Docs] Add admin api docs of Pulsar Functions

2019-11-08 Thread GitBox
Anonymitaet edited a comment on issue #5593: [Docs] Add admin api docs of Pulsar Functions URL: https://github.com/apache/pulsar/pull/5593#issuecomment-551451378 @sijie it seems that the contents of this PR are similar to the ["Use" chapter in Connector

[GitHub] [pulsar] codelipenghui commented on issue #5571: Add epoch for connection handler to handle create producer timeout.

2019-11-08 Thread GitBox
codelipenghui commented on issue #5571: Add epoch for connection handler to handle create producer timeout. URL: https://github.com/apache/pulsar/pull/5571#issuecomment-551533067 run java8 tests This is an automated message

[GitHub] [pulsar] sijie commented on issue #5278: Fixed reader cursor seek with disconnection

2019-11-08 Thread GitBox
sijie commented on issue #5278: Fixed reader cursor seek with disconnection URL: https://github.com/apache/pulsar/pull/5278#issuecomment-551440754 Moved this to 2.5.0 since I think it requires some more discussions about the side effect of this change.

[GitHub] [pulsar] codelipenghui commented on issue #5491: [Issue 5476]Fix message deduplicate issue while using external sequence id with batch produce

2019-11-08 Thread GitBox
codelipenghui commented on issue #5491: [Issue 5476]Fix message deduplicate issue while using external sequence id with batch produce URL: https://github.com/apache/pulsar/pull/5491#issuecomment-551445030 run java8 tests

[GitHub] [pulsar] codelipenghui commented on issue #5587: [Issue 5585][pulsar-client] Fix producer Semaphore release error

2019-11-08 Thread GitBox
codelipenghui commented on issue #5587: [Issue 5585][pulsar-client] Fix producer Semaphore release error URL: https://github.com/apache/pulsar/pull/5587#issuecomment-551510814 @sijie @merlimat please help review, i have run the unit test on master branch, the test is failed.

[GitHub] [pulsar] Jennifer88huang commented on issue #5553: [website] Lack of a coding-guide page on Pulsar website

2019-11-08 Thread GitBox
Jennifer88huang commented on issue #5553: [website] Lack of a coding-guide page on Pulsar website URL: https://github.com/apache/pulsar/issues/5553#issuecomment-551593196 I've refined parts according to powered-by page: https://github.com/apache/pulsar/pull/5018 I've added

[GitHub] [pulsar] Anonymitaet commented on issue #5593: [Docs] Add admin api docs of Pulsar Functions

2019-11-08 Thread GitBox
Anonymitaet commented on issue #5593: [Docs] Add admin api docs of Pulsar Functions URL: https://github.com/apache/pulsar/pull/5593#issuecomment-551840440 @wolfstudy I've updated the contents, you can use them if my understanding is correct (click **...** > **Edit**)

[GitHub] [pulsar] huangdx0726 commented on issue #5575: fix the typo error

2019-11-08 Thread GitBox
huangdx0726 commented on issue #5575: fix the typo error URL: https://github.com/apache/pulsar/issues/5575#issuecomment-551846936 shall i try to fix this issue? This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] Jennifer88huang edited a comment on issue #5553: [website] Lack of a coding-guide page on Pulsar website

2019-11-08 Thread GitBox
Jennifer88huang edited a comment on issue #5553: [website] Lack of a coding-guide page on Pulsar website URL: https://github.com/apache/pulsar/issues/5553#issuecomment-551593196 I've refined parts according to powered-by page: https://github.com/apache/pulsar/pull/5018 I've added

[GitHub] [pulsar] huangdx0726 opened a new pull request #5596: [Issue 5575] fix typo in BrokersBase file

2019-11-08 Thread GitBox
huangdx0726 opened a new pull request #5596: [Issue 5575] fix typo in BrokersBase file URL: https://github.com/apache/pulsar/pull/5596 ## [Issue 5575] fix typo Fixes #5575 ### Motivation fix typo ### Modifications change getOwnedNamespaes to getOwnedNamespaces.

[GitHub] [pulsar] Jennifer88huang commented on issue #5575: fix the typo error

2019-11-08 Thread GitBox
Jennifer88huang commented on issue #5575: fix the typo error URL: https://github.com/apache/pulsar/issues/5575#issuecomment-551850693 @huangdx0726 Sure, please go ahead, and thanks for your contribution. This is an automated

[GitHub] [pulsar] huangdx0726 closed pull request #5596: [Issue 5575] fix typo in BrokersBase file

2019-11-08 Thread GitBox
huangdx0726 closed pull request #5596: [Issue 5575] fix typo in BrokersBase file URL: https://github.com/apache/pulsar/pull/5596 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar] huangdx0726 opened a new pull request #5596: [Issue 5575] fix typo in BrokersBase file

2019-11-08 Thread GitBox
huangdx0726 opened a new pull request #5596: [Issue 5575] fix typo in BrokersBase file URL: https://github.com/apache/pulsar/pull/5596 ## [Issue 5575] fix typo Fixes #5575 ### Motivation fix typo ### Modifications change getOwnedNamespaes to getOwnedNamespaces.