[GitHub] [pulsar] eolivelli commented on pull request #10572: [Tests] Reduce flakiness of BacklogQuotaManagerTest

2021-05-13 Thread GitBox
eolivelli commented on pull request #10572: URL: https://github.com/apache/pulsar/pull/10572#issuecomment-840558143 it looks like that the test you wanted to fix failed on CI https://github.com/apache/pulsar/pull/10572/checks?check_run_id=2575259667

[GitHub] [pulsar] martin-macrometa opened a new issue #10575: Pulsar c++ subscriber receiving messages retroactively

2021-05-13 Thread GitBox
martin-macrometa opened a new issue #10575: URL: https://github.com/apache/pulsar/issues/10575 **Describe the bug** A clear and concise description of what the bug is. **To Reproduce** Steps to reproduce the behavior: 1. Deploy a cluster (e.g. `cluster0`) 2. On

[GitHub] [pulsar] Shoothzj opened a new pull request #10576: [Doc] Fix two link error in pulsar io-overview

2021-05-13 Thread GitBox
Shoothzj opened a new pull request #10576: URL: https://github.com/apache/pulsar/pull/10576 It is simple, just fix two link error. ![image](https://user-images.githubusercontent.com/12933197/118137123-6d024b80-b437-11eb-8c64-a2d4d7abd42e.png) -- This is an automated message

[GitHub] [pulsar] gaoran10 commented on a change in pull request #10573: [Schema] Add schemaType field in SchemaHash

2021-05-13 Thread GitBox
gaoran10 commented on a change in pull request #10573: URL: https://github.com/apache/pulsar/pull/10573#discussion_r631937227 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/schema/SchemaTest.java ## @@ -556,4 +558,39 @@ public void testDeleteTopicAndSchema()

[GitHub] [pulsar] eolivelli merged pull request #10567: [Tests] Limit Pulsar Functions Java runtime to 128MB of RAM in int tests

2021-05-13 Thread GitBox
eolivelli merged pull request #10567: URL: https://github.com/apache/pulsar/pull/10567 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [pulsar] linlinnn commented on issue #10577: CLI tools should have a command for showing the currently running/installed version.

2021-05-13 Thread GitBox
linlinnn commented on issue #10577: URL: https://github.com/apache/pulsar/issues/10577#issuecomment-840671903 @bdunn313 We already have this feature in [PR-9975](https://github.com/apache/pulsar/pull/9975) which will be released on 2.7.2. -- This is an automated message from the Apache

[GitHub] [pulsar] codelipenghui commented on a change in pull request #10573: [Schema] Add schemaType field in SchemaHash

2021-05-13 Thread GitBox
codelipenghui commented on a change in pull request #10573: URL: https://github.com/apache/pulsar/pull/10573#discussion_r631798502 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/schema/SchemaTest.java ## @@ -556,4 +558,39 @@ public void testDeleteTopicAndSchema()

[GitHub] [pulsar-client-go] EAHITechnology opened a new pull request #517: Check ParseTopicName() return err

2021-05-13 Thread GitBox
EAHITechnology opened a new pull request #517: URL: https://github.com/apache/pulsar-client-go/pull/517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] [pulsar] linlinnn commented on issue #10577: CLI tools should have a command for showing the currently running/installed version.

2021-05-13 Thread GitBox
linlinnn commented on issue #10577: URL: https://github.com/apache/pulsar/issues/10577#issuecomment-840653183 Related [PR-9975](https://github.com/apache/pulsar/pull/9975) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar] lhotari commented on pull request #10572: [Tests] Reduce flakiness of BacklogQuotaManagerTest

2021-05-13 Thread GitBox
lhotari commented on pull request #10572: URL: https://github.com/apache/pulsar/pull/10572#issuecomment-840516778 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] lhotari removed a comment on pull request #10567: [Tests] Limit Pulsar Functions Java runtime to 128MB of RAM in int tests

2021-05-13 Thread GitBox
lhotari removed a comment on pull request #10567: URL: https://github.com/apache/pulsar/pull/10567#issuecomment-840430925 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] eolivelli commented on a change in pull request #10573: [Schema] Add schemaType field in SchemaHash

2021-05-13 Thread GitBox
eolivelli commented on a change in pull request #10573: URL: https://github.com/apache/pulsar/pull/10573#discussion_r631803263 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/schema/SchemaTest.java ## @@ -556,4 +558,39 @@ public void testDeleteTopicAndSchema()

[GitHub] [pulsar] lhotari commented on pull request #10572: [Tests] Reduce flakiness of BacklogQuotaManagerTest

2021-05-13 Thread GitBox
lhotari commented on pull request #10572: URL: https://github.com/apache/pulsar/pull/10572#issuecomment-840661374 > it looks like that the test you wanted to fix failed on CI @eolivelli Thanks for pointing that out. I made some more changes in the PR to address flakiness. In

[GitHub] [pulsar] eolivelli commented on pull request #10550: Apache Pulsar 2.7.2 release notes

2021-05-13 Thread GitBox
eolivelli commented on pull request #10550: URL: https://github.com/apache/pulsar/pull/10550#issuecomment-840532007 @Anonymitaet can you please review again ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] lhotari commented on issue #6054: Catastrophic frequent random subscription freezes, especially on high-traffic topics.

2021-05-13 Thread GitBox
lhotari commented on issue #6054: URL: https://github.com/apache/pulsar/issues/6054#issuecomment-840535875 > In the unhealthy case, we don't see that at all. I'm not even seeing activity on that thread. The only activity in the logs that I'm seeing on that broker is this:

[GitHub] [pulsar] bdunn313 commented on issue #10577: CLI tools should have a command for showing the currently running/installed version.

2021-05-13 Thread GitBox
bdunn313 commented on issue #10577: URL: https://github.com/apache/pulsar/issues/10577#issuecomment-840666582 @linlinnn I tried to figure out if this was already tracked as an issue, but I didn't find this one! Should I close this as a duplicate? -- This is an automated message from the

[GitHub] [pulsar] eolivelli commented on pull request #10574: [Issue 905][api][pulsar-client] add serializable token class

2021-05-13 Thread GitBox
eolivelli commented on pull request #10574: URL: https://github.com/apache/pulsar/pull/10574#issuecomment-840603762 thank you @atezs82 We will review this patch @lhotari PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pulsar] lhotari removed a comment on pull request #10566: [Tests] Add workaround for failing PulsarFunctionsJavaProcessTest on JDK11

2021-05-13 Thread GitBox
lhotari removed a comment on pull request #10566: URL: https://github.com/apache/pulsar/pull/10566#issuecomment-840430949 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] eolivelli commented on a change in pull request #10573: [Schema] Add schemaType field in SchemaHash

2021-05-13 Thread GitBox
eolivelli commented on a change in pull request #10573: URL: https://github.com/apache/pulsar/pull/10573#discussion_r631764848 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/schema/SchemaTest.java ## @@ -556,4 +558,39 @@ public void testDeleteTopicAndSchema()

[GitHub] [pulsar] freeznet commented on pull request #10563: [fix #9640] remove `pulsar-client-admin-api` dependency : `pulsar-client-original`

2021-05-13 Thread GitBox
freeznet commented on pull request #10563: URL: https://github.com/apache/pulsar/pull/10563#issuecomment-840523402 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[pulsar] branch master updated (1926dee -> 61dc9e3)

2021-05-13 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 1926dee [Issue 10522] support mock zookeeper with different session (#10530) add 61dc9e3 [Tests] Limit

[GitHub] [pulsar] eolivelli commented on pull request #10540: Apache Pulsar 2.7.2 blog page

2021-05-13 Thread GitBox
eolivelli commented on pull request #10540: URL: https://github.com/apache/pulsar/pull/10540#issuecomment-840532264 @Anonymitaet I will ping you when I am done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] david-streamlio commented on pull request #10566: [Tests] Add workaround for failing PulsarFunctionsJavaProcessTest on JDK11

2021-05-13 Thread GitBox
david-streamlio commented on pull request #10566: URL: https://github.com/apache/pulsar/pull/10566#issuecomment-840663249 LGTM +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] atezs82 opened a new pull request #10574: [Issue 905][api][pulsar-client] add serializable token class

2021-05-13 Thread GitBox
atezs82 opened a new pull request #10574: URL: https://github.com/apache/pulsar/pull/10574 ### Motivation When trying to authenticate Pulsar in distributed systems (a very good example of this is the Spark connector, see here:

[GitHub] [pulsar] bdunn313 opened a new issue #10577: CLI tools should have a command for showing the currently running/installed version.

2021-05-13 Thread GitBox
bdunn313 opened a new issue #10577: URL: https://github.com/apache/pulsar/issues/10577 **Is your enhancement request related to a problem? Please describe.** When using the pulsar suite of CLI tools, there is no way to find the currently installed version of the tool. If one exists, the

[GitHub] [pulsar] david-streamlio commented on pull request #10576: [Doc] Fix two link error in pulsar io-overview

2021-05-13 Thread GitBox
david-streamlio commented on pull request #10576: URL: https://github.com/apache/pulsar/pull/10576#issuecomment-840661797 LGTM +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] bdunn313 opened a new issue #10578: Relative paths do not work for pulsar-admin schema upload --filename flag

2021-05-13 Thread GitBox
bdunn313 opened a new issue #10578: URL: https://github.com/apache/pulsar/issues/10578 **Describe the bug** Currently, when using the `pulsar-admin schemas upload` command to upload a schema via a file with the `--filename` flag, an exception is thrown because the file cannot be

[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request #517: Check ParseTopicName() return err

2021-05-13 Thread GitBox
cckellogg commented on a change in pull request #517: URL: https://github.com/apache/pulsar-client-go/pull/517#discussion_r631928139 ## File path: pulsar/consumer_regex.go ## @@ -383,11 +382,14 @@ func subscriber(c *client, topics []string, opts ConsumerOptions, ch chan

[GitHub] [pulsar] lhotari removed a comment on pull request #10572: [Tests] Reduce flakiness of BacklogQuotaManagerTest

2021-05-13 Thread GitBox
lhotari removed a comment on pull request #10572: URL: https://github.com/apache/pulsar/pull/10572#issuecomment-840516778 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] lhotari commented on pull request #10566: [Tests] Add workaround for failing PulsarFunctionsJavaProcessTest on JDK11

2021-05-13 Thread GitBox
lhotari commented on pull request #10566: URL: https://github.com/apache/pulsar/pull/10566#issuecomment-840739431 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[pulsar-client-go] branch master updated (203f2f6 -> 6426d39)

2021-05-13 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git. from 203f2f6 use pulsar-test-infra/pulsarbot (#487) add 6426d39 Make PartitionsAutoDiscoveryInterval

[GitHub] [pulsar-client-go] merlimat merged pull request #514: Make PartitionsAutoDiscoveryInterval configurable

2021-05-13 Thread GitBox
merlimat merged pull request #514: URL: https://github.com/apache/pulsar-client-go/pull/514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [pulsar] lhotari merged pull request #10566: [Tests] Add workaround for failing PulsarFunctionsJavaProcessTest on JDK11

2021-05-13 Thread GitBox
lhotari merged pull request #10566: URL: https://github.com/apache/pulsar/pull/10566 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

svn commit: r47685 - /dev/pulsar/pulsar-client-go/ /release/pulsar/pulsar-client-go-0.5.0/

2021-05-13 Thread mmerli
Author: mmerli Date: Thu May 13 18:19:40 2021 New Revision: 47685 Log: Pulsar Client Go release 0.5.0 Added: release/pulsar/pulsar-client-go-0.5.0/ - copied from r47684, dev/pulsar/pulsar-client-go/ Removed: dev/pulsar/pulsar-client-go/

[GitHub] [pulsar] eolivelli merged pull request #10572: [Tests] Reduce flakiness of BacklogQuotaManagerTest

2021-05-13 Thread GitBox
eolivelli merged pull request #10572: URL: https://github.com/apache/pulsar/pull/10572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[pulsar] branch master updated: Expose topic-level averageMsgSize to metrics (#10553)

2021-05-13 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new cb636b7 Expose topic-level averageMsgSize

[pulsar] branch master updated (cb636b7 -> 4f88f5a)

2021-05-13 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from cb636b7 Expose topic-level averageMsgSize to metrics (#10553) add 4f88f5a Removed AspectJ based metrics

[pulsar-client-go] tag v0.5.0 created (now aa1c9a3)

2021-05-13 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to tag v0.5.0 in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git. at aa1c9a3 (commit) No new revisions were added by this update.

[GitHub] [pulsar] lhotari opened a new pull request #10580: Switch to use JDK11 for CI and Docker images

2021-05-13 Thread GitBox
lhotari opened a new pull request #10580: URL: https://github.com/apache/pulsar/pull/10580 ### Motivation There has been discussions on the Pulsar dev mailing list and in Pulsar Community meetings about making the switch to use JDK11 for CI and for the Pulsar docker images in 2.8.0

[GitHub] [pulsar] aahmed-se opened a new pull request #10581: Update vcpkg.json package list

2021-05-13 Thread GitBox
aahmed-se opened a new pull request #10581: URL: https://github.com/apache/pulsar/pull/10581 * Restrict dlfcn-win32 to windows env * Add additonal components *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a

[GitHub] [pulsar] bdunn313 opened a new issue #10579: Sinks API endpoint `getSinkInfo` does not properly return a list of topic inputs

2021-05-13 Thread GitBox
bdunn313 opened a new issue #10579: URL: https://github.com/apache/pulsar/issues/10579 **Describe the bug** Currently, the [documented response shape](https://pulsar.apache.org/sink-rest-api/?version=2.7.1#operation/getSinkInfo) for `getSinkInfo` lists a node called `inputs` that

[GitHub] [pulsar] merlimat commented on issue #9731: Pulsar C++ Client Library not working on Alpine Linux

2021-05-13 Thread GitBox
merlimat commented on issue #9731: URL: https://github.com/apache/pulsar/issues/9731#issuecomment-840724219 While it's not shipped as part of the official releases (though it would be a good idea to do so), we do have scripts to generate Alpine APK packages and also Python wheel files

[pulsar] branch master updated: Add workaround for failing PulsarFunctionsJavaProcessTest on JDK11 (#10566)

2021-05-13 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 5f09de8 Add workaround for failing

svn commit: r47686 - in /release/pulsar: pulsar-client-go-0.1.0/ pulsar-client-go-0.1.1/ pulsar-client-go-0.2.0/ pulsar-client-go-0.3.0/ pulsar-client-go-0.4.0/

2021-05-13 Thread mmerli
Author: mmerli Date: Thu May 13 18:20:54 2021 New Revision: 47686 Log: Remoed older Pulsar-client-go releases Removed: release/pulsar/pulsar-client-go-0.1.0/ release/pulsar/pulsar-client-go-0.1.1/ release/pulsar/pulsar-client-go-0.2.0/ release/pulsar/pulsar-client-go-0.3.0/

[GitHub] [pulsar] eolivelli merged pull request #10553: Expose topic-level averageMsgSize to metrics

2021-05-13 Thread GitBox
eolivelli merged pull request #10553: URL: https://github.com/apache/pulsar/pull/10553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[pulsar] branch master updated (61dc9e3 -> 3831cd1)

2021-05-13 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 61dc9e3 [Tests] Limit Pulsar Functions Java runtime to 128MB of RAM in integration tests (#10567) add

[GitHub] [pulsar] eolivelli merged pull request #10533: Removed AspectJ based metrics for ZooKeeper

2021-05-13 Thread GitBox
eolivelli merged pull request #10533: URL: https://github.com/apache/pulsar/pull/10533 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [pulsar] dlg99 commented on pull request #10498: SinkContext: ability to seek/pause/resume consumer for a topic

2021-05-13 Thread GitBox
dlg99 commented on pull request #10498: URL: https://github.com/apache/pulsar/pull/10498#issuecomment-840821323 @jerrypeng @eolivelli I did the changes that @jerrypeng requested, also figured that `MultiTopicsConsumerImpl` (and, transitively, `PatternMultiTopicsConsumerImpl`) need special

[pulsar-client-go] annotated tag v0.5.0 updated (aa1c9a3 -> 6702229)

2021-05-13 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to annotated tag v0.5.0 in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git. *** WARNING: tag v0.5.0 was modified! *** from aa1c9a3 (commit) to 6702229 (tag) tagging

[GitHub] [pulsar] bdunn313 closed issue #10577: CLI tools should have a command for showing the currently running/installed version.

2021-05-13 Thread GitBox
bdunn313 closed issue #10577: URL: https://github.com/apache/pulsar/issues/10577 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [pulsar] bdunn313 commented on issue #10577: CLI tools should have a command for showing the currently running/installed version.

2021-05-13 Thread GitBox
bdunn313 commented on issue #10577: URL: https://github.com/apache/pulsar/issues/10577#issuecomment-840729606 > @bdunn313 We already have this feature in [PR-9975](https://github.com/apache/pulsar/pull/9975) which will be released on 2.7.2. Awesome! Since this is already tracked in

[GitHub] [pulsar] bharanic-dev opened a new issue #10582: Unable to build RPM packages

2021-05-13 Thread GitBox
bharanic-dev opened a new issue #10582: URL: https://github.com/apache/pulsar/issues/10582 **Describe the bug** I am unable to build the RPM packages on a MAC OS, using the steps described in the link:

[GitHub] [pulsar] merlimat commented on pull request #10574: [Issue 905][api][pulsar-client] add serializable token class

2021-05-13 Thread GitBox
merlimat commented on pull request #10574: URL: https://github.com/apache/pulsar/pull/10574#issuecomment-840864929 @atezs82 I'd rather not introduce a new auth provider here duplicating most of the code. Is there a way that this can be fixed/enhanced within the context of the existing

[GitHub] [pulsar] linlinnn closed issue #10570: Flaky-test: BacklogQuotaManagerTest.testConsumerBacklogEvictionWithAckTimeQuota

2021-05-13 Thread GitBox
linlinnn closed issue #10570: URL: https://github.com/apache/pulsar/issues/10570 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [pulsar] merlimat commented on a change in pull request #10574: [Issue 905][api][pulsar-client] add serializable token class

2021-05-13 Thread GitBox
merlimat commented on a change in pull request #10574: URL: https://github.com/apache/pulsar/pull/10574#discussion_r632136929 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/auth/SerializableAuthenticationToken.java ## @@ -0,0 +1,108 @@ +/** + *

[GitHub] [pulsar] devinbost commented on issue #6054: Catastrophic frequent random subscription freezes, especially on high-traffic topics.

2021-05-13 Thread GitBox
devinbost commented on issue #6054: URL: https://github.com/apache/pulsar/issues/6054#issuecomment-840891270 @lhotari I've attached thread dumps from two of the brokers that were exhibiting symptoms.

[GitHub] [pulsar] codelipenghui merged pull request #10580: Switch to use JDK11 for CI and Docker images

2021-05-13 Thread GitBox
codelipenghui merged pull request #10580: URL: https://github.com/apache/pulsar/pull/10580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[pulsar] branch master updated (5f09de8 -> eee622c)

2021-05-13 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 5f09de8 Add workaround for failing PulsarFunctionsJavaProcessTest on JDK11 (#10566) add eee622c Switch to

[pulsar] branch master updated (eee622c -> 52243b3)

2021-05-13 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from eee622c Switch to use JDK11 for CI and Docker images (#10580) add 52243b3 [Doc] Fix two link error in pulsar

[GitHub] [pulsar] codelipenghui merged pull request #10576: [Doc] Fix two link error in pulsar io-overview

2021-05-13 Thread GitBox
codelipenghui merged pull request #10576: URL: https://github.com/apache/pulsar/pull/10576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [pulsar] zymap merged pull request #10550: Apache Pulsar 2.7.2 release notes

2021-05-13 Thread GitBox
zymap merged pull request #10550: URL: https://github.com/apache/pulsar/pull/10550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[pulsar] branch master updated (52243b3 -> 11dcb0d)

2021-05-13 Thread yong
This is an automated email from the ASF dual-hosted git repository. yong pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 52243b3 [Doc] Fix two link error in pulsar io-overview (#10576) add 11dcb0d Apache Pulsar 2.7.2 release notes

[GitHub] [pulsar] devinbost opened a new pull request #10583: Synchronize OpAddEntry.safeRun() to prevent race on updating lastConfirmedEntry

2021-05-13 Thread GitBox
devinbost opened a new pull request #10583: URL: https://github.com/apache/pulsar/pull/10583 I noticed that OpAddEntry.safeRun() is modifying a volatile field (`ml.lastConfirmedEntry`) here:

[GitHub] [pulsar] devinbost commented on pull request #10583: Synchronize OpAddEntry.safeRun() to prevent race on updating lastConfirmedEntry

2021-05-13 Thread GitBox
devinbost commented on pull request #10583: URL: https://github.com/apache/pulsar/pull/10583#issuecomment-840899701 Please review @codelipenghui @rdhabalia @lhotari -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] codelipenghui commented on a change in pull request #10573: [Schema] Add schemaType field in SchemaHash

2021-05-13 Thread GitBox
codelipenghui commented on a change in pull request #10573: URL: https://github.com/apache/pulsar/pull/10573#discussion_r632170419 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/schema/SchemaTest.java ## @@ -556,4 +558,39 @@ public void testDeleteTopicAndSchema()

[GitHub] [pulsar] merlimat commented on pull request #10583: Synchronize OpAddEntry.safeRun() to prevent race on updating lastConfirmedEntry

2021-05-13 Thread GitBox
merlimat commented on pull request #10583: URL: https://github.com/apache/pulsar/pull/10583#issuecomment-840944024 > As I have mentioned earlier, if two threads are both reading and writing to a shared variable, then using the volatile keyword for that is not enough. You need to use a

[GitHub] [pulsar] Anonymitaet commented on pull request #7555: Modify the log level of functions and move the java_instance_log4j2.xml file from the jar package to the conf directory

2021-05-13 Thread GitBox
Anonymitaet commented on pull request #7555: URL: https://github.com/apache/pulsar/pull/7555#issuecomment-840954757 @g0715158 thanks for your code work. Does this need to update docs? If so, could you please help add docs accordingly? Then I can help review, thanks -- This is an

[GitHub] [pulsar] Anonymitaet commented on pull request #10540: Apache Pulsar 2.7.2 blog page

2021-05-13 Thread GitBox
Anonymitaet commented on pull request #10540: URL: https://github.com/apache/pulsar/pull/10540#issuecomment-840919347 @eolivelli OK -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] skyrocknroll commented on pull request #10583: Synchronize OpAddEntry.safeRun() to prevent race on updating lastConfirmedEntry

2021-05-13 Thread GitBox
skyrocknroll commented on pull request #10583: URL: https://github.com/apache/pulsar/pull/10583#issuecomment-840924787 @merlimat As I have mentioned earlier, if two threads are both reading and writing to a shared variable, then using the volatile keyword for that is not enough. You need

[GitHub] [pulsar] devinbost closed pull request #10583: Synchronize OpAddEntry.safeRun() to prevent race on updating lastConfirmedEntry

2021-05-13 Thread GitBox
devinbost closed pull request #10583: URL: https://github.com/apache/pulsar/pull/10583 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [pulsar] devinbost commented on pull request #10583: Synchronize OpAddEntry.safeRun() to prevent race on updating lastConfirmedEntry

2021-05-13 Thread GitBox
devinbost commented on pull request #10583: URL: https://github.com/apache/pulsar/pull/10583#issuecomment-840976438 @merlimat I took another look at the code, and you're right. I'll close this PR. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] devinbost commented on issue #6054: Catastrophic frequent random subscription freezes, especially on high-traffic topics.

2021-05-13 Thread GitBox
devinbost commented on issue #6054: URL: https://github.com/apache/pulsar/issues/6054#issuecomment-840894974 I noticed that in almost every case where the broker is getting a SEND command, it's producing a SEND_RECEIPT command: ``` $ cat messages_broker10.log | grep 'Received cmd

[GitHub] [pulsar] linlinnn closed issue #10569: Flaky-test: BacklogQuotaManagerTest.testTriggerBacklogQuotaSizeWithReader

2021-05-13 Thread GitBox
linlinnn closed issue #10569: URL: https://github.com/apache/pulsar/issues/10569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [pulsar] merlimat commented on pull request #10583: Synchronize OpAddEntry.safeRun() to prevent race on updating lastConfirmedEntry

2021-05-13 Thread GitBox
merlimat commented on pull request #10583: URL: https://github.com/apache/pulsar/pull/10583#issuecomment-840916995 > Since we don't have a mutex while updating lastConfirmedEntry, it looks like that could create a concurrency issue if another thread races on the update. Since the

[GitHub] [pulsar-client-go] EAHITechnology commented on a change in pull request #517: Check ParseTopicName() return err

2021-05-13 Thread GitBox
EAHITechnology commented on a change in pull request #517: URL: https://github.com/apache/pulsar-client-go/pull/517#discussion_r632281658 ## File path: pulsar/test_helper.go ## @@ -153,15 +153,24 @@ func deleteTopic(topic string) error { func topicStats(topic string)

[GitHub] [pulsar] eolivelli merged pull request #10557: Use Message.getReaderSchema() in Pulsar IO Sinks when possible

2021-05-13 Thread GitBox
eolivelli merged pull request #10557: URL: https://github.com/apache/pulsar/pull/10557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [pulsar-client-go] EAHITechnology commented on a change in pull request #517: Check ParseTopicName() return err

2021-05-13 Thread GitBox
EAHITechnology commented on a change in pull request #517: URL: https://github.com/apache/pulsar-client-go/pull/517#discussion_r632283014 ## File path: pulsar/consumer_regex.go ## @@ -383,11 +382,14 @@ func subscriber(c *client, topics []string, opts ConsumerOptions, ch chan

[GitHub] [pulsar-client-go] EAHITechnology commented on a change in pull request #517: Check ParseTopicName() return err

2021-05-13 Thread GitBox
EAHITechnology commented on a change in pull request #517: URL: https://github.com/apache/pulsar-client-go/pull/517#discussion_r632282800 ## File path: pulsar/producer_impl.go ## @@ -88,12 +88,17 @@ func newProducer(client *client, options *ProducerOptions) (*producer, error)

[GitHub] [pulsar-client-go] EAHITechnology commented on a change in pull request #517: Check ParseTopicName() return err

2021-05-13 Thread GitBox
EAHITechnology commented on a change in pull request #517: URL: https://github.com/apache/pulsar-client-go/pull/517#discussion_r632282548 ## File path: pulsar/producer_impl.go ## @@ -88,12 +88,17 @@ func newProducer(client *client, options *ProducerOptions) (*producer, error)

[GitHub] [pulsar-client-go] EAHITechnology commented on a change in pull request #517: Check ParseTopicName() return err

2021-05-13 Thread GitBox
EAHITechnology commented on a change in pull request #517: URL: https://github.com/apache/pulsar-client-go/pull/517#discussion_r632284185 ## File path: pulsar/producer_impl.go ## @@ -88,12 +88,17 @@ func newProducer(client *client, options *ProducerOptions) (*producer, error)

[pulsar] branch master updated: Use Message.getReaderSchema() in Pulsar IO Sinks when possible (#10557)

2021-05-13 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 90117b2 Use Message.getReaderSchema() in

[GitHub] [pulsar-client-go] EAHITechnology commented on a change in pull request #517: Check ParseTopicName() return err

2021-05-13 Thread GitBox
EAHITechnology commented on a change in pull request #517: URL: https://github.com/apache/pulsar-client-go/pull/517#discussion_r632280079 ## File path: pulsar/producer_impl.go ## @@ -88,12 +88,17 @@ func newProducer(client *client, options *ProducerOptions) (*producer, error)

[GitHub] [pulsar] devinbost opened a new issue #6054: Catastrophic frequent random subscription freezes, especially on high-traffic topics.

2021-05-13 Thread GitBox
devinbost opened a new issue #6054: URL: https://github.com/apache/pulsar/issues/6054 **Describe the bug** Topics randomly freeze, causing catastrophic topic outages on a weekly (or more frequent) basis. This has been an issue as long as my team has used Pulsar, and it's been

[GitHub] [pulsar] eolivelli commented on issue #6054: Catastrophic frequent random subscription freezes, especially on high-traffic topics.

2021-05-13 Thread GitBox
eolivelli commented on issue #6054: URL: https://github.com/apache/pulsar/issues/6054#issuecomment-840344473 @rdhabalia it looks like the issue is still to be kept open, as @devinbost is giving more information -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [pulsar] wangjialing218 commented on pull request #10552: get function cluster from broker config when start function worker with broker

2021-05-13 Thread GitBox
wangjialing218 commented on pull request #10552: URL: https://github.com/apache/pulsar/pull/10552#issuecomment-840358137 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] eolivelli commented on pull request #7266: [pulsar-broker] Dispatch batch messages according consumer permits

2021-05-13 Thread GitBox
eolivelli commented on pull request #7266: URL: https://github.com/apache/pulsar/pull/7266#issuecomment-840376961 @Anonymitaet I believe that this is only a bugfix, so need to add particular documentation. -- This is an automated message from the Apache Git Service. To respond to the

[pulsar] 38/46: AutoConsumeSchema: handle schema NONE as BYTES (#10277)

2021-05-13 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a commit to branch 2.7.2_ds_tmp in repository https://gitbox.apache.org/repos/asf/pulsar.git commit c73cdae681ff1326ae7717bb6d27c01106ac188f Author: Enrico Olivelli AuthorDate: Tue Apr 20 12:35:37 2021 +0200

[pulsar] 39/46: fix build

2021-05-13 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a commit to branch 2.7.2_ds_tmp in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 53e8c3e5eeebfea9d43dd81c44e14d9638fd63e7 Author: Enrico Olivelli AuthorDate: Wed May 12 18:32:18 2021 +0200

[pulsar] 36/46: PIP-85 Add Schema Information to Message in Java Client API (#10476)

2021-05-13 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a commit to branch 2.7.2_ds_tmp in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 4acd720eb2aea434a9839c6e738943a313e87b20 Author: Enrico Olivelli AuthorDate: Wed May 12 12:33:42 2021 +0200

[pulsar] 42/46: [Broker] Make Persistent*DispatcherMultipleConsumers.readMoreEntries synchronized (#10413)

2021-05-13 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a commit to branch 2.7.2_ds_tmp in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 83d10a140f220626eaa5360a62d4b78bacb63e1c Author: Lari Hotari AuthorDate: Wed Apr 28 19:57:54 2021 +0300

[pulsar] 40/46: Add streaming dispatcher. (#9056)

2021-05-13 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a commit to branch 2.7.2_ds_tmp in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 7e57cbe5de2e52b37706170e3c4ec1066cd9585b Author: Marvin Cai AuthorDate: Mon Feb 1 20:02:50 2021 -0800 Add

[pulsar] 43/46: [pulsar-broker] Dispatch messaages to consumer with permits (#10417)

2021-05-13 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a commit to branch 2.7.2_ds_tmp in repository https://gitbox.apache.org/repos/asf/pulsar.git commit a26de54f1bfe68fdd3d2084dc4505fceb768f96c Author: Rajan Dhabalia AuthorDate: Tue May 11 15:31:50 2021 -0700

[pulsar] 23/46: Add presto password authenticators plugin to enable password auth in Pulsar SQL

2021-05-13 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a commit to branch 2.7.2_ds_tmp in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 6fe93f50a8c1b6d63078e2a774d6ece77aec013f Author: Chris Bartholomew AuthorDate: Mon Feb 1 16:58:43 2021 -0500

[pulsar] 21/46: Enable Conscrypt for Jetty in the Broker and in the Proxy (#10541)

2021-05-13 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a commit to branch 2.7.2_ds_tmp in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 5bc23c6aead321fa1c6142d96b4563a2243e108a Author: Lari Hotari AuthorDate: Wed May 12 07:02:56 2021 +0300

[pulsar] 26/46: Pulsar IO: Allow to develop Sinks that support Schema but without setting it at build time (Sink) (#10034)

2021-05-13 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a commit to branch 2.7.2_ds_tmp in repository https://gitbox.apache.org/repos/asf/pulsar.git commit b116efd0944855174b422e43cecd13822c148dc6 Author: Enrico Olivelli AuthorDate: Sun Apr 11 16:44:33 2021 +0200

[pulsar] 25/46: GenericObject - support KeyValue in Message#getValue() (#10107)

2021-05-13 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a commit to branch 2.7.2_ds_tmp in repository https://gitbox.apache.org/repos/asf/pulsar.git commit ab3caca169c35b2ce189d84c6b3834023bfb2e90 Author: Enrico Olivelli AuthorDate: Fri Apr 9 19:29:00 2021 +0200

[pulsar] 20/46: Bump Debezium version to latest in series

2021-05-13 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a commit to branch 2.7.2_ds_tmp in repository https://gitbox.apache.org/repos/asf/pulsar.git commit e275813efc7bc1af4d5f16d1e6bca27d48c71a4a Author: Chris Bartholomew AuthorDate: Sat Feb 6 11:26:38 2021 -0500

[pulsar] 22/46: Fix checkstyle

2021-05-13 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a commit to branch 2.7.2_ds_tmp in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 4d1a8d79200bae83d0d26f530c46ef87d4fd0081 Author: Enrico Olivelli AuthorDate: Wed May 12 11:50:43 2021 +0200

[pulsar] 24/46: Implement GenericObject - Allow GenericRecord to wrap any Java Object (#10057)

2021-05-13 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a commit to branch 2.7.2_ds_tmp in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 23b2859389910698779c0a6d726c496429fc05f9 Author: Enrico Olivelli AuthorDate: Thu Apr 8 03:14:46 2021 +0200

[pulsar] 29/46: Java Client: MessageImpl - ensure that AutoConsumeSchema downloaded the schema before decoding the payload (#10248)

2021-05-13 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a commit to branch 2.7.2_ds_tmp in repository https://gitbox.apache.org/repos/asf/pulsar.git commit ff5924492d784fb69d795d694e3e58183dd989c9 Author: Enrico Olivelli AuthorDate: Mon Apr 19 14:18:29 2021 +0200

  1   2   >