[GitHub] [pulsar-dotpulsar] kandersen82 commented on a diff in pull request #149: Producer access mode fixes

2023-04-24 Thread via GitHub
kandersen82 commented on code in PR #149: URL: https://github.com/apache/pulsar-dotpulsar/pull/149#discussion_r1174934905 ## src/DotPulsar/Internal/Abstractions/IChannel.cs: ## @@ -23,6 +23,7 @@ public interface IChannel void ClosedByServer(); void

[GitHub] [pulsar] jiangpengcheng opened a new issue, #20173: [Bug] Python instance doesn't install dependency from requirements.txt

2023-04-24 Thread via GitHub
jiangpengcheng opened a new issue, #20173: URL: https://github.com/apache/pulsar/issues/20173 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version master, commit id:

[GitHub] [pulsar] AnonHxy commented on pull request #20152: [fix][admin] Fix examine messages if total message is zero

2023-04-24 Thread via GitHub
AnonHxy commented on PR #20152: URL: https://github.com/apache/pulsar/pull/20152#issuecomment-1519909875 > @AnonHxy hi, after check the intention of this admin interface. i think we can return a meaningful response directly without return exception to the caller. like if there is no

[pulsar] 01/02: [improve] Allow to build and push multi-arch Docker images (#19432)

2023-04-24 Thread zike
This is an automated email from the ASF dual-hosted git repository. zike pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 2fa28f427b8e5e05b4d0a233cc68f62d5bbe34d7 Author: Matteo Merli AuthorDate: Sat Apr 22 13:28:53 2023 -0700

[pulsar] branch branch-3.0 updated (e3e1c08e513 -> 89e4d46f4a5)

2023-04-24 Thread zike
This is an automated email from the ASF dual-hosted git repository. zike pushed a change to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git from e3e1c08e513 Revert "[improve][broker] Optimization protobuf code in the bucket delayed tracker (#20158)" new

[pulsar] 02/02: [fix] [broker] Make `LeastResourceUsageWithWeight` thread safe (#20159)

2023-04-24 Thread zike
This is an automated email from the ASF dual-hosted git repository. zike pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 89e4d46f4a5585ac126a03aa298020203100ad71 Author: lifepuzzlefun AuthorDate: Sun Apr 23 11:27:48 2023 +0800 [fix]

[pulsar] branch branch-3.0 updated: Revert "[fix][broker] Fix entry filter feature for the non-persistent topic (#20141)"

2023-04-24 Thread cbornet
This is an automated email from the ASF dual-hosted git repository. cbornet pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.0 by this push: new e8261fcef8d Revert "[fix][broker] Fix

[GitHub] [pulsar] asafm commented on issue #19611: PIP-249: Pulsar website redesign

2023-04-24 Thread via GitHub
asafm commented on issue #19611: URL: https://github.com/apache/pulsar/issues/19611#issuecomment-1520014420 This is issue is still being worked on -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar-dotpulsar] toneill818 commented on pull request #146: Partitioned Topic Consumer Support

2023-04-24 Thread via GitHub
toneill818 commented on PR #146: URL: https://github.com/apache/pulsar-dotpulsar/pull/146#issuecomment-1520060415 @blankensteiner Go ahead and create a new release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar] cbornet commented on pull request #20086: [fix][broker] Ensure previous delayed index be removed from snapshotSegmentLastIndexTable & Make load operate asynchronous

2023-04-24 Thread via GitHub
cbornet commented on PR #20086: URL: https://github.com/apache/pulsar/pull/20086#issuecomment-1519794136 This has been cherry-picked to branch-3.0 despite the code freeze. Do you feel strongly that this needs to be in the 3.0 release ? Otherwise we should revert this and delay it

[GitHub] [pulsar] coderzc commented on pull request #20086: [fix][broker] Ensure previous delayed index be removed from snapshotSegmentLastIndexTable & Make load operate asynchronous

2023-04-24 Thread via GitHub
coderzc commented on PR #20086: URL: https://github.com/apache/pulsar/pull/20086#issuecomment-1519841339 > This has been cherry-picked to branch-3.0 despite the code freeze. Do you feel strongly that this needs to be in the 3.0 release ? Otherwise we should revert this and delay it

[GitHub] [pulsar-site] raymondBourges opened a new pull request, #536: Update io-debezium-source.md

2023-04-24 Thread via GitHub
raymondBourges opened a new pull request, #536: URL: https://github.com/apache/pulsar-site/pull/536 Without "topicName" in YAML definition file "bin/pulsar-admin source localrun --source-config-file debezium-postgres-source-config.yaml" exits with a "Topic name cannot be null" error.

[GitHub] [pulsar-site] github-actions[bot] commented on pull request #536: Update io-debezium-source.md

2023-04-24 Thread via GitHub
github-actions[bot] commented on PR #536: URL: https://github.com/apache/pulsar-site/pull/536#issuecomment-1519856278 @raymondBourges Please add the following content to your PR description and select a checkbox: ``` - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed`

[GitHub] [pulsar] Technoboy- opened a new pull request, #20172: [branch-2.10][fix][build] Upgrade swagger version to fix CVE-2022-1471

2023-04-24 Thread via GitHub
Technoboy- opened a new pull request, #20172: URL: https://github.com/apache/pulsar/pull/20172 ### Motivation Upgrade swagger version to fix CVE-2022-1471 ### Documentation - [ ] `doc` - [ ] `doc-required` - [x] `doc-not-needed` - [ ] `doc-complete`

[GitHub] [pulsar] jiangpengcheng opened a new pull request, #20174: [fix][fn] Make python install dependencies from requirements.txt

2023-04-24 Thread via GitHub
jiangpengcheng opened a new pull request, #20174: URL: https://github.com/apache/pulsar/pull/20174 Fixes #20173 Master Issue: #xyz PIP: #xyz ### Motivation Python instance should install dependencies from requirements.txt

[GitHub] [pulsar] gaoran10 commented on a diff in pull request #20030: [fix][broker] Fix the reason label of authentication metrics

2023-04-24 Thread via GitHub
gaoran10 commented on code in PR #20030: URL: https://github.com/apache/pulsar/pull/20030#discussion_r1174918890 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/PulsarAuthenticationException.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache

[GitHub] [pulsar] cbornet commented on pull request #20155: [improve][broker] Support disabling delayed bucket merging.

2023-04-24 Thread via GitHub
cbornet commented on PR #20155: URL: https://github.com/apache/pulsar/pull/20155#issuecomment-1519738507 It seems that this commit will change a default setting and so will be breaking if we do it later. So I'd be in favor of leaving it in 3.0. WDYT ? -- This is an automated message

[pulsar] 04/04: Revert "[improve] [broker] Close temporary open ledger in BookkeeperBucketSnapshotStorage (#20111)"

2023-04-24 Thread cbornet
This is an automated email from the ASF dual-hosted git repository. cbornet pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 254f09b70d80640095f2fe6d12ed79f046fb3241 Author: Christophe Bornet AuthorDate: Mon Apr 24 11:50:50 2023 +0200

[pulsar] 03/04: Revert "[improve][broker] Make timer execute immediately after load index (#20126)"

2023-04-24 Thread cbornet
This is an automated email from the ASF dual-hosted git repository. cbornet pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 610c5f151436557d51b56e06a97ba422553592d7 Author: Christophe Bornet AuthorDate: Mon Apr 24 11:49:13 2023 +0200

[pulsar] branch branch-3.0 updated (89e4d46f4a5 -> 254f09b70d8)

2023-04-24 Thread cbornet
This is an automated email from the ASF dual-hosted git repository. cbornet pushed a change to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git from 89e4d46f4a5 [fix] [broker] Make `LeastResourceUsageWithWeight` thread safe (#20159) new 49539c20bea Revert

[pulsar] 02/04: Revert "[improve][broker] Optimize delayed metadata index bitmap (#20136)"

2023-04-24 Thread cbornet
This is an automated email from the ASF dual-hosted git repository. cbornet pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit f3572574b132dfb6d5a67011f7fb68096e69e1c7 Author: Christophe Bornet AuthorDate: Mon Apr 24 11:48:03 2023 +0200

[pulsar] 01/04: Revert "[improve][broker] Cache LedgerHandle in BookkeeperBucketSnapshotStorage (#20117)"

2023-04-24 Thread cbornet
This is an automated email from the ASF dual-hosted git repository. cbornet pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 49539c20bea1d8b10b8465be5ee632c1c4bdc7ce Author: Christophe Bornet AuthorDate: Mon Apr 24 11:46:27 2023 +0200

[GitHub] [pulsar] tisonkun edited a comment on the discussion: Pulsar-client-shaded[pulsar-client]模块生成的源码包是空的

2023-04-24 Thread GitBox
GitHub user tisonkun edited a comment on the discussion: Pulsar-client-shaded[pulsar-client]模块生成的源码包是空的 This is a known issue https://github.com/apache/pulsar/issues/19918 and has been fixed on the master branch. IIRC 3.0 will include this fix. GitHub link:

[GitHub] [pulsar] tisonkun edited a comment on the discussion: Pulsar-client-shaded[pulsar-client]模块生成的源码包是空的

2023-04-24 Thread GitBox
GitHub user tisonkun edited a comment on the discussion: Pulsar-client-shaded[pulsar-client]模块生成的源码包是空的 This is a known issue https://github.com/apache/pulsar/issues/19918 and has been fixed https://github.com/apache/pulsar/pull/19956 on the master branch. IIRC 3.0 will include this fix.

[GitHub] [pulsar] tisonkun added a comment to the discussion: Pulsar-client-shaded[pulsar-client]模块生成的源码包是空的

2023-04-24 Thread GitBox
GitHub user tisonkun added a comment to the discussion: Pulsar-client-shaded[pulsar-client]模块生成的源码包是空的 This is a known issue and has been fixed on the master branch. IIRC 3.0 will include this fix. GitHub link: https://github.com/apache/pulsar/discussions/20175#discussioncomment-5707164

[GitHub] [pulsar] tisonkun edited a comment on the discussion: Pulsar-client-shaded[pulsar-client]模块生成的源码包是空的

2023-04-24 Thread GitBox
GitHub user tisonkun edited a comment on the discussion: Pulsar-client-shaded[pulsar-client]模块生成的源码包是空的 This is a known issue https://github.com/apache/pulsar/issues/20034 and has been fixed on the master branch. IIRC 3.0 will include this fix. GitHub link:

[GitHub] [pulsar-dotpulsar] kandersen82 opened a new pull request, #149: Producer access mode fixes

2023-04-24 Thread via GitHub
kandersen82 opened a new pull request, #149: URL: https://github.com/apache/pulsar-dotpulsar/pull/149 Fixes issues with Producer access modes # Description Fixes disconnect issues related to producer access modes. Also changed behavior to to align with java client. When a

[GitHub] [pulsar-client-go] RobertIndie commented on a diff in pull request #1003: [Flaky Test]: Fix flaky test TestMaxPendingChunkMessages()

2023-04-24 Thread via GitHub
RobertIndie commented on code in PR #1003: URL: https://github.com/apache/pulsar-client-go/pull/1003#discussion_r1174946784 ## pulsar/message_chunking_test.go: ## @@ -576,3 +548,27 @@ func createTestMessagePayload(size int) []byte { } return payload } +

[pulsar] branch branch-2.10 updated: [branch-2.10][fix][build] Upgrade swagger version to fix CVE-2022-1471 (#20172)

2023-04-24 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.10 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.10 by this push: new 73462d65a26

[GitHub] [pulsar] codelipenghui merged pull request #20172: [branch-2.10][fix][build] Upgrade swagger version to fix CVE-2022-1471

2023-04-24 Thread via GitHub
codelipenghui merged PR #20172: URL: https://github.com/apache/pulsar/pull/20172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] asafm commented on issue #19912: PIP-261: Restructure Getting Started section

2023-04-24 Thread via GitHub
asafm commented on issue #19912: URL: https://github.com/apache/pulsar/issues/19912#issuecomment-1520241695 I've updated the PIP according to all comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #534: Release 2.9.5

2023-04-24 Thread via GitHub
Anonymitaet commented on code in PR #534: URL: https://github.com/apache/pulsar-site/pull/534#discussion_r1175301328 ## release-notes/versioned/pulsar-2.9.5.md: ## @@ -0,0 +1,123 @@ +--- +id: pulsar-2.9.5 +title: Apache Pulsar2.9.5 +sidebar_label: Apache Pulsar 2.9.5 +--- +

[GitHub] [pulsar-site] shibd commented on pull request #538: Fix wrong examples of CPP advertised listeners.

2023-04-24 Thread via GitHub
shibd commented on PR #538: URL: https://github.com/apache/pulsar-site/pull/538#issuecomment-1520263395 > Could you check if other maintained versions (2.10 & 2.11) are suffering similar issue? This content was added by #515, and the other version does not have this content. --

[GitHub] [pulsar-site] tisonkun commented on pull request #538: Fix wrong examples of CPP advertised listeners.

2023-04-24 Thread via GitHub
tisonkun commented on PR #538: URL: https://github.com/apache/pulsar-site/pull/538#issuecomment-1520295646 Thanks for your confirmation! Merging... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar-site] shibd opened a new pull request, #537: Add producer access mode examples for Java and C++ client.

2023-04-24 Thread via GitHub
shibd opened a new pull request, #537: URL: https://github.com/apache/pulsar-site/pull/537 ### Preview https://user-images.githubusercontent.com/33416836/234018290-914234da-9b47-44da-8276-04678af7bb8a.png;>

[GitHub] [pulsar-site] shibd opened a new pull request, #538: Fix wrong examples of CPP advertised listeners.

2023-04-24 Thread via GitHub
shibd opened a new pull request, #538: URL: https://github.com/apache/pulsar-site/pull/538 ### Preview https://user-images.githubusercontent.com/33416836/234022727-c9ad8303-fba1-4d0e-bbda-97ae2fbc906f.png;> ### Documentation - [x] `doc` - [ ]

[GitHub] [pulsar-client-go] frankjkelly commented on issue #1010: Seeing ten second p99 pulsar_client_consumer_processing_time_seconds_bucket values

2023-04-24 Thread via GitHub
frankjkelly commented on issue #1010: URL: https://github.com/apache/pulsar-client-go/issues/1010#issuecomment-1520649470 Ah ok - thanks @BewareMyPower From our side we've identified a cause of our high consumer processing time (somehow related to the choice of EC2 node in our EKS

[GitHub] [pulsar] rdhabalia commented on pull request #20147: [feat] [broker] Add broker health check status into prometheus metrics

2023-04-24 Thread via GitHub
rdhabalia commented on PR #20147: URL: https://github.com/apache/pulsar/pull/20147#issuecomment-1520599376 @mattisonchao I don't think and I also don't see draft requirements for configuration-related changes at : https://github.com/apache/pulsar/blob/master/wiki/proposals/PIP.md

[GitHub] [pulsar-site] Anonymitaet commented on pull request #537: Add producer access mode examples for Java and C++ client.

2023-04-24 Thread via GitHub
Anonymitaet commented on PR #537: URL: https://github.com/apache/pulsar-site/pull/537#issuecomment-1521046996 For versioned docs, how about adding the docs as below? The location might not be perfect but it's the most relevant place. Java

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #537: Add producer access mode examples for Java and C++ client.

2023-04-24 Thread via GitHub
Anonymitaet commented on code in PR #537: URL: https://github.com/apache/pulsar-site/pull/537#discussion_r1175866970 ## docs/client-libraries-producers.md: ## @@ -784,4 +784,41 @@ This example shows how to set the `EnforceUnencrypted` encryption policy. - \ No

[GitHub] [pulsar] github-actions[bot] commented on pull request #19464: [fix][authentication] Improve AuthenticationFilter response

2023-04-24 Thread via GitHub
github-actions[bot] commented on PR #19464: URL: https://github.com/apache/pulsar/pull/19464#issuecomment-1521045073 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar-site] Anonymitaet commented on pull request #536: Update io-debezium-source.md

2023-04-24 Thread via GitHub
Anonymitaet commented on PR #536: URL: https://github.com/apache/pulsar-site/pull/536#issuecomment-1520948182 @liangyepianzhou Could you please review this PR from a technical perspective? TIA! -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar] massakam commented on pull request #19983: [improve][broker] Log resource usage rate of brokers that need to be offloaded in ThresholdShedder

2023-04-24 Thread via GitHub
massakam commented on PR #19983: URL: https://github.com/apache/pulsar/pull/19983#issuecomment-1521026210 @eolivelli Could you please re-review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar-site] shibd commented on pull request #537: Add producer access mode examples for Java and C++ client.

2023-04-24 Thread via GitHub
shibd commented on PR #537: URL: https://github.com/apache/pulsar-site/pull/537#issuecomment-1521041383 > Soft reminder: do not forget the 2nd task commented in. Hi, @Anonymitaet The structure of the current document(next) is very different from the previous document(2.11.x, 2.10.x,

[GitHub] [pulsar-client-cpp] Anonymitaet commented on pull request #232: Support waiting for the ACK response

2023-04-24 Thread via GitHub
Anonymitaet commented on PR #232: URL: https://github.com/apache/pulsar-client-cpp/pull/232#issuecomment-1520171751 Hi @RobertIndie, Just now, I discussed with @BewareMyPower on how we add docs for this PR and summarized the thoughts below. He suggests that you're an expert in this

[pulsar-site] branch main updated: [fix][doc] CPP client advertised listeners examples (#538)

2023-04-24 Thread tison
This is an automated email from the ASF dual-hosted git repository. tison pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new e819fc14fb6 [fix][doc] CPP client advertised

[GitHub] [pulsar-site] tisonkun merged pull request #538: Fix wrong examples of CPP advertised listeners.

2023-04-24 Thread via GitHub
tisonkun merged PR #538: URL: https://github.com/apache/pulsar-site/pull/538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] 3286360470 added a comment to the discussion: Pulsar-client-shaded[pulsar-client]模块生成的源码包是空的

2023-04-24 Thread GitBox
GitHub user 3286360470 added a comment to the discussion: Pulsar-client-shaded[pulsar-client]模块生成的源码包是空的 @tisonkun thanks for your reply, your answer perfectly solved my problem! GitHub link: https://github.com/apache/pulsar/discussions/20175#discussioncomment-5714381 This is an

[GitHub] [pulsar-client-go] BewareMyPower commented on issue #1010: Seeing ten second p99 pulsar_client_consumer_processing_time_seconds_bucket values

2023-04-24 Thread via GitHub
BewareMyPower commented on issue #1010: URL: https://github.com/apache/pulsar-client-go/issues/1010#issuecomment-1521084731 It seems that we don't have any document for these prometheus metrics yet. It would be good to add some docs. And since you already found the reason of the

[GitHub] [pulsar] coderzc opened a new pull request, #20176: [fix][broker] Fix RoaringBitmap contains can't check value 65535

2023-04-24 Thread via GitHub
coderzc opened a new pull request, #20176: URL: https://github.com/apache/pulsar/pull/20176 Master Issue: #xyz https://github.com/RoaringBitmap/RoaringBitmap/issues/623 PIP: #xyz ### Motivation Using `contains(final int x)` instead of `contains(long

[GitHub] [pulsar] mattisonchao opened a new pull request, #20177: Upgrade jackson version to 2.15.0 to fix CVE-2022-1471

2023-04-24 Thread via GitHub
mattisonchao opened a new pull request, #20177: URL: https://github.com/apache/pulsar/pull/20177 ### Motivation Fix CVE https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-1471 ### Modifications - Upgrade jackson version to 2.15.0 ### Verifying this

[GitHub] [pulsar] mattisonchao closed pull request #20177: Upgrade jackson version to 2.15.0 to fix CVE-2022-1471

2023-04-24 Thread via GitHub
mattisonchao closed pull request #20177: Upgrade jackson version to 2.15.0 to fix CVE-2022-1471 URL: https://github.com/apache/pulsar/pull/20177 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar-site] coderzc commented on a diff in pull request #534: Release 2.9.5

2023-04-24 Thread via GitHub
coderzc commented on code in PR #534: URL: https://github.com/apache/pulsar-site/pull/534#discussion_r1175971794 ## release-notes/versioned/pulsar-2.9.5.md: ## @@ -0,0 +1,123 @@ +--- +id: pulsar-2.9.5 +title: Apache Pulsar2.9.5 +sidebar_label: Apache Pulsar 2.9.5 +--- + +

[pulsar-site] branch release-2.9.5 updated (b1eb4f87555 -> 934962471e0)

2023-04-24 Thread zhaocong
This is an automated email from the ASF dual-hosted git repository. zhaocong pushed a change to branch release-2.9.5 in repository https://gitbox.apache.org/repos/asf/pulsar-site.git from b1eb4f87555 Update release-notes/versioned/pulsar-2.9.5.md add 934962471e0 Keep consistent on the

[GitHub] [pulsar] shibd opened a new issue, #20178: [Doc] Add producer access mode examples on 2.8.x ~ 2.11.x version.

2023-04-24 Thread via GitHub
shibd opened a new issue, #20178: URL: https://github.com/apache/pulsar/issues/20178 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### What issue do you find in Pulsar docs? In

[GitHub] [pulsar] Technoboy- commented on pull request #20177: Upgrade jackson version to 2.15.0 to fix CVE-2022-1471

2023-04-24 Thread via GitHub
Technoboy- commented on PR #20177: URL: https://github.com/apache/pulsar/pull/20177#issuecomment-1521133032 > I wonder if #20085 already fixes [CVE-2022-1471](https://github.com/advisories/GHSA-mjmj-j48q-9wg2)? > > cc @Technoboy- Yes, fixed, but it's better also to accept

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #20030: [fix][broker] Fix the reason label of authentication metrics

2023-04-24 Thread via GitHub
michaeljmarshall commented on code in PR #20030: URL: https://github.com/apache/pulsar/pull/20030#discussion_r1176006164 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderToken.java: ## @@ -158,19 +164,18 @@ public String

[GitHub] [pulsar] asafm commented on a diff in pull request #19832: [fix][misc] Change PIP issue template

2023-04-24 Thread via GitHub
asafm commented on code in PR #19832: URL: https://github.com/apache/pulsar/pull/19832#discussion_r1176030857 ## .github/ISSUE_TEMPLATE/pip.md: ## @@ -0,0 +1,151 @@ +--- +name: PIP +about: Submit a Pulsar Improvement Proposal (PIP) +title: 'PIP-XYZ: ' +labels: PIP +--- + + + +#

[GitHub] [pulsar] asafm commented on a diff in pull request #19832: [fix][misc] Change PIP issue template

2023-04-24 Thread via GitHub
asafm commented on code in PR #19832: URL: https://github.com/apache/pulsar/pull/19832#discussion_r1176031180 ## .github/ISSUE_TEMPLATE/pip.md: ## @@ -0,0 +1,157 @@ +--- +name: PIP +about: Submit a Pulsar Improvement Proposal (PIP) +title: 'PIP-XYZ: ' +labels: PIP +--- + + + +#

[GitHub] [pulsar] codelipenghui commented on pull request #20176: [fix][broker] Fix `RoaringBitmap.contains` can't check value 65535

2023-04-24 Thread via GitHub
codelipenghui commented on PR #20176: URL: https://github.com/apache/pulsar/pull/20176#issuecomment-1521184920 Interesting, ConcurrentBitmapSortedLongPairSet also used the same method. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [pulsar-site] coderzc commented on a diff in pull request #534: Release 2.9.5

2023-04-24 Thread via GitHub
coderzc commented on code in PR #534: URL: https://github.com/apache/pulsar-site/pull/534#discussion_r1175973086 ## release-notes/versioned/pulsar-2.9.5.md: ## @@ -0,0 +1,123 @@ +--- +id: pulsar-2.9.5 +title: Apache Pulsar2.9.5 +sidebar_label: Apache Pulsar 2.9.5 +--- + +

[GitHub] [pulsar-manager] saurabh21316 commented on pull request #478: Use correct path for initdb and pg_ctl

2023-04-24 Thread via GitHub
saurabh21316 commented on PR #478: URL: https://github.com/apache/pulsar-manager/pull/478#issuecomment-1521146231 Hello Martin, I am new to pulsar, since the v0.4.0 is not released yet, could you please help with deploying it local with this fix or something you can point me out to.

[GitHub] [pulsar] tisonkun commented on pull request #20177: [improve][build] Upgrade jackson version to 2.15.0

2023-04-24 Thread via GitHub
tisonkun commented on PR #20177: URL: https://github.com/apache/pulsar/pull/20177#issuecomment-1521146839 After an offline discussion with @mattisonchao I notice that `jackson-dataformat-yaml` 2.14.2 still depend on snakeyaml 1.33 so this patch does fix a CVE. -- This is an automated

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #537: Add producer access mode examples for Java and C++ client.

2023-04-24 Thread via GitHub
Anonymitaet commented on code in PR #537: URL: https://github.com/apache/pulsar-site/pull/537#discussion_r1176005098 ## docs/client-libraries-producers.md: ## @@ -798,6 +798,8 @@ This example shows how to set producer access mode.

[GitHub] [pulsar] equanz opened a new pull request, #20179: [fix][broker] Fix recentlyJoinedConsumers to address the out-of-order bug.

2023-04-24 Thread via GitHub
equanz opened a new pull request, #20179: URL: https://github.com/apache/pulsar/pull/20179 ### Motivation The Key_Shared subscription type has the following issues. 1. Key_Shared subscription has out-of-order cases because of the race condition of [the recently joined

[GitHub] [pulsar] coderzc commented on pull request #20176: [fix][broker] Fix `RoaringBitmap.contains` can't check value 65535

2023-04-24 Thread via GitHub
coderzc commented on PR #20176: URL: https://github.com/apache/pulsar/pull/20176#issuecomment-1521190130 > RoaringBitmap/RoaringBitmap#623 Yeah, I'm not sure if our usage is wrong -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pulsar-dotpulsar] blankensteiner commented on pull request #146: Partitioned Topic Consumer Support

2023-04-24 Thread via GitHub
blankensteiner commented on PR #146: URL: https://github.com/apache/pulsar-dotpulsar/pull/146#issuecomment-1519443474 Hi @toneill818 Just wanted to know if you have an ETA? (if I should create a new release and wait for this PR if you are close to finishing) :-) -- This is an automated

[GitHub] [pulsar-client-go] Anonymitaet commented on pull request #1002: [feat][txn]Implement transactional consumer/producer API

2023-04-24 Thread via GitHub
Anonymitaet commented on PR #1002: URL: https://github.com/apache/pulsar-client-go/pull/1002#issuecomment-1519452516 Hi @liangyepianzhou thanks for introducing this great feature! As we discussed just now, for the doc side: ### ✅

[GitHub] [pulsar] eolivelli commented on a diff in pull request #20116: [improve][fn] Allow unknown fields in connectors config

2023-04-24 Thread via GitHub
eolivelli commented on code in PR #20116: URL: https://github.com/apache/pulsar/pull/20116#discussion_r1174842575 ## pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java: ## @@ -870,6 +872,56 @@ private void

[GitHub] [pulsar] thetumbled closed pull request #19662: [feat][txn] Support for idempotent commit and abort, Solution1.

2023-04-24 Thread via GitHub
thetumbled closed pull request #19662: [feat][txn] Support for idempotent commit and abort, Solution1. URL: https://github.com/apache/pulsar/pull/19662 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] StevenLuMT commented on pull request #20168: [fix][broker] log update in class:LeastResourceUsageWithWeight

2023-04-24 Thread via GitHub
StevenLuMT commented on PR #20168: URL: https://github.com/apache/pulsar/pull/20168#issuecomment-1519497624 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the