[GitHub] [pulsar] addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options

addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#issuecomment-553758466 @sijie if you have a second to merge this, that would be awesome :)

[GitHub] [pulsar] addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options

addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#issuecomment-553586235 rerun integration tests This is an automated message

[GitHub] [pulsar] addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options

addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#issuecomment-553489854 rerun integration tests This is an automated message from

[GitHub] [pulsar] addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options

addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#issuecomment-553165046 @jerrypeng changes made, let me know if you have anything else, glad it shaped up well :)

[GitHub] [pulsar] addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options

addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#issuecomment-552625063 @jerrypeng I ended up re-working this a fair amount to be more in-line with some of your ideas. Primarily: -

[GitHub] [pulsar] addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options

addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#issuecomment-552048442 Perhaps I am missing something, but I think there is a mismatch here. The `FunctionRuntimeManager` can manage the

[GitHub] [pulsar] addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options

addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#issuecomment-552046680 I considered such an approach, but wasn't sure if that was something that made sense for other providers. Will take a look

[GitHub] [pulsar] addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options

addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#issuecomment-552028052 @sijie @jerrypeng this is ready for another look, let me know if you have any questions!

[GitHub] [pulsar] addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options

addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#issuecomment-551971510 rerun java8 tests This is an automated message from the

[GitHub] [pulsar] addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options

addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#issuecomment-548826149 @jerrypeng @sijie I reworked this to account for the changes from #5404, I think it seems pretty reasonable. If you

[GitHub] [pulsar] addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options

addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#issuecomment-548686861 rerun integration tests This is an automated message from

[GitHub] [pulsar] addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options

addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#issuecomment-548664048 rerun java8 tests This is an automated message from the

[GitHub] [pulsar] addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options

addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#issuecomment-546643173 I started in on re-working this... the changes introduced in #5404 broke one of the assumptions this made, which was that

[GitHub] [pulsar] addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options

addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#issuecomment-544696751 okay @jerrypeng I changed that, will see if I can get the tests happy, let me know if you have any other feedback!

[GitHub] [pulsar] addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options

addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#issuecomment-542912063 This conflicts with #5398, will need rebased if that is merged first