codelipenghui opened a new pull request #6604: Fix function related test issue.
URL: https://github.com/apache/pulsar/pull/6604
 
 
   ### Motivation
   
   There are some tests that failed in the master branch related to functions. 
For example 
https://github.com/apache/pulsar/blob/master/pulsar-broker/src/test/java/org/apache/pulsar/functions/worker/PulsarFunctionE2ESecurityTest.java#L630,
 the test checks the properties of the message are forwarded, but we don't call 
`functionConfig.setForwardSourceMessageProperty(true)`,  I have no idea why 
previous CI can pass.
   
   And getApiException method 
(https://github.com/apache/pulsar/blob/master/pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/BaseResource.java#L235)
 very confusing, this will cause the async function admin method that #6580 
introduced can't complete when met exceptions. Looks CI has passed in #6580.
   
   So this PR fixes the issue rated forwarding message properties in Functions 
related tests and fix exception handle in async function admin APIs.
   
   ### Verifying this change
   
   This is the tests fix.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (no)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to