[GitHub] [pulsar] sijie commented on issue #5045: [client] Introduce `batchingMaxBytes` setting in pulsar producer
sijie commented on issue #5045: [client] Introduce `batchingMaxBytes` setting in pulsar producer URL: https://github.com/apache/pulsar/pull/5045#issuecomment-552945867 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5045: [client] Introduce `batchingMaxBytes` setting in pulsar producer
sijie commented on issue #5045: [client] Introduce `batchingMaxBytes` setting in pulsar producer URL: https://github.com/apache/pulsar/pull/5045#issuecomment-533840098 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5045: [client] Introduce `batchingMaxBytes` setting in pulsar producer
sijie commented on issue #5045: [client] Introduce `batchingMaxBytes` setting in pulsar producer URL: https://github.com/apache/pulsar/pull/5045#issuecomment-533106430 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5045: [client] Introduce `batchingMaxBytes` setting in pulsar producer
sijie commented on issue #5045: [client] Introduce `batchingMaxBytes` setting in pulsar producer URL: https://github.com/apache/pulsar/pull/5045#issuecomment-531995974 ping @jiazhai @codelipenghui @merlimat // run cpp tests // run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5045: [client] Introduce `batchingMaxBytes` setting in pulsar producer
sijie commented on issue #5045: [client] Introduce `batchingMaxBytes` setting in pulsar producer URL: https://github.com/apache/pulsar/pull/5045#issuecomment-531729542 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5045: [client] Introduce `batchingMaxBytes` setting in pulsar producer
sijie commented on issue #5045: [client] Introduce `batchingMaxBytes` setting in pulsar producer URL: https://github.com/apache/pulsar/pull/5045#issuecomment-529650938 @codelipenghui @jiazhai @merlimat I have addressed all the comments. PTAL This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5045: [client] Introduce `batchingMaxBytes` setting in pulsar producer
sijie commented on issue #5045: [client] Introduce `batchingMaxBytes` setting in pulsar producer URL: https://github.com/apache/pulsar/pull/5045#issuecomment-525076754 @merlimat I fixed the batch container check logic for handling max message size. although I didn't add any validations in producer configuration data. because: 1) `<=0` is used for disabling number-based or size-based batching strategy. 2) it is hard to get the upper bound for max message size because it is a dynamic number. in that sense, if I configure the max message size to 10MB and maxBytes should be able to set to be more than 5MB but it should be capped to 10MB. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
