[GitHub] [pulsar] yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer

2020-03-25 Thread GitBox
yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer URL: https://github.com/apache/pulsar/pull/5955#issuecomment-604226736 /pulsarbot run-failure-checks

[GitHub] [pulsar] yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer

2020-03-25 Thread GitBox
yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer URL: https://github.com/apache/pulsar/pull/5955#issuecomment-604151271 /pulsarbot run-failure-checks

[GitHub] [pulsar] yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer

2020-03-25 Thread GitBox
yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer URL: https://github.com/apache/pulsar/pull/5955#issuecomment-603851237 /pulsarbot run-failure-checks

[GitHub] [pulsar] yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer

2020-03-25 Thread GitBox
yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer URL: https://github.com/apache/pulsar/pull/5955#issuecomment-603702507 /pulsarbot run-failure-checks

[GitHub] [pulsar] yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer

2020-03-25 Thread GitBox
yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer URL: https://github.com/apache/pulsar/pull/5955#issuecomment-603689599 /pulsarbot run-failure-checks

[GitHub] [pulsar] yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer

2020-03-24 Thread GitBox
yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer URL: https://github.com/apache/pulsar/pull/5955#issuecomment-603576917 @duli559 could you please merge the master? (git fetch apache master && git merge

[GitHub] [pulsar] yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer

2020-03-24 Thread GitBox
yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer URL: https://github.com/apache/pulsar/pull/5955#issuecomment-603576306 /pulsarbot run-failure-checks

[GitHub] [pulsar] yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer

2020-03-24 Thread GitBox
yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer URL: https://github.com/apache/pulsar/pull/5955#issuecomment-603575551 /pulsarbot run-failure-checks

[GitHub] [pulsar] yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer

2020-01-01 Thread GitBox
yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer URL: https://github.com/apache/pulsar/pull/5955#issuecomment-570033080 @sijie I agree. @duli559 could you please check sijie's advice above?

[GitHub] [pulsar] yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer

2019-12-31 Thread GitBox
yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer URL: https://github.com/apache/pulsar/pull/5955#issuecomment-570013369 As discussed in #5934, users need to subclass `FlinkPulsarProducer`, overwrite

[GitHub] [pulsar] yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer

2019-12-31 Thread GitBox
yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer URL: https://github.com/apache/pulsar/pull/5955#issuecomment-570011448 LGTM. This is an automated