[GitHub] [pulsar] yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer
yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer URL: https://github.com/apache/pulsar/pull/5955#issuecomment-604226736 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer
yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer URL: https://github.com/apache/pulsar/pull/5955#issuecomment-604151271 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer
yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer URL: https://github.com/apache/pulsar/pull/5955#issuecomment-603851237 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer
yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer URL: https://github.com/apache/pulsar/pull/5955#issuecomment-603702507 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer
yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer URL: https://github.com/apache/pulsar/pull/5955#issuecomment-603689599 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer
yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer URL: https://github.com/apache/pulsar/pull/5955#issuecomment-603576917 @duli559 could you please merge the master? (git fetch apache master && git merge apache/master) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer
yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer URL: https://github.com/apache/pulsar/pull/5955#issuecomment-603576306 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer
yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer URL: https://github.com/apache/pulsar/pull/5955#issuecomment-603575551 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer
yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer URL: https://github.com/apache/pulsar/pull/5955#issuecomment-570033080 @sijie I agree. @duli559 could you please check sijie's advice above? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer
yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer URL: https://github.com/apache/pulsar/pull/5955#issuecomment-570013369 As discussed in #5934, users need to subclass `FlinkPulsarProducer`, overwrite `generateProperties` proposed by this PR, and generate properties based on: - the current value to write - constant provided in subclass - `RuntimeContext` from the base `RichSinkFunction`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer
yjshen commented on issue #5955: ISSUE-5934: Support read/write properties from/to Message in flink pulsar consumer/producer URL: https://github.com/apache/pulsar/pull/5955#issuecomment-570011448 LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
