Re: [I] [Bug] ExtensibleLoadManager's broker registry cannot recover from session expiration / reconnection [pulsar]

2025-03-22 Thread via GitHub


lhotari closed issue #24057: [Bug] ExtensibleLoadManager's broker registry 
cannot recover from session expiration / reconnection
URL: https://github.com/apache/pulsar/issues/24057


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Bug] ExtensibleLoadManager's broker registry cannot recover from session expiration / reconnection [pulsar]

2025-03-20 Thread via GitHub


lhotari commented on issue #24057:
URL: https://github.com/apache/pulsar/issues/24057#issuecomment-2742516834

   > BrokerRegistryImpl uses `MetadataCache 
brokerLookupDataMetadataCache; `.
   > 
   > I think the session events are handled at AbstractMetadataStore and 
MetadataStore Implementations(e.g. ZKMetadataStore). The behavior seems to be 1 
"watch again(if sessions are reestablished) and 2. invalidate the metadata 
cache(hence the next lookup should fetch broker registries from the metadata 
store)
   > 
   > ref: 
https://github.com/apache/pulsar/blob/master/pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/AbstractMetadataStore.java#L497-L522
   > 
   > 
https://github.com/apache/pulsar/blob/master/pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/ZKMetadataStore.java#L149-L174
   
   @heesung-sn Thanks for the explanation. I'll close this issue as a non-issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Bug] ExtensibleLoadManager's broker registry cannot recover from session expiration / reconnection [pulsar]

2025-03-20 Thread via GitHub


heesung-sn commented on issue #24057:
URL: https://github.com/apache/pulsar/issues/24057#issuecomment-2741480688

   BrokerRegistryImpl uses `MetadataCache 
brokerLookupDataMetadataCache; `.
   
   I think the session events are handled at AbstractMetadataStore and  
MetadataStore Implementations(e.g. ZKMetadataStore). 
   The behavior seems to be 
   1 "watch again(if sessions are reestablished) and 2. invalidate the metadata 
cache(hence the next lookup should fetch broker registries from the metadata 
store)
   
   
   ref: 
   
https://github.com/apache/pulsar/blob/master/pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/AbstractMetadataStore.java#L497-L522
   
   
   
https://github.com/apache/pulsar/blob/master/pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/ZKMetadataStore.java#L149-L174


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Bug] ExtensibleLoadManager's broker registry cannot recover from session expiration / reconnection [pulsar]

2025-03-17 Thread via GitHub


lhotari commented on issue #24057:
URL: https://github.com/apache/pulsar/issues/24057#issuecomment-2730486165

   One possible detail to consider is to revert #23298 & #23359 and rely on the 
original way of leader election. It seems that leader election logic gets 
duplicated in ExtensibleLoadManager's broker registry implementation. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org