Re: [PR] [improve][build] Support custom image and label names [pulsar]

2024-05-15 Thread via GitHub 


lhotari merged PR #22703:
URL: https://github.com/apache/pulsar/pull/22703


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [improve][build] Support custom image and label names [pulsar]

2024-05-14 Thread via GitHub 


nodece commented on PR #22703:
URL: https://github.com/apache/pulsar/pull/22703#issuecomment-2109689997

   @lhotari CI has been passed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [improve][build] Support custom image and label names [pulsar]

2024-05-14 Thread via GitHub 


codecov-commenter commented on PR #22703:
URL: https://github.com/apache/pulsar/pull/22703#issuecomment-2109685890

   ## 
[Codecov](https://app.codecov.io/gh/apache/pulsar/pull/22703?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 73.17%. Comparing base 
[(`bbc6224`)](https://app.codecov.io/gh/apache/pulsar/commit/bbc62245c5ddba1de4b1e7cee4ab49334bc36277?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 to head 
[(`67192b5`)](https://app.codecov.io/gh/apache/pulsar/pull/22703?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 267 commits behind head on master.
   
   Additional details and impacted files
   
   
   [![Impacted file tree 
graph](https://app.codecov.io/gh/apache/pulsar/pull/22703/graphs/tree.svg?width=650&height=150&src=pr&token=acYqCpsK9J&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/pulsar/pull/22703?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #22703  +/-   ##
   
   - Coverage 73.57%   73.17%   -0.41% 
   + Complexity3262432531  -93 
   
 Files  1877 1889  +12 
 Lines139502   141392+1890 
 Branches  1529915516 +217 
   
   + Hits 102638   103460 +822 
   - Misses2890829928+1020 
   - Partials   7956 8004  +48 
   ```
   
   | 
[Flag](https://app.codecov.io/gh/apache/pulsar/pull/22703/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Coverage Δ | |
   |---|---|---|
   | 
[inttests](https://app.codecov.io/gh/apache/pulsar/pull/22703/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `27.43% <ø> (+2.84%)` | :arrow_up: |
   | 
[systests](https://app.codecov.io/gh/apache/pulsar/pull/22703/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `24.77% <ø> (+0.44%)` | :arrow_up: |
   | 
[unittests](https://app.codecov.io/gh/apache/pulsar/pull/22703/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `72.17% <ø> (-0.68%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   [see 352 files with indirect coverage 
changes](https://app.codecov.io/gh/apache/pulsar/pull/22703/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [improve][build] Support custom image and label names [pulsar]

2024-05-14 Thread via GitHub 


nodece commented on PR #22703:
URL: https://github.com/apache/pulsar/pull/22703#issuecomment-2109493660

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [improve][build] Support custom image and label names [pulsar]

2024-05-13 Thread via GitHub 


nodece commented on PR #22703:
URL: https://github.com/apache/pulsar/pull/22703#issuecomment-2109338511

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [improve][build] Support custom image and label names [pulsar]

2024-05-13 Thread via GitHub 


lhotari commented on code in PR #22703:
URL: https://github.com/apache/pulsar/pull/22703#discussion_r1599345168


##
tests/docker-images/latest-version-image/pom.xml:
##
@@ -152,11 +152,15 @@
 
   
 
-  
${docker.organization}/pulsar-test-latest-version
+  
${docker.organization}/${docker.tag}-test-latest-version

Review Comment:
   ```suggestion
 
${docker.organization}/${docker.image}-test-latest-version
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [improve][build] Support custom image and label names [pulsar]

2024-05-13 Thread via GitHub 


lhotari commented on code in PR #22703:
URL: https://github.com/apache/pulsar/pull/22703#discussion_r1598408361


##
tests/docker-images/latest-version-image/Dockerfile:
##
@@ -27,12 +27,14 @@ RUN cd 
/go/src/github.com/apache/pulsar/pulsar-function-go/pf && go install
 RUN cd /go/src/github.com/apache/pulsar/pulsar-function-go/examples && go 
install ./...
 
 # Reference pulsar-all to copy connectors from there
-FROM apachepulsar/pulsar-all:latest as pulsar-all
+ARG PULSAR_ALL_IMAGE
+FROM $PULSAR_ALL_IMAGE as pulsar-all
 
 
 ## Main image build
 
-FROM apachepulsar/pulsar:latest
+ARG PULSAR_IMAGE
+FROM $PULSAR_IMAGE

Review Comment:
   It seems that `PULSAR_ALL_IMAGE` and `PULSAR_IMAGE` aren't passed as args 
for building the docker image



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [improve][build] Support custom image and label names [pulsar]

2024-05-13 Thread via GitHub 


lhotari commented on code in PR #22703:
URL: https://github.com/apache/pulsar/pull/22703#discussion_r1598408361


##
tests/docker-images/latest-version-image/Dockerfile:
##
@@ -27,12 +27,14 @@ RUN cd 
/go/src/github.com/apache/pulsar/pulsar-function-go/pf && go install
 RUN cd /go/src/github.com/apache/pulsar/pulsar-function-go/examples && go 
install ./...
 
 # Reference pulsar-all to copy connectors from there
-FROM apachepulsar/pulsar-all:latest as pulsar-all
+ARG PULSAR_ALL_IMAGE
+FROM $PULSAR_ALL_IMAGE as pulsar-all
 
 
 ## Main image build
 
-FROM apachepulsar/pulsar:latest
+ARG PULSAR_IMAGE
+FROM $PULSAR_IMAGE

Review Comment:
   It seems that `PULSAR_ALL_IMAGE` and `PULSAR_IMAGE` aren't passed as args 
for building the docker image



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org