Re: [PR] [improve][client] Reduce unshaded dependencies and shading warnings in shaded Java client modules [pulsar]
eolivelli merged PR #23647: URL: https://github.com/apache/pulsar/pull/23647 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [improve][client] Reduce unshaded dependencies and shading warnings in shaded Java client modules [pulsar]
codecov-commenter commented on PR #23647: URL: https://github.com/apache/pulsar/pull/23647#issuecomment-2507256625 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/23647?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 74.35%. Comparing base [(`bbc6224`)](https://app.codecov.io/gh/apache/pulsar/commit/bbc62245c5ddba1de4b1e7cee4ab49334bc36277?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`c0e137a`)](https://app.codecov.io/gh/apache/pulsar/commit/c0e137ad7af87c8c44bea0d4df313a25140075bd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 764 commits behind head on master. Additional details and impacted files [](https://app.codecov.io/gh/apache/pulsar/pull/23647?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #23647 +/- ## + Coverage 73.57% 74.35% +0.78% - Complexity3262434488+1864 Files 1877 1944 +67 Lines139502 147242+7740 Branches 1529916250 +951 + Hits 102638 109482+6844 - Misses2890829306 +398 - Partials 7956 8454 +498 ``` | [Flag](https://app.codecov.io/gh/apache/pulsar/pull/23647/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [inttests](https://app.codecov.io/gh/apache/pulsar/pull/23647/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `27.30% <ø> (+2.72%)` | :arrow_up: | | [systests](https://app.codecov.io/gh/apache/pulsar/pull/23647/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.35% <ø> (+0.03%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/apache/pulsar/pull/23647/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.74% <ø> (+0.89%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 672 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/23647/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [improve][client] Reduce unshaded dependencies and shading warnings in shaded Java client modules [pulsar]
lhotari commented on PR #23647: URL: https://github.com/apache/pulsar/pull/23647#issuecomment-2506798224 I didn't notice until now that shaded `pulsar-client-admin` also includes the shaded `pulsar-client`. The main difference between `pulsar-client-admin` and `pulsar-client-all` is that `pulsar-client-all` shaded most dependencies. It seems pointless. Perhaps there was a reason in the past for doing this. I think that `pulsar-client-all` should replace the shaded `pulsar-client-admin` in the future to cleanup the situation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
