Re: [PR] [improve][offload] Use filesystemURI as the storage path [pulsar]
lhotari commented on PR #23591: URL: https://github.com/apache/pulsar/pull/23591#issuecomment-2503304362 @zymap I'm curious to know why the test fails in branch-3.0 and not in master. I don't see other explanation to that other than #23411. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [improve][offload] Use filesystemURI as the storage path [pulsar]
lhotari commented on PR #23591: URL: https://github.com/apache/pulsar/pull/23591#issuecomment-2503300141 @zymap The comment referenced the test failure, https://github.com/apache/pulsar/actions/runs/11977750391/job/33404574103#step:12:11625 ``` Error: Tests run: 6, Failures: 3, Errors: 0, Skipped: 3, Time elapsed: 541.109 s <<< FAILURE! - in TestSuite Error: org.apache.pulsar.tests.integration.offload.TestFileSystemOffload.testPublishOffloadAndConsumeDeletionLag[org.apache.pulsar.tests.integration.topologies.PulsarClusterTestBase$$Lambda$539/0x7f269061e4b0@7e31d53b, org.apache.pulsar.tests.integration.topologies.PulsarClusterTestBase$$Lambda$540/0x7f269061e6d8@68d8eb4f](4) Time elapsed: 45.88 s <<< FAILURE! java.lang.AssertionError: expected [true] but found [false] at org.testng.Assert.fail(Assert.java:110) at org.testng.Assert.failNotEquals(Assert.java:1577) at org.testng.Assert.assertTrue(Assert.java:56) at org.testng.Assert.assertTrue(Assert.java:66) at org.apache.pulsar.tests.integration.offload.TestBaseOffload.writeAndWaitForOffload(TestBaseOffload.java:267) at org.apache.pulsar.tests.integration.offload.TestBaseOffload.writeAndWaitForOffload(TestBaseOffload.java:224) at org.apache.pulsar.tests.integration.offload.TestBaseOffload.testPublishOffloadAndConsumeDeletionLag(TestBaseOffload.java:307) at org.apache.pulsar.tests.integration.offload.TestFileSystemOffload.testPublishOffloadAndConsumeDeletionLag(TestFileSystemOffload.java:43) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:569) at org.testng.internal.invokers.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:139) at org.testng.internal.invokers.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:47) at org.testng.internal.invokers.InvokeMethodRunnable.call(InvokeMethodRunnable.java:76) at org.testng.internal.invokers.InvokeMethodRunnable.call(InvokeMethodRunnable.java:11) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) at java.base/java.lang.Thread.run(Thread.java:840) Error: org.apache.pulsar.tests.integration.offload.TestFileSystemOffload.testPublishOffloadAndConsumeViaCLI[org.apache.pulsar.tests.integration.topologies.PulsarClusterTestBase$$Lambda$539/0x7f269061e4b0@18483b8b, org.apache.pulsar.tests.integration.topologies.PulsarClusterTestBase$$Lambda$540/0x7f269061e6d8@24fc2c80](4) Time elapsed: 20.055 s <<< FAILURE! org.apache.pulsar.tests.integration.docker.ContainerExecException: /pulsar/bin/pulsar-admin topics offload-status -w persistent://offload-test-cli-egxb/ns1/topic1 failed on 565f687e87d19742184c52a01ec7db077dd5c4d044f3dcb06d57d19fe4185098 with error code 1 at org.apache.pulsar.tests.integration.utils.DockerUtils$2.onComplete(DockerUtils.java:284) at org.testcontainers.shaded.com.github.dockerjava.core.exec.AbstrAsyncDockerCmdExec$1.onComplete(AbstrAsyncDockerCmdExec.java:51) at org.testcontainers.shaded.com.github.dockerjava.core.DefaultInvocationBuilder.lambda$executeAndStream$1(DefaultInvocationBuilder.java:276) at java.base/java.lang.Thread.run(Thread.java:840) Error: org.apache.pulsar.tests.integration.offload.TestFileSystemOffload.testPublishOffloadAndConsumeViaThreshold[org.apache.pulsar.tests.integration.topologies.PulsarClusterTestBase$$Lambda$539/0x7f269061e4b0@20a47036, org.apache.pulsar.tests.integration.topologies.PulsarClusterTestBase$$Lambda$540/0x7f269061e6d8@70c205bf](4) Time elapsed: 43.208 s <<< FAILURE! java.lang.AssertionError: expected [true] but found [false] at org.testng.Assert.fail(Assert.java:110) at org.testng.Assert.failNotEquals(Assert.java:1577) at org.testng.Assert.assertTrue(Assert.java:56) at org.testng.Assert.assertTrue(Assert.java:66) at org.apache.pulsar.tests.integration.offload.TestBaseOffload.testPublishOffloadAndConsumeViaThreshold(TestBaseOffload.java:182) at org.apache.pulsar.tests.integration.offload.TestFileSystemOffload.testPublishOffloadAndConsumeViaThreshold(TestFileSystemOffload.java:38) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) at java.base/
Re: [PR] [improve][offload] Use filesystemURI as the storage path [pulsar]
lhotari commented on PR #23591: URL: https://github.com/apache/pulsar/pull/23591#issuecomment-2503281458 > @lhotari I fixed the issue and pushed a commit to run the pulsar test [here](https://github.com/zymap/pulsar/pull/62). The root cause is after this fix the fileSystemURI is working which makes the integration tests fail due to the permission issue. Because it used the root path. After changing it to the /pulsar/data, it runs successfully in my local. @zymap thanks! Wouldn't it be useful to submit similar test improvements to master branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [improve][offload] Use filesystemURI as the storage path [pulsar]
lhotari commented on PR #23591: URL: https://github.com/apache/pulsar/pull/23591#issuecomment-2503280505 > @lhotari I don't understand why a configuration change will related to a dependency change. Shouldn't we check why the test is failed? @zymap The difference in branch-3.0 is that #23411 isn't included. That's why the test failure in branch-3.0 was most likely related to that change. Something simply behaves differently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [improve][offload] Use filesystemURI as the storage path [pulsar]
zymap commented on PR #23591: URL: https://github.com/apache/pulsar/pull/23591#issuecomment-2502402513 @lhotari I don't understand why a configuration change will related to a dependency change. Shouldn't we check why the test is failed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [improve][offload] Use filesystemURI as the storage path [pulsar]
lhotari commented on PR #23591: URL: https://github.com/apache/pulsar/pull/23591#issuecomment-2494918243 This change is related to #23411. I'll revert the change in branch-3.0 since the [TestFileSystemOffload](https://github.com/apache/pulsar/commit/f68f282803e69cb95dc7b3a2f576b0accfacdd3f#annotation_28959402383) fails and block 3.0.8 release. branch-3.0 doesn't include #23411 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [improve][offload] Use filesystemURI as the storage path [pulsar]
zymap merged PR #23591: URL: https://github.com/apache/pulsar/pull/23591 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [improve][offload] Use filesystemURI as the storage path [pulsar]
github-actions[bot] commented on PR #23591: URL: https://github.com/apache/pulsar/pull/23591#issuecomment-2470107622 @zymap Please add the following content to your PR description and select a checkbox: ``` - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ] `doc-complete` ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
