[GitHub] codelipenghui commented on a change in pull request #2508: PIP-22: Dead Letter Topic

2018-09-13 Thread GitBox
codelipenghui commented on a change in pull request #2508: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2508#discussion_r217270244 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java ## @@ -265,7

[GitHub] codelipenghui commented on a change in pull request #2508: PIP-22: Dead Letter Topic

2018-09-13 Thread GitBox
codelipenghui commented on a change in pull request #2508: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2508#discussion_r217272237 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java

[GitHub] codelipenghui commented on issue #2508: PIP-22: Dead Letter Topic

2018-09-13 Thread GitBox
codelipenghui commented on issue #2508: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2508#issuecomment-420901198 @merlimat To summarize, i need to disable the RedeliveryTracker in PersistentDispatcherSingleActiveConsumer. Next step i will start

[GitHub] massakam opened a new pull request #2572: Shorten the timeout value of C++ ZTS client

2018-09-13 Thread GitBox
massakam opened a new pull request #2572: Shorten the timeout value of C++ ZTS client URL: https://github.com/apache/incubator-pulsar/pull/2572 C++ ZTS client waits 1 seconds for a response from ZTS server even if there is no response. I think there is a mistake in specifying curl

[GitHub] merlimat commented on issue #2567: Another fix for website build website/scripts/replace.js

2018-09-13 Thread GitBox
merlimat commented on issue #2567: Another fix for website build website/scripts/replace.js URL: https://github.com/apache/incubator-pulsar/pull/2567#issuecomment-420968758 run java8 tests This is an automated message from

[GitHub] merlimat commented on issue #2508: PIP-22: Dead Letter Topic

2018-09-13 Thread GitBox
merlimat commented on issue #2508: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2508#issuecomment-420968603 retest this please This is an automated message from the Apache Git Service. To

[GitHub] merlimat commented on a change in pull request #2535: Add ledger op timeout to avoid topics stuck on ledger-creation

2018-09-13 Thread GitBox
merlimat commented on a change in pull request #2535: Add ledger op timeout to avoid topics stuck on ledger-creation URL: https://github.com/apache/incubator-pulsar/pull/2535#discussion_r217344073 ## File path:

[GitHub] sijie commented on issue #2543: Add ServiceUrlProvider and add method forceCloseConnection in PulsarC…

2018-09-13 Thread GitBox
sijie commented on issue #2543: Add ServiceUrlProvider and add method forceCloseConnection in PulsarC… URL: https://github.com/apache/incubator-pulsar/pull/2543#issuecomment-421159758 @merlimat can you review this PR? This

[GitHub] sijie closed pull request #2548: Stop all functions gracefully on closing worker-service

2018-09-13 Thread GitBox
sijie closed pull request #2548: Stop all functions gracefully on closing worker-service URL: https://github.com/apache/incubator-pulsar/pull/2548 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[incubator-pulsar] branch master updated: optimizing throughput in Pulsar Presto connector (#2564)

2018-09-13 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 6ef7aca optimizing throughput in

[incubator-pulsar] branch master updated: Stop all functions gracefully on closing worker-service (#2548)

2018-09-13 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 95ed9b9 Stop all functions gracefully

[GitHub] sijie closed pull request #2567: Another fix for website build website/scripts/replace.js

2018-09-13 Thread GitBox
sijie closed pull request #2567: Another fix for website build website/scripts/replace.js URL: https://github.com/apache/incubator-pulsar/pull/2567 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] dsambandam opened a new issue #2576: Pulsar client consume command fails with

2018-09-13 Thread GitBox
dsambandam opened a new issue #2576: Pulsar client consume command fails with URL: https://github.com/apache/incubator-pulsar/issues/2576 Expected behavior Tell us what should happen Actual behavior ./bin/pulsar-client consume

[GitHub] jerrypeng opened a new pull request #2577: fix behavior of JSONSchema for derived classes

2018-09-13 Thread GitBox
jerrypeng opened a new pull request #2577: fix behavior of JSONSchema for derived classes URL: https://github.com/apache/incubator-pulsar/pull/2577 ### Motivation This is an automated message from the Apache Git

[incubator-pulsar] branch master updated: ManagedLedger only closes ledger on error if current ledger (#240) (#2573)

2018-09-13 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 7c62ecf ManagedLedger only closes

[GitHub] merlimat closed pull request #2573: ManagedLedger only closes ledger on error if current ledger (#240)

2018-09-13 Thread GitBox
merlimat closed pull request #2573: ManagedLedger only closes ledger on error if current ledger (#240) URL: https://github.com/apache/incubator-pulsar/pull/2573 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] aahmed-se opened a new pull request #2578: [WIP] Add support for schema extraction from a jar

2018-09-13 Thread GitBox
aahmed-se opened a new pull request #2578: [WIP] Add support for schema extraction from a jar URL: https://github.com/apache/incubator-pulsar/pull/2578 Add options to create a schema based on pojo class in a jar. This is an

[GitHub] sijie commented on a change in pull request #2570: Fix BC issue in functions trigger function submitted by old CLI

2018-09-13 Thread GitBox
sijie commented on a change in pull request #2570: Fix BC issue in functions trigger function submitted by old CLI URL: https://github.com/apache/incubator-pulsar/pull/2570#discussion_r217553912 ## File path:

[GitHub] srids commented on issue #2568: MacOS: Could not find a version that satisfies the requirement pulsar-client==2.1.0

2018-09-13 Thread GitBox
srids commented on issue #2568: MacOS: Could not find a version that satisfies the requirement pulsar-client==2.1.0 URL: https://github.com/apache/incubator-pulsar/issues/2568#issuecomment-421125156 ic. sounds good to fix in 2.1.1 then. thanks.

[incubator-pulsar] branch master updated: Another fix for website build (#2567)

2018-09-13 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 0964dad Another fix for website build

[GitHub] sijie closed pull request #2564: optimizing throughput in Pulsar Presto connector

2018-09-13 Thread GitBox
sijie closed pull request #2564: optimizing throughput in Pulsar Presto connector URL: https://github.com/apache/incubator-pulsar/pull/2564 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] sijie commented on issue #2500: [schema] add schemas for primtive types

2018-09-13 Thread GitBox
sijie commented on issue #2500: [schema] add schemas for primtive types URL: https://github.com/apache/incubator-pulsar/pull/2500#issuecomment-421164099 run integration tests This is an automated message from the Apache Git

[GitHub] sijie commented on issue #2500: [schema] add schemas for primtive types

2018-09-13 Thread GitBox
sijie commented on issue #2500: [schema] add schemas for primtive types URL: https://github.com/apache/incubator-pulsar/pull/2500#issuecomment-421164188 run java8 tests This is an automated message from the Apache Git

[GitHub] rdhabalia commented on a change in pull request #2549: [Function] avoid creating assignment snapshot and publish individual assignment msg

2018-09-13 Thread GitBox
rdhabalia commented on a change in pull request #2549: [Function] avoid creating assignment snapshot and publish individual assignment msg URL: https://github.com/apache/incubator-pulsar/pull/2549#discussion_r217502837 ## File path:

[GitHub] srids commented on issue #2568: MacOS: Could not find a version that satisfies the requirement pulsar-client==2.1.0

2018-09-13 Thread GitBox
srids commented on issue #2568: MacOS: Could not find a version that satisfies the requirement pulsar-client==2.1.0 URL: https://github.com/apache/incubator-pulsar/issues/2568#issuecomment-421120900 you mean 36 for macos :) - yea that should work but think it will be consistent to

[GitHub] sijie commented on issue #2568: MacOS: Could not find a version that satisfies the requirement pulsar-client==2.1.0

2018-09-13 Thread GitBox
sijie commented on issue #2568: MacOS: Could not find a version that satisfies the requirement pulsar-client==2.1.0 URL: https://github.com/apache/incubator-pulsar/issues/2568#issuecomment-421124528 @srids yes I mean 36. a release typically requires reviews and votes in apache software

[GitHub] sijie commented on issue #2508: PIP-22: Dead Letter Topic

2018-09-13 Thread GitBox
sijie commented on issue #2508: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2508#issuecomment-421164855 run java8 tests run integration tests This is an automated message from the Apache

[GitHub] srkukarni commented on a change in pull request #2570: Fix BC issue in functions trigger function submitted by old CLI

2018-09-13 Thread GitBox
srkukarni commented on a change in pull request #2570: Fix BC issue in functions trigger function submitted by old CLI URL: https://github.com/apache/incubator-pulsar/pull/2570#discussion_r217554182 ## File path:

[GitHub] merlimat commented on issue #2580: [Python] Consolidated duplicated subscribe_*() methods into a single one

2018-09-13 Thread GitBox
merlimat commented on issue #2580: [Python] Consolidated duplicated subscribe_*() methods into a single one URL: https://github.com/apache/incubator-pulsar/pull/2580#issuecomment-421185405 @jiazhai I missed that in the original PR. I think this should reduce the publicly exposed API in

[GitHub] sijie commented on issue #2576: Pulsar client consume command fails with java.lang.IllegalArgumentException: port out of range:-1

2018-09-13 Thread GitBox
sijie commented on issue #2576: Pulsar client consume command fails with java.lang.IllegalArgumentException: port out of range:-1 URL: https://github.com/apache/incubator-pulsar/issues/2576#issuecomment-421193236 @dsambandam what is your broker url? is it `broker1`? or `broker1` was

[GitHub] dsambandam commented on issue #2576: Pulsar client consume command fails with java.lang.IllegalArgumentException: port out of range:-1

2018-09-13 Thread GitBox
dsambandam commented on issue #2576: Pulsar client consume command fails with java.lang.IllegalArgumentException: port out of range:-1 URL: https://github.com/apache/incubator-pulsar/issues/2576#issuecomment-421200024 @sijie I replaced the real hostname with broker1 when I posted it.

[GitHub] massakam commented on issue #2572: Shorten the timeout value of C++ ZTS client

2018-09-13 Thread GitBox
massakam commented on issue #2572: Shorten the timeout value of C++ ZTS client URL: https://github.com/apache/incubator-pulsar/pull/2572#issuecomment-421204621 rerun java8 tests rerun integration tests This is an automated

[GitHub] srkukarni commented on issue #2570: Fix BC issue in functions trigger function submitted by old CLI

2018-09-13 Thread GitBox
srkukarni commented on issue #2570: Fix BC issue in functions trigger function submitted by old CLI URL: https://github.com/apache/incubator-pulsar/pull/2570#issuecomment-421206316 --customSerdeMap was a map from topicName -> Serde and not topicPattern -> Serde. The way we specify

[GitHub] pablichjenkov opened a new issue #2581: Android and IOS client support

2018-09-13 Thread GitBox
pablichjenkov opened a new issue #2581: Android and IOS client support URL: https://github.com/apache/incubator-pulsar/issues/2581 I am trying to build a Chat App with the purpose of testing Apache Pulsar. I am facing the following problems on both mobile platforms. Android: I was

[GitHub] srkukarni commented on issue #2577: fix behavior of JSONSchema for derived classes

2018-09-13 Thread GitBox
srkukarni commented on issue #2577: fix behavior of JSONSchema for derived classes URL: https://github.com/apache/incubator-pulsar/pull/2577#issuecomment-421182362 run cpp tests run integration tests run java8 tests

[GitHub] srkukarni commented on issue #2577: fix behavior of JSONSchema for derived classes

2018-09-13 Thread GitBox
srkukarni commented on issue #2577: fix behavior of JSONSchema for derived classes URL: https://github.com/apache/incubator-pulsar/pull/2577#issuecomment-421182305 run tests This is an automated message from the Apache Git

[GitHub] jerrypeng closed pull request #2577: fix behavior of JSONSchema for derived classes

2018-09-13 Thread GitBox
jerrypeng closed pull request #2577: fix behavior of JSONSchema for derived classes URL: https://github.com/apache/incubator-pulsar/pull/2577 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] rdhabalia commented on a change in pull request #2535: Add ledger op timeout to avoid topics stuck on ledger-creation

2018-09-13 Thread GitBox
rdhabalia commented on a change in pull request #2535: Add ledger op timeout to avoid topics stuck on ledger-creation URL: https://github.com/apache/incubator-pulsar/pull/2535#discussion_r217576629 ## File path:

[GitHub] massakam commented on issue #2572: Shorten the timeout value of C++ ZTS client

2018-09-13 Thread GitBox
massakam commented on issue #2572: Shorten the timeout value of C++ ZTS client URL: https://github.com/apache/incubator-pulsar/pull/2572#issuecomment-421205105 rerun java8 tests This is an automated message from the Apache

[GitHub] massakam removed a comment on issue #2572: Shorten the timeout value of C++ ZTS client

2018-09-13 Thread GitBox
massakam removed a comment on issue #2572: Shorten the timeout value of C++ ZTS client URL: https://github.com/apache/incubator-pulsar/pull/2572#issuecomment-421204621 rerun java8 tests rerun integration tests This is an

[GitHub] merlimat commented on issue #2508: PIP-22: Dead Letter Topic

2018-09-13 Thread GitBox
merlimat commented on issue #2508: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2508#issuecomment-421181976 run java8 tests This is an automated message from the Apache Git Service. To

[GitHub] srkukarni opened a new pull request #2579: Misc fixes

2018-09-13 Thread GitBox
srkukarni opened a new pull request #2579: Misc fixes URL: https://github.com/apache/incubator-pulsar/pull/2579 ### Motivation This pr does a couple of minor nits 1. Add a log statement in Sink to make it consistent with the Source. 2. Added AllArgs/NoArgs constructor for some

[GitHub] sijie commented on a change in pull request #2570: Fix BC issue in functions trigger function submitted by old CLI

2018-09-13 Thread GitBox
sijie commented on a change in pull request #2570: Fix BC issue in functions trigger function submitted by old CLI URL: https://github.com/apache/incubator-pulsar/pull/2570#discussion_r217570601 ## File path:

[GitHub] aahmed-se commented on a change in pull request #2578: [WIP] Add support for schema extraction from a jar

2018-09-13 Thread GitBox
aahmed-se commented on a change in pull request #2578: [WIP] Add support for schema extraction from a jar URL: https://github.com/apache/incubator-pulsar/pull/2578#discussion_r217573668 ## File path: pulsar-client-tools/pom.xml ## @@ -101,6 +101,18 @@ test

[GitHub] jiazhai removed a comment on issue #2560: [proxy][functions] Issue #2154: proxy should be able to forward rest requests to function workers cluster

2018-09-13 Thread GitBox
jiazhai removed a comment on issue #2560: [proxy][functions] Issue #2154: proxy should be able to forward rest requests to function workers cluster URL: https://github.com/apache/incubator-pulsar/pull/2560#issuecomment-421236834 run integration tests

[GitHub] merlimat opened a new pull request #2580: [Python] Consolidated duplicated subscribe_*() methods into a single one

2018-09-13 Thread GitBox
merlimat opened a new pull request #2580: [Python] Consolidated duplicated subscribe_*() methods into a single one URL: https://github.com/apache/incubator-pulsar/pull/2580 ### Motivation In Python client lib, removed duplicated code and consolidated `subscribe_topics()` and

[GitHub] sijie commented on a change in pull request #2578: [WIP] Add support for schema extraction from a jar

2018-09-13 Thread GitBox
sijie commented on a change in pull request #2578: [WIP] Add support for schema extraction from a jar URL: https://github.com/apache/incubator-pulsar/pull/2578#discussion_r217571498 ## File path:

[GitHub] sijie commented on a change in pull request #2578: [WIP] Add support for schema extraction from a jar

2018-09-13 Thread GitBox
sijie commented on a change in pull request #2578: [WIP] Add support for schema extraction from a jar URL: https://github.com/apache/incubator-pulsar/pull/2578#discussion_r217571566 ## File path: pulsar-client-tools/pom.xml ## @@ -101,6 +101,18 @@ test +

[GitHub] sijie commented on a change in pull request #2578: [WIP] Add support for schema extraction from a jar

2018-09-13 Thread GitBox
sijie commented on a change in pull request #2578: [WIP] Add support for schema extraction from a jar URL: https://github.com/apache/incubator-pulsar/pull/2578#discussion_r217571451 ## File path:

[GitHub] rdhabalia commented on issue #2535: Add ledger op timeout to avoid topics stuck on ledger-creation

2018-09-13 Thread GitBox
rdhabalia commented on issue #2535: Add ledger op timeout to avoid topics stuck on ledger-creation URL: https://github.com/apache/incubator-pulsar/pull/2535#issuecomment-421199228 @merlimat fixed it. This is an automated

[GitHub] jerrypeng opened a new pull request #2577: fix behavior of JSONSchema for derived classes

2018-09-13 Thread GitBox
jerrypeng opened a new pull request #2577: fix behavior of JSONSchema for derived classes URL: https://github.com/apache/incubator-pulsar/pull/2577 ### Motivation Currently declaring a JSONSchema of a certain class and serializing a instance of a derived class does not produce the

[GitHub] sijie commented on issue #2570: Fix BC issue in functions trigger function submitted by old CLI

2018-09-13 Thread GitBox
sijie commented on issue #2570: Fix BC issue in functions trigger function submitted by old CLI URL: https://github.com/apache/incubator-pulsar/pull/2570#issuecomment-421231232 @srkukarni : ``` @Parameter(names = "--topicsPattern", description = "TopicsPattern to consume from

[GitHub] sijie commented on issue #2570: Fix BC issue in functions trigger function submitted by old CLI

2018-09-13 Thread GitBox
sijie commented on issue #2570: Fix BC issue in functions trigger function submitted by old CLI URL: https://github.com/apache/incubator-pulsar/pull/2570#issuecomment-421232435 https://github.com/apache/incubator-pulsar/pull/1903/files#diff-cae1c6ad6356263a1292cfcb9fddc015R110 if

[GitHub] jiazhai commented on issue #2560: [proxy][functions] Issue #2154: proxy should be able to forward rest requests to function workers cluster

2018-09-13 Thread GitBox
jiazhai commented on issue #2560: [proxy][functions] Issue #2154: proxy should be able to forward rest requests to function workers cluster URL: https://github.com/apache/incubator-pulsar/pull/2560#issuecomment-421236834 run integration tests

[GitHub] sijie commented on issue #2508: PIP-22: Dead Letter Topic

2018-09-13 Thread GitBox
sijie commented on issue #2508: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2508#issuecomment-421236785 run java8 tests run integration tests This is an automated message from the Apache

[GitHub] sijie commented on issue #2571: Change repository tag for test image

2018-09-13 Thread GitBox
sijie commented on issue #2571: Change repository tag for test image URL: https://github.com/apache/incubator-pulsar/pull/2571#issuecomment-421236455 retest this please This is an automated message from the Apache Git

[GitHub] sijie commented on issue #2570: Fix BC issue in functions trigger function submitted by old CLI

2018-09-13 Thread GitBox
sijie commented on issue #2570: Fix BC issue in functions trigger function submitted by old CLI URL: https://github.com/apache/incubator-pulsar/pull/2570#issuecomment-421232586 looking into the refactor. I believe the refactor mess up this -

[GitHub] sijie commented on issue #2570: Fix BC issue in functions trigger function submitted by old CLI

2018-09-13 Thread GitBox
sijie commented on issue #2570: Fix BC issue in functions trigger function submitted by old CLI URL: https://github.com/apache/incubator-pulsar/pull/2570#issuecomment-421231882 > --topic-pattern = Input Topic Pattern with default schema hmm, I don't believe so. Let me find the

[GitHub] ivankelly opened a new pull request #2573: ManagedLedger only closes ledger on error if current ledger (#240)

2018-09-13 Thread GitBox
ivankelly opened a new pull request #2573: ManagedLedger only closes ledger on error if current ledger (#240) URL: https://github.com/apache/incubator-pulsar/pull/2573 If we have a managed ledger, ml and we write 2 entries to it, if both entries fail, both will end up calling

[GitHub] jiazhai opened a new issue #2574: Timeout message not get redeliver in TopicsConsumer when use message listener

2018-09-13 Thread GitBox
jiazhai opened a new issue #2574: Timeout message not get redeliver in TopicsConsumer when use message listener URL: https://github.com/apache/incubator-pulsar/issues/2574 Expected behavior Timeout message get redeliver in TopicsConsumer when use message listener

[GitHub] jiazhai commented on issue #2574: Timeout message not get redeliver in TopicsConsumer when use message listener

2018-09-13 Thread GitBox
jiazhai commented on issue #2574: Timeout message not get redeliver in TopicsConsumer when use message listener URL: https://github.com/apache/incubator-pulsar/issues/2574#issuecomment-421044188 Penghui meet this issue in their test. This issue may be caused by the un-acked messages

[GitHub] sijie commented on issue #2503: add auto ack and timeout configurable

2018-09-13 Thread GitBox
sijie commented on issue #2503: add auto ack and timeout configurable URL: https://github.com/apache/incubator-pulsar/pull/2503#issuecomment-421110182 run java8 tests This is an automated message from the Apache Git Service.

[GitHub] sijie commented on issue #2560: [proxy][functions] Issue #2154: proxy should be able to forward rest requests to function workers cluster

2018-09-13 Thread GitBox
sijie commented on issue #2560: [proxy][functions] Issue #2154: proxy should be able to forward rest requests to function workers cluster URL: https://github.com/apache/incubator-pulsar/pull/2560#issuecomment-421110056 run integration tests

[GitHub] srkukarni commented on issue #2500: [schema] add schemas for primtive types

2018-09-13 Thread GitBox
srkukarni commented on issue #2500: [schema] add schemas for primtive types URL: https://github.com/apache/incubator-pulsar/pull/2500#issuecomment-421100264 run java8 tests run integration tests This is an automated

[GitHub] aahmed-se commented on issue #2504: Add Presto Sql Test

2018-09-13 Thread GitBox
aahmed-se commented on issue #2504: Add Presto Sql Test URL: https://github.com/apache/incubator-pulsar/pull/2504#issuecomment-42864 retest this please This is an automated message from the Apache Git Service. To respond

[GitHub] sijie closed pull request #2516: Fix: get function status with auth enable

2018-09-13 Thread GitBox
sijie closed pull request #2516: Fix: get function status with auth enable URL: https://github.com/apache/incubator-pulsar/pull/2516 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[incubator-pulsar] branch master updated: Fix: get function status with auth enable (#2516)

2018-09-13 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new e5a7b53 Fix: get function status with

[GitHub] sijie commented on issue #2567: Another fix for website build website/scripts/replace.js

2018-09-13 Thread GitBox
sijie commented on issue #2567: Another fix for website build website/scripts/replace.js URL: https://github.com/apache/incubator-pulsar/pull/2567#issuecomment-421110786 run java8 tests This is an automated message from the

[GitHub] srkukarni commented on a change in pull request #2549: [Function] avoid creating assignment snapshot and publish individual assignment msg

2018-09-13 Thread GitBox
srkukarni commented on a change in pull request #2549: [Function] avoid creating assignment snapshot and publish individual assignment msg URL: https://github.com/apache/incubator-pulsar/pull/2549#discussion_r217492954 ## File path:

[GitHub] jerrypeng commented on a change in pull request #2549: [Function] avoid creating assignment snapshot and publish individual assignment msg

2018-09-13 Thread GitBox
jerrypeng commented on a change in pull request #2549: [Function] avoid creating assignment snapshot and publish individual assignment msg URL: https://github.com/apache/incubator-pulsar/pull/2549#discussion_r217500097 ## File path:

[GitHub] sijie commented on issue #2568: MacOS: Could not find a version that satisfies the requirement pulsar-client==2.1.0

2018-09-13 Thread GitBox
sijie commented on issue #2568: MacOS: Could not find a version that satisfies the requirement pulsar-client==2.1.0 URL: https://github.com/apache/incubator-pulsar/issues/2568#issuecomment-421119465 @srids gotcha. we have a release 2.1.1 upcoming in 2 days. we can try to publish 37 for

[GitHub] sijie commented on issue #2575: Issue #2574: Timeout message not get redeliver in TopicsConsumer when use message listener

2018-09-13 Thread GitBox
sijie commented on issue #2575: Issue #2574: Timeout message not get redeliver in TopicsConsumer when use message listener URL: https://github.com/apache/incubator-pulsar/pull/2575#issuecomment-421106390 @jiazhai I think there are some tests need to be changed.

[GitHub] srkukarni commented on a change in pull request #2549: [Function] avoid creating assignment snapshot and publish individual assignment msg

2018-09-13 Thread GitBox
srkukarni commented on a change in pull request #2549: [Function] avoid creating assignment snapshot and publish individual assignment msg URL: https://github.com/apache/incubator-pulsar/pull/2549#discussion_r217493540 ## File path:

[GitHub] sijie commented on a change in pull request #2575: Issue #2574: Timeout message not get redeliver in TopicsConsumer when use message listener

2018-09-13 Thread GitBox
sijie commented on a change in pull request #2575: Issue #2574: Timeout message not get redeliver in TopicsConsumer when use message listener URL: https://github.com/apache/incubator-pulsar/pull/2575#discussion_r217436845 ## File path:

[GitHub] jiazhai opened a new pull request #2575: Issue #2574: Timeout message not get redeliver in TopicsConsumer when use message listener

2018-09-13 Thread GitBox
jiazhai opened a new pull request #2575: Issue #2574: Timeout message not get redeliver in TopicsConsumer when use message listener URL: https://github.com/apache/incubator-pulsar/pull/2575 ### Motivation fix issue #2574 . Timeout message not get redeliver in TopicsConsumer when

[GitHub] sijie commented on issue #2575: Issue #2574: Timeout message not get redeliver in TopicsConsumer when use message listener

2018-09-13 Thread GitBox
sijie commented on issue #2575: Issue #2574: Timeout message not get redeliver in TopicsConsumer when use message listener URL: https://github.com/apache/incubator-pulsar/pull/2575#issuecomment-421054906 Let's make this fix as part of 2.2 release