[GitHub] sijie opened a new pull request #2599: [java-client] Issue #2384: ConnectionHandler: Log stack trace instead of printing

2018-09-17 Thread GitBox
sijie opened a new pull request #2599: [java-client] Issue #2384: ConnectionHandler: Log stack trace instead of printing URL: https://github.com/apache/incubator-pulsar/pull/2599 *Motivation* Fixes #2384. The pulsar java client is currently very noisy in case of

[GitHub] sijie opened a new pull request #2600: [tests] make PersistentQueueE2ETest tolerant failures during deleting topic at cleanup

2018-09-17 Thread GitBox
sijie opened a new pull request #2600: [tests] make PersistentQueueE2ETest tolerant failures during deleting topic at cleanup URL: https://github.com/apache/incubator-pulsar/pull/2600 *Motivation* "Topic has active producers/subscriptions" can be thrown during deleting topic at

[GitHub] jerrypeng opened a new pull request #2601: docs for 2.1.1-incubating release

2018-09-17 Thread GitBox
jerrypeng opened a new pull request #2601: docs for 2.1.1-incubating release URL: https://github.com/apache/incubator-pulsar/pull/2601 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] rdhabalia commented on a change in pull request #2591: Fix: Compaction with last deleted keys not completing compaction

2018-09-17 Thread GitBox
rdhabalia commented on a change in pull request #2591: Fix: Compaction with last deleted keys not completing compaction URL: https://github.com/apache/incubator-pulsar/pull/2591#discussion_r218200167 ## File path:

[GitHub] ivankelly commented on a change in pull request #2591: Fix: Compaction with last deleted keys not completing compaction

2018-09-17 Thread GitBox
ivankelly commented on a change in pull request #2591: Fix: Compaction with last deleted keys not completing compaction URL: https://github.com/apache/incubator-pulsar/pull/2591#discussion_r218200350 ## File path:

[GitHub] sijie commented on issue #2568: MacOS: Could not find a version that satisfies the requirement pulsar-client==2.1.0

2018-09-17 Thread GitBox
sijie commented on issue #2568: MacOS: Could not find a version that satisfies the requirement pulsar-client==2.1.0 URL: https://github.com/apache/incubator-pulsar/issues/2568#issuecomment-422163989 Closed this issue as question answered.

[GitHub] sijie closed issue #2568: MacOS: Could not find a version that satisfies the requirement pulsar-client==2.1.0

2018-09-17 Thread GitBox
sijie closed issue #2568: MacOS: Could not find a version that satisfies the requirement pulsar-client==2.1.0 URL: https://github.com/apache/incubator-pulsar/issues/2568 This is an automated message from the Apache Git

[GitHub] rdhabalia commented on a change in pull request #2591: Fix: Compaction with last deleted keys not completing compaction

2018-09-17 Thread GitBox
rdhabalia commented on a change in pull request #2591: Fix: Compaction with last deleted keys not completing compaction URL: https://github.com/apache/incubator-pulsar/pull/2591#discussion_r218200057 ## File path:

[GitHub] rdhabalia commented on issue #2549: [Function] avoid creating assignment snapshot and publish individual assignment msg

2018-09-17 Thread GitBox
rdhabalia commented on issue #2549: [Function] avoid creating assignment snapshot and publish individual assignment msg URL: https://github.com/apache/incubator-pulsar/pull/2549#issuecomment-422143170 @sijie yes, I have fixed this test-failure in last commit and now tests are passing. I

[GitHub] sijie opened a new pull request #2597: [build] Fix docker organization parameter

2018-09-17 Thread GitBox
sijie opened a new pull request #2597: [build] Fix docker organization parameter URL: https://github.com/apache/incubator-pulsar/pull/2597 *Motivation* docker orgnization is missing for building test image. so the build will be failing with `-Pdocker`. *Changes* Move

[GitHub] sijie commented on a change in pull request #2585: [tests] Make BrokerClientIntegrationTest testing behavior deterministic

2018-09-17 Thread GitBox
sijie commented on a change in pull request #2585: [tests] Make BrokerClientIntegrationTest testing behavior deterministic URL: https://github.com/apache/incubator-pulsar/pull/2585#discussion_r218218701 ## File path:

svn commit: r29454 - /release/incubator/pulsar/pulsar-2.1.1-incubating/

2018-09-17 Thread jerrypeng
Author: jerrypeng Date: Mon Sep 17 20:45:49 2018 New Revision: 29454 Log: Delete old release Removed: release/incubator/pulsar/pulsar-2.1.1-incubating/

[GitHub] sijie opened a new pull request #2598: [tests] Flaky Test ZooKeeperCacheTest#testChildrenCacheZnodeCreatedAfterCache

2018-09-17 Thread GitBox
sijie opened a new pull request #2598: [tests] Flaky Test ZooKeeperCacheTest#testChildrenCacheZnodeCreatedAfterCache URL: https://github.com/apache/incubator-pulsar/pull/2598 *Motivation* The problem is zookeeper watcher notification is non-deterministic. That says if you create N

[incubator-pulsar] branch master updated: [tests] Fix the synchronization problem at BrokerClientIntegrationTest.testMaxConcurrentTopicLoading (#2595)

2018-09-17 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 259275b [tests] Fix the

[GitHub] merlimat closed pull request #2595: [tests] Fix the synchronization problem at BrokerClientIntegrationTest.testMaxConcurrentTopicLoading

2018-09-17 Thread GitBox
merlimat closed pull request #2595: [tests] Fix the synchronization problem at BrokerClientIntegrationTest.testMaxConcurrentTopicLoading URL: https://github.com/apache/incubator-pulsar/pull/2595 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it

[incubator-pulsar] annotated tag v2.1.1-incubating updated (68faf85 -> e4883fb)

2018-09-17 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a change to annotated tag v2.1.1-incubating in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git. *** WARNING: tag v2.1.1-incubating was modified! *** from 68faf85 (commit) to

svn commit: r29453 - /dev/incubator/pulsar/pulsar-2.1.1-incubating-candidate-1/ /release/incubator/pulsar/pulsar-2.1.1-incubating/

2018-09-17 Thread jerrypeng
Author: jerrypeng Date: Mon Sep 17 20:44:42 2018 New Revision: 29453 Log: Release v2.1.1-incubating Added: release/incubator/pulsar/pulsar-2.1.1-incubating/ - copied from r29452, dev/incubator/pulsar/pulsar-2.1.1-incubating-candidate-1/ Removed:

[GitHub] sijie commented on issue #2597: [build] Fix docker organization parameter

2018-09-17 Thread GitBox
sijie commented on issue #2597: [build] Fix docker organization parameter URL: https://github.com/apache/incubator-pulsar/pull/2597#issuecomment-422188503 run java8 tests This is an automated message from the Apache Git

[GitHub] srkukarni opened a new pull request #2593: Add support for running python functions with wheel file

2018-09-17 Thread GitBox
srkukarni opened a new pull request #2593: Add support for running python functions with wheel file URL: https://github.com/apache/incubator-pulsar/pull/2593 ### Motivation Currently running python functions require all function logic to be contained within one python file. This pr

[GitHub] merlimat commented on issue #2580: [Python] Consolidated duplicated subscribe_*() methods into a single one

2018-09-17 Thread GitBox
merlimat commented on issue #2580: [Python] Consolidated duplicated subscribe_*() methods into a single one URL: https://github.com/apache/incubator-pulsar/pull/2580#issuecomment-422081330 run cpp tests run integration tests

[GitHub] srkukarni commented on issue #2587: [tests] improve connector related integration tests

2018-09-17 Thread GitBox
srkukarni commented on issue #2587: [tests] improve connector related integration tests URL: https://github.com/apache/incubator-pulsar/pull/2587#issuecomment-422075457 run java8 tests This is an automated message from the

[GitHub] srkukarni commented on issue #2549: [Function] avoid creating assignment snapshot and publish individual assignment msg

2018-09-17 Thread GitBox
srkukarni commented on issue #2549: [Function] avoid creating assignment snapshot and publish individual assignment msg URL: https://github.com/apache/incubator-pulsar/pull/2549#issuecomment-422079888 run integration tests

[incubator-pulsar.wiki] branch master updated: Updated Release process (markdown)

2018-09-17 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.wiki.git The following commit(s) were added to refs/heads/master by this push: new faa092f Updated Release

[GitHub] merlimat opened a new pull request #2602: ManagedLedger should share BK worker pool threads

2018-09-17 Thread GitBox
merlimat opened a new pull request #2602: ManagedLedger should share BK worker pool threads URL: https://github.com/apache/incubator-pulsar/pull/2602 ### Motivation Currently, both BookKeeper client and ManagedLedger have their own worker thread pools. There is no advantage in

[GitHub] merlimat opened a new pull request #2603: Share EventLoopGroup between Broker and BK client

2018-09-17 Thread GitBox
merlimat opened a new pull request #2603: Share EventLoopGroup between Broker and BK client URL: https://github.com/apache/incubator-pulsar/pull/2603 ### Motivation Share the Netty `EventLoopGroup` thread pool between Pulsar broker and BookKeeper client. Since broker and bk

[GitHub] merlimat commented on issue #2601: docs for 2.1.1-incubating release

2018-09-17 Thread GitBox
merlimat commented on issue #2601: docs for 2.1.1-incubating release URL: https://github.com/apache/incubator-pulsar/pull/2601#issuecomment-422210162 run java8 tests This is an automated message from the Apache Git Service.

[GitHub] merlimat commented on issue #2597: [build] Fix docker organization parameter

2018-09-17 Thread GitBox
merlimat commented on issue #2597: [build] Fix docker organization parameter URL: https://github.com/apache/incubator-pulsar/pull/2597#issuecomment-422210655 rerun tests please This is an automated message from the Apache Git

[GitHub] merlimat removed a comment on issue #2597: [build] Fix docker organization parameter

2018-09-17 Thread GitBox
merlimat removed a comment on issue #2597: [build] Fix docker organization parameter URL: https://github.com/apache/incubator-pulsar/pull/2597#issuecomment-422210655 rerun tests please This is an automated message from the

[GitHub] merlimat commented on issue #2597: [build] Fix docker organization parameter

2018-09-17 Thread GitBox
merlimat commented on issue #2597: [build] Fix docker organization parameter URL: https://github.com/apache/incubator-pulsar/pull/2597#issuecomment-422210763 run cpp tests run java8 tests run integration tests This is

[GitHub] srkukarni commented on issue #2600: [tests] make PersistentQueueE2ETest tolerant failures during deleting topic at cleanup

2018-09-17 Thread GitBox
srkukarni commented on issue #2600: [tests] make PersistentQueueE2ETest tolerant failures during deleting topic at cleanup URL: https://github.com/apache/incubator-pulsar/pull/2600#issuecomment-422217016 run cpp tests run integration tests

[GitHub] rdhabalia commented on issue #2503: add auto ack and timeout configurable

2018-09-17 Thread GitBox
rdhabalia commented on issue #2503: add auto ack and timeout configurable URL: https://github.com/apache/incubator-pulsar/pull/2503#issuecomment-45549 rerun java8 tests This is an automated message from the Apache Git

[GitHub] rdhabalia commented on issue #2591: Fix: Compaction with last deleted keys not completing compaction

2018-09-17 Thread GitBox
rdhabalia commented on issue #2591: Fix: Compaction with last deleted keys not completing compaction URL: https://github.com/apache/incubator-pulsar/pull/2591#issuecomment-45857 Have added test where all the records are deleted in the ledger.

[GitHub] sijie commented on issue #2587: [tests] improve connector related integration tests

2018-09-17 Thread GitBox
sijie commented on issue #2587: [tests] improve connector related integration tests URL: https://github.com/apache/incubator-pulsar/pull/2587#issuecomment-422106026 run java8 tests This is an automated message from the

[GitHub] sijie commented on issue #2585: [tests] Make BrokerClientIntegrationTest testing behavior deterministic

2018-09-17 Thread GitBox
sijie commented on issue #2585: [tests] Make BrokerClientIntegrationTest testing behavior deterministic URL: https://github.com/apache/incubator-pulsar/pull/2585#issuecomment-422111850 retest this please This is an automated

[GitHub] sijie opened a new pull request #2596: (WIP) [tests] improve, stabilize or disable unit tests

2018-09-17 Thread GitBox
sijie opened a new pull request #2596: (WIP) [tests] improve, stabilize or disable unit tests URL: https://github.com/apache/incubator-pulsar/pull/2596 serve as a master pr to fix or disable unit tests to bring CI to green.

[GitHub] jerrypeng opened a new pull request #2594: Correcting SQL getting started title

2018-09-17 Thread GitBox
jerrypeng opened a new pull request #2594: Correcting SQL getting started title URL: https://github.com/apache/incubator-pulsar/pull/2594 This is an automated message from the Apache Git Service. To respond to the message,

[incubator-pulsar] 01/01: Correcting SQL getting started title

2018-09-17 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a commit to branch jerrypeng-patch-1 in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git commit e4eb459d477d01edead131817e9c15b756ab7af7 Author: Boyang Jerry Peng AuthorDate: Mon Sep 17

[incubator-pulsar] branch jerrypeng-patch-1 created (now e4eb459)

2018-09-17 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a change to branch jerrypeng-patch-1 in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git. at e4eb459 Correcting SQL getting started title This branch includes the following new

[GitHub] sijie commented on issue #2549: [Function] avoid creating assignment snapshot and publish individual assignment msg

2018-09-17 Thread GitBox
sijie commented on issue #2549: [Function] avoid creating assignment snapshot and publish individual assignment msg URL: https://github.com/apache/incubator-pulsar/pull/2549#issuecomment-422111382 I see failures in this PR, this sounds like related to the change here. @rdhabalia can you

[GitHub] sijie commented on a change in pull request #2578: Add support for schema extraction from a jar

2018-09-17 Thread GitBox
sijie commented on a change in pull request #2578: Add support for schema extraction from a jar URL: https://github.com/apache/incubator-pulsar/pull/2578#discussion_r218168735 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSchemas.java ##

[GitHub] sijie opened a new pull request #2595: [tests] Fix the synchronization problem at BrokerClientIntegrationTest.testMaxConcurrentTopicLoading

2018-09-17 Thread GitBox
sijie opened a new pull request #2595: [tests] Fix the synchronization problem at BrokerClientIntegrationTest.testMaxConcurrentTopicLoading URL: https://github.com/apache/incubator-pulsar/pull/2595 *Motivation* Following exception is observed in one of the CI jobs. ```

[GitHub] realwanpengli commented on issue #2589: Fail to deploy on Kubernetes cluster

2018-09-17 Thread GitBox
realwanpengli commented on issue #2589: Fail to deploy on Kubernetes cluster URL: https://github.com/apache/incubator-pulsar/issues/2589#issuecomment-422230991 @sijie But in v2.0.1, the line you mentioned is not existed in pulsar-admin pod.

[GitHub] sijie commented on issue #2589: Fail to deploy on Kubernetes cluster

2018-09-17 Thread GitBox
sijie commented on issue #2589: Fail to deploy on Kubernetes cluster URL: https://github.com/apache/incubator-pulsar/issues/2589#issuecomment-422231515 @realwanpengli I see. so it is referencing the config map `broker-config`:

[GitHub] merlimat commented on issue #2580: [Python] Consolidated duplicated subscribe_*() methods into a single one

2018-09-17 Thread GitBox
merlimat commented on issue #2580: [Python] Consolidated duplicated subscribe_*() methods into a single one URL: https://github.com/apache/incubator-pulsar/pull/2580#issuecomment-422238929 run java8 tests This is an

[GitHub] rdhabalia commented on issue #2591: Fix: Compaction with last deleted keys not completing compaction

2018-09-17 Thread GitBox
rdhabalia commented on issue #2591: Fix: Compaction with last deleted keys not completing compaction URL: https://github.com/apache/incubator-pulsar/pull/2591#issuecomment-422259139 rerun java8 tests This is an automated

[GitHub] rdhabalia removed a comment on issue #2591: Fix: Compaction with last deleted keys not completing compaction

2018-09-17 Thread GitBox
rdhabalia removed a comment on issue #2591: Fix: Compaction with last deleted keys not completing compaction URL: https://github.com/apache/incubator-pulsar/pull/2591#issuecomment-422259139 rerun java8 tests This is an

[GitHub] sijie removed a comment on issue #2503: add auto ack and timeout configurable

2018-09-17 Thread GitBox
sijie removed a comment on issue #2503: add auto ack and timeout configurable URL: https://github.com/apache/incubator-pulsar/pull/2503#issuecomment-421431340 run java8 tests This is an automated message from the Apache Git

[GitHub] rdhabalia removed a comment on issue #2503: add auto ack and timeout configurable

2018-09-17 Thread GitBox
rdhabalia removed a comment on issue #2503: add auto ack and timeout configurable URL: https://github.com/apache/incubator-pulsar/pull/2503#issuecomment-421650099 rerun java8 tests This is an automated message from the

[GitHub] rdhabalia commented on issue #2503: add auto ack and timeout configurable

2018-09-17 Thread GitBox
rdhabalia commented on issue #2503: add auto ack and timeout configurable URL: https://github.com/apache/incubator-pulsar/pull/2503#issuecomment-421906236 rerun java8 tests This is an automated message from the Apache Git

[GitHub] sijie removed a comment on issue #2503: add auto ack and timeout configurable

2018-09-17 Thread GitBox
sijie removed a comment on issue #2503: add auto ack and timeout configurable URL: https://github.com/apache/incubator-pulsar/pull/2503#issuecomment-421110182 run java8 tests This is an automated message from the Apache Git

[incubator-pulsar] branch master updated: [schema] add schemas for primtive types (#2500)

2018-09-17 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 5a2d75c [schema] add schemas for

[GitHub] sijie closed pull request #2500: [schema] add schemas for primtive types

2018-09-17 Thread GitBox
sijie closed pull request #2500: [schema] add schemas for primtive types URL: https://github.com/apache/incubator-pulsar/pull/2500 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] sijie removed a comment on issue #2503: add auto ack and timeout configurable

2018-09-17 Thread GitBox
sijie removed a comment on issue #2503: add auto ack and timeout configurable URL: https://github.com/apache/incubator-pulsar/pull/2503#issuecomment-420557062 run java8 tests This is an automated message from the Apache Git

[GitHub] sijie closed pull request #2571: Change repository tag for test image

2018-09-17 Thread GitBox
sijie closed pull request #2571: Change repository tag for test image URL: https://github.com/apache/incubator-pulsar/pull/2571 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[incubator-pulsar] branch master updated: Change repository tag for test image (#2571)

2018-09-17 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 844f46f Change repository tag for

[GitHub] sijie commented on issue #2587: [tests] improve connector related integration tests

2018-09-17 Thread GitBox
sijie commented on issue #2587: [tests] improve connector related integration tests URL: https://github.com/apache/incubator-pulsar/pull/2587#issuecomment-421919287 run java8 tests This is an automated message from the

[GitHub] sijie commented on issue #2589: Fail to deploy on Kubernetes cluster

2018-09-17 Thread GitBox
sijie commented on issue #2589: Fail to deploy on Kubernetes cluster URL: https://github.com/apache/incubator-pulsar/issues/2589#issuecomment-421920296 @realwanpengli I think this is related to #2484 it is fixed and will be released as part of 2.1.1 for a workaround, you can remove

[GitHub] ivankelly commented on a change in pull request #2585: [tests] Make BrokerClientIntegrationTest testing behavior deterministic

2018-09-17 Thread GitBox
ivankelly commented on a change in pull request #2585: [tests] Make BrokerClientIntegrationTest testing behavior deterministic URL: https://github.com/apache/incubator-pulsar/pull/2585#discussion_r217976070 ## File path:

[incubator-pulsar] branch asf-site updated: Updated site at revision a123380

2018-09-17 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/asf-site by this push: new 4437db0 Updated site at revision

[GitHub] aahmed-se commented on issue #2578: Add support for schema extraction from a jar

2018-09-17 Thread GitBox
aahmed-se commented on issue #2578: Add support for schema extraction from a jar URL: https://github.com/apache/incubator-pulsar/pull/2578#issuecomment-421915872 this should be ready for review, I will add some tests later.

[GitHub] sijie closed pull request #2588: Preserve filename of the original function submission

2018-09-17 Thread GitBox
sijie closed pull request #2588: Preserve filename of the original function submission URL: https://github.com/apache/incubator-pulsar/pull/2588 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[incubator-pulsar] branch master updated: Preserve filename of the original function submission (#2588)

2018-09-17 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new a123380 Preserve filename of the

[GitHub] ivankelly commented on a change in pull request #2591: Fix: Compaction with last deleted keys not completing compaction

2018-09-17 Thread GitBox
ivankelly commented on a change in pull request #2591: Fix: Compaction with last deleted keys not completing compaction URL: https://github.com/apache/incubator-pulsar/pull/2591#discussion_r217979707 ## File path:

[GitHub] kramasamy opened a new issue #2592: Package a docker compose file in the release distriution

2018-09-17 Thread GitBox
kramasamy opened a new issue #2592: Package a docker compose file in the release distriution URL: https://github.com/apache/incubator-pulsar/issues/2592 With a docker compose file, it will be easy to try out pulsar and pulsar dashboard. The steps will be - Download and extract the

[GitHub] ivankelly commented on a change in pull request #2591: Fix: Compaction with last deleted keys not completing compaction

2018-09-17 Thread GitBox
ivankelly commented on a change in pull request #2591: Fix: Compaction with last deleted keys not completing compaction URL: https://github.com/apache/incubator-pulsar/pull/2591#discussion_r217978740 ## File path:

[GitHub] sijie commented on issue #2587: [tests] improve connector related integration tests

2018-09-17 Thread GitBox
sijie commented on issue #2587: [tests] improve connector related integration tests URL: https://github.com/apache/incubator-pulsar/pull/2587#issuecomment-421940159 run java8 tests This is an automated message from the

[GitHub] rdhabalia removed a comment on issue #2549: [Function] avoid creating assignment snapshot and publish individual assignment msg

2018-09-17 Thread GitBox
rdhabalia removed a comment on issue #2549: [Function] avoid creating assignment snapshot and publish individual assignment msg URL: https://github.com/apache/incubator-pulsar/pull/2549#issuecomment-421911308 rerun tests please

[GitHub] rdhabalia commented on issue #2549: [Function] avoid creating assignment snapshot and publish individual assignment msg

2018-09-17 Thread GitBox
rdhabalia commented on issue #2549: [Function] avoid creating assignment snapshot and publish individual assignment msg URL: https://github.com/apache/incubator-pulsar/pull/2549#issuecomment-421911308 rerun tests please This

[GitHub] jiazhai commented on issue #2543: Add ServiceUrlProvider and add method forceCloseConnection in PulsarC…

2018-09-17 Thread GitBox
jiazhai commented on issue #2543: Add ServiceUrlProvider and add method forceCloseConnection in PulsarC… URL: https://github.com/apache/incubator-pulsar/pull/2543#issuecomment-422015904 over all lgtm, it would be better provide more comments and examples as @sijie suggested.

[GitHub] dsambandam commented on issue #2576: Pulsar client consume command fails with java.lang.IllegalArgumentException: port out of range:-1

2018-09-17 Thread GitBox
dsambandam commented on issue #2576: Pulsar client consume command fails with java.lang.IllegalArgumentException: port out of range:-1 URL: https://github.com/apache/incubator-pulsar/issues/2576#issuecomment-422047799 @sijie - Is this a bug as the command runs fine without any TLS Auth.