[GitHub] merlimat opened a new pull request #677: Removed unnecessary Copyright notices in NOTICE file for bin distribution

2017-08-11 Thread git
merlimat opened a new pull request #677: Removed unnecessary Copyright notices in NOTICE file for bin distribution URL: https://github.com/apache/incubator-pulsar/pull/677 ### Motivation Based on comments on the 1.19.0-incubating release voting thread (https://lists.apache.org/threa

[GitHub] merlimat opened a new pull request #678: Fixed Maven test jars warnings

2017-08-11 Thread git
merlimat opened a new pull request #678: Fixed Maven test jars warnings URL: https://github.com/apache/incubator-pulsar/pull/678 ### Motivation Removed unnecessary maven plugin configs that were generating build warnings. -

[GitHub] merlimat commented on a change in pull request #634: PIP-3 : Introduce message-dispatch rate limiting

2017-08-11 Thread git
merlimat commented on a change in pull request #634: PIP-3 : Introduce message-dispatch rate limiting URL: https://github.com/apache/incubator-pulsar/pull/634#discussion_r132753377 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/cache/LocalZooKeeperCacheService.j

[GitHub] merlimat commented on a change in pull request #634: PIP-3 : Introduce message-dispatch rate limiting

2017-08-11 Thread git
merlimat commented on a change in pull request #634: PIP-3 : Introduce message-dispatch rate limiting URL: https://github.com/apache/incubator-pulsar/pull/634#discussion_r132697173 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/Namespaces.java ##

[GitHub] merlimat commented on a change in pull request #634: PIP-3 : Introduce message-dispatch rate limiting

2017-08-11 Thread git
merlimat commented on a change in pull request #634: PIP-3 : Introduce message-dispatch rate limiting URL: https://github.com/apache/incubator-pulsar/pull/634#discussion_r132516454 ## File path: conf/broker.conf ## @@ -106,6 +106,14 @@ maxUnackedMessagesPerBroker=0 # limi

[GitHub] merlimat commented on a change in pull request #634: PIP-3 : Introduce message-dispatch rate limiting

2017-08-11 Thread git
merlimat commented on a change in pull request #634: PIP-3 : Introduce message-dispatch rate limiting URL: https://github.com/apache/incubator-pulsar/pull/634#discussion_r132564889 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispa

[GitHub] merlimat commented on a change in pull request #634: PIP-3 : Introduce message-dispatch rate limiting

2017-08-11 Thread git
merlimat commented on a change in pull request #634: PIP-3 : Introduce message-dispatch rate limiting URL: https://github.com/apache/incubator-pulsar/pull/634#discussion_r132516119 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/util/RateLimiter.java ##

[GitHub] merlimat commented on a change in pull request #634: PIP-3 : Introduce message-dispatch rate limiting

2017-08-11 Thread git
merlimat commented on a change in pull request #634: PIP-3 : Introduce message-dispatch rate limiting URL: https://github.com/apache/incubator-pulsar/pull/634#discussion_r132516572 ## File path: conf/broker.conf ## @@ -106,6 +106,14 @@ maxUnackedMessagesPerBroker=0 # limi

[GitHub] merlimat commented on issue #404: Intermittent test failure: OwnershipCacheTest.testGetOwner

2017-08-11 Thread git
merlimat commented on issue #404: Intermittent test failure: OwnershipCacheTest.testGetOwner URL: https://github.com/apache/incubator-pulsar/issues/404#issuecomment-321893491 Still happening https://builds.apache.org/job/pulsar-pull-request/org.apache.pulsar$pulsar-broker/148/testR

[GitHub] merlimat closed issue #657: Intermittent C++ test failure BatchMessageTest.testProducerConfig

2017-08-11 Thread git
merlimat closed issue #657: Intermittent C++ test failure BatchMessageTest.testProducerConfig URL: https://github.com/apache/incubator-pulsar/issues/657 This is an automated message from the Apache Git Service. To respond t

[GitHub] merlimat closed pull request #673: Fix #657: Use exceptions instead of assert() to do runtime parameter ?

2017-08-11 Thread git
merlimat closed pull request #673: Fix #657: Use exceptions instead of assert() to do runtime parameter ? URL: https://github.com/apache/incubator-pulsar/pull/673 This is an automated message from the Apache Git Service. To

[GitHub] merlimat opened a new pull request #679: Refactored usages of deprecated classes

2017-08-11 Thread git
merlimat opened a new pull request #679: Refactored usages of deprecated classes URL: https://github.com/apache/incubator-pulsar/pull/679 ### Motivation Removed some of the warning printed during the build. This is an

[GitHub] merlimat closed issue #655: Documentation for "Set retention policy" has wrong parameters

2017-08-11 Thread git
merlimat closed issue #655: Documentation for "Set retention policy" has wrong parameters URL: https://github.com/apache/incubator-pulsar/issues/655 This is an automated message from the Apache Git Service. To respond to th

[GitHub] rdhabalia opened a new pull request #680: Upgrade to log4j2 dependency and configuration

2017-08-11 Thread git
rdhabalia opened a new pull request #680: Upgrade to log4j2 dependency and configuration URL: https://github.com/apache/incubator-pulsar/pull/680 ### Motivation Replacing log4j with log4j2 for better performance and other useful feature such as filtering. Therefore, also added s

[GitHub] rdhabalia commented on a change in pull request #678: Fixed Maven test jars warnings

2017-08-11 Thread git
rdhabalia commented on a change in pull request #678: Fixed Maven test jars warnings URL: https://github.com/apache/incubator-pulsar/pull/678#discussion_r132804981 ## File path: pulsar-checksum/src/main/assembly/assembly.xml ## @@ -31,7 +31,6 @@ org.slf4j:

[GitHub] merlimat commented on a change in pull request #678: Fixed Maven test jars warnings

2017-08-11 Thread git
merlimat commented on a change in pull request #678: Fixed Maven test jars warnings URL: https://github.com/apache/incubator-pulsar/pull/678#discussion_r132805102 ## File path: pulsar-checksum/src/main/assembly/assembly.xml ## @@ -31,7 +31,6 @@ org.slf4j:s

[GitHub] merlimat commented on a change in pull request #678: Fixed Maven test jars warnings

2017-08-11 Thread git
merlimat commented on a change in pull request #678: Fixed Maven test jars warnings URL: https://github.com/apache/incubator-pulsar/pull/678#discussion_r132805116 ## File path: pulsar-checksum/src/main/assembly/assembly.xml ## @@ -31,7 +31,6 @@ org.slf4j:s

[GitHub] merlimat commented on a change in pull request #680: Upgrade to log4j2 dependency and configuration

2017-08-11 Thread git
merlimat commented on a change in pull request #680: Upgrade to log4j2 dependency and configuration URL: https://github.com/apache/incubator-pulsar/pull/680#discussion_r132805324 ## File path: conf/log4j2.xml ## @@ -0,0 +1,70 @@ + + + + Review comment: Since we're st

[GitHub] merlimat commented on a change in pull request #680: Upgrade to log4j2 dependency and configuration

2017-08-11 Thread git
merlimat commented on a change in pull request #680: Upgrade to log4j2 dependency and configuration URL: https://github.com/apache/incubator-pulsar/pull/680#discussion_r132805342 ## File path: conf/log4j2.xml ## @@ -0,0 +1,70 @@ + Review comment: Also, we should dele

[GitHub] merlimat commented on a change in pull request #680: Upgrade to log4j2 dependency and configuration

2017-08-11 Thread git
merlimat commented on a change in pull request #680: Upgrade to log4j2 dependency and configuration URL: https://github.com/apache/incubator-pulsar/pull/680#discussion_r132805146 ## File path: pom.xml ## @@ -113,6 +113,7 @@ flexible messaging model and an intuitive client

[GitHub] merlimat commented on a change in pull request #680: Upgrade to log4j2 dependency and configuration

2017-08-11 Thread git
merlimat commented on a change in pull request #680: Upgrade to log4j2 dependency and configuration URL: https://github.com/apache/incubator-pulsar/pull/680#discussion_r132805216 ## File path: conf/log4j2-scripts/filter.js ## @@ -0,0 +1,32 @@ +/** + * Licensed to the Apach

[GitHub] merlimat commented on a change in pull request #680: Upgrade to log4j2 dependency and configuration

2017-08-11 Thread git
merlimat commented on a change in pull request #680: Upgrade to log4j2 dependency and configuration URL: https://github.com/apache/incubator-pulsar/pull/680#discussion_r132805446 ## File path: conf/log4j2.xml ## @@ -0,0 +1,70 @@ + + + + Review comment: log4j2 yaml ex

[GitHub] merlimat commented on a change in pull request #680: Upgrade to log4j2 dependency and configuration

2017-08-11 Thread git
merlimat commented on a change in pull request #680: Upgrade to log4j2 dependency and configuration URL: https://github.com/apache/incubator-pulsar/pull/680#discussion_r132805243 ## File path: conf/log4j2.xml ## @@ -0,0 +1,70 @@ + Review comment: I think we should ha

[GitHub] merlimat commented on a change in pull request #680: Upgrade to log4j2 dependency and configuration

2017-08-11 Thread git
merlimat commented on a change in pull request #680: Upgrade to log4j2 dependency and configuration URL: https://github.com/apache/incubator-pulsar/pull/680#discussion_r132805383 ## File path: conf/log4j2.xml ## @@ -0,0 +1,70 @@ + + + + + + + +

[GitHub] rdhabalia commented on a change in pull request #634: PIP-3 : Introduce message-dispatch rate limiting

2017-08-11 Thread git
rdhabalia commented on a change in pull request #634: PIP-3 : Introduce message-dispatch rate limiting URL: https://github.com/apache/incubator-pulsar/pull/634#discussion_r132805842 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/cache/LocalZooKeeperCacheService.

[GitHub] merlimat commented on a change in pull request #680: Upgrade to log4j2 dependency and configuration

2017-08-11 Thread git
merlimat commented on a change in pull request #680: Upgrade to log4j2 dependency and configuration URL: https://github.com/apache/incubator-pulsar/pull/680#discussion_r132805854 ## File path: conf/log4j2-scripts/filter.js ## @@ -0,0 +1,32 @@ +/** Review comment: Som

[GitHub] rdhabalia commented on a change in pull request #680: Upgrade to log4j2 dependency and configuration

2017-08-11 Thread git
rdhabalia commented on a change in pull request #680: Upgrade to log4j2 dependency and configuration URL: https://github.com/apache/incubator-pulsar/pull/680#discussion_r132806142 ## File path: conf/log4j2.xml ## @@ -0,0 +1,70 @@ + + + + + + + +