[GitHub] yush1ga commented on a change in pull request #1087: Add basic authentication plugin

yush1ga commented on a change in pull request #1087: Add basic authentication plugin URL: https://github.com/apache/incubator-pulsar/pull/1087#discussion_r162860524 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/auth/AuthenticationDataBasic.java

[GitHub] yush1ga commented on a change in pull request #1087: Add basic authentication plugin

yush1ga commented on a change in pull request #1087: Add basic authentication plugin URL: https://github.com/apache/incubator-pulsar/pull/1087#discussion_r162860379 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/web/AuthenticationFilter.java ## @@

[GitHub] merlimat commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

merlimat commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r162838288 ## File path:

[GitHub] Licht-T commented on issue #1080: ENH: Apply `make format` into C++ client

Licht-T commented on issue #1080: ENH: Apply `make format` into C++ client URL: https://github.com/apache/incubator-pulsar/pull/1080#issuecomment-359289555 @merlimat @maskit Using `clang-format-5.0` is reasonable option. But, it is better to arrange the both versions in CI and local

[GitHub] zhaijack commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

zhaijack commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r162845520 ## File path:

[GitHub] Licht-T commented on issue #1080: ENH: Apply `make format` into C++ client

Licht-T commented on issue #1080: ENH: Apply `make format` into C++ client URL: https://github.com/apache/incubator-pulsar/pull/1080#issuecomment-359285229 @maskit @merlimat @jai1 Thanks for your review! Here is the new settings.

[GitHub] Licht-T commented on a change in pull request #1080: ENH: Apply `make format` into C++ client

Licht-T commented on a change in pull request #1080: ENH: Apply `make format` into C++ client URL: https://github.com/apache/incubator-pulsar/pull/1080#discussion_r162827261 ## File path: pulsar-client-cpp/include/pulsar/CompressionType.h ## @@ -20,11 +20,7 @@ #define

[GitHub] zhaijack commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

zhaijack commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r162833852 ## File path:

[GitHub] zhaijack commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

zhaijack commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r162833840 ## File path: